<AWT Dev> [8] Review request for CR 7147075: JTextField doesn't get focus or loses focus forever

[Anthony Petrov]

Looks fine.

--
best regards,
Anthony

On 4/10/2013 20:43, Anton V. Tarasov wrote:
> Hello,
> 
> Please, review:
> 
> bug: https://jbs.oracle.com/bugs/browse/JDK-7147075
> webrev: http://cr.openjdk.java.net/~ant/JDK-7147075/webrev.0
> 
> I'm copying comments from jbs:
> 
> It's a regression of 6613426 (integrated in jdk7 b27). 6613426 is a 
> workaround for a Metacity issue [1].
> 
> Some WMs (which are reported to fail: e16, IceWM, CygwinX) don't 
> strictly follow "Global Active" focus model specification [2], which 
> assumes that a WM doesn't set focus to a window, but only notifies it 
> with WM_TAKE_FOCUS client message (for example, when the window is 
> clicked). But the focus log (sun.awt.X11.level=ALL) shows that the frame 
> is natively focused right after it receives WM_TAKE_FOCUS which prevents 
> the frame from normal activation (due to the fix for 6613426).
> 
> Suggested fix: http://cr.openjdk.java.net/~ant/JDK-7147075/webrev.0
> 
> It narrows down the scope of 6613426 to Metacity WM only.
> 
> Thanks,
> Anton.
> 
> [1] https://bugzilla.gnome.org/show_bug.cgi?id=485016
> [2] http://tronche.com/gui/x/icccm/sec-4.html#s-4.1.7