<AWT Dev> [8] Review request for CR 8011186 [TEST_BUG] java/awt/Focus/OverrideRedirectWindowActivationTest/OverrideRedirectWindowActivationTest.java failed on windows 8
Konstantin Shefov
konstantin.shefov at oracle.com
Tue Apr 23 08:13:35 PDT 2013
I have renamed the test:
http://cr.openjdk.java.net/~kshefov/8011186/webrev.01/
<http://cr.openjdk.java.net/%7Ekshefov/8011186/webrev.01/>
On 23-Apr-13 9:47, Anton V. Tarasov wrote:
> On 23.04.2013 0:03, Anthony Petrov wrote:
>> Thanks for the clarification. Perhaps we should rename it then? Or at
>> least add a comment in the test code to avoid confusion in the future.
>>
>> Konstantin, please do either of the above.
>
> Yes, please.
>
> Thanks,
> Anton.
>
>>
>> --
>> best regards,
>> Anthony
>>
>> On 04/22/2013 06:11 PM, Anton V. Tarasov wrote:
>>> The name of the test is confusing. It should have better been called
>>> SimpleWindowActivationTest as it tests some generic focus behavior,
>>> though the original bug was reported against X11.
>>> So, it's Ok to run it on Windows as well.
>>>
>>> Thanks,
>>> Anton.
>>>
>>> On 22.04.2013 18:03, Anthony Petrov wrote:
>>>> Looks good to me. Although why do we run this test on Windows
>>>> platform? There's no OverrideRedirect windows there. Anton?
>>>>
>>>> --
>>>> best regards,
>>>> Anthony
>>>>
>>>> On 04/22/13 17:31, Konstantin Shefov wrote:
>>>>> Hello,
>>>>>
>>>>> Please review a fix for the issue:
>>>>>
>>>>> 8011186 [TEST_BUG]
>>>>> java/awt/Focus/OverrideRedirectWindowActivationTest/OverrideRedirectWindowActivationTest.java
>>>>>
>>>>>
>>>>> failed on windows 8
>>>>>
>>>>> http://bugs.sun.com/view_bug.do?bug_id=8011186
>>>>>
>>>>> The webrev is: http://cr.openjdk.java.net/~kshefov/8011186/webrev.00/
>>>>>
>>>>> Thanks,
>>>>> Konstantin
>>>>>
>>>
>
More information about the awt-dev
mailing list