From alexandr.scherbatiy at oracle.com Thu Aug 1 05:09:42 2013 From: alexandr.scherbatiy at oracle.com (Alexander Scherbatiy) Date: Thu, 01 Aug 2013 16:09:42 +0400 Subject: [8] Review request for 8013849 Awt assert on Hashtable.cpp:124 Message-ID: <51FA5006.1060503@oracle.com> Hello, Could you review the fix: bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8013849 webrev: http://cr.openjdk.java.net/~alexsch/8013849/webrev.00 The fix for the issue 7197619 uses the awt Hashtable to store boolean values for the dead key flags. The awt Hashtable throws assertion if a stored value is null in the debug mode. The fix puts a key to the table if a flag is true and removes it if a flag is false. Thanks, Alexandr. From Sergey.Bylokhov at oracle.com Thu Aug 1 05:35:49 2013 From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov) Date: Thu, 01 Aug 2013 16:35:49 +0400 Subject: [8] Review request for 8013849 Awt assert on Hashtable.cpp:124 In-Reply-To: <51FA5006.1060503@oracle.com> References: <51FA5006.1060503@oracle.com> Message-ID: <51FA5625.3060101@oracle.com> Hi, Alexander. Fix looks fine, but it would be good to add frame.dispose() at the end of the test. On 01.08.2013 16:09, Alexander Scherbatiy wrote: > > Hello, > > Could you review the fix: > bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8013849 > webrev: http://cr.openjdk.java.net/~alexsch/8013849/webrev.00 > > The fix for the issue 7197619 uses the awt Hashtable to store boolean > values for the dead key flags. > The awt Hashtable throws assertion if a stored value is null in the > debug mode. > > The fix puts a key to the table if a flag is true and removes it if a > flag is false. > > Thanks, > Alexandr. > -- Best regards, Sergey. From alexandr.scherbatiy at oracle.com Thu Aug 1 05:59:37 2013 From: alexandr.scherbatiy at oracle.com (alexandr.scherbatiy at oracle.com) Date: Thu, 01 Aug 2013 12:59:37 +0000 Subject: hg: jdk8/awt/jdk: 7161568: [macosx] api/javax_swing/JTabbedPane/index2.html#varios fails Message-ID: <20130801130033.A7C8948508@hg.openjdk.java.net> Changeset: 495ca130cbde Author: alexsch Date: 2013-08-01 17:09 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/495ca130cbde 7161568: [macosx] api/javax_swing/JTabbedPane/index2.html#varios fails Reviewed-by: malenkov, serb ! src/macosx/classes/com/apple/laf/AquaTabbedPaneCopyFromBasicUI.java ! src/macosx/classes/com/apple/laf/AquaTabbedPaneUI.java + test/javax/swing/JTabbedPane/4361477/bug4361477.java + test/javax/swing/JTabbedPane/6495408/bug6495408.java + test/javax/swing/JTabbedPane/7161568/bug7161568.java From alexander.zvegintsev at oracle.com Thu Aug 1 10:03:57 2013 From: alexander.zvegintsev at oracle.com (Alexander Zvegintsev) Date: Thu, 01 Aug 2013 21:03:57 +0400 Subject: [8] Review request for 8021943: FileDialog getFile returns corrupted string after previous setFile Message-ID: <51FA94FD.7060603@oracle.com> Hello, Could you please review a fix for the following issue: http://bugs.sun.com/view_bug.do?bug_id=8021943 The fix is available at: http://cr.openjdk.java.net/~serb/8021943/webrev.00/ lpstrFile should be treated as double NULL terminated (DNT) string only when OFN_ALLOWMULTISELECT flag is set. http://msdn.microsoft.com/en-us/library/windows/desktop/ms646839%28v=vs.85%29.aspx > If the *OFN_ALLOWMULTISELECT* flag is set and the user selects > multiple files, the buffer contains the current directory followed by > the file names of the selected files. For Explorer-style dialog boxes, > the directory and file name strings are *NULL* separated, with an > extra *NULL* character after the last file name. Currently we check length of a lpstrFile with GetBufferLength() which treats \0\0 as an end of a string. It works nice, unless we call setFile() with a filename longer than a path of a saved file (in single-select mode). In single-select mode lpstrFile string ends with single \0, and GetBufferLength() fails to find correct length and we pass \0-separated buffer to WFileDialogPeer.handleSelected() which will be treated as multi-select mode. -- Thanks, Alexander. -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20130801/e7700c2a/attachment.html From leonid.romanov at oracle.com Fri Aug 2 04:42:28 2013 From: leonid.romanov at oracle.com (leonid.romanov at oracle.com) Date: Fri, 02 Aug 2013 11:42:28 +0000 Subject: hg: jdk8/awt/jdk: 8021381: JavaFX scene included in Swing JDialog not starting from Web Start Message-ID: <20130802114347.AD5824856B@hg.openjdk.java.net> Changeset: e76b1568d002 Author: leonidr Date: 2013-08-02 15:42 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/e76b1568d002 8021381: JavaFX scene included in Swing JDialog not starting from Web Start Reviewed-by: art, dcherepanov ! src/share/classes/sun/awt/AppContext.java From leonid.romanov at oracle.com Mon Aug 5 14:03:50 2013 From: leonid.romanov at oracle.com (Leonid Romanov) Date: Tue, 6 Aug 2013 01:03:50 +0400 Subject: [8] Review request for 8022247: java/awt/EventDispatchThread/LoopRobustness/LoopRobustness throws NPE Message-ID: <4AB1AF1B-9D92-43FC-9D15-DE6AB2DCB1D3@oracle.com> Hello, Please review a fix for 8022247: java/awt/EventDispatchThread/LoopRobustness/LoopRobustness throws NPE . The problem is in the test: the rules regarding AppContext usage have changed since 7u25, so, because the test creates its own thread group and an AppContext for it, it also must create an AppContext for the main thread group. bug: http://bugs.sun.com/view_bug.do?bug_id=8022247 webrev: http://cr.openjdk.java.net/~leonidr/8022247/webrev.00/ Thanks, Leonid. From leonid.romanov at oracle.com Tue Aug 6 01:22:31 2013 From: leonid.romanov at oracle.com (Leonid Romanov) Date: Tue, 06 Aug 2013 12:22:31 +0400 Subject: [7u] Review request for 8021381: JavaFX scene included in Swing JDialog not starting from Web Start Message-ID: <5200B247.2060602@oracle.com> Hello, Please review a fix for 8021381. bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8021381 webrev: http://cr.openjdk.java.net/~leonidr/8021381/webrev.00/ Thanks, Leonid. From artem.ananiev at oracle.com Tue Aug 6 02:26:30 2013 From: artem.ananiev at oracle.com (Artem Ananiev) Date: Tue, 06 Aug 2013 13:26:30 +0400 Subject: [8] Review request for 8022247: java/awt/EventDispatchThread/LoopRobustness/LoopRobustness throws NPE In-Reply-To: <4AB1AF1B-9D92-43FC-9D15-DE6AB2DCB1D3@oracle.com> References: <4AB1AF1B-9D92-43FC-9D15-DE6AB2DCB1D3@oracle.com> Message-ID: <5200C146.3000903@oracle.com> Looks fine. Thanks, Artem On 8/6/2013 1:03 AM, Leonid Romanov wrote: > Hello, > Please review a fix for 8022247: java/awt/EventDispatchThread/LoopRobustness/LoopRobustness throws NPE . The problem is in the test: the rules regarding AppContext usage have changed since 7u25, so, because the test creates its own thread group and an AppContext for it, it also must create an AppContext for the main thread group. > > bug: http://bugs.sun.com/view_bug.do?bug_id=8022247 > webrev: http://cr.openjdk.java.net/~leonidr/8022247/webrev.00/ > > Thanks, > Leonid. > From artem.ananiev at oracle.com Tue Aug 6 02:27:21 2013 From: artem.ananiev at oracle.com (Artem Ananiev) Date: Tue, 06 Aug 2013 13:27:21 +0400 Subject: [7u] Review request for 8021381: JavaFX scene included in Swing JDialog not starting from Web Start In-Reply-To: <5200B247.2060602@oracle.com> References: <5200B247.2060602@oracle.com> Message-ID: <5200C179.5000302@oracle.com> Hi, Leonid, the fix looks fine. Thanks, Artem On 8/6/2013 12:22 PM, Leonid Romanov wrote: > Hello, > Please review a fix for 8021381. > > bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8021381 > webrev: http://cr.openjdk.java.net/~leonidr/8021381/webrev.00/ > > > Thanks, > Leonid. > From dmitry.cherepanov at oracle.com Tue Aug 6 02:39:10 2013 From: dmitry.cherepanov at oracle.com (Dmitry Cherepanov) Date: Tue, 06 Aug 2013 13:39:10 +0400 Subject: [7u] Review request for 8021381: JavaFX scene included in Swing JDialog not starting from Web Start In-Reply-To: <5200B247.2060602@oracle.com> References: <5200B247.2060602@oracle.com> Message-ID: <5200C43E.1010703@oracle.com> Looks fine to me. Thanks Dmitry On 8/6/13 12:22 PM, Leonid Romanov wrote: > Hello, > Please review a fix for 8021381. > > bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8021381 > webrev: http://cr.openjdk.java.net/~leonidr/8021381/webrev.00/ > > > Thanks, > Leonid. > From leonid.romanov at oracle.com Tue Aug 6 06:09:12 2013 From: leonid.romanov at oracle.com (leonid.romanov at oracle.com) Date: Tue, 06 Aug 2013 13:09:12 +0000 Subject: hg: jdk8/awt/jdk: 8022247: java/awt/EventDispatchThread/LoopRobustness/LoopRobustness throws NPE Message-ID: <20130806131005.7FF9848603@hg.openjdk.java.net> Changeset: 07abddc1d7f2 Author: leonidr Date: 2013-08-06 17:07 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/07abddc1d7f2 8022247: java/awt/EventDispatchThread/LoopRobustness/LoopRobustness throws NPE Reviewed-by: art ! test/java/awt/EventDispatchThread/LoopRobustness/LoopRobustness.java From Sergey.Bylokhov at oracle.com Tue Aug 6 06:15:14 2013 From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov) Date: Tue, 06 Aug 2013 17:15:14 +0400 Subject: [8] Request for review: 7124339 [macosx] setIconImage is not endlessly tolerant to the broken image-arguments Message-ID: <5200F6E2.4090007@oracle.com> Hello, Please review the fix for jdk 8. After the fix of 6436455 we skip window's incorrect icon on all platforms. In this fix we do the same for OSX. See additional info in the bug description Input validation was removed, because it is done in the createFromImages() Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7124339 Webrev can be found at: http://cr.openjdk.java.net/~serb/7124339/webrev.00 -- Best regards, Sergey. From leonid.romanov at oracle.com Tue Aug 6 07:19:44 2013 From: leonid.romanov at oracle.com (Leonid Romanov) Date: Tue, 06 Aug 2013 18:19:44 +0400 Subject: [8] Request for review: 7124339 [macosx] setIconImage is not endlessly tolerant to the broken image-arguments In-Reply-To: <5200F6E2.4090007@oracle.com> References: <5200F6E2.4090007@oracle.com> Message-ID: <52010600.3020304@oracle.com> Looks good. On 8/6/2013 17:15, Sergey Bylokhov wrote: > Hello, > Please review the fix for jdk 8. > After the fix of 6436455 we skip window's incorrect icon on all > platforms. > In this fix we do the same for OSX. See additional info in the bug > description > Input validation was removed, because it is done in the > createFromImages() > > Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7124339 > Webrev can be found at: > http://cr.openjdk.java.net/~serb/7124339/webrev.00 > From mikhail.cherkasov at oracle.com Tue Aug 6 07:18:58 2013 From: mikhail.cherkasov at oracle.com (mikhail.cherkasov at oracle.com) Date: Tue, 06 Aug 2013 14:18:58 +0000 Subject: hg: jdk8/awt/jdk: 8016833: Underlines and strikethrough not rendering correctly Message-ID: <20130806141925.095FD4860D@hg.openjdk.java.net> Changeset: 27d1bdf2f7d9 Author: mcherkas Date: 2013-08-06 17:29 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/27d1bdf2f7d9 8016833: Underlines and strikethrough not rendering correctly Reviewed-by: alexsch, serb Contributed-by: anton.nashatyrev at oracle.com ! src/share/classes/javax/swing/text/GlyphView.java + test/javax/swing/text/StyledEditorKit/8016833/bug8016833.java From Sergey.Bylokhov at oracle.com Tue Aug 6 07:26:31 2013 From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov) Date: Tue, 06 Aug 2013 18:26:31 +0400 Subject: [8] Review request for 8021943: FileDialog getFile returns corrupted string after previous setFile In-Reply-To: <51FA94FD.7060603@oracle.com> References: <51FA94FD.7060603@oracle.com> Message-ID: <52010797.1000305@oracle.com> Hi, Alexander. Fix looks fine. On 01.08.2013 21:03, Alexander Zvegintsev wrote: > Hello, > > Could you please review a fix for the following issue: > http://bugs.sun.com/view_bug.do?bug_id=8021943 > > The fix is available at: > http://cr.openjdk.java.net/~serb/8021943/webrev.00/ > > lpstrFile should be treated as double NULL terminated (DNT) string > only when OFN_ALLOWMULTISELECT flag is set. > http://msdn.microsoft.com/en-us/library/windows/desktop/ms646839%28v=vs.85%29.aspx >> If the *OFN_ALLOWMULTISELECT* flag is set and the user selects >> multiple files, the buffer contains the current directory followed by >> the file names of the selected files. For Explorer-style dialog >> boxes, the directory and file name strings are *NULL* separated, with >> an extra *NULL* character after the last file name. > Currently we check length of a lpstrFile with GetBufferLength() which > treats \0\0 as an end of a string. > It works nice, unless we call setFile() with a filename longer than a > path of a saved file (in single-select mode). > In single-select mode lpstrFile string ends with single \0, and > GetBufferLength() fails to find correct length and we pass > \0-separated buffer to > WFileDialogPeer.handleSelected() which will be treated as > multi-select mode. > > -- > Thanks, > > Alexander. -- Best regards, Sergey. -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20130806/0144a5e8/attachment-0001.html From anton.litvinov at oracle.com Tue Aug 6 10:04:33 2013 From: anton.litvinov at oracle.com (Anton Litvinov) Date: Tue, 06 Aug 2013 21:04:33 +0400 Subject: [8] Review request for 7191018: Manual test closed/java/awt/JAWT causes JVM to crash starting from JDK 5 Message-ID: <52012CA1.7050106@oracle.com> Hello, Could you please review the following fix for a bug from AWT Native Interface area. Bug: http://bugs.sun.com/view_bug.do?bug_id=7191018 Webrev: http://cr.openjdk.java.net/~alitvinov/7191018/webrev.00 The solution is based on introduction of initialization of "jobject peer" local variable by means of JNI invocation of the Java method "sun.awt.X11.XToolkit.windowToXWindow(long window)". Thank you, Anton From alexandr.scherbatiy at oracle.com Wed Aug 7 06:30:09 2013 From: alexandr.scherbatiy at oracle.com (Alexander Scherbatiy) Date: Wed, 07 Aug 2013 17:30:09 +0400 Subject: [8] Request for review: 7124339 [macosx] setIconImage is not endlessly tolerant to the broken image-arguments In-Reply-To: <5200F6E2.4090007@oracle.com> References: <5200F6E2.4090007@oracle.com> Message-ID: <52024BE1.80309@oracle.com> On 8/6/2013 5:15 PM, Sergey Bylokhov wrote: > Hello, > Please review the fix for jdk 8. > After the fix of 6436455 we skip window's incorrect icon on all > platforms. > In this fix we do the same for OSX. See additional info in the bug > description > Input validation was removed, because it is done in the > createFromImages() > > Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7124339 > Webrev can be found at: > http://cr.openjdk.java.net/~serb/7124339/webrev.00 Should the fix also check that the malicious mage.getWidth(ImageObserver) method does not throw an Error? Thanks, Alexandr. From Sergey.Bylokhov at oracle.com Wed Aug 7 06:56:30 2013 From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov) Date: Wed, 07 Aug 2013 17:56:30 +0400 Subject: [8] Request for review: 7124339 [macosx] setIconImage is not endlessly tolerant to the broken image-arguments In-Reply-To: <52024BE1.80309@oracle.com> References: <5200F6E2.4090007@oracle.com> <52024BE1.80309@oracle.com> Message-ID: <5202520E.3080302@oracle.com> On 07.08.2013 17:30, Alexander Scherbatiy wrote: > On 8/6/2013 5:15 PM, Sergey Bylokhov wrote: > Should the fix also check that the malicious > mage.getWidth(ImageObserver) method does not throw an Error? I think catch an errors like oom is not a good idea, even here. > > Thanks, > Alexandr. > > -- Best regards, Sergey. From alexandr.scherbatiy at oracle.com Wed Aug 7 07:32:29 2013 From: alexandr.scherbatiy at oracle.com (alexandr.scherbatiy at oracle.com) Date: Wed, 07 Aug 2013 14:32:29 +0000 Subject: hg: jdk8/awt/jdk: 8022532: [parfait] Potential memory leak in gtk2_interface.c Message-ID: <20130807143309.952B34867B@hg.openjdk.java.net> Changeset: f8ed88f5ed87 Author: alexsch Date: 2013-08-07 18:32 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/f8ed88f5ed87 8022532: [parfait] Potential memory leak in gtk2_interface.c Reviewed-by: art, serb ! src/solaris/native/sun/awt/gtk2_interface.c From alexandr.scherbatiy at oracle.com Wed Aug 7 07:45:07 2013 From: alexandr.scherbatiy at oracle.com (Alexander Scherbatiy) Date: Wed, 07 Aug 2013 18:45:07 +0400 Subject: [8] Request for review: 7124339 [macosx] setIconImage is not endlessly tolerant to the broken image-arguments In-Reply-To: <5202520E.3080302@oracle.com> References: <5200F6E2.4090007@oracle.com> <52024BE1.80309@oracle.com> <5202520E.3080302@oracle.com> Message-ID: <52025D73.9020509@oracle.com> The fix looks good for me. Thanks, Alexandr. On 8/7/2013 5:56 PM, Sergey Bylokhov wrote: > On 07.08.2013 17:30, Alexander Scherbatiy wrote: >> On 8/6/2013 5:15 PM, Sergey Bylokhov wrote: >> Should the fix also check that the malicious >> mage.getWidth(ImageObserver) method does not throw an Error? > I think catch an errors like oom is not a good idea, even here. >> >> Thanks, >> Alexandr. >> >> > > From alexandr.scherbatiy at oracle.com Wed Aug 7 07:59:02 2013 From: alexandr.scherbatiy at oracle.com (alexandr.scherbatiy at oracle.com) Date: Wed, 07 Aug 2013 14:59:02 +0000 Subject: hg: jdk8/awt/jdk: 8013849: Awt assert on Hashtable.cpp:124 Message-ID: <20130807145914.6F2914867F@hg.openjdk.java.net> Changeset: 7706a622d35f Author: alexsch Date: 2013-08-07 18:58 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/7706a622d35f 8013849: Awt assert on Hashtable.cpp:124 Reviewed-by: serb ! src/windows/native/sun/windows/awt_Component.cpp + test/java/awt/event/KeyEvent/DeadKey/DeadKeySystemAssertionDialog.java From sergey.bylokhov at oracle.com Wed Aug 7 09:00:22 2013 From: sergey.bylokhov at oracle.com (sergey.bylokhov at oracle.com) Date: Wed, 07 Aug 2013 16:00:22 +0000 Subject: hg: jdk8/awt/jdk: 7124339: [macosx] setIconImage is not endlessly tolerant to the broken image-arguments Message-ID: <20130807160112.74EC048682@hg.openjdk.java.net> Changeset: f70492d969e7 Author: serb Date: 2013-08-07 19:57 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/f70492d969e7 7124339: [macosx] setIconImage is not endlessly tolerant to the broken image-arguments Reviewed-by: alexsch, leonidr ! src/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java From artem.ananiev at oracle.com Wed Aug 7 10:17:16 2013 From: artem.ananiev at oracle.com (Artem Ananiev) Date: Wed, 07 Aug 2013 21:17:16 +0400 Subject: Request for review: 6551589 Message-ID: <5202811C.6080400@oracle.com> Hi, AWT team, could you please review the fix for the following bug: 6551589: ContainerListener Documentation may be incorrect The webrev is available here: http://cr.openjdk.java.net/~art/jdk8/6551589/ Thanks, Artem From Sergey.Bylokhov at oracle.com Wed Aug 7 10:24:42 2013 From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov) Date: Wed, 07 Aug 2013 21:24:42 +0400 Subject: Request for review: 6551589 In-Reply-To: <5202811C.6080400@oracle.com> References: <5202811C.6080400@oracle.com> Message-ID: <520282DA.1090407@oracle.com> Hi, Artem. Fix looks fine. On 07.08.2013 21:17, Artem Ananiev wrote: > Hi, AWT team, > > could you please review the fix for the following bug: > > 6551589: ContainerListener Documentation may be incorrect > > The webrev is available here: > > http://cr.openjdk.java.net/~art/jdk8/6551589/ > > Thanks, > > Artem -- Best regards, Sergey. From artem.ananiev at oracle.com Wed Aug 7 10:33:34 2013 From: artem.ananiev at oracle.com (artem.ananiev at oracle.com) Date: Wed, 07 Aug 2013 17:33:34 +0000 Subject: hg: jdk8/awt/jdk: 6551589: ContainerListener Documentation may be incorrect Message-ID: <20130807173404.AEABA4868C@hg.openjdk.java.net> Changeset: 540192229a69 Author: art Date: 2013-08-07 21:31 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/540192229a69 6551589: ContainerListener Documentation may be incorrect Reviewed-by: serb ! src/share/classes/java/awt/event/ContainerListener.java From lana.steuck at oracle.com Wed Aug 7 12:56:14 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 07 Aug 2013 19:56:14 +0000 Subject: hg: jdk8/awt/jaxws: Added tag jdk8-b101 for changeset 60b623a36164 Message-ID: <20130807195629.088C94869B@hg.openjdk.java.net> Changeset: 988a5f2ac559 Author: cl Date: 2013-08-01 04:56 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jaxws/rev/988a5f2ac559 Added tag jdk8-b101 for changeset 60b623a36164 ! .hgtags From lana.steuck at oracle.com Wed Aug 7 12:56:14 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 07 Aug 2013 19:56:14 +0000 Subject: hg: jdk8/awt/corba: Added tag jdk8-b101 for changeset a013024b0747 Message-ID: <20130807195616.F17D24869A@hg.openjdk.java.net> Changeset: 528c7e76eaee Author: cl Date: 2013-08-01 04:56 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/corba/rev/528c7e76eaee Added tag jdk8-b101 for changeset a013024b0747 ! .hgtags From lana.steuck at oracle.com Wed Aug 7 12:56:16 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 07 Aug 2013 19:56:16 +0000 Subject: hg: jdk8/awt/jaxp: 4 new changesets Message-ID: <20130807195642.3C0E34869C@hg.openjdk.java.net> Changeset: b8cd8b101ecb Author: cl Date: 2013-08-01 04:56 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jaxp/rev/b8cd8b101ecb Added tag jdk8-b101 for changeset 0a7432f898e5 ! .hgtags Changeset: 251ca1e2ccd3 Author: joehw Date: 2013-07-25 13:02 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jaxp/rev/251ca1e2ccd3 8021148: Regression in SAXParserImpl in 7u40 b34 (NPE) Reviewed-by: chegar, lancea, dfuchs ! src/com/sun/org/apache/xerces/internal/jaxp/SAXParserImpl.java Changeset: 467e1948612d Author: lana Date: 2013-07-26 14:01 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jaxp/rev/467e1948612d Merge Changeset: 7cffafa606e9 Author: lana Date: 2013-08-06 10:02 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jaxp/rev/7cffafa606e9 Merge From lana.steuck at oracle.com Wed Aug 7 12:56:14 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 07 Aug 2013 19:56:14 +0000 Subject: hg: jdk8/awt: Added tag jdk8-b101 for changeset 9f74a220677d Message-ID: <20130807195615.14F3A48699@hg.openjdk.java.net> Changeset: 5eb3c1dc348f Author: cl Date: 2013-08-01 04:56 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/rev/5eb3c1dc348f Added tag jdk8-b101 for changeset 9f74a220677d ! .hgtags From lana.steuck at oracle.com Wed Aug 7 12:56:25 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 07 Aug 2013 19:56:25 +0000 Subject: hg: jdk8/awt/langtools: 17 new changesets Message-ID: <20130807195749.C7D354869E@hg.openjdk.java.net> Changeset: 4c42fba7b0e7 Author: cl Date: 2013-08-01 04:56 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/4c42fba7b0e7 Added tag jdk8-b101 for changeset 0324dbf07b0f ! .hgtags Changeset: 80e75aa6a707 Author: jjg Date: 2013-07-17 18:18 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/80e75aa6a707 8014636: TestLiteralCodeInPre fails on windows Reviewed-by: ksrini ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/TagletWriterImpl.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/Util.java ! test/com/sun/javadoc/testCRLineSeparator/TestCRLineSeparator.java ! test/com/sun/javadoc/testLeadingSpaces/LeadingSpaces.java ! test/com/sun/javadoc/testLinkTaglet/TestLinkTaglet.java ! test/com/sun/javadoc/testLiteralCodeInPre/TestLiteralCodeInPre.java ! test/com/sun/javadoc/testRelativeLinks/TestRelativeLinks.java Changeset: 1e533c1bfb01 Author: jjg Date: 2013-07-17 19:12 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/1e533c1bfb01 8020313: doclint doesn't reset HTML anchors correctly Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/doclint/Checker.java + test/tools/doclint/AnchorTest2.java + test/tools/doclint/AnchorTest2.out + test/tools/doclint/AnchorTest2a.java Changeset: 1476d54fdc61 Author: jjg Date: 2013-07-17 19:16 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/1476d54fdc61 8020664: doclint gives incorrect warnings on normal package statements Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/doclint/DocLint.java ! src/share/classes/com/sun/tools/doclint/resources/doclint.properties ! test/tools/doclint/BadPackageCommentTest.out ! test/tools/doclint/DocLintTester.java + test/tools/doclint/packageTests/bad/Test.java + test/tools/doclint/packageTests/bad/Test.out + test/tools/doclint/packageTests/bad/package-info.java + test/tools/doclint/packageTests/bad/package-info.out + test/tools/doclint/packageTests/good/Test.java + test/tools/doclint/packageTests/good/package-info.java Changeset: 0a9f5cbe37d9 Author: ksrini Date: 2013-07-19 07:22 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/0a9f5cbe37d9 8017216: javac doesn't fill in end position for some errors of type not found 8019421: Javac doesn't fill in end position for some annotation related errors 8019422: Javac doesn't fill in end position for uninitialized variable errors Reviewed-by: jjg, mcimadamore ! src/share/classes/com/sun/tools/javac/comp/Annotate.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Flow.java ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! src/share/classes/com/sun/tools/javac/tree/EndPosTable.java + test/tools/javac/diags/examples/VarNotIntializedInDefaultConstructor.java + test/tools/javac/positions/TreeEndPosTest.java Changeset: 129751018061 Author: jjg Date: 2013-07-23 16:06 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/129751018061 8021215: javac gives incorrect doclint warnings on normal package statements Reviewed-by: darcy ! src/share/classes/com/sun/tools/doclint/Checker.java ! src/share/classes/com/sun/tools/doclint/DocLint.java ! test/tools/doclint/packageTests/bad/Test.java + test/tools/doclint/packageTests/bad/Test.javac.out ! test/tools/doclint/packageTests/bad/Test.out ! test/tools/doclint/packageTests/bad/package-info.java + test/tools/doclint/packageTests/bad/package-info.javac.out ! test/tools/doclint/packageTests/bad/package-info.out ! test/tools/doclint/packageTests/good/Test.java ! test/tools/doclint/packageTests/good/package-info.java Changeset: 558fe98d1ac0 Author: emc Date: 2013-07-23 20:42 -0400 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/558fe98d1ac0 8016880: 42 tests in annot102* fail with compile-time errors. Summary: Fixes error in type equality when bounds of type variables have annotations. Reviewed-by: jjg, mcimadamore ! src/share/classes/com/sun/tools/javac/code/Types.java + test/tools/javac/annotations/typeAnnotations/ErasureTest.java Changeset: 2fbe77c38802 Author: jjg Date: 2013-07-24 17:35 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/2fbe77c38802 8020556: doclint does not check type variables for @throws Reviewed-by: mcimadamore ! src/share/classes/com/sun/source/util/DocTrees.java ! src/share/classes/com/sun/tools/doclint/Checker.java ! src/share/classes/com/sun/tools/javac/api/JavacTrees.java ! src/share/classes/com/sun/tools/javac/comp/Env.java ! test/tools/doclint/ReferenceTest.java Changeset: a218f7befd55 Author: jfranck Date: 2013-07-25 11:02 +0200 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/a218f7befd55 8007961: javax.lang.model tests for repeating annotations fail in getAnnotationsByType Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Symbol.java ! src/share/classes/com/sun/tools/javac/model/JavacAnnoConstructs.java ! test/tools/javac/processing/model/element/repeatingAnnotations/MixRepeatableAndOfficialContainerInheritedA1Test.java ! test/tools/javac/processing/model/element/repeatingAnnotations/MixRepeatableAndOfficialContainerInheritedB1Test.java ! test/tools/javac/processing/model/element/repeatingAnnotations/MixRepeatableAndOfficialContainerInheritedB2Test.java ! test/tools/javac/processing/model/element/repeatingAnnotations/RepeatableOverrideATest.java ! test/tools/javac/processing/model/element/repeatingAnnotations/RepeatableOverrideBTest.java + test/tools/javac/processing/model/inheritedByType/EnsureOrder.java Changeset: 3155e77d2676 Author: mcimadamore Date: 2013-07-25 14:47 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/3155e77d2676 8020804: javac crashes when speculative attribution infers intersection type with array component Summary: Assertion is causing javac to crash because of lack of support for arrays in intersection types Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Infer.java + test/tools/javac/lambda/8020804/T8020804.java Changeset: b02f28bf7f1c Author: mcimadamore Date: 2013-07-25 14:49 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/b02f28bf7f1c 8016081: field initialized with lambda in annotation types doesn't compile Summary: check for annotation attributes should skip over synthetic methods Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Check.java + test/tools/javac/lambda/8016081/T8016081.java Changeset: dae52d74c1fc Author: mcimadamore Date: 2013-07-25 14:51 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/dae52d74c1fc 8020843: javac crashes on accessibility check with method reference with typevar receiver Summary: method reference overload check doesn't walk through type-variable receivers Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties + test/tools/javac/diags/examples/ReportAccessFragment.java + test/tools/javac/lambda/8020843/T8020843a.java + test/tools/javac/lambda/8020843/T8020843a.out + test/tools/javac/lambda/8020843/T8020843b.java + test/tools/javac/lambda/8020843/T8020843b.out ! test/tools/javac/lambda/MethodReference28.out Changeset: 37048aa3ac19 Author: lana Date: 2013-07-26 14:08 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/37048aa3ac19 Merge Changeset: 8c4b2987edac Author: jlahoda Date: 2013-07-28 10:17 +0200 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/8c4b2987edac 8020689: Missing LineNumberTable entries in compiled class files Reviewed-by: ksrini, mcimadamore ! src/share/classes/com/sun/tools/javac/jvm/Gen.java + test/tools/javac/jvm/T8020689.java Changeset: cd9e8cea1b3c Author: jlahoda Date: 2013-07-28 10:17 +0200 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/cd9e8cea1b3c 8021338: Diamond finder may mark a required type argument as unnecessary Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! test/tools/javac/generics/diamond/6939780/T6939780.java Changeset: 7696282873f6 Author: vromero Date: 2013-07-31 10:52 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/7696282873f6 8013179: assertion failure in javac when compiling with -source 1.6 -target 1.6 Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/TransTypes.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties + test/tools/javac/diags/examples/MethodInvokedWithWrongNumberOfArgs.java Changeset: 453a305e1165 Author: lana Date: 2013-08-06 10:03 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/453a305e1165 Merge From lana.steuck at oracle.com Wed Aug 7 12:56:20 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 07 Aug 2013 19:56:20 +0000 Subject: hg: jdk8/awt/nashorn: 29 new changesets Message-ID: <20130807195701.544284869D@hg.openjdk.java.net> Changeset: 573ccf92d646 Author: cl Date: 2013-08-01 04:56 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/nashorn/rev/573ccf92d646 Added tag jdk8-b101 for changeset a302b05d0ee4 ! .hgtags Changeset: e1d19f9fd5a9 Author: jlaskey Date: 2013-07-16 17:40 -0300 URL: http://hg.openjdk.java.net/jdk8/awt/nashorn/rev/e1d19f9fd5a9 8017585: Exclude two failing tests from Nashorn CC run Reviewed-by: jlaskey, sundar, attila Contributed-by: konstantin.shefov at oracle.com + exclude/exclude_list.txt + exclude/exclude_list_cc.txt ! make/build.xml Changeset: 71cfe4e66bcb Author: jlaskey Date: 2013-07-17 11:53 -0300 URL: http://hg.openjdk.java.net/jdk8/awt/nashorn/rev/71cfe4e66bcb 8020596: Initialization of white space strings in scanner should be done with \u strings Reviewed-by: attila, hannesw Contributed-by: james.laskey at oracle.com ! src/jdk/nashorn/internal/parser/Lexer.java Changeset: 3d6f6b8d8bc8 Author: hannesw Date: 2013-07-17 18:20 +0200 URL: http://hg.openjdk.java.net/jdk8/awt/nashorn/rev/3d6f6b8d8bc8 8020356: ClassCastException Undefined->Scope on spiltter class generated for a large switch statement Reviewed-by: jlaskey, attila ! src/jdk/nashorn/internal/codegen/CodeGenerator.java ! src/jdk/nashorn/internal/codegen/Label.java ! src/jdk/nashorn/internal/codegen/Splitter.java ! src/jdk/nashorn/internal/codegen/WeighNodes.java ! src/jdk/nashorn/internal/ir/Block.java ! src/jdk/nashorn/internal/ir/FunctionNode.java ! src/jdk/nashorn/internal/ir/LexicalContext.java + test/script/basic/JDK-8020356.js + test/script/basic/JDK-8020356.js.EXPECTED Changeset: e3307f1a30e5 Author: sundar Date: 2013-07-18 18:08 +0530 URL: http://hg.openjdk.java.net/jdk8/awt/nashorn/rev/e3307f1a30e5 8020731: Revisit checkPermission calls in Context class Reviewed-by: attila, hannesw ! src/jdk/nashorn/api/scripting/NashornScriptEngine.java ! src/jdk/nashorn/api/scripting/ScriptObjectMirror.java ! src/jdk/nashorn/internal/objects/Global.java ! src/jdk/nashorn/internal/runtime/Context.java ! src/jdk/nashorn/internal/runtime/NativeJavaPackage.java ! src/jdk/nashorn/internal/runtime/ScriptRuntime.java ! src/jdk/nashorn/internal/runtime/WithObject.java ! src/jdk/nashorn/internal/runtime/linker/JavaAdapterBytecodeGenerator.java ! src/jdk/nashorn/internal/runtime/linker/JavaAdapterClassLoader.java - src/jdk/nashorn/internal/runtime/linker/JavaAdapterGeneratorBase.java Changeset: 624f8be5c3fe Author: attila Date: 2013-07-18 16:22 +0200 URL: http://hg.openjdk.java.net/jdk8/awt/nashorn/rev/624f8be5c3fe 8020809: Java adapter should not allow overriding of caller sensitive methods Reviewed-by: jlaskey, sundar ! src/jdk/nashorn/internal/runtime/linker/JavaAdapterBytecodeGenerator.java + test/script/trusted/JDK-8020809.js + test/script/trusted/JDK-8020809.js.EXPECTED Changeset: 4b06441b7624 Author: attila Date: 2013-07-18 16:47 +0200 URL: http://hg.openjdk.java.net/jdk8/awt/nashorn/rev/4b06441b7624 8020820: Limit access to static members of reflective classes Reviewed-by: jlaskey, sundar ! make/build.xml ! src/jdk/nashorn/internal/runtime/linker/NashornStaticClassLinker.java ! test/script/basic/JDK-8010946-2.js ! test/script/basic/JDK-8010946-2.js.EXPECTED ! test/script/basic/NASHORN-473.js + test/script/basic/classloader.js + test/script/basic/classloader.js.EXPECTED ! test/script/basic/javaarray.js ! test/script/sandbox/classloader.js.EXPECTED ! test/script/sandbox/reflection.js ! test/src/jdk/nashorn/api/javaaccess/BooleanAccessTest.java ! test/src/jdk/nashorn/api/javaaccess/NumberAccessTest.java ! test/src/jdk/nashorn/api/javaaccess/ObjectAccessTest.java ! test/src/jdk/nashorn/api/javaaccess/StringAccessTest.java Changeset: 0cfa27ed82fe Author: sundar Date: 2013-07-23 18:17 +0530 URL: http://hg.openjdk.java.net/jdk8/awt/nashorn/rev/0cfa27ed82fe 8021122: Not all callables are handled for toString and other function valued properties Reviewed-by: attila, hannesw, jlaskey ! src/jdk/nashorn/internal/ir/debug/ASTWriter.java ! src/jdk/nashorn/internal/objects/Global.java ! src/jdk/nashorn/internal/objects/NativeArray.java ! src/jdk/nashorn/internal/objects/NativeDate.java ! src/jdk/nashorn/internal/objects/NativeJSON.java ! src/jdk/nashorn/internal/objects/NativeObject.java ! src/jdk/nashorn/internal/runtime/Context.java ! src/jdk/nashorn/internal/runtime/ListAdapter.java ! src/jdk/nashorn/internal/runtime/ScriptRuntime.java ! src/jdk/nashorn/internal/runtime/arrays/IteratorAction.java ! src/jdk/nashorn/internal/runtime/linker/Bootstrap.java ! src/jdk/nashorn/internal/runtime/linker/JavaAdapterBytecodeGenerator.java ! src/jdk/nashorn/internal/runtime/linker/NashornBottomLinker.java + test/script/basic/JDK-8021122.js + test/script/basic/JDK-8021122.js.EXPECTED Changeset: e86b297d26aa Author: jlaskey Date: 2013-07-23 12:00 -0300 URL: http://hg.openjdk.java.net/jdk8/awt/nashorn/rev/e86b297d26aa 8021130: Comments need to be tokens Reviewed-by: lagergren, attila Contributed-by: james.laskey at oracle.com ! src/jdk/nashorn/internal/parser/AbstractParser.java ! src/jdk/nashorn/internal/parser/Lexer.java ! src/jdk/nashorn/internal/parser/TokenType.java Changeset: ccbea9172aa5 Author: sundar Date: 2013-07-23 21:45 +0530 URL: http://hg.openjdk.java.net/jdk8/awt/nashorn/rev/ccbea9172aa5 8021164: REGRESSION: test262 failures after JDK-8021122 Reviewed-by: jlaskey, hannesw ! src/jdk/nashorn/internal/runtime/linker/Bootstrap.java Changeset: 4cb1780bc385 Author: sundar Date: 2013-07-23 21:51 +0530 URL: http://hg.openjdk.java.net/jdk8/awt/nashorn/rev/4cb1780bc385 Merge - src/jdk/nashorn/internal/runtime/linker/JavaAdapterGeneratorBase.java Changeset: 8b97fe2b7c98 Author: attila Date: 2013-07-23 18:28 +0200 URL: http://hg.openjdk.java.net/jdk8/awt/nashorn/rev/8b97fe2b7c98 8021129: Use public lookup again Reviewed-by: lagergren, sundar ! src/jdk/internal/dynalink/beans/AbstractJavaLinker.java ! src/jdk/internal/dynalink/beans/FacetIntrospector.java - src/jdk/internal/dynalink/beans/SafeUnreflector.java - src/jdk/internal/dynalink/beans/SafeUnreflectorImpl.java - src/jdk/internal/dynalink/beans/SandboxClassLoader.java - src/jdk/internal/dynalink/beans/sandbox/Unreflector.java + test/script/trusted/JDK-8021129.js + test/script/trusted/JDK-8021129.js.EXPECTED + test/src/jdk/nashorn/internal/test/models/InternalRunnable.java + test/src/jdk/nashorn/internal/test/models/RestrictedRunnable.java + test/src/jdk/nashorn/test/models/InternalRunnableSuperclass.java Changeset: a58a07a00122 Author: attila Date: 2013-07-24 11:13 +0200 URL: http://hg.openjdk.java.net/jdk8/awt/nashorn/rev/a58a07a00122 8021189: Prevent access to constructors of restricted classes Reviewed-by: lagergren, sundar ! src/jdk/internal/dynalink/beans/AbstractJavaLinker.java ! src/jdk/internal/dynalink/beans/FacetIntrospector.java ! src/jdk/internal/dynalink/beans/StaticClassLinker.java ! test/script/trusted/JDK-8006529.js ! test/script/trusted/JDK-8021129.js + test/script/trusted/JDK-8021189.js + test/script/trusted/JDK-8021189.js.EXPECTED Changeset: e4efb3ce97b2 Author: attila Date: 2013-07-24 12:48 +0200 URL: http://hg.openjdk.java.net/jdk8/awt/nashorn/rev/e4efb3ce97b2 8021246: Fix regression for 8021189 Reviewed-by: lagergren, sundar ! src/jdk/nashorn/internal/runtime/linker/JavaAdapterBytecodeGenerator.java ! test/script/trusted/JDK-8006529.js Changeset: 2a25917777f7 Author: hannesw Date: 2013-07-24 13:16 +0200 URL: http://hg.openjdk.java.net/jdk8/awt/nashorn/rev/2a25917777f7 8020718: RETURN symbol has wrong type in split functions Reviewed-by: lagergren, attila ! src/jdk/nashorn/internal/codegen/CodeGenerator.java ! src/jdk/nashorn/internal/codegen/FinalizeTypes.java ! src/jdk/nashorn/internal/codegen/MethodEmitter.java ! src/jdk/nashorn/internal/codegen/SplitMethodEmitter.java ! src/jdk/nashorn/internal/ir/Block.java ! src/jdk/nashorn/internal/ir/FunctionNode.java ! src/jdk/nashorn/internal/ir/IdentNode.java ! src/jdk/nashorn/internal/ir/Symbol.java Changeset: 573cc6eb66ae Author: jlaskey Date: 2013-07-24 08:25 -0300 URL: http://hg.openjdk.java.net/jdk8/awt/nashorn/rev/573cc6eb66ae Merge - src/jdk/internal/dynalink/beans/SafeUnreflector.java - src/jdk/internal/dynalink/beans/SafeUnreflectorImpl.java - src/jdk/internal/dynalink/beans/SandboxClassLoader.java - src/jdk/internal/dynalink/beans/sandbox/Unreflector.java Changeset: dc54df348a58 Author: sundar Date: 2013-07-24 20:28 +0530 URL: http://hg.openjdk.java.net/jdk8/awt/nashorn/rev/dc54df348a58 8021262: Make nashorn access checks consistent with underlying dynalink Reviewed-by: jlaskey, lagergren, attila ! make/code_coverage.xml ! src/jdk/nashorn/internal/codegen/SpillObjectCreator.java ! src/jdk/nashorn/internal/objects/NativeDate.java ! src/jdk/nashorn/internal/objects/NativeObject.java ! src/jdk/nashorn/internal/runtime/Context.java ! src/jdk/nashorn/internal/runtime/NashornLoader.java ! src/jdk/nashorn/internal/runtime/PropertyMap.java ! src/jdk/nashorn/internal/runtime/ScriptObject.java ! src/jdk/nashorn/internal/runtime/ScriptRuntime.java ! src/jdk/nashorn/internal/runtime/Source.java ! src/jdk/nashorn/internal/runtime/linker/JavaAdapterBytecodeGenerator.java ! src/jdk/nashorn/internal/runtime/linker/JavaAdapterClassLoader.java ! src/jdk/nashorn/internal/runtime/linker/JavaAdapterFactory.java ! src/jdk/nashorn/internal/runtime/linker/LinkerCallSite.java ! src/jdk/nashorn/internal/runtime/linker/NashornBottomLinker.java ! src/jdk/nashorn/internal/runtime/linker/NashornStaticClassLinker.java ! src/jdk/nashorn/internal/runtime/linker/ReflectionCheckLinker.java ! test/script/sandbox/nashorninternals.js ! test/script/trusted/JDK-8006529.js ! test/script/trusted/JDK-8021129.js ! test/script/trusted/JDK-8021189.js ! test/script/trusted/JDK-8021189.js.EXPECTED ! test/src/jdk/nashorn/test/models/InternalRunnableSuperclass.java Changeset: d203d68f6624 Author: sundar Date: 2013-07-24 21:01 +0530 URL: http://hg.openjdk.java.net/jdk8/awt/nashorn/rev/d203d68f6624 8021294: --verify-code option results in AnalyzerException Reviewed-by: hannesw, jlaskey ! src/jdk/nashorn/internal/runtime/Context.java Changeset: 5c035c4ccc61 Author: sundar Date: 2013-07-25 14:05 +0530 URL: http://hg.openjdk.java.net/jdk8/awt/nashorn/rev/5c035c4ccc61 8021252: invokeMethod throws NoSuchMethodException when script object is from different script context Reviewed-by: lagergren, hannesw ! src/jdk/nashorn/api/scripting/NashornScriptEngine.java ! src/jdk/nashorn/api/scripting/ScriptObjectMirror.java ! test/src/jdk/nashorn/api/scripting/ScriptEngineTest.java Changeset: f74faac51bfb Author: hannesw Date: 2013-07-25 11:56 +0200 URL: http://hg.openjdk.java.net/jdk8/awt/nashorn/rev/f74faac51bfb 8021244: Inconsistent stackmap with splitter threshold set very low Reviewed-by: sundar, lagergren ! src/jdk/nashorn/internal/codegen/Lower.java ! src/jdk/nashorn/internal/ir/Block.java Changeset: f22ca0f9b6ee Author: sundar Date: 2013-07-25 20:10 +0530 URL: http://hg.openjdk.java.net/jdk8/awt/nashorn/rev/f22ca0f9b6ee 8021361: ClassCastException:.ScriptObjectMirror -> ScriptObject when getInterface called on object from different ScriptContext Reviewed-by: jlaskey, attila ! src/jdk/nashorn/api/scripting/NashornScriptEngine.java ! src/jdk/nashorn/api/scripting/ScriptObjectMirror.java + src/jdk/nashorn/api/scripting/resources/Messages.properties ! src/jdk/nashorn/internal/runtime/ScriptObject.java ! test/src/jdk/nashorn/api/scripting/ScriptEngineTest.java Changeset: d55856f82352 Author: lana Date: 2013-07-26 14:08 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/nashorn/rev/d55856f82352 Merge Changeset: f6588f168d79 Author: hannesw Date: 2013-07-26 13:50 +0200 URL: http://hg.openjdk.java.net/jdk8/awt/nashorn/rev/f6588f168d79 8020719: Run tests with reduced splitter threshold Reviewed-by: lagergren, sundar, jlaskey ! make/build.xml ! make/project.properties + test/script/basic/NASHORN-592-dual.js + test/script/basic/NASHORN-592-dual.js.EXPECTED + test/script/basic/compile-octane-splitter.js + test/script/basic/compile-octane-splitter.js.EXPECTED + test/script/basic/splitter.js + test/script/basic/splitter.js.EXPECTED - test/script/representations/NASHORN-592a.js ! test/src/jdk/nashorn/internal/test/framework/AbstractScriptRunnable.java ! test/src/jdk/nashorn/internal/test/framework/ScriptRunnable.java ! test/src/jdk/nashorn/internal/test/framework/TestConfig.java ! test/src/jdk/nashorn/internal/test/framework/TestFinder.java Changeset: 17a947418e65 Author: jlaskey Date: 2013-07-26 09:17 -0300 URL: http://hg.openjdk.java.net/jdk8/awt/nashorn/rev/17a947418e65 8021321: Two runsunspider tests fail after updating sunspider to 1.0 Reviewed-by: jlaskey, sundar Contributed-by: michael.horowitz at oracle.com ! test/script/basic/runsunspider.js Changeset: fbd21b00197b Author: sundar Date: 2013-07-26 20:10 +0530 URL: http://hg.openjdk.java.net/jdk8/awt/nashorn/rev/fbd21b00197b 8021571: @fork tests should use VM options passed from project.properties Reviewed-by: lagergren, hannesw, jlaskey ! buildtools/nasgen/src/jdk/nashorn/internal/tools/nasgen/ClassGenerator.java ! buildtools/nasgen/src/jdk/nashorn/internal/tools/nasgen/ConstructorGenerator.java ! buildtools/nasgen/src/jdk/nashorn/internal/tools/nasgen/PrototypeGenerator.java ! make/project.properties ! src/jdk/nashorn/internal/objects/BoundScriptFunctionImpl.java ! src/jdk/nashorn/internal/objects/PrototypeObject.java ! src/jdk/nashorn/internal/runtime/AccessorProperty.java ! src/jdk/nashorn/internal/runtime/FinalScriptFunctionData.java ! src/jdk/nashorn/internal/runtime/ListAdapter.java ! src/jdk/nashorn/internal/runtime/Property.java ! src/jdk/nashorn/internal/runtime/PropertyListenerManager.java ! src/jdk/nashorn/internal/runtime/ScriptFunctionData.java ! src/jdk/nashorn/internal/runtime/UserAccessorProperty.java ! src/jdk/nashorn/internal/runtime/WithObject.java ! src/jdk/nashorn/internal/runtime/linker/AdaptationException.java ! src/jdk/nashorn/internal/runtime/linker/AdaptationResult.java ! src/jdk/nashorn/internal/runtime/linker/InvokeByName.java ! src/jdk/nashorn/internal/runtime/linker/JavaAdapterBytecodeGenerator.java ! src/jdk/nashorn/internal/runtime/linker/JavaAdapterServices.java ! src/jdk/nashorn/internal/runtime/linker/JavaArgumentConverters.java ! src/jdk/nashorn/internal/runtime/linker/NashornCallSiteDescriptor.java ! src/jdk/nashorn/internal/runtime/linker/NashornLinker.java ! src/jdk/nashorn/internal/runtime/linker/PrimitiveLookup.java ! src/jdk/nashorn/internal/runtime/options/KeyValueOption.java ! src/jdk/nashorn/internal/runtime/options/OptionTemplate.java ! test/src/jdk/nashorn/internal/test/framework/AbstractScriptRunnable.java ! test/src/jdk/nashorn/internal/test/framework/ScriptRunnable.java ! test/src/jdk/nashorn/internal/test/framework/TestConfig.java Changeset: 5fc6b7f11289 Author: sundar Date: 2013-07-29 10:28 +0530 URL: http://hg.openjdk.java.net/jdk8/awt/nashorn/rev/5fc6b7f11289 Merge - test/script/representations/NASHORN-592a.js Changeset: 0532397d0732 Author: sundar Date: 2013-07-29 18:07 +0530 URL: http://hg.openjdk.java.net/jdk8/awt/nashorn/rev/0532397d0732 8012792: print function defined in engine.js does not handle multiple arguments Reviewed-by: hannesw ! src/jdk/nashorn/api/scripting/resources/engine.js ! test/src/jdk/nashorn/api/scripting/ScriptEngineTest.java Changeset: 7d5d24bdb671 Author: sundar Date: 2013-07-29 21:56 +0530 URL: http://hg.openjdk.java.net/jdk8/awt/nashorn/rev/7d5d24bdb671 Merge Changeset: e966ff0a3ffe Author: lana Date: 2013-08-06 10:02 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/nashorn/rev/e966ff0a3ffe Merge From lana.steuck at oracle.com Wed Aug 7 12:56:38 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 07 Aug 2013 19:56:38 +0000 Subject: hg: jdk8/awt/hotspot: 61 new changesets Message-ID: <20130807195857.DFA9A4869F@hg.openjdk.java.net> Changeset: 2285b4a0a4e6 Author: amurillo Date: 2013-07-18 09:35 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/2285b4a0a4e6 8020797: new hotspot build - hs25-b43 Reviewed-by: jcoomes ! make/hotspot_version Changeset: dbc0b5dc08f5 Author: fparain Date: 2013-07-10 15:49 +0000 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/dbc0b5dc08f5 7143807: ResourceMark nesting problem in stringStream Reviewed-by: kvn, dcubed ! src/share/vm/memory/resourceArea.hpp ! src/share/vm/runtime/thread.cpp ! src/share/vm/runtime/thread.hpp ! src/share/vm/utilities/ostream.cpp ! src/share/vm/utilities/ostream.hpp Changeset: c9a5fab39234 Author: zgu Date: 2013-07-11 13:15 -0400 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/c9a5fab39234 8012241: NMT huge memory footprint, it usually leads to OOME Summary: Enforce memory limitation on NMT to prevent JVM OOM Reviewed-by: acorn, dcubed, minqi ! src/share/vm/services/memTracker.cpp Changeset: 5f056abe17c6 Author: zgu Date: 2013-07-12 04:35 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/5f056abe17c6 Merge Changeset: 2e8f19c2feef Author: allwin Date: 2013-07-12 18:43 +0200 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/2e8f19c2feef 7162400: Intermittent java.io.IOException: Bad file number during HotSpotVirtualMachine.executeCommand Summary: Intermittent java.io.IOException: Bad file number during HotSpotVirtualMachine.executeCommand Reviewed-by: dcubed, dholmes, sspitsyn, mgerdin, ctornqvi, dsamersoff ! src/os/bsd/vm/attachListener_bsd.cpp ! src/os/linux/vm/attachListener_linux.cpp ! src/os/solaris/vm/attachListener_solaris.cpp ! src/os/windows/vm/attachListener_windows.cpp ! src/share/vm/runtime/thread.cpp ! src/share/vm/services/attachListener.hpp + test/serviceability/attach/AttachWithStalePidFile.java + test/serviceability/attach/AttachWithStalePidFileTarget.java Changeset: c0cb474be37e Author: ctornqvi Date: 2013-07-12 20:47 +0200 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/c0cb474be37e Merge Changeset: 862625d214fa Author: fparain Date: 2013-07-15 00:23 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/862625d214fa Merge Changeset: 23123fc6968a Author: rbackman Date: 2013-07-15 11:35 +0200 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/23123fc6968a 8019324: assert(_f2 == 0 || _f2 == f2) failed: illegal field change Reviewed-by: dholmes, rbackman Contributed-by: David Simms ! src/share/vm/oops/cpCache.hpp Changeset: ee9e76adced3 Author: rbackman Date: 2013-07-15 12:06 +0200 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/ee9e76adced3 Merge Changeset: 33c52908bcdb Author: dholmes Date: 2013-07-15 23:23 -0400 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/33c52908bcdb 8015759: hotspot changes needed to compile with Visual Studio 2012 Reviewed-by: anthony, dholmes, dcubed Contributed-by: Tim Bell ! make/windows/makefiles/compile.make ! make/windows/makefiles/sanity.make ! make/windows/makefiles/vm.make ! src/os_cpu/windows_x86/vm/unwind_windows_x86.hpp Changeset: 39deebbc90b3 Author: mgerdin Date: 2013-07-16 07:33 +0200 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/39deebbc90b3 6671508: JNI GetPrimitiveArrayCritical should not be callable on object arrays Summary: Checked JNI now reports error for Get/ReleasePrimitiveArrayCritical on object arrays Reviewed-by: dholmes, acorn Contributed-by: david.simms at oracle.com ! src/share/vm/prims/jniCheck.cpp Changeset: e619a2766bcc Author: rbackman Date: 2013-06-12 11:17 +0200 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/e619a2766bcc 8016131: nsk/sysdict/vm/stress/chain tests crash the VM in 'entry_frame_is_first()' Reviewed-by: jrose, kvn, mgronlun ! src/cpu/sparc/vm/frame_sparc.inline.hpp ! src/cpu/x86/vm/frame_x86.inline.hpp ! src/share/vm/prims/forte.cpp ! src/share/vm/runtime/frame.cpp ! src/share/vm/runtime/frame.hpp ! src/share/vm/runtime/javaCalls.hpp ! src/share/vm/runtime/thread.cpp ! src/share/vm/runtime/thread.hpp Changeset: 732af649bc3a Author: ccheung Date: 2013-07-17 12:22 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/732af649bc3a 8017498: JVM crashes when native code calls sigaction(sig) where sig>=0x20 Summary: Added (sig < MAXSIGNUM) check in jsig.c Reviewed-by: dholmes, acorn ! src/os/linux/vm/jsig.c + test/runtime/jsig/Test8017498.sh + test/runtime/jsig/TestJNI.c + test/runtime/jsig/TestJNI.java Changeset: 825e6cb66923 Author: jiangli Date: 2013-07-17 18:06 -0400 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/825e6cb66923 8020309: Eliminate InstanceKlass::_cached_class_file_len. Summary: Use JvmtiCachedClassFileData. Reviewed-by: iklam, sspitsyn, dcubed ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/oops/instanceKlass.hpp ! src/share/vm/prims/jvmtiExport.cpp ! src/share/vm/prims/jvmtiExport.hpp ! src/share/vm/prims/jvmtiRedefineClasses.cpp ! src/share/vm/prims/jvmtiRedefineClasses.hpp Changeset: 6388dbc4b7ca Author: jiangli Date: 2013-07-17 17:14 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/6388dbc4b7ca Merge Changeset: c29568b733d2 Author: dholmes Date: 2013-07-18 06:47 -0400 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/c29568b733d2 8020697: jniCheck.cpp:check_is_obj_array asserts on TypeArrayKlass::cast(aOop->klass()) Reviewed-by: dcubed, fparain, dholmes Contributed-by: David Simms ! src/share/vm/prims/jniCheck.cpp Changeset: 5e3b6f79d280 Author: rbackman Date: 2013-07-17 13:48 +0200 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/5e3b6f79d280 8020701: Avoid crashes in WatcherThread Reviewed-by: acorn, dcubed, dsimms ! src/os/posix/vm/os_posix.cpp ! src/os/posix/vm/os_posix.hpp ! src/os/windows/vm/os_windows.cpp ! src/os/windows/vm/os_windows.hpp ! src/os_cpu/bsd_x86/vm/os_bsd_x86.cpp ! src/os_cpu/linux_sparc/vm/os_linux_sparc.cpp ! src/os_cpu/linux_x86/vm/os_linux_x86.cpp ! src/os_cpu/solaris_sparc/vm/os_solaris_sparc.cpp ! src/os_cpu/solaris_x86/vm/os_solaris_x86.cpp ! src/share/vm/runtime/mutex.cpp ! src/share/vm/runtime/os.cpp ! src/share/vm/runtime/os.hpp ! src/share/vm/runtime/thread.cpp ! src/share/vm/runtime/thread.hpp Changeset: 248c459b2b75 Author: dcubed Date: 2013-07-18 12:05 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/248c459b2b75 Merge ! src/share/vm/services/memTracker.cpp Changeset: af21010d1062 Author: dcubed Date: 2013-07-18 12:35 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/af21010d1062 Merge ! src/os/windows/vm/os_windows.cpp ! src/os_cpu/bsd_x86/vm/os_bsd_x86.cpp ! src/os_cpu/linux_sparc/vm/os_linux_sparc.cpp ! src/os_cpu/linux_x86/vm/os_linux_x86.cpp ! src/os_cpu/solaris_sparc/vm/os_solaris_sparc.cpp ! src/os_cpu/solaris_x86/vm/os_solaris_x86.cpp ! src/share/vm/runtime/os.hpp Changeset: 02d7aa1456c9 Author: ccheung Date: 2013-07-18 14:57 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/02d7aa1456c9 8004872: Early loading of HashMap and StringValue under -XX:+AggressiveOpts can be removed Summary: this fix also removes the -XX:+UseStringCache option Reviewed-by: dholmes, acorn, iklam ! src/share/vm/classfile/vmSymbols.hpp ! src/share/vm/opto/bytecodeInfo.cpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/thread.cpp Changeset: 383a5e21cc2d Author: minqi Date: 2013-07-18 18:00 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/383a5e21cc2d Merge Changeset: 060ae9b7ffea Author: mgronlun Date: 2013-07-19 17:56 +0200 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/060ae9b7ffea 8020547: Event based tracing needs a UNICODE string type Reviewed-by: egahlin, rbackman, dcubed, brutisso, acorn ! src/share/vm/trace/traceDataTypes.hpp ! src/share/vm/trace/tracetypes.xml ! src/share/vm/trace/xinclude.mod Changeset: 4614a598dae1 Author: minqi Date: 2013-07-19 08:34 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/4614a598dae1 8016538: volatile double access via Unsafe.cpp is not atomic Summary: volatile jdouble load/store is not atomic, fix by using of existing volatile jlong operations which are atomic for jdouble. Reviewed-by: kvn, vladidan, jrose Contributed-by: david.holmes at oracle.com ! src/os_cpu/bsd_x86/vm/orderAccess_bsd_x86.inline.hpp ! src/os_cpu/linux_x86/vm/orderAccess_linux_x86.inline.hpp ! src/os_cpu/solaris_x86/vm/orderAccess_solaris_x86.inline.hpp ! src/os_cpu/windows_x86/vm/orderAccess_windows_x86.inline.hpp Changeset: 55a61ceb2fe7 Author: minqi Date: 2013-07-19 11:17 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/55a61ceb2fe7 Merge Changeset: 16511b7e3d35 Author: emc Date: 2013-07-22 17:57 -0400 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/16511b7e3d35 8019632: Method parameters are not copied in clone_with_new_data Summary: Add code to copy method parameters data in clone_with_new_data Reviewed-by: coleenp, sspitsyn ! src/share/vm/oops/method.cpp Changeset: 72727c4b6dec Author: ccheung Date: 2013-07-19 14:54 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/72727c4b6dec 8020791: [TESTBUG] runtime/jsig/Test8017498.sh failed to compile native code Summary: Added -DLINUX to the gcc command and improved the .sh script Reviewed-by: dcubed, dholmes, minqi ! test/runtime/jsig/Test8017498.sh ! test/runtime/jsig/TestJNI.c Changeset: 5165d659cebd Author: minqi Date: 2013-07-22 22:21 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/5165d659cebd Merge Changeset: c0f353803b47 Author: minqi Date: 2013-07-23 12:50 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/c0f353803b47 Merge Changeset: c90c698831d7 Author: kvn Date: 2013-07-12 14:01 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/c90c698831d7 8020215: Different execution plan when using JIT vs interpreter Summary: fix bytecode analyzer Reviewed-by: twisti ! src/share/vm/ci/bcEscapeAnalyzer.cpp ! src/share/vm/ci/bcEscapeAnalyzer.hpp + test/compiler/EscapeAnalysis/Test8020215.java Changeset: fcf521c3fbc6 Author: kvn Date: 2013-07-12 14:03 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/fcf521c3fbc6 8007898: Incorrect optimization of Memory Barriers in Matcher::post_store_load_barrier() Summary: generate one "fat" membar instead of set of barriers for volitile store Reviewed-by: roland ! src/share/vm/opto/matcher.cpp ! src/share/vm/opto/parse3.cpp + test/compiler/membars/DekkerTest.java Changeset: 34ce0b5acb81 Author: morris Date: 2013-07-15 06:27 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/34ce0b5acb81 Merge Changeset: 0f57ccdb9084 Author: kvn Date: 2013-07-15 10:28 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/0f57ccdb9084 8020433: Crash when using -XX:+RestoreMXCSROnJNICalls Summary: remove StubRoutines::x86::_mxcsr_std and use StubRoutines::_mxcsr_std Reviewed-by: jrose ! src/cpu/x86/vm/stubGenerator_x86_64.cpp ! src/cpu/x86/vm/stubRoutines_x86_64.cpp ! src/cpu/x86/vm/stubRoutines_x86_64.hpp + test/compiler/cpuflags/RestoreMXCSR.java Changeset: 46a90f83df31 Author: morris Date: 2013-07-19 13:59 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/46a90f83df31 Merge ! src/cpu/x86/vm/stubGenerator_x86_64.cpp Changeset: 6efedc114807 Author: morris Date: 2013-07-24 13:54 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/6efedc114807 Merge Changeset: 01aa164323fa Author: dholmes Date: 2013-07-24 19:23 -0400 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/01aa164323fa 8020799: Allow customization of hotspot source directories and files Reviewed-by: kvn, dlong ! make/linux/makefiles/vm.make Changeset: a4b9a8ec8f4a Author: jiangli Date: 2013-07-25 18:12 -0400 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/a4b9a8ec8f4a Merge Changeset: 46487ba40ff2 Author: amurillo Date: 2013-07-26 03:48 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/46487ba40ff2 Merge Changeset: f6921c876db1 Author: amurillo Date: 2013-07-26 03:48 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/f6921c876db1 Added tag hs25-b43 for changeset 46487ba40ff2 ! .hgtags Changeset: 7c9885d23744 Author: cl Date: 2013-08-01 04:56 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/7c9885d23744 Added tag jdk8-b101 for changeset f6921c876db1 ! .hgtags Changeset: e84845884c85 Author: amurillo Date: 2013-07-26 04:01 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/e84845884c85 8021566: new hotspot build - hs25-b44 Reviewed-by: jcoomes ! make/hotspot_version Changeset: d90d1b96b65b Author: kvn Date: 2013-07-26 12:37 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/d90d1b96b65b 8008938: TieredCompilation should be default Summary: switch on TieredCompilation by default Reviewed-by: twisti ! src/cpu/sparc/vm/c2_globals_sparc.hpp ! src/cpu/x86/vm/c2_globals_x86.hpp Changeset: 1b6395189726 Author: minqi Date: 2013-07-19 14:43 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/1b6395189726 8012263: ciReplay: gracefully exit & report meaningful error when replay data parsing fails Summary: find_method could return NULL so need explicitly check if there is error after parse_method, exit on error to avoid crash. Reviewed-by: kvn, twisti Contributed-by: yumin.qi at oracle.com ! src/share/vm/ci/ciReplay.cpp Changeset: 5ad7f8179bf7 Author: minqi Date: 2013-07-24 08:04 +0200 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/5ad7f8179bf7 Merge Changeset: b6baf306e698 Author: fparain Date: 2013-07-26 05:54 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/b6baf306e698 Merge Changeset: 83ca9dc4564d Author: fparain Date: 2013-07-26 15:24 +0000 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/83ca9dc4564d 8019845: Memory leak during class redefinition Reviewed-by: acorn, jmasa, coleenp, dcubed, mgerdin ! src/share/vm/memory/metaspace.cpp Changeset: f9ee986a9fea Author: ccheung Date: 2013-07-30 14:14 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/f9ee986a9fea 8021296: [TESTBUG] Test8017498.sh fails to find "gcc" and fails to compile on some Linux releases Summary: Added checking for gcc and simplified the sig_handler() in the test case Reviewed-by: dcubed, coleenp, minqi, dlong ! test/runtime/6929067/Test6929067.sh ! test/runtime/7107135/Test7107135.sh ! test/runtime/jsig/Test8017498.sh ! test/runtime/jsig/TestJNI.c Changeset: 0f98cc013b21 Author: fparain Date: 2013-07-31 08:28 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/0f98cc013b21 Merge Changeset: c65045599519 Author: dholmes Date: 2013-07-25 21:05 -0400 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/c65045599519 8021314: minimal1.make needs to force off components not supported by the minimal VM Reviewed-by: coleenp, bpittore ! make/bsd/makefiles/minimal1.make ! make/linux/makefiles/minimal1.make Changeset: 078e5eb2e52e Author: clucasius Date: 2013-07-27 17:23 -0400 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/078e5eb2e52e Merge Changeset: da839a3c5735 Author: dholmes Date: 2013-07-31 19:05 -0400 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/da839a3c5735 Merge Changeset: e3c8767c5cf8 Author: tschatzl Date: 2013-07-24 10:07 +0200 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/e3c8767c5cf8 8020123: Test gc/g1/TestPrintRegionRememberedSetInfo.java fails with "test result: Error. No action after @build" Summary: Remove the @build tag and replace it by a @run tag so that the test gets executed Reviewed-by: brutisso, mgerdin ! test/gc/g1/TestPrintRegionRememberedSetInfo.java Changeset: 7b06ae405d7b Author: jmasa Date: 2013-07-23 09:49 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/7b06ae405d7b 6990419: CMS Remaining work for 6572569: consistently skewed work distribution in (long) re-mark pauses Reviewed-by: rasbold, tschatzl, jmasa Contributed-by: yamauchi at google.com ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.hpp ! src/share/vm/memory/defNewGeneration.cpp ! src/share/vm/memory/generation.hpp ! src/share/vm/runtime/globals.hpp Changeset: fb7010c7c011 Author: jmasa Date: 2013-07-25 07:02 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/fb7010c7c011 Merge Changeset: ca9dedeebdec Author: jmasa Date: 2013-07-25 11:07 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/ca9dedeebdec 6412968: CMS Long initial mark pauses Reviewed-by: rasbold, tschatzl, jmasa Contributed-by: yamauchi at google.com ! src/share/vm/gc_implementation/concurrentMarkSweep/cmsOopClosures.hpp ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.hpp ! src/share/vm/memory/sharedHeap.cpp ! src/share/vm/runtime/globals.hpp Changeset: 8796fd3ac898 Author: tamao Date: 2013-07-26 13:34 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/8796fd3ac898 Merge ! src/share/vm/runtime/globals.hpp Changeset: 313227279a05 Author: brutisso Date: 2013-08-01 07:03 +0200 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/313227279a05 8021967: Deprecate -XX:DefaultMaxRAMFraction Reviewed-by: tschatzl, jmasa, kvn, tamao ! src/share/vm/runtime/arguments.cpp + test/gc/startup_warnings/TestDefaultMaxRAMFraction.java Changeset: dae8324fc7d1 Author: brutisso Date: 2013-08-01 09:35 +0200 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/dae8324fc7d1 8021879: G1: G1HeapRegionSize flag value not updated correctly Reviewed-by: tschatzl, jmasa ! src/share/vm/gc_implementation/g1/heapRegion.cpp + test/gc/arguments/TestG1HeapRegionSize.java Changeset: 8d4ff57af591 Author: brutisso Date: 2013-08-01 17:29 +0200 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/8d4ff57af591 8022051: G1: Remove some unused G1 flags Reviewed-by: tschatzl, jmasa ! src/share/vm/gc_implementation/g1/g1_globals.hpp Changeset: 69d0dbb53c78 Author: tamao Date: 2013-08-01 17:17 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/69d0dbb53c78 Merge Changeset: 530fe88b3b2c Author: amurillo Date: 2013-08-02 02:54 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/530fe88b3b2c Merge Changeset: c4697c1c4484 Author: amurillo Date: 2013-08-02 02:54 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/c4697c1c4484 Added tag hs25-b44 for changeset 530fe88b3b2c ! .hgtags From lana.steuck at oracle.com Wed Aug 7 13:00:14 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 07 Aug 2013 20:00:14 +0000 Subject: hg: jdk8/awt/jdk: 64 new changesets Message-ID: <20130807202118.182C9486A1@hg.openjdk.java.net> Changeset: b52a2ecdb803 Author: cl Date: 2013-08-01 04:56 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/b52a2ecdb803 Added tag jdk8-b101 for changeset 690161232823 ! .hgtags Changeset: 2978c0a543ed Author: prr Date: 2013-07-22 12:52 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/2978c0a543ed 7196866: CTW fails on all Solaris platforms Reviewed-by: prr, jrose, twisti, kvn ! src/solaris/native/sun/awt/awt_GraphicsEnv.c ! src/solaris/native/sun/java2d/x11/XRBackendNative.c Changeset: 784589c7bc55 Author: vadim Date: 2013-07-24 13:38 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/784589c7bc55 8008782: NPE in TrueTypeGlyphMapper Reviewed-by: bae, prr ! src/share/classes/sun/font/TrueTypeFont.java Changeset: db2e3a686cf3 Author: jchen Date: 2013-07-24 12:40 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/db2e3a686cf3 8011709: [parfait] False positive: memory leak in jdk/src/share/native/sun/font/layout/CanonShaping.cpp Reviewed-by: jgodinez, prr ! src/share/native/sun/font/layout/CanonShaping.cpp Changeset: c2e27e7a42ae Author: jchen Date: 2013-07-24 13:05 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/c2e27e7a42ae 8005126: [parfait] #418 - #428 XRBackendNative.c Integer overflow Reviewed-by: prr, vadim ! src/solaris/native/sun/java2d/x11/XRBackendNative.c Changeset: 833f05116f7b Author: bae Date: 2013-07-25 17:14 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/833f05116f7b 8019201: Regression: java.awt.image.ConvolveOp throws java.awt.image.ImagingOpException Reviewed-by: prr ! src/share/native/sun/awt/medialib/awt_ImagingLib.c + test/sun/awt/image/ImagingLib/SamePackingTypeTest.java Changeset: a8b9df782017 Author: serb Date: 2013-07-26 21:18 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/a8b9df782017 7190349: [macosx] Text (Label) is incorrectly drawn with a rotated g2d 8013569: [macosx] JLabel preferred size incorrect on retina displays with non-default font size Reviewed-by: prr ! src/macosx/classes/sun/font/CStrike.java ! src/macosx/native/sun/font/AWTStrike.h ! src/macosx/native/sun/font/AWTStrike.m ! src/macosx/native/sun/font/CGGlyphImages.m + test/java/awt/Graphics2D/DrawString/DrawRotatedString.java + test/java/awt/Graphics2D/IncorrectTextSize/IncorrectTextSize.java Changeset: 467a0c21790b Author: jgodinez Date: 2013-07-26 15:08 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/467a0c21790b 8020208: NullPointerException at sun.print.Win32PrintService.getMediaPrintables Reviewed-by: jchen, prr ! src/windows/classes/sun/print/Win32PrintService.java Changeset: 56c6f9a9653d Author: jgodinez Date: 2013-07-26 15:25 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/56c6f9a9653d 8016343: [macosx] Print job goes to default printer regardless of chosen printer Reviewed-by: jchen, prr ! src/share/classes/sun/print/PSPrinterJob.java ! src/solaris/classes/sun/print/IPPPrintService.java ! src/solaris/classes/sun/print/UnixPrintJob.java ! test/javax/print/DialogMargins.java Changeset: 1c48544c3da9 Author: lana Date: 2013-07-26 15:46 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/1c48544c3da9 Merge - src/share/classes/com/sun/org/apache/xml/internal/security/resource/log4j.properties - src/share/classes/com/sun/org/apache/xml/internal/security/transforms/implementations/FuncHereContext.java - src/share/classes/com/sun/org/apache/xml/internal/security/utils/CachedXPathAPIHolder.java - src/share/classes/com/sun/org/apache/xml/internal/security/utils/CachedXPathFuncHereAPI.java - src/share/classes/com/sun/org/apache/xml/internal/security/utils/XPathFuncHereAPI.java - src/share/classes/java/util/stream/StreamBuilder.java - src/share/classes/javax/security/auth/callback/package.html - src/share/classes/javax/security/auth/kerberos/package.html - src/share/classes/javax/security/auth/login/package.html - src/share/classes/javax/security/auth/package.html - src/share/classes/javax/security/auth/spi/package.html - src/share/classes/javax/security/auth/x500/package.html - src/share/classes/javax/security/cert/package.html - src/share/classes/javax/security/sasl/package.html - test/java/util/Collections/EmptySortedSet.java Changeset: 921338e44ba7 Author: lana Date: 2013-07-26 17:12 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/921338e44ba7 Merge Changeset: 046025f78ea8 Author: jgodinez Date: 2013-07-30 13:01 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/046025f78ea8 8021835: Fix for 8016343 will not compile on Windows. Reviewed-by: jchen, prr ! src/share/classes/sun/print/PSPrinterJob.java Changeset: 7f0e569c5a66 Author: bae Date: 2013-07-31 13:11 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/7f0e569c5a66 8020983: OutOfMemoryError caused by non garbage collected JPEGImageWriter Instances Reviewed-by: prr, flar ! src/share/native/sun/awt/image/jpeg/imageioJPEG.c + test/javax/imageio/plugins/jpeg/JpegWriterLeakTest.java Changeset: 726ac8f75b54 Author: lana Date: 2013-07-31 12:56 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/726ac8f75b54 Merge Changeset: 6e10d93273d0 Author: juh Date: 2013-07-18 10:49 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/6e10d93273d0 8020426: Fix doclint accessibility issues in java.io Reviewed-by: mduigou, darcy, chegar ! src/share/classes/java/io/DataInput.java ! src/share/classes/java/io/File.java ! src/share/classes/java/io/ObjectStreamField.java ! src/share/classes/java/io/RandomAccessFile.java Changeset: b39797bb86c0 Author: sherman Date: 2013-07-18 11:02 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/b39797bb86c0 8016025: JSR 310 DateTime API Updates IV 8020418: Cleanup of -Xlint warnings in java.time 8016623: test/java/time/format/TestDateTimeTextProvider.java failing Summary: Integration of JSR310 Date/Time API update IV Reviewed-by: sherman Contributed-by: scolebourne at joda.org, roger.riggs at oracle.com, masayoshi.okutsu at oracle.com, patrick.zhang at oracle.com, chand.basha at oracle.com ! src/share/classes/java/time/DayOfWeek.java ! src/share/classes/java/time/Duration.java ! src/share/classes/java/time/Instant.java ! src/share/classes/java/time/LocalDate.java ! src/share/classes/java/time/LocalDateTime.java ! src/share/classes/java/time/LocalTime.java ! src/share/classes/java/time/Month.java ! src/share/classes/java/time/MonthDay.java ! src/share/classes/java/time/OffsetDateTime.java ! src/share/classes/java/time/OffsetTime.java ! src/share/classes/java/time/Period.java ! src/share/classes/java/time/Year.java ! src/share/classes/java/time/YearMonth.java ! src/share/classes/java/time/ZoneId.java ! src/share/classes/java/time/ZoneOffset.java ! src/share/classes/java/time/ZoneRegion.java ! src/share/classes/java/time/ZonedDateTime.java ! src/share/classes/java/time/chrono/ChronoDateImpl.java ! src/share/classes/java/time/chrono/ChronoLocalDate.java ! src/share/classes/java/time/chrono/ChronoLocalDateTime.java ! src/share/classes/java/time/chrono/ChronoLocalDateTimeImpl.java ! src/share/classes/java/time/chrono/ChronoZonedDateTime.java ! src/share/classes/java/time/chrono/ChronoZonedDateTimeImpl.java ! src/share/classes/java/time/chrono/Chronology.java ! src/share/classes/java/time/chrono/Era.java ! src/share/classes/java/time/chrono/HijrahChronology.java ! src/share/classes/java/time/chrono/HijrahDate.java ! src/share/classes/java/time/chrono/IsoChronology.java ! src/share/classes/java/time/chrono/JapaneseChronology.java ! src/share/classes/java/time/chrono/JapaneseDate.java ! src/share/classes/java/time/chrono/JapaneseEra.java ! src/share/classes/java/time/chrono/MinguoChronology.java ! src/share/classes/java/time/chrono/MinguoDate.java ! src/share/classes/java/time/chrono/ThaiBuddhistChronology.java ! src/share/classes/java/time/chrono/ThaiBuddhistDate.java ! src/share/classes/java/time/chrono/package-info.java ! src/share/classes/java/time/format/DateTimeFormatter.java ! src/share/classes/java/time/format/DateTimeFormatterBuilder.java ! src/share/classes/java/time/format/DateTimePrintContext.java ! src/share/classes/java/time/format/Parsed.java ! src/share/classes/java/time/temporal/ChronoField.java ! src/share/classes/java/time/temporal/ChronoUnit.java ! src/share/classes/java/time/temporal/IsoFields.java ! src/share/classes/java/time/temporal/JulianFields.java ! src/share/classes/java/time/temporal/Temporal.java ! src/share/classes/java/time/temporal/TemporalAccessor.java ! src/share/classes/java/time/temporal/TemporalField.java ! src/share/classes/java/time/temporal/TemporalUnit.java ! src/share/classes/java/time/temporal/ValueRange.java ! src/share/classes/java/time/temporal/WeekFields.java ! src/share/lib/hijrah-config-umalqura.properties ! test/java/time/tck/java/time/MockSimplePeriod.java ! test/java/time/tck/java/time/TCKClock_Fixed.java ! test/java/time/tck/java/time/TCKDayOfWeek.java ! test/java/time/tck/java/time/TCKInstant.java ! test/java/time/tck/java/time/TCKLocalDate.java ! test/java/time/tck/java/time/TCKLocalDateTime.java ! test/java/time/tck/java/time/TCKLocalTime.java ! test/java/time/tck/java/time/TCKMonth.java ! test/java/time/tck/java/time/TCKMonthDay.java ! test/java/time/tck/java/time/TCKOffsetDateTime.java ! test/java/time/tck/java/time/TCKOffsetTime.java ! test/java/time/tck/java/time/TCKPeriod.java ! test/java/time/tck/java/time/TCKYear.java ! test/java/time/tck/java/time/TCKYearMonth.java ! test/java/time/tck/java/time/TCKZoneId.java ! test/java/time/tck/java/time/TCKZonedDateTime.java ! test/java/time/tck/java/time/chrono/CopticDate.java ! test/java/time/tck/java/time/chrono/TCKChronoLocalDate.java ! test/java/time/tck/java/time/chrono/TCKChronoLocalDateTime.java ! test/java/time/tck/java/time/chrono/TCKChronoZonedDateTime.java ! test/java/time/tck/java/time/chrono/TCKChronology.java ! test/java/time/tck/java/time/chrono/TCKHijrahChronology.java ! test/java/time/tck/java/time/chrono/TCKHijrahEra.java ! test/java/time/tck/java/time/chrono/TCKIsoChronology.java ! test/java/time/tck/java/time/chrono/TCKJapaneseChronology.java ! test/java/time/tck/java/time/chrono/TCKJapaneseEra.java ! test/java/time/tck/java/time/chrono/TCKMinguoChronology.java ! test/java/time/tck/java/time/chrono/TCKThaiBuddhistChronology.java + test/java/time/tck/java/time/format/TCKFormatStyle.java + test/java/time/tck/java/time/format/TCKResolverStyle.java + test/java/time/tck/java/time/format/TCKSignStyle.java ! test/java/time/tck/java/time/format/TCKTextStyle.java ! test/java/time/tck/java/time/format/TCKZoneIdPrinterParser.java + test/java/time/tck/java/time/temporal/TCKChronoField.java + test/java/time/tck/java/time/temporal/TCKChronoUnit.java ! test/java/time/tck/java/time/temporal/TCKWeekFields.java ! test/java/time/tck/java/time/zone/TCKZoneRules.java ! test/java/time/test/java/time/MockSimplePeriod.java ! test/java/time/test/java/time/chrono/TestChronoLocalDate.java ! test/java/time/test/java/time/chrono/TestExampleCode.java ! test/java/time/test/java/time/chrono/TestJapaneseChronoImpl.java ! test/java/time/test/java/time/chrono/TestJapaneseChronology.java ! test/java/time/test/java/time/chrono/TestUmmAlQuraChronology.java ! test/java/time/test/java/time/format/TestDateTimeTextProvider.java ! test/java/time/test/java/time/format/TestNonIsoFormatter.java ! test/java/time/test/java/time/format/TestNumberPrinter.java ! test/java/time/test/java/time/format/TestReducedPrinter.java ! test/java/time/test/java/time/temporal/MockFieldNoValue.java ! test/java/time/test/java/time/temporal/MockFieldValue.java Changeset: 2323b973adaa Author: darcy Date: 2013-07-18 23:16 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/2323b973adaa 8020810: Typo in javadoc for Class.toGenericString() Reviewed-by: dholmes ! src/share/classes/java/lang/Class.java ! src/share/classes/java/lang/reflect/Parameter.java Changeset: e6aeeec33e53 Author: uta Date: 2013-07-19 12:53 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/e6aeeec33e53 8016579: (process) IOException thrown by ProcessBuilder.start() method is incorrectly encoded Reviewed-by: martin, dxu ! src/share/native/java/io/io_util.c ! src/windows/native/java/io/io_util_md.c ! src/windows/native/java/lang/ProcessImpl_md.c Changeset: e013b32118af Author: darcy Date: 2013-07-19 09:42 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/e013b32118af 8020948: Fix doclint issues in misc package-info.java files Reviewed-by: dholmes, chegar ! src/share/classes/java/nio/file/attribute/package-info.java ! src/share/classes/java/util/function/package-info.java Changeset: 4bd04969a228 Author: darcy Date: 2013-07-20 11:39 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/4bd04969a228 8020971: Fix doclint issues in java.nio.* Reviewed-by: lancea ! src/share/classes/java/nio/channels/package-info.java ! src/share/classes/java/nio/charset/Charset.java ! src/share/classes/java/nio/charset/MalformedInputException.java ! src/share/classes/java/nio/charset/UnmappableCharacterException.java ! src/share/classes/java/nio/file/package-info.java Changeset: dcd89e60051a Author: khazra Date: 2013-07-22 15:24 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/dcd89e60051a 8020498: Crash when both libnet.so and libmawt.so are loaded Reviewed-by: chegar, dsamersoff ! src/share/native/java/net/net_util.c Changeset: a3a2889b1049 Author: dl Date: 2013-07-22 15:26 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/a3a2889b1049 8020976: Ensure consistent insertion for ConcurrentHashMap Reviewed-by: chegar ! src/share/classes/java/util/concurrent/ConcurrentHashMap.java Changeset: a6cbb9808e4b Author: mduigou Date: 2013-07-22 12:59 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/a6cbb9808e4b 6799426: Adds constructor PriorityQueue(Comparator) Reviewed-by: lancea ! src/share/classes/java/util/PriorityQueue.java Changeset: 7716beb127d4 Author: darcy Date: 2013-07-22 22:11 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/7716beb127d4 8021109: Add serialVersionUID to LambdaConversionException.java Reviewed-by: jrose ! src/share/classes/java/lang/invoke/LambdaConversionException.java Changeset: 6f3b940fe9f8 Author: igerasim Date: 2013-07-23 18:57 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/6f3b940fe9f8 8016838: improvement of RedefineBigClass and RetransformBigClass tests Reviewed-by: dcubed ! test/ProblemList.txt ! test/java/lang/instrument/RedefineBigClass.sh ! test/java/lang/instrument/RedefineBigClassApp.java ! test/java/lang/instrument/RetransformBigClass.sh ! test/java/lang/instrument/RetransformBigClassApp.java Changeset: 8156630c1ed3 Author: mduigou Date: 2013-07-23 13:20 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/8156630c1ed3 8019840: Spec updates for java.util.function Reviewed-by: mduigou, chegar Contributed-by: brian.goetz at oracle.com ! src/share/classes/java/util/function/BiConsumer.java ! src/share/classes/java/util/function/BiFunction.java ! src/share/classes/java/util/function/BiPredicate.java ! src/share/classes/java/util/function/BinaryOperator.java ! src/share/classes/java/util/function/BooleanSupplier.java ! src/share/classes/java/util/function/Consumer.java ! src/share/classes/java/util/function/DoubleBinaryOperator.java ! src/share/classes/java/util/function/DoubleConsumer.java ! src/share/classes/java/util/function/DoubleFunction.java ! src/share/classes/java/util/function/DoublePredicate.java ! src/share/classes/java/util/function/DoubleSupplier.java ! src/share/classes/java/util/function/DoubleToIntFunction.java ! src/share/classes/java/util/function/DoubleToLongFunction.java ! src/share/classes/java/util/function/DoubleUnaryOperator.java ! src/share/classes/java/util/function/Function.java ! src/share/classes/java/util/function/IntBinaryOperator.java ! src/share/classes/java/util/function/IntConsumer.java ! src/share/classes/java/util/function/IntFunction.java ! src/share/classes/java/util/function/IntPredicate.java ! src/share/classes/java/util/function/IntSupplier.java ! src/share/classes/java/util/function/IntToDoubleFunction.java ! src/share/classes/java/util/function/IntToLongFunction.java ! src/share/classes/java/util/function/IntUnaryOperator.java ! src/share/classes/java/util/function/LongBinaryOperator.java ! src/share/classes/java/util/function/LongConsumer.java ! src/share/classes/java/util/function/LongFunction.java ! src/share/classes/java/util/function/LongPredicate.java ! src/share/classes/java/util/function/LongSupplier.java ! src/share/classes/java/util/function/LongToDoubleFunction.java ! src/share/classes/java/util/function/LongToIntFunction.java ! src/share/classes/java/util/function/LongUnaryOperator.java ! src/share/classes/java/util/function/ObjDoubleConsumer.java ! src/share/classes/java/util/function/ObjIntConsumer.java ! src/share/classes/java/util/function/ObjLongConsumer.java ! src/share/classes/java/util/function/Predicate.java ! src/share/classes/java/util/function/Supplier.java ! src/share/classes/java/util/function/ToDoubleBiFunction.java ! src/share/classes/java/util/function/ToDoubleFunction.java ! src/share/classes/java/util/function/ToIntBiFunction.java ! src/share/classes/java/util/function/ToIntFunction.java ! src/share/classes/java/util/function/ToLongBiFunction.java ! src/share/classes/java/util/function/ToLongFunction.java ! src/share/classes/java/util/function/UnaryOperator.java ! src/share/classes/java/util/function/package-info.java Changeset: 012996e9259f Author: mduigou Date: 2013-07-23 13:21 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/012996e9259f Merge Changeset: 187a1f2613c0 Author: sjiang Date: 2013-07-24 15:47 +0200 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/187a1f2613c0 8016221: A unit test should not use a fix port to run a jmx connector Reviewed-by: jbachorik, dfuchs ! test/com/sun/management/DiagnosticCommandMBean/DcmdMBeanDoubleInvocationTest.java ! test/com/sun/management/DiagnosticCommandMBean/DcmdMBeanInvocationTest.java ! test/com/sun/management/DiagnosticCommandMBean/DcmdMBeanTest.java Changeset: f9224fb49890 Author: juh Date: 2013-07-24 12:48 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/f9224fb49890 8016916: UnstructuredName should support DirectoryString Reviewed-by: mullan ! src/share/classes/sun/security/pkcs/PKCS9Attribute.java ! src/share/classes/sun/security/tools/keytool/Main.java + test/sun/security/pkcs/pkcs9/UnstructuredName.java Changeset: fd1b5adcfdf0 Author: chegar Date: 2013-07-24 22:52 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/fd1b5adcfdf0 8021261: ProblemList.txt updates (7/2013) Reviewed-by: alanb, mcimadamore ! test/ProblemList.txt Changeset: a834ab2c1354 Author: mullan Date: 2013-07-25 10:58 -0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/a834ab2c1354 8010748: Add PKIXRevocationChecker NO_FALLBACK option and improve SOFT_FAIL option Reviewed-by: vinnie ! src/share/classes/java/security/cert/PKIXRevocationChecker.java ! src/share/classes/sun/security/provider/certpath/OCSP.java ! src/share/classes/sun/security/provider/certpath/OCSPResponse.java ! src/share/classes/sun/security/provider/certpath/PKIXCertPathValidator.java ! src/share/classes/sun/security/provider/certpath/ReverseState.java ! src/share/classes/sun/security/provider/certpath/RevocationChecker.java ! src/share/classes/sun/security/provider/certpath/SunCertPathBuilder.java ! test/java/security/cert/PKIXRevocationChecker/UnitTest.java Changeset: 22a391706a0b Author: mullan Date: 2013-07-25 11:09 -0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/22a391706a0b Merge - make/sun/xawt/ToBin.java - makefiles/sun/awt/X11/ToBin.java - src/share/classes/com/sun/org/apache/xml/internal/security/resource/log4j.properties - src/share/classes/com/sun/org/apache/xml/internal/security/transforms/implementations/FuncHereContext.java - src/share/classes/com/sun/org/apache/xml/internal/security/utils/CachedXPathAPIHolder.java - src/share/classes/com/sun/org/apache/xml/internal/security/utils/CachedXPathFuncHereAPI.java - src/share/classes/com/sun/org/apache/xml/internal/security/utils/XPathFuncHereAPI.java - src/share/classes/java/security/acl/package.html - src/share/classes/java/security/cert/package.html - src/share/classes/java/security/interfaces/package.html - src/share/classes/java/security/package.html - src/share/classes/java/security/spec/package.html - src/share/classes/java/util/stream/StreamBuilder.java - src/share/classes/javax/security/auth/callback/package.html - src/share/classes/javax/security/auth/kerberos/package.html - src/share/classes/javax/security/auth/login/package.html - src/share/classes/javax/security/auth/package.html - src/share/classes/javax/security/auth/spi/package.html - src/share/classes/javax/security/auth/x500/package.html - src/share/classes/javax/security/cert/package.html - src/share/classes/javax/security/sasl/package.html - src/share/classes/sun/misc/Hashing.java - src/share/classes/sun/security/krb5/internal/rcache/CacheTable.java - src/share/classes/sun/security/krb5/internal/rcache/ReplayCache.java ! src/share/classes/sun/security/provider/certpath/RevocationChecker.java - src/solaris/classes/sun/awt/X11/XIconInfo.java - src/solaris/classes/sun/awt/X11/security-icon-bw16.png - src/solaris/classes/sun/awt/X11/security-icon-bw24.png - src/solaris/classes/sun/awt/X11/security-icon-bw32.png - src/solaris/classes/sun/awt/X11/security-icon-bw48.png - src/solaris/classes/sun/awt/X11/security-icon-interim16.png - src/solaris/classes/sun/awt/X11/security-icon-interim24.png - src/solaris/classes/sun/awt/X11/security-icon-interim32.png - src/solaris/classes/sun/awt/X11/security-icon-interim48.png - src/solaris/classes/sun/awt/X11/security-icon-yellow16.png - src/solaris/classes/sun/awt/X11/security-icon-yellow24.png - src/solaris/classes/sun/awt/X11/security-icon-yellow32.png - src/solaris/classes/sun/awt/X11/security-icon-yellow48.png - src/solaris/classes/sun/awt/fontconfigs/linux.fontconfig.Fedora.properties - src/solaris/classes/sun/awt/fontconfigs/linux.fontconfig.SuSE.properties - src/solaris/classes/sun/awt/fontconfigs/linux.fontconfig.Ubuntu.properties - src/solaris/classes/sun/awt/fontconfigs/linux.fontconfig.properties - test/java/lang/invoke/7196190/MHProxyTest.java - test/java/util/Collections/EmptySortedSet.java - test/java/util/Comparators/BasicTest.java - test/sun/misc/Hashing.java - test/sun/security/krb5/auto/ReplayCache.java Changeset: 21120e3682ef Author: darcy Date: 2013-07-25 09:59 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/21120e3682ef 8021408: Fix misc doclint issues in java.util and java.io Reviewed-by: dholmes, chegar, psandoz ! src/share/classes/java/io/ObjectInputStream.java ! src/share/classes/java/io/ObjectOutputStream.java ! src/share/classes/java/util/jar/Attributes.java ! src/share/classes/java/util/jar/JarEntry.java ! src/share/classes/java/util/jar/JarFile.java ! src/share/classes/java/util/stream/StreamSupport.java Changeset: 690dcbaa69b7 Author: chegar Date: 2013-07-25 19:37 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/690dcbaa69b7 8021417: Fix doclint issues in java.util.concurrent Reviewed-by: chegar, lancea Contributed-by: Doug Lea
! src/share/classes/java/util/concurrent/AbstractExecutorService.java ! src/share/classes/java/util/concurrent/ExecutorService.java ! src/share/classes/java/util/concurrent/Executors.java ! src/share/classes/java/util/concurrent/ForkJoinPool.java ! src/share/classes/java/util/concurrent/ForkJoinTask.java ! src/share/classes/java/util/concurrent/ScheduledExecutorService.java ! src/share/classes/java/util/concurrent/ScheduledThreadPoolExecutor.java ! src/share/classes/java/util/concurrent/TimeUnit.java ! src/share/classes/java/util/concurrent/atomic/AtomicIntegerFieldUpdater.java ! src/share/classes/java/util/concurrent/atomic/AtomicLongFieldUpdater.java ! src/share/classes/java/util/concurrent/atomic/AtomicReferenceFieldUpdater.java Changeset: 9cd5159fa870 Author: chegar Date: 2013-07-25 19:45 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/9cd5159fa870 8021421: More doclint fixes in java.net Reviewed-by: lancea, darcy ! src/share/classes/java/net/URI.java Changeset: 662ec7782102 Author: joehw Date: 2013-07-25 13:20 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/662ec7782102 8021148: Regression in SAXParserImpl in 7u40 b34 (NPE) Reviewed-by: chegar, lancea, dfuchs + test/javax/xml/jaxp/parsers/8021148/JAXPSAXParserTest.java + test/javax/xml/jaxp/parsers/8021148/TestBase.java Changeset: 1744a32d3db3 Author: mullan Date: 2013-07-25 20:12 -0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/1744a32d3db3 8012288: XML DSig API allows wrong tag names and extra elements in SignedInfo Reviewed-by: xuelei ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMKeyValue.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMManifest.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMReference.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMRetrievalMethod.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMSignatureProperties.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMSignedInfo.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMUtils.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMX509IssuerSerial.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMXMLSignature.java Changeset: 4100ab44ba4f Author: mullan Date: 2013-07-25 20:30 -0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/4100ab44ba4f Merge Changeset: 86a827321c39 Author: darcy Date: 2013-07-25 20:03 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/86a827321c39 8021429: Fix lint warnings in java.lang.ref Reviewed-by: lancea, mduigou, alanb ! src/share/classes/java/lang/ref/FinalReference.java ! src/share/classes/java/lang/ref/Finalizer.java ! src/share/classes/java/lang/ref/Reference.java ! src/share/classes/java/lang/ref/ReferenceQueue.java Changeset: 6cc15a808b93 Author: peytoia Date: 2013-07-26 17:22 +0900 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/6cc15a808b93 8021108: Clean up doclint warnings and errors in java.text package Reviewed-by: darcy, okutsu ! src/share/classes/java/text/Annotation.java ! src/share/classes/java/text/AttributedCharacterIterator.java ! src/share/classes/java/text/Bidi.java ! src/share/classes/java/text/BreakIterator.java ! src/share/classes/java/text/ChoiceFormat.java ! src/share/classes/java/text/CollationElementIterator.java ! src/share/classes/java/text/CollationKey.java ! src/share/classes/java/text/DateFormat.java ! src/share/classes/java/text/DateFormatSymbols.java ! src/share/classes/java/text/DecimalFormat.java ! src/share/classes/java/text/DecimalFormatSymbols.java ! src/share/classes/java/text/FieldPosition.java ! src/share/classes/java/text/Format.java ! src/share/classes/java/text/MessageFormat.java ! src/share/classes/java/text/Normalizer.java ! src/share/classes/java/text/NumberFormat.java ! src/share/classes/java/text/ParseException.java ! src/share/classes/java/text/ParsePosition.java ! src/share/classes/java/text/RuleBasedCollator.java ! src/share/classes/java/text/SimpleDateFormat.java ! src/share/classes/java/text/StringCharacterIterator.java Changeset: 952476b80fa7 Author: jbachorik Date: 2013-07-26 10:12 +0200 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/952476b80fa7 8020875: java/lang/management/ThreadMXBean/ResetPeakThreadCount.java fails intermittently Reviewed-by: dfuchs, chegar ! test/java/lang/management/ThreadMXBean/ResetPeakThreadCount.java Changeset: 7ae061cfd4be Author: juh Date: 2013-07-26 14:16 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/7ae061cfd4be 8019544: Need to run ProviderTest.java in othervm mode. Reviewed-by: wetmore, xuelei, vinnie Contributed-by: rajan.halade at oracle.com ! test/sun/security/ssl/com/sun/net/ssl/SSLSecurity/ProviderTest.java Changeset: 25575c3c209d Author: lana Date: 2013-07-26 14:07 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/25575c3c209d Merge Changeset: 9f9ffe6be557 Author: lana Date: 2013-07-26 15:16 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/9f9ffe6be557 Merge Changeset: f056728871f8 Author: mduigou Date: 2013-07-26 17:23 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/f056728871f8 8021601: Add unit test for PriorityQueue(Comparator) constructor Reviewed-by: darcy, alanb ! src/share/classes/java/util/PriorityQueue.java ! test/java/util/PriorityQueue/RemoveContains.java Changeset: d4b2436892c8 Author: bpb Date: 2013-07-26 17:03 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/d4b2436892c8 8014319: Faster division of large integers Summary: Implement Burnickel-Ziegler division algorithm in BigInteger Reviewed-by: bpb, martin Contributed-by: Tim Buktu ! src/share/classes/java/math/BigInteger.java ! src/share/classes/java/math/MutableBigInteger.java ! test/java/math/BigInteger/BigIntegerTest.java Changeset: a1c01457cf6c Author: bpb Date: 2013-07-26 17:09 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/a1c01457cf6c 8020641: Clean up some code style in recent BigInteger contributions Summary: Some minor cleanup to adhere better to Java coding conventions. Reviewed-by: darcy Contributed-by: Brian Burkhalter ! src/share/classes/java/math/BigInteger.java ! src/share/classes/java/math/MutableBigInteger.java ! test/java/math/BigInteger/BigIntegerTest.java Changeset: eb1dc65162e8 Author: darcy Date: 2013-07-27 10:27 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/eb1dc65162e8 8021609: Fix doclint issues in java.nio.charset Reviewed-by: alanb ! src/share/classes/java/nio/charset/Charset-X-Coder.java.template Changeset: 5d4a35823071 Author: mduigou Date: 2013-07-27 12:26 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/5d4a35823071 8021588: Remove explicit othervm execution from jdk/test/Makefile Reviewed-by: alanb ! test/Makefile Changeset: 24bda55fca48 Author: sundar Date: 2013-07-29 21:39 +0530 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/24bda55fca48 8021773: print function as defined by jrunscript's init.js script is incompatible with nashorn's definition Reviewed-by: hannesw, lagergren ! src/share/classes/com/sun/tools/script/shell/init.js Changeset: e83fc6d9cf03 Author: psandoz Date: 2013-07-29 19:41 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/e83fc6d9cf03 8020156: TreeMap.values().spliterator() does not report ORDERED 8020009: TreeMap.entrySet().spliterator() reports SORTED + null comparator but the elements are not Comparable Reviewed-by: mduigou ! src/share/classes/java/util/TreeMap.java + test/java/util/Spliterator/SpliteratorCharacteristics.java Changeset: c042fd498f79 Author: ascarpino Date: 2013-07-19 11:34 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/c042fd498f79 8012971: PKCS11Test hiding exception failures Reviewed-by: vinnie, valeriep ! test/ProblemList.txt ! test/sun/security/pkcs11/PKCS11Test.java ! test/sun/security/pkcs11/SecmodTest.java Changeset: e47569593fa0 Author: ascarpino Date: 2013-07-29 13:43 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/e47569593fa0 8020424: The NSS version should be detected before running crypto tests Reviewed-by: valeriep ! test/ProblemList.txt ! test/sun/security/pkcs11/KeyStore/SecretKeysBasic.java ! test/sun/security/pkcs11/PKCS11Test.java + test/sun/security/pkcs11/README ! test/sun/security/pkcs11/ec/ReadCertificates.java ! test/sun/security/pkcs11/ec/TestCurves.java ! test/sun/security/pkcs11/ec/TestECDH.java ! test/sun/security/pkcs11/ec/TestECDH2.java ! test/sun/security/pkcs11/ec/TestECDSA.java ! test/sun/security/pkcs11/ec/TestECDSA2.java ! test/sun/security/pkcs11/ec/TestECGenSpec.java ! test/sun/security/pkcs11/ec/TestKeyFactory.java Changeset: 613cc7beba64 Author: xuelei Date: 2013-07-29 19:36 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/613cc7beba64 8021841: Remove SSLEngineDeadlock.java from problem list Reviewed-by: wetmore ! test/ProblemList.txt Changeset: c76f89695c90 Author: juh Date: 2013-07-30 11:04 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/c76f89695c90 8021833: javadoc cleanup in java.net Summary: and converted to {@code }; package.html to package-info.java Reviewed-by: darcy, chegar ! src/share/classes/java/net/Authenticator.java ! src/share/classes/java/net/ContentHandler.java ! src/share/classes/java/net/ContentHandlerFactory.java ! src/share/classes/java/net/CookieHandler.java ! src/share/classes/java/net/CookieManager.java ! src/share/classes/java/net/CookiePolicy.java ! src/share/classes/java/net/CookieStore.java ! src/share/classes/java/net/DatagramPacket.java ! src/share/classes/java/net/DatagramSocket.java ! src/share/classes/java/net/DatagramSocketImpl.java ! src/share/classes/java/net/DatagramSocketImplFactory.java ! src/share/classes/java/net/FileNameMap.java ! src/share/classes/java/net/HttpCookie.java ! src/share/classes/java/net/HttpRetryException.java ! src/share/classes/java/net/HttpURLConnection.java ! src/share/classes/java/net/IDN.java ! src/share/classes/java/net/Inet4Address.java ! src/share/classes/java/net/Inet6Address.java ! src/share/classes/java/net/InetAddress.java ! src/share/classes/java/net/InetSocketAddress.java ! src/share/classes/java/net/InterfaceAddress.java ! src/share/classes/java/net/JarURLConnection.java ! src/share/classes/java/net/MalformedURLException.java ! src/share/classes/java/net/MulticastSocket.java ! src/share/classes/java/net/NetPermission.java ! src/share/classes/java/net/NetworkInterface.java ! src/share/classes/java/net/PasswordAuthentication.java ! src/share/classes/java/net/PortUnreachableException.java ! src/share/classes/java/net/ProtocolException.java ! src/share/classes/java/net/Proxy.java ! src/share/classes/java/net/ProxySelector.java ! src/share/classes/java/net/ResponseCache.java ! src/share/classes/java/net/ServerSocket.java ! src/share/classes/java/net/Socket.java ! src/share/classes/java/net/SocketException.java ! src/share/classes/java/net/SocketImpl.java ! src/share/classes/java/net/SocketImplFactory.java ! src/share/classes/java/net/SocketInputStream.java ! src/share/classes/java/net/SocketOptions.java ! src/share/classes/java/net/SocketOutputStream.java ! src/share/classes/java/net/SocketPermission.java ! src/share/classes/java/net/SocksSocketImpl.java ! src/share/classes/java/net/URI.java ! src/share/classes/java/net/URISyntaxException.java ! src/share/classes/java/net/URL.java ! src/share/classes/java/net/URLClassLoader.java ! src/share/classes/java/net/URLConnection.java ! src/share/classes/java/net/URLDecoder.java ! src/share/classes/java/net/URLEncoder.java ! src/share/classes/java/net/URLStreamHandler.java ! src/share/classes/java/net/URLStreamHandlerFactory.java ! src/share/classes/java/net/UnknownHostException.java ! src/share/classes/java/net/UnknownServiceException.java + src/share/classes/java/net/package-info.java - src/share/classes/java/net/package.html Changeset: 8bc1bbd5b659 Author: sherman Date: 2013-07-30 14:43 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/8bc1bbd5b659 8021767: test/java/time/tck/java/time/format/TCKFormatStyle.java failing Summary: Correct to use fixed locale, not locale of test environment Reviewed-by: alanb, okutsu Contributed-by: roger.riggs at oracle.com ! test/java/time/tck/java/time/format/TCKFormatStyle.java Changeset: 09a77a1bdbc3 Author: henryjen Date: 2013-07-30 15:47 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/09a77a1bdbc3 8020977: StringJoiner merges with itself not as expected Reviewed-by: psandoz, chegar, mduigou, smarks ! src/share/classes/java/util/StringJoiner.java ! test/java/util/StringJoiner/MergeTest.java Changeset: 76d88a752a03 Author: psandoz Date: 2013-07-30 11:32 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/76d88a752a03 8021863: Stream.concat incorrectly calculates unsized state Reviewed-by: chegar ! src/share/classes/java/util/stream/Streams.java ! test/java/util/stream/test/org/openjdk/tests/java/util/stream/ConcatOpTest.java Changeset: d30f357c6050 Author: psandoz Date: 2013-07-30 14:03 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/d30f357c6050 8021883: j.u.Random/RandomStream.java test needs more robust timeout duration Reviewed-by: chegar ! test/java/util/Random/RandomStreamTest.java Changeset: 5561b34f6d4c Author: bpb Date: 2013-07-30 10:35 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/5561b34f6d4c 8020539: Clean up doclint problems in java.util package, part 2 Summary: Clean up doclint errors and warnings in classes in java.util Reviewed-by: darcy, chegar Contributed-by: Brian Burkhalter ! src/share/classes/java/util/List.java ! src/share/classes/java/util/Map.java ! src/share/classes/java/util/Optional.java ! src/share/classes/java/util/Random.java ! src/share/classes/java/util/Scanner.java ! src/share/classes/java/util/ServiceLoader.java ! src/share/classes/java/util/StringJoiner.java ! src/share/classes/java/util/TimeZone.java ! src/share/classes/java/util/UUID.java ! src/share/classes/java/util/Vector.java Changeset: 4bd51f6268f4 Author: rbackman Date: 2013-07-24 10:57 +0200 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/4bd51f6268f4 8006324: [TEST_BUG] sun/invoke/util/ValueConversionsTest.java should be modified Reviewed-by: kvn, twisti ! test/sun/invoke/util/ValueConversionsTest.java Changeset: 0741b19835b0 Author: lana Date: 2013-07-31 13:02 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/0741b19835b0 Merge - src/share/classes/java/net/package.html Changeset: 8ed8e2b4b90e Author: lana Date: 2013-08-06 10:10 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/8ed8e2b4b90e Merge Changeset: 9bcc3f2af980 Author: lana Date: 2013-08-07 12:03 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/9bcc3f2af980 Merge - src/share/classes/java/net/package.html From anton.tarasov at oracle.com Thu Aug 8 02:20:57 2013 From: anton.tarasov at oracle.com (anton.tarasov at oracle.com) Date: Thu, 08 Aug 2013 09:20:57 +0000 Subject: hg: jdk8/awt/jdk: 8013611: Modal dialog fails to obtain keyboard focus Message-ID: <20130808092126.BCF81486CB@hg.openjdk.java.net> Changeset: 903a279f1fce Author: ant Date: 2013-08-09 05:20 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/903a279f1fce 8013611: Modal dialog fails to obtain keyboard focus Reviewed-by: leonidr ! src/share/classes/java/awt/KeyboardFocusManager.java + test/java/awt/Focus/8013611/JDK8013611.java From konstantin.perikov at gmail.com Thu Aug 8 03:20:26 2013 From: konstantin.perikov at gmail.com (Konstantin Perikov) Date: Thu, 8 Aug 2013 14:20:26 +0400 Subject: Request for review: 7027045 Message-ID: Hi, AWT team, Could you please review the fix for the following bug: *7027045: : (doc) java/awt/Window.java has several typos in javadoc* Fix for version OpenJDK8. Also, I fix some stuff and change it for {@code } The webrev is available here: http://yadi.sk/d/KHB0hBlA7gkke P.S. Since, I'm newcomer, I don't have rights to push, so I need a sponsor. Who could help me? Thanks, Konstantin -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20130808/f4a736be/attachment.html From artem.ananiev at oracle.com Thu Aug 8 05:33:47 2013 From: artem.ananiev at oracle.com (Artem Ananiev) Date: Thu, 08 Aug 2013 16:33:47 +0400 Subject: Request for review: 7027045 In-Reply-To: References: Message-ID: <5203902B.7010701@oracle.com> Hi, Konstantin, I looked through the changes, which mostly replacements with {@code}. This part of the fix looks fine. Changing /* to /** for the "isInShow" field doesn't make sense, as this field is transient and is not serialized anyway. However, it doesn't hurt as well. Please, keep comment about synchronization for the "type" field. It's a hint for developers, that this field should only be accessed or modified under the object lock. I agree, JavaDoc is not the best place for such hints, but I don't see any better solutions. Non-technical comments: 1. Please, provide a direct link to webrev, so people can click and see the changes. Downloading archives is not as convenient (and in this particular case just impossible, as Yandex.Disk is in Russian, people just won't be able to read the "Download" button). 2. Please, wait for at least one more person to have reviewed this fix. Thanks, Artem On 8/8/2013 2:20 PM, Konstantin Perikov wrote: > Hi, AWT team, > > Could you please review the fix for the following bug: > > *7027045: : (doc) java/awt/Window.java has several typos in javadoc* > > Fix for version OpenJDK8. Also, I fix some stuff and change it for {@code } > > The webrev is available here: > > http://yadi.sk/d/KHB0hBlA7gkke > > > P.S. Since, I'm newcomer, I don't have rights to push, so I need a sponsor. Who could help me? > > Thanks, > > Konstantin > From konstantin.perikov at gmail.com Thu Aug 8 05:54:40 2013 From: konstantin.perikov at gmail.com (Konstantin Perikov) Date: Thu, 8 Aug 2013 16:54:40 +0400 Subject: Request for review: 7027045 In-Reply-To: <5203902B.7010701@oracle.com> References: <5203902B.7010701@oracle.com> Message-ID: Okay. I keep comment about synchronization for the "type" field and return comment style for transient field. Is Google Drive better place for it? (that's why I ask yesterday about "good" place for webrev) https://drive.google.com/folderview?id=0B4QwwAaNe6wZUWJvTE9HRG40dnM&usp=sharing Artem, could you answer on my last question? P.S. Since, I'm newcomer, I don't have rights to push, so I need a sponsor. > Who could help me? Thanks, Konstantin. 2013/8/8 Artem Ananiev > Hi, Konstantin, > > I looked through the changes, which mostly replacements with > {@code}. This part of the fix looks fine. > > Changing /* to /** for the "isInShow" field doesn't make sense, as this > field is transient and is not serialized anyway. However, it doesn't hurt > as well. > > Please, keep comment about synchronization for the "type" field. It's a > hint for developers, that this field should only be accessed or modified > under the object lock. I agree, JavaDoc is not the best place for such > hints, but I don't see any better solutions. > > Non-technical comments: > > 1. Please, provide a direct link to webrev, so people can click and see > the changes. Downloading archives is not as convenient (and in this > particular case just impossible, as Yandex.Disk is in Russian, people just > won't be able to read the "Download" button). > > 2. Please, wait for at least one more person to have reviewed this fix. > > Thanks, > > Artem > > On 8/8/2013 2:20 PM, Konstantin Perikov wrote: > >> Hi, AWT team, >> >> Could you please review the fix for the following bug: >> >> *7027045: : (doc) java/awt/Window.java has several typos in javadoc* >> >> Fix for version OpenJDK8. Also, I fix some stuff and change >> it for {@code } >> >> The webrev is available here: >> >> http://yadi.sk/d/KHB0hBlA7gkke >> >> >> P.S. Since, I'm newcomer, I don't have rights to push, so I need a >> sponsor. Who could help me? >> >> Thanks, >> >> Konstantin >> >> -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20130808/094bde23/attachment.html From Sergey.Bylokhov at oracle.com Thu Aug 8 06:08:26 2013 From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov) Date: Thu, 08 Aug 2013 17:08:26 +0400 Subject: Request for review: 7027045 In-Reply-To: References: <5203902B.7010701@oracle.com> Message-ID: <5203984A.30409@oracle.com> On 08.08.2013 16:54, Konstantin Perikov wrote: > Artem, could you answer on my last question? > > P.S. Since, I'm newcomer, I don't have rights to push, so I need a > sponsor. Who could help me? > I will help to push these changes after review > > Thanks, Konstantin. > > > 2013/8/8 Artem Ananiev > > > Hi, Konstantin, > > I looked through the changes, which mostly replacements > with {@code}. This part of the fix looks fine. > > Changing /* to /** for the "isInShow" field doesn't make sense, as > this field is transient and is not serialized anyway. However, it > doesn't hurt as well. > > Please, keep comment about synchronization for the "type" field. > It's a hint for developers, that this field should only be > accessed or modified under the object lock. I agree, JavaDoc is > not the best place for such hints, but I don't see any better > solutions. > > Non-technical comments: > > 1. Please, provide a direct link to webrev, so people can click > and see the changes. Downloading archives is not as convenient > (and in this particular case just impossible, as Yandex.Disk is in > Russian, people just won't be able to read the "Download" button). > > 2. Please, wait for at least one more person to have reviewed this > fix. > > Thanks, > > Artem > > On 8/8/2013 2:20 PM, Konstantin Perikov wrote: > > Hi, AWT team, > > Could you please review the fix for the following bug: > > *7027045: : (doc) java/awt/Window.java has several typos in > javadoc* > > Fix for version OpenJDK8. Also, I fix some stuff > and change it for {@code } > > The webrev is available here: > > http://yadi.sk/d/KHB0hBlA7gkke > > > P.S. Since, I'm newcomer, I don't have rights to push, so I > need a sponsor. Who could help me? > > Thanks, > > Konstantin > > -- Best regards, Sergey. -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20130808/461ef0a0/attachment.html From Sergey.Bylokhov at oracle.com Thu Aug 8 06:47:43 2013 From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov) Date: Thu, 08 Aug 2013 17:47:43 +0400 Subject: Request for review: 7027045 In-Reply-To: References: <5203902B.7010701@oracle.com> Message-ID: <5203A17F.4060209@oracle.com> Hi, Konstantin. A few comments about the fix. FooListener in a few places was changed to the {@code FooListener} but it is not equivalent. Also I suggest to remove one of "and" from the "and and" in the line 2887, because you change this line anyway. On 08.08.2013 16:54, Konstantin Perikov wrote: > Okay. I keep comment about synchronization for the "type" field and > return comment style for transient field. > > Is Google Drive better place for it? (that's why I ask yesterday about > "good" place for webrev) > https://drive.google.com/folderview?id=0B4QwwAaNe6wZUWJvTE9HRG40dnM&usp=sharing No, it is not better, atleast i don't understand how to view index.html in this case or download all files at once. > > > > 2013/8/8 Artem Ananiev > > > Hi, Konstantin, > > I looked through the changes, which mostly replacements > with {@code}. This part of the fix looks fine. > > Changing /* to /** for the "isInShow" field doesn't make sense, as > this field is transient and is not serialized anyway. However, it > doesn't hurt as well. > > Please, keep comment about synchronization for the "type" field. > It's a hint for developers, that this field should only be > accessed or modified under the object lock. I agree, JavaDoc is > not the best place for such hints, but I don't see any better > solutions. > > Non-technical comments: > > 1. Please, provide a direct link to webrev, so people can click > and see the changes. Downloading archives is not as convenient > (and in this particular case just impossible, as Yandex.Disk is in > Russian, people just won't be able to read the "Download" button). > > 2. Please, wait for at least one more person to have reviewed this > fix. > > Thanks, > > Artem > > On 8/8/2013 2:20 PM, Konstantin Perikov wrote: > > Hi, AWT team, > > Could you please review the fix for the following bug: > > *7027045: : (doc) java/awt/Window.java has several typos in > javadoc* > > Fix for version OpenJDK8. Also, I fix some stuff > and change it for {@code } > > The webrev is available here: > > http://yadi.sk/d/KHB0hBlA7gkke > > > P.S. Since, I'm newcomer, I don't have rights to push, so I > need a sponsor. Who could help me? > > Thanks, > > Konstantin > > -- Best regards, Sergey. -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20130808/589fcc0f/attachment-0001.html From konstantin.perikov at gmail.com Thu Aug 8 08:01:00 2013 From: konstantin.perikov at gmail.com (Konstantin Perikov) Date: Thu, 8 Aug 2013 19:01:00 +0400 Subject: Request for review: 7027045 In-Reply-To: <5203A17F.4060209@oracle.com> References: <5203902B.7010701@oracle.com> <5203A17F.4060209@oracle.com> Message-ID: So, what is the best place for webrev, if I don't have access to ftp server? I don't have possibility to set up Apache server for that. Also, maybe I'm wrong, but to view index.html on ftp, you need to download it as well. Okay, I will remove "and and" at line 2887. About tag, let me look at Javadoc documentation, I have no idea, how it will behave in {@code} tag Konstantin. 2013/8/8 Sergey Bylokhov > Hi, Konstantin. > A few comments about the fix. > FooListener in a few places was changed to the > {@code FooListener} but it is not equivalent. > Also I suggest to remove one of "and" from the "and and" in the line 2887, > because you change this line anyway. > > > On 08.08.2013 16:54, Konstantin Perikov wrote: > > Okay. I keep comment about synchronization for the "type" field and return > comment style for transient field. > > Is Google Drive better place for it? (that's why I ask yesterday about > "good" place for webrev) > > https://drive.google.com/folderview?id=0B4QwwAaNe6wZUWJvTE9HRG40dnM&usp=sharing > > No, it is not better, atleast i don't understand how to view index.html in > this case or download all files at once. > > > > > 2013/8/8 Artem Ananiev > >> Hi, Konstantin, >> >> I looked through the changes, which mostly replacements >> with {@code}. This part of the fix looks fine. >> >> Changing /* to /** for the "isInShow" field doesn't make sense, as this >> field is transient and is not serialized anyway. However, it doesn't hurt >> as well. >> >> Please, keep comment about synchronization for the "type" field. It's a >> hint for developers, that this field should only be accessed or modified >> under the object lock. I agree, JavaDoc is not the best place for such >> hints, but I don't see any better solutions. >> >> Non-technical comments: >> >> 1. Please, provide a direct link to webrev, so people can click and see >> the changes. Downloading archives is not as convenient (and in this >> particular case just impossible, as Yandex.Disk is in Russian, people just >> won't be able to read the "Download" button). >> >> 2. Please, wait for at least one more person to have reviewed this fix. >> >> Thanks, >> >> Artem >> >> On 8/8/2013 2:20 PM, Konstantin Perikov wrote: >> >>> Hi, AWT team, >>> >>> Could you please review the fix for the following bug: >>> >>> *7027045: : (doc) java/awt/Window.java has several typos in javadoc* >>> >>> Fix for version OpenJDK8. Also, I fix some stuff and >>> change it for {@code } >>> >>> The webrev is available here: >>> >>> http://yadi.sk/d/KHB0hBlA7gkke >>> >>> >>> P.S. Since, I'm newcomer, I don't have rights to push, so I need a >>> sponsor. Who could help me? >>> >>> Thanks, >>> >>> Konstantin >>> >>> > > > -- > Best regards, Sergey. > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20130808/576cfd9c/attachment.html From konstantin.perikov at gmail.com Fri Aug 9 03:01:29 2013 From: konstantin.perikov at gmail.com (Konstantin Perikov) Date: Fri, 9 Aug 2013 14:01:29 +0400 Subject: Request for review: 7027045 In-Reply-To: References: <5203902B.7010701@oracle.com> <5203A17F.4060209@oracle.com> Message-ID: Hi, AWT team I update fix. Short summary: - Javadoc fixed from /* to /** for two serializable fields - Hint about synchronization still exists - Also, I change to {@code}, but left some of them, where is using inside tags - Remove "and and" at line 2887 Now webrev placed in Dropbox here- https://www.dropbox.com/sh/fz7qws34btuvq8f/KvIB0ZdL79 You could donwload webrev in one click or open jdk.patch and looks inside, using your favourite browser. Please review it. Thanks, Konstantin. 2013/8/8 Konstantin Perikov > So, what is the best place for webrev, if I don't have access to ftp > server? > I don't have possibility to set up Apache server for that. > Also, maybe I'm wrong, but to view index.html on ftp, you need to download > it as well. > > Okay, I will remove "and and" at line 2887. > > About tag, let me look at Javadoc documentation, I have no idea, how > it will behave in {@code} tag > > Konstantin. > > > > > 2013/8/8 Sergey Bylokhov > >> Hi, Konstantin. >> A few comments about the fix. >> FooListener in a few places was changed to the >> {@code FooListener} but it is not equivalent. >> Also I suggest to remove one of "and" from the "and and" in the line >> 2887, because you change this line anyway. >> >> >> On 08.08.2013 16:54, Konstantin Perikov wrote: >> >> Okay. I keep comment about synchronization for the "type" field and >> return comment style for transient field. >> >> Is Google Drive better place for it? (that's why I ask yesterday about >> "good" place for webrev) >> >> https://drive.google.com/folderview?id=0B4QwwAaNe6wZUWJvTE9HRG40dnM&usp=sharing >> >> No, it is not better, atleast i don't understand how to view index.html >> in this case or download all files at once. >> >> >> >> >> 2013/8/8 Artem Ananiev >> >>> Hi, Konstantin, >>> >>> I looked through the changes, which mostly replacements >>> with {@code}. This part of the fix looks fine. >>> >>> Changing /* to /** for the "isInShow" field doesn't make sense, as this >>> field is transient and is not serialized anyway. However, it doesn't hurt >>> as well. >>> >>> Please, keep comment about synchronization for the "type" field. It's a >>> hint for developers, that this field should only be accessed or modified >>> under the object lock. I agree, JavaDoc is not the best place for such >>> hints, but I don't see any better solutions. >>> >>> Non-technical comments: >>> >>> 1. Please, provide a direct link to webrev, so people can click and see >>> the changes. Downloading archives is not as convenient (and in this >>> particular case just impossible, as Yandex.Disk is in Russian, people just >>> won't be able to read the "Download" button). >>> >>> 2. Please, wait for at least one more person to have reviewed this fix. >>> >>> Thanks, >>> >>> Artem >>> >>> On 8/8/2013 2:20 PM, Konstantin Perikov wrote: >>> >>>> Hi, AWT team, >>>> >>>> Could you please review the fix for the following bug: >>>> >>>> *7027045: : (doc) java/awt/Window.java has several typos in javadoc* >>>> >>>> Fix for version OpenJDK8. Also, I fix some stuff and >>>> change it for {@code } >>>> >>>> The webrev is available here: >>>> >>>> http://yadi.sk/d/KHB0hBlA7gkke >>>> >>>> >>>> P.S. Since, I'm newcomer, I don't have rights to push, so I need a >>>> sponsor. Who could help me? >>>> >>>> Thanks, >>>> >>>> Konstantin >>>> >>>> >> >> >> -- >> Best regards, Sergey. >> >> > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20130809/a31f53e6/attachment.html From alexandr.scherbatiy at oracle.com Fri Aug 9 03:17:28 2013 From: alexandr.scherbatiy at oracle.com (alexandr.scherbatiy at oracle.com) Date: Fri, 09 Aug 2013 10:17:28 +0000 Subject: hg: jdk8/awt/jdk: 7121409: Two conformance tests for AccessibleText.getCharacterBounds(int i) fail Message-ID: <20130809101821.DD58948741@hg.openjdk.java.net> Changeset: 2cd1a041381b Author: alexsch Date: 2013-08-09 14:16 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/2cd1a041381b 7121409: Two conformance tests for AccessibleText.getCharacterBounds(int i) fail Reviewed-by: serb ! src/share/classes/javax/swing/JLabel.java From konstantin.perikov at gmail.com Mon Aug 12 03:52:09 2013 From: konstantin.perikov at gmail.com (Konstantin Perikov) Date: Mon, 12 Aug 2013 14:52:09 +0400 Subject: Request for review: 7027045 In-Reply-To: References: <5203902B.7010701@oracle.com> <5203A17F.4060209@oracle.com> Message-ID: Hi, AWT team. Any updates on review of my fix? Konstantin. 2013/8/9 Konstantin Perikov > Hi, AWT team > > I update fix. Short summary: > > > - Javadoc fixed from /* to /** for two serializable fields > - Hint about synchronization still exists > - Also, I change to {@code}, but left some of them, > where is using inside tags > - Remove "and and" at line 2887 > > > Now webrev placed in Dropbox here- > https://www.dropbox.com/sh/fz7qws34btuvq8f/KvIB0ZdL79 > You could donwload webrev in one click or open jdk.patch and looks inside, > using your favourite browser. > > Please review it. > > Thanks, > > Konstantin. > > > > 2013/8/8 Konstantin Perikov > >> So, what is the best place for webrev, if I don't have access to ftp >> server? >> I don't have possibility to set up Apache server for that. >> Also, maybe I'm wrong, but to view index.html on ftp, you need to >> download it as well. >> >> Okay, I will remove "and and" at line 2887. >> >> About tag, let me look at Javadoc documentation, I have no idea, how >> it will behave in {@code} tag >> >> Konstantin. >> >> >> >> >> 2013/8/8 Sergey Bylokhov >> >>> Hi, Konstantin. >>> A few comments about the fix. >>> FooListener in a few places was changed to the >>> {@code FooListener} but it is not equivalent. >>> Also I suggest to remove one of "and" from the "and and" in the line >>> 2887, because you change this line anyway. >>> >>> >>> On 08.08.2013 16:54, Konstantin Perikov wrote: >>> >>> Okay. I keep comment about synchronization for the "type" field and >>> return comment style for transient field. >>> >>> Is Google Drive better place for it? (that's why I ask yesterday about >>> "good" place for webrev) >>> >>> https://drive.google.com/folderview?id=0B4QwwAaNe6wZUWJvTE9HRG40dnM&usp=sharing >>> >>> No, it is not better, atleast i don't understand how to view index.html >>> in this case or download all files at once. >>> >>> >>> >>> >>> 2013/8/8 Artem Ananiev >>> >>>> Hi, Konstantin, >>>> >>>> I looked through the changes, which mostly replacements >>>> with {@code}. This part of the fix looks fine. >>>> >>>> Changing /* to /** for the "isInShow" field doesn't make sense, as this >>>> field is transient and is not serialized anyway. However, it doesn't hurt >>>> as well. >>>> >>>> Please, keep comment about synchronization for the "type" field. It's a >>>> hint for developers, that this field should only be accessed or modified >>>> under the object lock. I agree, JavaDoc is not the best place for such >>>> hints, but I don't see any better solutions. >>>> >>>> Non-technical comments: >>>> >>>> 1. Please, provide a direct link to webrev, so people can click and see >>>> the changes. Downloading archives is not as convenient (and in this >>>> particular case just impossible, as Yandex.Disk is in Russian, people just >>>> won't be able to read the "Download" button). >>>> >>>> 2. Please, wait for at least one more person to have reviewed this fix. >>>> >>>> Thanks, >>>> >>>> Artem >>>> >>>> On 8/8/2013 2:20 PM, Konstantin Perikov wrote: >>>> >>>>> Hi, AWT team, >>>>> >>>>> Could you please review the fix for the following bug: >>>>> >>>>> *7027045: : (doc) java/awt/Window.java has several typos in javadoc* >>>>> >>>>> Fix for version OpenJDK8. Also, I fix some stuff and >>>>> change it for {@code } >>>>> >>>>> The webrev is available here: >>>>> >>>>> http://yadi.sk/d/KHB0hBlA7gkke >>>>> >>>>> >>>>> P.S. Since, I'm newcomer, I don't have rights to push, so I need a >>>>> sponsor. Who could help me? >>>>> >>>>> Thanks, >>>>> >>>>> Konstantin >>>>> >>>>> >>> >>> >>> -- >>> Best regards, Sergey. >>> >>> >> > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20130812/7a23150a/attachment.html From Sergey.Bylokhov at oracle.com Mon Aug 12 05:32:55 2013 From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov) Date: Mon, 12 Aug 2013 16:32:55 +0400 Subject: Request for review: 7027045 In-Reply-To: References: <5203902B.7010701@oracle.com> <5203A17F.4060209@oracle.com> Message-ID: <5208D5F7.4010306@oracle.com> Hi, Konstantin. Fix looks fine to me. Thanks! On 09.08.2013 14:01, Konstantin Perikov wrote: > Hi, AWT team > > I update fix. Short summary: > > * Javadoc fixed from /* to /** for two serializable fields > * Hint about synchronization still exists > * Also, I change to {@code}, but left some of them, > where is using inside tags > * Remove "and and" at line 2887 > > > Now webrev placed in Dropbox here- > https://www.dropbox.com/sh/fz7qws34btuvq8f/KvIB0ZdL79 > You could donwload webrev in one click or open jdk.patch and looks > inside, using your favourite browser. > > Please review it. > > Thanks, > > Konstantin. > > > > 2013/8/8 Konstantin Perikov > > > So, what is the best place for webrev, if I don't have access to > ftp server? > I don't have possibility to set up Apache server for that. > Also, maybe I'm wrong, but to view index.html on ftp, you need to > download it as well. > > Okay, I will remove "and and" at line 2887. > > About tag, let me look at Javadoc documentation, I have no > idea, how it will behave in {@code} tag > > Konstantin. > > > > > 2013/8/8 Sergey Bylokhov > > > Hi, Konstantin. > A few comments about the fix. > FooListener in a few places was changed > to the {@code FooListener} but it is not equivalent. > Also I suggest to remove one of "and" from the "and and" in > the line 2887, because you change this line anyway. > > > On 08.08.2013 16:54, Konstantin Perikov wrote: >> Okay. I keep comment about synchronization for the "type" >> field and return comment style for transient field. >> >> Is Google Drive better place for it? (that's why I ask >> yesterday about "good" place for webrev) >> https://drive.google.com/folderview?id=0B4QwwAaNe6wZUWJvTE9HRG40dnM&usp=sharing > No, it is not better, atleast i don't understand how to view > index.html in this case or download all files at once. > >> >> >> >> 2013/8/8 Artem Ananiev > > >> >> Hi, Konstantin, >> >> I looked through the changes, which mostly replacements >> with {@code}. This part of the fix looks fine. >> >> Changing /* to /** for the "isInShow" field doesn't make >> sense, as this field is transient and is not serialized >> anyway. However, it doesn't hurt as well. >> >> Please, keep comment about synchronization for the "type" >> field. It's a hint for developers, that this field should >> only be accessed or modified under the object lock. I >> agree, JavaDoc is not the best place for such hints, but >> I don't see any better solutions. >> >> Non-technical comments: >> >> 1. Please, provide a direct link to webrev, so people can >> click and see the changes. Downloading archives is not as >> convenient (and in this particular case just impossible, >> as Yandex.Disk is in Russian, people just won't be able >> to read the "Download" button). >> >> 2. Please, wait for at least one more person to have >> reviewed this fix. >> >> Thanks, >> >> Artem >> >> On 8/8/2013 2:20 PM, Konstantin Perikov wrote: >> >> Hi, AWT team, >> >> Could you please review the fix for the following bug: >> >> *7027045: : (doc) java/awt/Window.java has several >> typos in javadoc* >> >> Fix for version OpenJDK8. Also, I fix some >> stuff and change it for {@code } >> >> The webrev is available here: >> >> http://yadi.sk/d/KHB0hBlA7gkke >> >> >> P.S. Since, I'm newcomer, I don't have rights to >> push, so I need a sponsor. Who could help me? >> >> Thanks, >> >> Konstantin >> >> > > > -- > Best regards, Sergey. > > > -- Best regards, Sergey. -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20130812/1b62b44f/attachment-0001.html From konstantin.perikov at gmail.com Mon Aug 12 07:20:07 2013 From: konstantin.perikov at gmail.com (Konstantin Perikov) Date: Mon, 12 Aug 2013 18:20:07 +0400 Subject: Request for review: 7027045 In-Reply-To: <5208D5F7.4010306@oracle.com> References: <5203902B.7010701@oracle.com> <5203A17F.4060209@oracle.com> <5208D5F7.4010306@oracle.com> Message-ID: So, it will ready to be processed further? Konstantin. 2013/8/12 Sergey Bylokhov > Hi, Konstantin. > Fix looks fine to me. > Thanks! > > On 09.08.2013 14:01, Konstantin Perikov wrote: > > Hi, AWT team > > I update fix. Short summary: > > > - Javadoc fixed from /* to /** for two serializable fields > - Hint about synchronization still exists > - Also, I change to {@code}, but left some of them, > where is using inside tags > - Remove "and and" at line 2887 > > > Now webrev placed in Dropbox here- > https://www.dropbox.com/sh/fz7qws34btuvq8f/KvIB0ZdL79 > You could donwload webrev in one click or open jdk.patch and looks inside, > using your favourite browser. > > Please review it. > > Thanks, > > Konstantin. > > > > 2013/8/8 Konstantin Perikov > >> So, what is the best place for webrev, if I don't have access to ftp >> server? >> I don't have possibility to set up Apache server for that. >> Also, maybe I'm wrong, but to view index.html on ftp, you need to >> download it as well. >> >> Okay, I will remove "and and" at line 2887. >> >> About tag, let me look at Javadoc documentation, I have no idea, >> how it will behave in {@code} tag >> >> Konstantin. >> >> >> >> >> 2013/8/8 Sergey Bylokhov >> >>> Hi, Konstantin. >>> A few comments about the fix. >>> FooListener in a few places was changed to the >>> {@code FooListener} but it is not equivalent. >>> Also I suggest to remove one of "and" from the "and and" in the line >>> 2887, because you change this line anyway. >>> >>> >>> On 08.08.2013 16:54, Konstantin Perikov wrote: >>> >>> Okay. I keep comment about synchronization for the "type" field and >>> return comment style for transient field. >>> >>> Is Google Drive better place for it? (that's why I ask yesterday about >>> "good" place for webrev) >>> >>> https://drive.google.com/folderview?id=0B4QwwAaNe6wZUWJvTE9HRG40dnM&usp=sharing >>> >>> No, it is not better, atleast i don't understand how to view index.html >>> in this case or download all files at once. >>> >>> >>> >>> >>> 2013/8/8 Artem Ananiev >>> >>>> Hi, Konstantin, >>>> >>>> I looked through the changes, which mostly replacements >>>> with {@code}. This part of the fix looks fine. >>>> >>>> Changing /* to /** for the "isInShow" field doesn't make sense, as this >>>> field is transient and is not serialized anyway. However, it doesn't hurt >>>> as well. >>>> >>>> Please, keep comment about synchronization for the "type" field. It's a >>>> hint for developers, that this field should only be accessed or modified >>>> under the object lock. I agree, JavaDoc is not the best place for such >>>> hints, but I don't see any better solutions. >>>> >>>> Non-technical comments: >>>> >>>> 1. Please, provide a direct link to webrev, so people can click and see >>>> the changes. Downloading archives is not as convenient (and in this >>>> particular case just impossible, as Yandex.Disk is in Russian, people just >>>> won't be able to read the "Download" button). >>>> >>>> 2. Please, wait for at least one more person to have reviewed this fix. >>>> >>>> Thanks, >>>> >>>> Artem >>>> >>>> On 8/8/2013 2:20 PM, Konstantin Perikov wrote: >>>> >>>>> Hi, AWT team, >>>>> >>>>> Could you please review the fix for the following bug: >>>>> >>>>> *7027045: : (doc) java/awt/Window.java has several typos in javadoc* >>>>> >>>>> Fix for version OpenJDK8. Also, I fix some stuff and >>>>> change it for {@code } >>>>> >>>>> The webrev is available here: >>>>> >>>>> http://yadi.sk/d/KHB0hBlA7gkke >>>>> >>>>> >>>>> P.S. Since, I'm newcomer, I don't have rights to push, so I need a >>>>> sponsor. Who could help me? >>>>> >>>>> Thanks, >>>>> >>>>> Konstantin >>>>> >>>>> >>> >>> >>> -- >>> Best regards, Sergey. >>> >>> >> > > > -- > Best regards, Sergey. > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20130812/f25036db/attachment.html From anton.litvinov at oracle.com Mon Aug 12 07:37:45 2013 From: anton.litvinov at oracle.com (Anton Litvinov) Date: Mon, 12 Aug 2013 18:37:45 +0400 Subject: [8] Review request for 7191018: Manual test closed/java/awt/JAWT causes JVM to crash starting from JDK 5 In-Reply-To: <52012CA1.7050106@oracle.com> References: <52012CA1.7050106@oracle.com> Message-ID: <5208F339.3010409@oracle.com> Hello, Could you please review the already applied request which is presented below. Thank you, Anton On 8/6/2013 9:04 PM, Anton Litvinov wrote: > Hello, > > Could you please review the following fix for a bug from AWT Native > Interface area. > > Bug: http://bugs.sun.com/view_bug.do?bug_id=7191018 > Webrev: http://cr.openjdk.java.net/~alitvinov/7191018/webrev.00 > > The solution is based on introduction of initialization of "jobject > peer" local variable by means of JNI invocation of the Java method > "sun.awt.X11.XToolkit.windowToXWindow(long window)". > > Thank you, > Anton From artem.ananiev at oracle.com Mon Aug 12 08:50:53 2013 From: artem.ananiev at oracle.com (Artem Ananiev) Date: Mon, 12 Aug 2013 19:50:53 +0400 Subject: Request for review: 7027045 In-Reply-To: References: <5203902B.7010701@oracle.com> <5203A17F.4060209@oracle.com> Message-ID: <5209045D.1020908@oracle.com> Hi, Konstantin, the new version looks fine. As Sergey wrote in another email, he will help you with pushing this fix to the workspace. No further actions are required from your side. Thank you for help in making Java better :) We usually specify contributor's email in the "Contributed-by" field in mercurial comments. Can we use your current @gmail.com address? Thanks, Artem On 8/12/2013 2:52 PM, Konstantin Perikov wrote: > Hi, AWT team. > > Any updates on review of my fix? > > Konstantin. > > > 2013/8/9 Konstantin Perikov > > > Hi, AWT team > > I update fix. Short summary: > > * Javadoc fixed from /* to /** for two serializable fields > * Hint about synchronization still exists > * Also, I change to {@code}, but left some of them, > where is using inside tags > * Remove "and and" at line 2887 > > > Now webrev placed in Dropbox here- > https://www.dropbox.com/sh/fz7qws34btuvq8f/KvIB0ZdL79 > You could donwload webrev in one click or open jdk.patch and looks > inside, using your favourite browser. > > Please review it. > > Thanks, > > Konstantin. > > > > 2013/8/8 Konstantin Perikov > > > So, what is the best place for webrev, if I don't have access to > ftp server? > I don't have possibility to set up Apache server for that. > Also, maybe I'm wrong, but to view index.html on ftp, you need > to download it as well. > > Okay, I will remove "and and" at line 2887. > > About tag, let me look at Javadoc documentation, I have no > idea, how it will behave in {@code} tag > > Konstantin. > > > > > 2013/8/8 Sergey Bylokhov > > > Hi, Konstantin. > A few comments about the fix. > FooListener in a few places was > changed to the {@code FooListener} but it is not > equivalent. > Also I suggest to remove one of "and" from the "and and" in > the line 2887, because you change this line anyway. > > > On 08.08.2013 16:54, Konstantin Perikov wrote: >> Okay. I keep comment about synchronization for the "type" >> field and return comment style for transient field. >> >> Is Google Drive better place for it? (that's why I ask >> yesterday about "good" place for webrev) >> https://drive.google.com/folderview?id=0B4QwwAaNe6wZUWJvTE9HRG40dnM&usp=sharing > No, it is not better, atleast i don't understand how to view > index.html in this case or download all files at once. > >> >> >> >> 2013/8/8 Artem Ananiev > > >> >> Hi, Konstantin, >> >> I looked through the changes, which mostly >> replacements with {@code}. This part of >> the fix looks fine. >> >> Changing /* to /** for the "isInShow" field doesn't >> make sense, as this field is transient and is not >> serialized anyway. However, it doesn't hurt as well. >> >> Please, keep comment about synchronization for the >> "type" field. It's a hint for developers, that this >> field should only be accessed or modified under the >> object lock. I agree, JavaDoc is not the best place >> for such hints, but I don't see any better solutions. >> >> Non-technical comments: >> >> 1. Please, provide a direct link to webrev, so people >> can click and see the changes. Downloading archives is >> not as convenient (and in this particular case just >> impossible, as Yandex.Disk is in Russian, people just >> won't be able to read the "Download" button). >> >> 2. Please, wait for at least one more person to have >> reviewed this fix. >> >> Thanks, >> >> Artem >> >> On 8/8/2013 2:20 PM, Konstantin Perikov wrote: >> >> Hi, AWT team, >> >> Could you please review the fix for the following bug: >> >> *7027045: : (doc) java/awt/Window.java has >> several typos in javadoc* >> >> Fix for version OpenJDK8. Also, I fix some >> stuff and change it for {@code } >> >> The webrev is available here: >> >> http://yadi.sk/d/KHB0hBlA7gkke >> >> >> P.S. Since, I'm newcomer, I don't have rights to >> push, so I need a sponsor. Who could help me? >> >> Thanks, >> >> Konstantin >> >> > > > -- > Best regards, Sergey. > > > > From konstantin.perikov at gmail.com Mon Aug 12 10:13:26 2013 From: konstantin.perikov at gmail.com (Konstantin Perikov) Date: Mon, 12 Aug 2013 21:13:26 +0400 Subject: Request for review: 7027045 In-Reply-To: <5209045D.1020908@oracle.com> References: <5203902B.7010701@oracle.com> <5203A17F.4060209@oracle.com> <5209045D.1020908@oracle.com> Message-ID: Yes, sure you can use my current gmail Thanks. 2013/8/12 Artem Ananiev > Hi, Konstantin, > > the new version looks fine. > > As Sergey wrote in another email, he will help you with pushing this fix > to the workspace. No further actions are required from your side. Thank you > for help in making Java better :) > > We usually specify contributor's email in the "Contributed-by" field in > mercurial comments. Can we use your current @gmail.com address? > > Thanks, > > Artem > > On 8/12/2013 2:52 PM, Konstantin Perikov wrote: > >> Hi, AWT team. >> >> Any updates on review of my fix? >> >> Konstantin. >> >> >> 2013/8/9 Konstantin Perikov > >> >> >> >> Hi, AWT team >> >> I update fix. Short summary: >> >> * Javadoc fixed from /* to /** for two serializable fields >> * Hint about synchronization still exists >> * Also, I change to {@code}, but left some of them, >> >> where is using inside tags >> * Remove "and and" at line 2887 >> >> >> >> Now webrev placed in Dropbox here- >> https://www.dropbox.com/sh/**fz7qws34btuvq8f/KvIB0ZdL79 >> You could donwload webrev in one click or open jdk.patch and looks >> inside, using your favourite browser. >> >> Please review it. >> >> Thanks, >> >> Konstantin. >> >> >> >> 2013/8/8 Konstantin Perikov > >> >> >> >> >> So, what is the best place for webrev, if I don't have access to >> ftp server? >> I don't have possibility to set up Apache server for that. >> Also, maybe I'm wrong, but to view index.html on ftp, you need >> to download it as well. >> >> Okay, I will remove "and and" at line 2887. >> >> About tag, let me look at Javadoc documentation, I have no >> idea, how it will behave in {@code} tag >> >> Konstantin. >> >> >> >> >> 2013/8/8 Sergey Bylokhov > >> >> >> >> >> Hi, Konstantin. >> A few comments about the fix. >> FooListener in a few places was >> changed to the {@code FooListener} but it is not >> equivalent. >> Also I suggest to remove one of "and" from the "and and" in >> the line 2887, because you change this line anyway. >> >> >> On 08.08.2013 16:54, Konstantin Perikov wrote: >> >>> Okay. I keep comment about synchronization for the "type" >>> field and return comment style for transient field. >>> >>> Is Google Drive better place for it? (that's why I ask >>> yesterday about "good" place for webrev) >>> https://drive.google.com/**folderview?id=** >>> 0B4QwwAaNe6wZUWJvTE9HRG40dnM&**usp=sharing >>> >> No, it is not better, atleast i don't understand how to view >> index.html in this case or download all files at once. >> >> >>> >>> >>> 2013/8/8 Artem Ananiev >> >>> >> >>> >>> >>> Hi, Konstantin, >>> >>> I looked through the changes, which mostly >>> replacements with {@code}. This part of >>> the fix looks fine. >>> >>> Changing /* to /** for the "isInShow" field doesn't >>> make sense, as this field is transient and is not >>> serialized anyway. However, it doesn't hurt as well. >>> >>> Please, keep comment about synchronization for the >>> "type" field. It's a hint for developers, that this >>> field should only be accessed or modified under the >>> object lock. I agree, JavaDoc is not the best place >>> for such hints, but I don't see any better solutions. >>> >>> Non-technical comments: >>> >>> 1. Please, provide a direct link to webrev, so people >>> can click and see the changes. Downloading archives is >>> not as convenient (and in this particular case just >>> impossible, as Yandex.Disk is in Russian, people just >>> won't be able to read the "Download" button). >>> >>> 2. Please, wait for at least one more person to have >>> reviewed this fix. >>> >>> Thanks, >>> >>> Artem >>> >>> On 8/8/2013 2:20 PM, Konstantin Perikov wrote: >>> >>> Hi, AWT team, >>> >>> Could you please review the fix for the following >>> bug: >>> >>> *7027045: : (doc) java/awt/Window.java has >>> several typos in javadoc* >>> >>> Fix for version OpenJDK8. Also, I fix some >>> stuff and change it for {@code } >>> >>> The webrev is available here: >>> >>> http://yadi.sk/d/KHB0hBlA7gkke >>> >>> >>> P.S. Since, I'm newcomer, I don't have rights to >>> push, so I need a sponsor. Who could help me? >>> >>> Thanks, >>> >>> Konstantin >>> >>> >>> >> >> -- >> Best regards, Sergey. >> >> >> >> >> -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20130812/94892612/attachment-0001.html From anthony.petrov at oracle.com Tue Aug 13 03:24:59 2013 From: anthony.petrov at oracle.com (Anthony Petrov) Date: Tue, 13 Aug 2013 14:24:59 +0400 Subject: [8] Review request for 8021943: FileDialog getFile returns corrupted string after previous setFile In-Reply-To: <51FA94FD.7060603@oracle.com> References: <51FA94FD.7060603@oracle.com> Message-ID: <520A097B.4040204@oracle.com> Hi Alexander, Please add a comment to the bug report with your evaluation. I suggest to always do that before sending out a fix for review. The fix itself looks fine to me. -- best regards, Anthony On 08/01/2013 09:03 PM, Alexander Zvegintsev wrote: > Hello, > > Could you please review a fix for the following issue: > http://bugs.sun.com/view_bug.do?bug_id=8021943 > > The fix is available at: > http://cr.openjdk.java.net/~serb/8021943/webrev.00/ > > lpstrFile should be treated as double NULL terminated (DNT) string only > when OFN_ALLOWMULTISELECT flag is set. > http://msdn.microsoft.com/en-us/library/windows/desktop/ms646839%28v=vs.85%29.aspx >> If the *OFN_ALLOWMULTISELECT* flag is set and the user selects >> multiple files, the buffer contains the current directory followed by >> the file names of the selected files. For Explorer-style dialog boxes, >> the directory and file name strings are *NULL* separated, with an >> extra *NULL* character after the last file name. > Currently we check length of a lpstrFile with GetBufferLength() which > treats \0\0 as an end of a string. > It works nice, unless we call setFile() with a filename longer than a > path of a saved file (in single-select mode). > In single-select mode lpstrFile string ends with single \0, and > GetBufferLength() fails to find correct length and we pass \0-separated > buffer to > WFileDialogPeer.handleSelected() which will be treated as multi-select > mode. > > -- > Thanks, > > Alexander. > From anthony.petrov at oracle.com Tue Aug 13 03:49:47 2013 From: anthony.petrov at oracle.com (Anthony Petrov) Date: Tue, 13 Aug 2013 14:49:47 +0400 Subject: [8] Review request for 7191018: Manual test closed/java/awt/JAWT causes JVM to crash starting from JDK 5 In-Reply-To: <52012CA1.7050106@oracle.com> References: <52012CA1.7050106@oracle.com> Message-ID: <520A0F4B.6020907@oracle.com> Hi Anton, The fix looks good to me. -- best regards, Anthony On 08/06/2013 09:04 PM, Anton Litvinov wrote: > Hello, > > Could you please review the following fix for a bug from AWT Native > Interface area. > > Bug: http://bugs.sun.com/view_bug.do?bug_id=7191018 > Webrev: http://cr.openjdk.java.net/~alitvinov/7191018/webrev.00 > > The solution is based on introduction of initialization of "jobject > peer" local variable by means of JNI invocation of the Java method > "sun.awt.X11.XToolkit.windowToXWindow(long window)". > > Thank you, > Anton From sergey.bylokhov at oracle.com Tue Aug 13 04:44:14 2013 From: sergey.bylokhov at oracle.com (sergey.bylokhov at oracle.com) Date: Tue, 13 Aug 2013 11:44:14 +0000 Subject: hg: jdk8/awt/jdk: 7027045: (doc) java/awt/Window.java has several typos in javadoc Message-ID: <20130813114447.2A61E48802@hg.openjdk.java.net> Changeset: 4702ab74b70a Author: serb Date: 2013-08-13 15:41 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/4702ab74b70a 7027045: (doc) java/awt/Window.java has several typos in javadoc Reviewed-by: art, serb Contributed-by: konstantin.perikov at gmail.com ! src/share/classes/java/awt/Window.java From lana.steuck at oracle.com Tue Aug 13 17:00:14 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 14 Aug 2013 00:00:14 +0000 Subject: hg: jdk8/awt/corba: 4 new changesets Message-ID: <20130814000019.DD44B48841@hg.openjdk.java.net> Changeset: f8ed09af1df6 Author: cl Date: 2013-08-08 10:10 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/corba/rev/f8ed09af1df6 Added tag jdk8-b102 for changeset 528c7e76eaee ! .hgtags Changeset: cc11a0efb4f9 Author: aefimov Date: 2013-08-01 14:59 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/corba/rev/cc11a0efb4f9 8015987: The corba repo contains unneeded .sjava files Reviewed-by: alanb, chegar, coffeys - src/share/classes/com/sun/corba/se/impl/copyobject/JavaInputStream.sjava - src/share/classes/com/sun/corba/se/impl/copyobject/JavaOutputStream.sjava - src/share/classes/com/sun/corba/se/impl/interceptors/ThreadCurrentStack.sjava - src/share/classes/com/sun/corba/se/impl/orbutil/DefineWrapper.sjava - src/share/classes/com/sun/corba/se/impl/presentation/rmi/IDLNameTranslatorImpl_save.sjava - src/share/classes/com/sun/corba/se/impl/presentation/rmi/IDLTypesUtil_save.sjava - src/share/classes/com/sun/corba/se/impl/protocol/oldlocal/LocalClientRequestImpl.sjava - src/share/classes/com/sun/corba/se/impl/protocol/oldlocal/LocalClientResponseImpl.sjava - src/share/classes/com/sun/corba/se/impl/protocol/oldlocal/LocalServerRequestImpl.sjava - src/share/classes/com/sun/corba/se/impl/protocol/oldlocal/LocalServerResponseImpl.sjava - src/share/classes/com/sun/corba/se/impl/transport/BufferConnectionImpl.sjava Changeset: 342a954b68f3 Author: lana Date: 2013-08-06 16:54 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/corba/rev/342a954b68f3 Merge Changeset: 49c4a777fdfd Author: lana Date: 2013-08-13 10:34 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/corba/rev/49c4a777fdfd Merge From lana.steuck at oracle.com Tue Aug 13 17:00:20 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 14 Aug 2013 00:00:20 +0000 Subject: hg: jdk8/awt/jaxp: Added tag jdk8-b102 for changeset 7cffafa606e9 Message-ID: <20130814000032.B78FF48842@hg.openjdk.java.net> Changeset: b1ceab582fc6 Author: cl Date: 2013-08-08 10:10 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jaxp/rev/b1ceab582fc6 Added tag jdk8-b102 for changeset 7cffafa606e9 ! .hgtags From lana.steuck at oracle.com Tue Aug 13 17:00:25 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 14 Aug 2013 00:00:25 +0000 Subject: hg: jdk8/awt/nashorn: 5 new changesets Message-ID: <20130814000035.5B48F48843@hg.openjdk.java.net> Changeset: 795cff5c1b5c Author: cl Date: 2013-08-08 10:10 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/nashorn/rev/795cff5c1b5c Added tag jdk8-b102 for changeset e966ff0a3ffe ! .hgtags Changeset: 0ad00ae4fec6 Author: hannesw Date: 2013-08-01 12:23 +0200 URL: http://hg.openjdk.java.net/jdk8/awt/nashorn/rev/0ad00ae4fec6 8020132: Big object literal with numerical keys exceeds method size Reviewed-by: lagergren, sundar ! src/jdk/nashorn/internal/codegen/CodeGenerator.java ! src/jdk/nashorn/internal/codegen/FieldObjectCreator.java ! src/jdk/nashorn/internal/codegen/MapCreator.java ! src/jdk/nashorn/internal/codegen/SpillObjectCreator.java ! src/jdk/nashorn/internal/objects/ArrayBufferView.java ! src/jdk/nashorn/internal/runtime/NashornLoader.java ! src/jdk/nashorn/internal/runtime/arrays/ArrayData.java ! src/jdk/nashorn/internal/runtime/arrays/ArrayIndex.java ! src/jdk/nashorn/internal/runtime/arrays/ArrayIterator.java ! src/jdk/nashorn/internal/runtime/arrays/DeletedArrayFilter.java ! src/jdk/nashorn/internal/runtime/arrays/DeletedRangeArrayFilter.java ! src/jdk/nashorn/internal/runtime/arrays/FrozenArrayFilter.java ! src/jdk/nashorn/internal/runtime/arrays/IntArrayData.java ! src/jdk/nashorn/internal/runtime/arrays/LongArrayData.java ! src/jdk/nashorn/internal/runtime/arrays/NoTypeArrayData.java ! src/jdk/nashorn/internal/runtime/arrays/NumberArrayData.java ! src/jdk/nashorn/internal/runtime/arrays/ObjectArrayData.java ! src/jdk/nashorn/internal/runtime/arrays/ReverseArrayIterator.java ! src/jdk/nashorn/internal/runtime/arrays/SealedArrayFilter.java ! src/jdk/nashorn/internal/runtime/arrays/SparseArrayData.java ! src/jdk/nashorn/internal/runtime/arrays/UndefinedArrayFilter.java + test/script/basic/JDK-8020132.js + test/script/basic/JDK-8020132.js.EXPECTED Changeset: bb0f3c896cb7 Author: sundar Date: 2013-08-06 13:10 +0530 URL: http://hg.openjdk.java.net/jdk8/awt/nashorn/rev/bb0f3c896cb7 Merge Changeset: ab90c566272d Author: lana Date: 2013-08-06 17:01 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/nashorn/rev/ab90c566272d Merge Changeset: 414203de4374 Author: lana Date: 2013-08-13 10:34 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/nashorn/rev/414203de4374 Merge From lana.steuck at oracle.com Tue Aug 13 17:00:28 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 14 Aug 2013 00:00:28 +0000 Subject: hg: jdk8/awt/jaxws: Added tag jdk8-b102 for changeset 988a5f2ac559 Message-ID: <20130814000037.3533B48844@hg.openjdk.java.net> Changeset: 6cdc6ed98780 Author: cl Date: 2013-08-08 10:10 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jaxws/rev/6cdc6ed98780 Added tag jdk8-b102 for changeset 988a5f2ac559 ! .hgtags From lana.steuck at oracle.com Tue Aug 13 17:00:31 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 14 Aug 2013 00:00:31 +0000 Subject: hg: jdk8/awt/langtools: 11 new changesets Message-ID: <20130814000116.97AD848845@hg.openjdk.java.net> Changeset: 6718df4cd616 Author: cl Date: 2013-08-08 10:10 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/6718df4cd616 Added tag jdk8-b102 for changeset 453a305e1165 ! .hgtags Changeset: 05370ef9dccb Author: ksrini Date: 2013-07-31 08:37 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/05370ef9dccb 8014826: c.s.t.javac.tree.Pretty.visitNewArray() prints duplicate dimension markers Reviewed-by: jjg, vromero ! src/share/classes/com/sun/tools/javac/tree/Pretty.java + test/tools/javac/tree/NewArrayPretty.java Changeset: 99b60bcf3862 Author: vromero Date: 2013-08-06 15:08 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/99b60bcf3862 8022186: javac generates dead code if a try with an empty body has a finalizer Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/jvm/Gen.java + test/tools/javac/T8022186/DeadCodeGeneratedForEmptyTryTest.java Changeset: 051e64d0816e Author: jfranck Date: 2013-08-07 01:32 +0200 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/051e64d0816e 8009367: Wrong kind of name used in comparison in javax.lang.model code for repeatable annotations Reviewed-by: jjg, darcy ! src/share/classes/com/sun/tools/javac/model/JavacAnnoConstructs.java + test/tools/javac/processing/model/element/8009367/TestQualifiedNameUsed.java + test/tools/javac/processing/model/element/8009367/p/Q.java + test/tools/javac/processing/model/element/8009367/p/QQ.java + test/tools/javac/processing/model/element/8009367/p/R.java + test/tools/javac/processing/model/element/8009367/p/RR.java Changeset: f3ea20a6e958 Author: lana Date: 2013-08-06 17:01 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/f3ea20a6e958 Merge Changeset: b926dc251be8 Author: lana Date: 2013-08-06 17:12 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/b926dc251be8 Merge Changeset: f3deeccbf4cf Author: vromero Date: 2013-08-07 10:41 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/f3deeccbf4cf 8020997: TreeMaker.AnnotationBuilder creates broken element literals with repeating annotations Reviewed-by: jjg, jfranck ! src/share/classes/com/sun/tools/javac/tree/TreeMaker.java + test/tools/javac/T8020997/CannotCompileRepeatedAnnoTest.java Changeset: c7dcf899ffff Author: vromero Date: 2013-08-07 11:04 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/c7dcf899ffff 8008274: javac should not reference/use sample code Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/Main.java Changeset: 8c55df2442c1 Author: bpatel Date: 2013-08-07 15:00 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/8c55df2442c1 7198274: RFE : Javadoc Accessibility : Use CSS styles rather than or tags Reviewed-by: jjg ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractExecutableMemberWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AnnotationTypeRequiredMemberWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/AnnotationTypeWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/ClassWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/EnumConstantWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/FieldWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/MethodWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/NestedClassWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/ProfilePackageFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PropertyWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/SubWriterHolderWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/TagletWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlStyle.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlTree.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/resources/stylesheet.css ! test/com/sun/javadoc/testClassCrossReferences/TestClassCrossReferences.java ! test/com/sun/javadoc/testExternalOverridenMethod/TestExternalOverridenMethod.java ! test/com/sun/javadoc/testHtmlDefinitionListTag/TestHtmlDefinitionListTag.java ! test/com/sun/javadoc/testInterface/TestInterface.java ! test/com/sun/javadoc/testJavaFX/TestJavaFX.java ! test/com/sun/javadoc/testMemberInheritence/TestMemberInheritence.java ! test/com/sun/javadoc/testMemberSummary/TestMemberSummary.java ! test/com/sun/javadoc/testNewLanguageFeatures/TestNewLanguageFeatures.java ! test/com/sun/javadoc/testOverridenMethods/TestOverridenMethodDocCopy.java ! test/com/sun/javadoc/testOverridenMethods/TestOverridenPrivateMethods.java ! test/com/sun/javadoc/testOverridenMethods/TestOverridenPrivateMethodsWithPackageFlag.java ! test/com/sun/javadoc/testOverridenMethods/TestOverridenPrivateMethodsWithPrivateFlag.java ! test/com/sun/javadoc/testPackageDeprecation/TestPackageDeprecation.java ! test/com/sun/javadoc/testPrivateClasses/TestPrivateClasses.java ! test/com/sun/javadoc/testSerializedFormDeprecationInfo/TestSerializedFormDeprecationInfo.java Changeset: 33294f02c9a5 Author: bpatel Date: 2013-08-07 16:09 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/33294f02c9a5 4749567: stddoclet: Add CSS style for setting header/footer to be italic Reviewed-by: jjg ! src/share/classes/com/sun/tools/doclets/formats/html/HelpWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlTree.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/resources/stylesheet.css + test/com/sun/javadoc/testOptions/TestOptions.java + test/com/sun/javadoc/testOptions/pkg/Foo.java Changeset: 76cfe7c61f25 Author: lana Date: 2013-08-13 10:35 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/76cfe7c61f25 Merge From lana.steuck at oracle.com Tue Aug 13 17:00:33 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 14 Aug 2013 00:00:33 +0000 Subject: hg: jdk8/awt/hotspot: 25 new changesets Message-ID: <20130814000138.5FAAE48846@hg.openjdk.java.net> Changeset: b9a927798f12 Author: cl Date: 2013-08-08 10:10 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/b9a927798f12 Added tag jdk8-b102 for changeset c4697c1c4484 ! .hgtags Changeset: 79ce055063e9 Author: amurillo Date: 2013-08-02 03:06 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/79ce055063e9 8022124: new hotspot build - hs25-b45 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 9bd314787fad Author: mseledtsov Date: 2013-08-01 22:15 +0200 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/9bd314787fad 8020614: OutputAnalyzer.shouldHaveExitValue() should print stdout/stderr output Summary: OutputAnalyzer.shouldHaveExitValue() should print stdout/stderr output Reviewed-by: kvn, ctornqvi, dholmes + test/testlibrary/OutputAnalyzerReportingTest.java ! test/testlibrary/com/oracle/java/testlibrary/OutputAnalyzer.java ! test/testlibrary/com/oracle/java/testlibrary/ProcessTools.java Changeset: c01913206da5 Author: ctornqvi Date: 2013-08-01 22:20 +0200 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/c01913206da5 8014294: Assert in ThreadTimesClosure::do_thread() due to use of naked oop instead of handle Summary: Assert in ThreadTimesClosure::do_thread() due to use of naked oop instead of handle Reviewed-by: coleenp, sspitsyn ! src/share/vm/services/management.cpp Changeset: 81e0f17ade64 Author: ctornqvi Date: 2013-08-01 22:25 +0200 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/81e0f17ade64 8009407: runtime/8000968/Test8000968.sh has incorrect check for proper config Summary: runtime/8000968/Test8000968.sh has incorrect check for proper config Reviewed-by: coleenp, mseledtsov, sspitsyn, hseigel - test/runtime/8000968/Test8000968.sh + test/runtime/CompressedOops/CompressedKlassPointerAndOops.java Changeset: 32e3bada0978 Author: kevinw Date: 2013-08-02 12:26 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/32e3bada0978 8020943: Memory leak when GCNotifier uses create_from_platform_dependent_str() Reviewed-by: mgerdin, fparain, dcubed ! src/share/vm/services/gcNotifier.cpp Changeset: dee4c330acd4 Author: dcubed Date: 2013-08-02 08:32 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/dee4c330acd4 Merge - test/runtime/8000968/Test8000968.sh Changeset: fa57c8104b76 Author: ctornqvi Date: 2013-08-02 18:12 +0200 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/fa57c8104b76 8009585: test/runtime/7196045 times out Summary: test/runtime/7196045 times out Reviewed-by: dholmes, mseledtsov - test/runtime/7196045/Test7196045.java + test/runtime/InternalApi/ThreadCpuTimesDeadlock.java Changeset: 0f209afdfcf8 Author: ctornqvi Date: 2013-08-02 18:26 +0200 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/0f209afdfcf8 Merge Changeset: d02de8cac823 Author: ctornqvi Date: 2013-08-02 22:34 +0200 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/d02de8cac823 Merge - test/runtime/7196045/Test7196045.java Changeset: e0379d5ba5d2 Author: kevinw Date: 2013-08-05 10:27 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/e0379d5ba5d2 8021444: SA: ClassDump.run() should not ignore existing ClassFilter. Reviewed-by: minqi, poonam ! agent/src/share/classes/sun/jvm/hotspot/tools/jcore/ClassDump.java Changeset: b67604b59546 Author: hseigel Date: 2013-08-04 16:30 -0400 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/b67604b59546 7073961: [TESTBUG] closed/runtime/4845371/DBB.java failed on solaris 10 X65 Summary: Added a x86 64-bit Solaris shared library and rewrote test in Java Reviewed-by: dholmes, ctornqvi ! test/testlibrary/com/oracle/java/testlibrary/Platform.java Changeset: 9064e3a19525 Author: hseigel Date: 2013-08-05 08:55 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/9064e3a19525 Merge - test/runtime/7196045/Test7196045.java - test/runtime/8000968/Test8000968.sh Changeset: 22a5aff0df0b Author: dsamersoff Date: 2013-08-06 14:28 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/22a5aff0df0b 8019396: SA-JDI OSThread class initialization throws an exception Summary: Method sun.jvm.hotspot.runtime.OSThread.initialize throws a sun.jvm.hotspot.types.WrongTypeException Reviewed-by: dholmes, mgerdin ! agent/src/share/classes/sun/jvm/hotspot/jdi/JVMTIThreadState.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/OSThread.java Changeset: cd25d3be91c5 Author: vladidan Date: 2013-08-06 20:01 -0400 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/cd25d3be91c5 8012144: multiple SIGSEGVs fails on staxf Summary: Forward port of 7u change to add additional fence() on RMO platforms, with a load_acquire on all platforms Reviewed-by: dholmes, kvn ! src/share/vm/utilities/taskqueue.hpp Changeset: f5bed20f2492 Author: dholmes Date: 2013-08-08 08:29 -0400 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/f5bed20f2492 Merge Changeset: 79a5283f4595 Author: iignatyev Date: 2013-07-29 11:54 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/79a5283f4595 8021120: TieredCompilation can be enabled even if TIERED is undefined Reviewed-by: kvn, dholmes ! src/share/vm/runtime/arguments.cpp Changeset: 8d77d02828d9 Author: twisti Date: 2013-07-29 16:32 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/8d77d02828d9 8016474: Crash in sun.reflect.UnsafeObjectFieldAccessorImpl.get Summary: C1's GetUnsafeObject G1 pre-barrier uses the wrong type to read the klass pointer. Reviewed-by: iveresov, kvn ! src/share/vm/c1/c1_LIRGenerator.cpp + test/compiler/unsafe/GetUnsafeObjectG1PreBarrier.java Changeset: 446cb5d25d03 Author: anoll Date: 2013-08-01 16:01 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/446cb5d25d03 8020531: Test compiler/codecache/CheckUpperLimit.java fails when memory limited Summary: Removed part of the test that required the VM to start up with -XX:ReservedCodeCacheSize=2048m Reviewed-by: kvn, rbackman ! test/compiler/codecache/CheckUpperLimit.java Changeset: 6e04c193845f Author: anoll Date: 2013-08-02 10:20 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/6e04c193845f 8021301: better event messages Summary: made event messages better readable Reviewed-by: kvn, rbackman ! src/share/vm/classfile/classLoader.cpp ! src/share/vm/utilities/exceptions.cpp Changeset: 5e0b3d7df485 Author: rbackman Date: 2013-08-05 17:15 +0200 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/5e0b3d7df485 Merge ! src/share/vm/runtime/arguments.cpp Changeset: 71526a36ebb4 Author: twisti Date: 2013-08-05 15:03 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/71526a36ebb4 8022029: GetUnsafeObjectG1PreBarrier fails on 32-bit with: Unrecognized VM option 'ObjectAlignmentInBytes=32' Reviewed-by: kvn ! test/compiler/unsafe/GetUnsafeObjectG1PreBarrier.java Changeset: dadf62510ae4 Author: rbackman Date: 2013-08-08 23:49 +0200 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/dadf62510ae4 Merge Changeset: 7f55137d6aa8 Author: amurillo Date: 2013-08-09 01:32 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/7f55137d6aa8 Merge - test/runtime/7196045/Test7196045.java - test/runtime/8000968/Test8000968.sh Changeset: 6f9be7f87b96 Author: amurillo Date: 2013-08-09 01:32 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/6f9be7f87b96 Added tag hs25-b45 for changeset 7f55137d6aa8 ! .hgtags From lana.steuck at oracle.com Tue Aug 13 17:02:26 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 14 Aug 2013 00:02:26 +0000 Subject: hg: jdk8/awt/jdk: 55 new changesets Message-ID: <20130814001345.5A41B48847@hg.openjdk.java.net> Changeset: e057cddf0d6c Author: cl Date: 2013-08-08 10:10 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/e057cddf0d6c Added tag jdk8-b102 for changeset 8ed8e2b4b90e ! .hgtags Changeset: 1c6bfb303ffc Author: prr Date: 2013-08-06 13:38 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/1c6bfb303ffc 8022175: Fix doclint warnings in javax.print Reviewed-by: darcy ! src/share/classes/javax/print/DocFlavor.java ! src/share/classes/javax/print/MultiDocPrintJob.java ! src/share/classes/javax/print/PrintService.java ! src/share/classes/javax/print/ServiceUI.java ! src/share/classes/javax/print/ServiceUIFactory.java ! src/share/classes/javax/print/attribute/AttributeSet.java ! src/share/classes/javax/print/attribute/DateTimeSyntax.java ! src/share/classes/javax/print/attribute/DocAttributeSet.java ! src/share/classes/javax/print/attribute/EnumSyntax.java ! src/share/classes/javax/print/attribute/HashAttributeSet.java ! src/share/classes/javax/print/attribute/IntegerSyntax.java ! src/share/classes/javax/print/attribute/PrintJobAttributeSet.java ! src/share/classes/javax/print/attribute/PrintRequestAttributeSet.java ! src/share/classes/javax/print/attribute/PrintServiceAttributeSet.java ! src/share/classes/javax/print/attribute/ResolutionSyntax.java ! src/share/classes/javax/print/attribute/Size2DSyntax.java ! src/share/classes/javax/print/attribute/standard/Chromaticity.java ! src/share/classes/javax/print/attribute/standard/Compression.java ! src/share/classes/javax/print/attribute/standard/Finishings.java ! src/share/classes/javax/print/attribute/standard/JobKOctets.java ! src/share/classes/javax/print/attribute/standard/MediaPrintableArea.java ! src/share/classes/javax/print/attribute/standard/MediaSize.java ! src/share/classes/javax/print/attribute/standard/PresentationDirection.java ! src/share/classes/javax/print/attribute/standard/PrinterMoreInfoManufacturer.java ! src/share/classes/javax/print/attribute/standard/PrinterResolution.java Changeset: c3b91dc2504a Author: jgodinez Date: 2013-08-06 14:22 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/c3b91dc2504a 8021583: test/javax/print/autosense/PrintAutoSenseData.java throwing NPE Reviewed-by: jchen, prr ! src/solaris/classes/sun/print/UnixPrintJob.java ! src/windows/classes/sun/print/Win32PrintJob.java ! test/javax/print/attribute/autosense/PrintAutoSenseData.java + test/javax/print/attribute/autosense/sample.txt Changeset: fe04f40cf469 Author: prr Date: 2013-08-06 17:11 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/fe04f40cf469 8022455: Fix doclint warnings in javax.imageio Reviewed-by: darcy ! src/share/classes/javax/imageio/ImageIO.java ! src/share/classes/javax/imageio/ImageReadParam.java ! src/share/classes/javax/imageio/ImageReader.java ! src/share/classes/javax/imageio/ImageTypeSpecifier.java ! src/share/classes/javax/imageio/ImageWriteParam.java ! src/share/classes/javax/imageio/ImageWriter.java ! src/share/classes/javax/imageio/metadata/IIOMetadataFormatImpl.java ! src/share/classes/javax/imageio/plugins/bmp/BMPImageWriteParam.java ! src/share/classes/javax/imageio/plugins/jpeg/JPEGImageReadParam.java ! src/share/classes/javax/imageio/plugins/jpeg/JPEGImageWriteParam.java ! src/share/classes/javax/imageio/spi/ImageReaderSpi.java ! src/share/classes/javax/imageio/spi/ImageWriterSpi.java ! src/share/classes/javax/imageio/spi/ServiceRegistry.java ! src/share/classes/javax/imageio/stream/ImageInputStream.java ! src/share/classes/javax/imageio/stream/ImageInputStreamImpl.java ! src/share/classes/javax/imageio/stream/ImageOutputStream.java Changeset: c827ad8c1101 Author: prr Date: 2013-08-06 17:12 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/c827ad8c1101 8022447: Fix doclint warnings in java.awt.image Reviewed-by: darcy ! src/share/classes/java/awt/image/BufferStrategy.java ! src/share/classes/java/awt/image/BufferedImage.java ! src/share/classes/java/awt/image/ByteLookupTable.java ! src/share/classes/java/awt/image/ColorModel.java ! src/share/classes/java/awt/image/DirectColorModel.java ! src/share/classes/java/awt/image/ImageProducer.java ! src/share/classes/java/awt/image/IndexColorModel.java ! src/share/classes/java/awt/image/MemoryImageSource.java ! src/share/classes/java/awt/image/MultiPixelPackedSampleModel.java ! src/share/classes/java/awt/image/PixelGrabber.java ! src/share/classes/java/awt/image/RGBImageFilter.java ! src/share/classes/java/awt/image/ShortLookupTable.java ! src/share/classes/java/awt/image/SinglePixelPackedSampleModel.java ! src/share/classes/java/awt/image/WritableRaster.java Changeset: 9314c199003d Author: lana Date: 2013-08-06 22:47 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/9314c199003d Merge - src/share/classes/java/net/package.html Changeset: ab64c138d5bd Author: prr Date: 2013-08-07 18:24 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/ab64c138d5bd 8014883: java.awt.container.add(component comp object constraints) doesn't work as expected on some linux platforms Reviewed-by: jgodinez ! makefiles/CompileNativeLibraries.gmk ! src/solaris/native/sun/java2d/x11/XRBackendNative.c Changeset: e193c4ad940a Author: lana Date: 2013-08-07 19:52 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/e193c4ad940a Merge Changeset: c49b538ef054 Author: chegar Date: 2013-08-01 12:38 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/c49b538ef054 8022061: More ProblemList.txt updates (7/2013) Reviewed-by: alanb, psandoz ! test/ProblemList.txt Changeset: 36f4cf8872f3 Author: igerasim Date: 2013-07-30 21:11 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/36f4cf8872f3 7192942: (coll) Inefficient calculation of power of two in HashMap Reviewed-by: mduigou ! src/share/classes/java/util/HashMap.java Changeset: 54329c24c2f4 Author: igerasim Date: 2013-07-29 12:35 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/54329c24c2f4 8020669: (fs) Files.readAllBytes() does not read any data when Files.size() is 0 Reviewed-by: alanb, chegar, martin, rriggs ! src/share/classes/java/nio/file/Files.java ! test/java/nio/file/Files/BytesAndLines.java Changeset: d6de149b9f20 Author: xuelei Date: 2013-08-01 07:34 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/d6de149b9f20 7127524: P11TlsPrfGenerator has anonymous inner class with serialVersionUID Reviewed-by: vinnie ! src/share/classes/sun/security/pkcs11/P11TlsPrfGenerator.java Changeset: cd13a4a45a37 Author: chegar Date: 2013-08-01 16:53 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/cd13a4a45a37 8022087: Fix doclint issues in j.u.Deque & Queue Reviewed-by: chegar, darcy Contributed-by: Doug Lea
! src/share/classes/java/util/Deque.java ! src/share/classes/java/util/Queue.java Changeset: 0be7839d4599 Author: psandoz Date: 2013-08-01 15:28 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/0be7839d4599 8020016: Numerous splitereator impls do not throw NPE for null Consumers Reviewed-by: mduigou, alanb, henryjen ! src/share/classes/java/util/stream/SpinedBuffer.java ! src/share/classes/java/util/stream/StreamSpliterators.java ! src/share/classes/java/util/stream/Streams.java ! test/java/util/Spliterator/SpliteratorTraversingAndSplittingTest.java ! test/java/util/stream/bootlib/java/util/stream/SpliteratorTestHelper.java Changeset: 29f153e11683 Author: weijun Date: 2013-08-02 08:59 +0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/29f153e11683 8021789: jarsigner parses alias as command line option (depending on locale) Reviewed-by: vinnie ! src/share/classes/sun/security/tools/jarsigner/Main.java + test/sun/security/tools/jarsigner/collator.sh Changeset: 40221b09812f Author: uta Date: 2013-08-02 13:16 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/40221b09812f 8020191: System.getProperty("os.name") returns "Windows NT (unknown)" on Windows 8.1 Reviewed-by: alanb, khazra, chegar ! src/windows/native/java/lang/java_props_md.c ! src/windows/resource/java.manifest Changeset: 60c275e56a69 Author: chegar Date: 2013-08-02 11:25 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/60c275e56a69 8022121: Remove superfluous @test tag from SpliteratorTraversingAndSplittingTest Reviewed-by: psandoz ! test/java/util/Spliterator/SpliteratorTraversingAndSplittingTest.java Changeset: 6ec910ff3ea1 Author: chegar Date: 2013-08-02 14:29 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/6ec910ff3ea1 8020291: j.u.c.CompletionStage 8020435: CompletableFuture/Basic.java fails on single core machine Reviewed-by: chegar, psandoz Contributed-by: Doug Lea
! src/share/classes/java/util/concurrent/CompletableFuture.java + src/share/classes/java/util/concurrent/CompletionStage.java ! test/ProblemList.txt ! test/java/util/concurrent/CompletableFuture/Basic.java Changeset: 42b786f2fb99 Author: mullan Date: 2013-08-02 08:30 -0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/42b786f2fb99 8001319: Add SecurityPermission "insertProvider" target name Reviewed-by: vinnie ! src/share/classes/java/security/Security.java ! src/share/classes/java/security/SecurityPermission.java + test/java/security/Security/AddProvider.java + test/java/security/Security/AddProvider.policy.1 + test/java/security/Security/AddProvider.policy.2 + test/java/security/Security/AddProvider.policy.3 Changeset: 7bbc6c2351d7 Author: mullan Date: 2013-08-02 08:37 -0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/7bbc6c2351d7 Merge - src/share/classes/java/net/package.html - src/share/classes/java/util/stream/StreamBuilder.java - src/share/classes/javax/security/auth/callback/package.html - src/share/classes/javax/security/auth/kerberos/package.html - src/share/classes/javax/security/auth/login/package.html - src/share/classes/javax/security/auth/package.html - src/share/classes/javax/security/auth/spi/package.html - src/share/classes/javax/security/auth/x500/package.html - src/share/classes/javax/security/cert/package.html - src/share/classes/javax/security/sasl/package.html - test/java/util/Collections/EmptySortedSet.java Changeset: 0a778e487a73 Author: mullan Date: 2013-08-02 09:38 -0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/0a778e487a73 Merge Changeset: 33617583c545 Author: bpb Date: 2013-07-31 10:53 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/33617583c545 6476168: (fmt) Inconsistency formatting subnormal doubles with hexadecimal conversion Summary: Update specification to match implementation. Reviewed-by: darcy Contributed-by: Brian Burkhalter ! src/share/classes/java/util/Formatter.java ! test/java/util/Formatter/Basic-X.java.template ! test/java/util/Formatter/Basic.java ! test/java/util/Formatter/BasicDouble.java Changeset: 883cc296ec89 Author: bchristi Date: 2013-08-02 15:30 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/883cc296ec89 8011194: Apps launched via double-clicked .jars have file.encoding value of US-ASCII on Mac OS X Summary: On Mac, default to UTF-8 if no environmental hints are available Reviewed-by: naoto, ddehaven ! src/solaris/native/java/lang/java_props_md.c + test/java/lang/System/MacEncoding/ExpectedEncoding.java + test/java/lang/System/MacEncoding/MacJNUEncoding.sh + test/java/lang/System/MacEncoding/TestFileEncoding.java - test/java/lang/System/MacJNUEncoding/ExpectedEncoding.java - test/java/lang/System/MacJNUEncoding/MacJNUEncoding.sh Changeset: dd1040690e31 Author: bpb Date: 2013-08-02 11:10 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/dd1040690e31 8022094: BigDecimal/CompareToTests and BigInteger/CompareToTests are incorrect Summary: Fail test if errors; fix test values; port BigDecimal version to BigInteger Reviewed-by: smarks, alanb Contributed-by: Brian Burkhalter ! test/java/math/BigDecimal/CompareToTests.java ! test/java/math/BigInteger/CompareToTests.java Changeset: 80da091343af Author: darcy Date: 2013-08-05 07:50 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/80da091343af 8022190: Fix varargs lint warnings in the JDK Reviewed-by: alanb, lancea, alexsch ! src/share/classes/java/util/stream/Stream.java ! src/share/classes/javax/swing/SwingWorker.java ! src/share/classes/sun/reflect/annotation/AnnotationParser.java ! src/share/classes/sun/swing/AccumulativeRunnable.java Changeset: 87367a1c7f76 Author: sundar Date: 2013-08-05 21:31 +0530 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/87367a1c7f76 8016531: jconsole-plugin script demo does not work with nashorn Reviewed-by: lagergren, hannesw Contributed-by: rieberandreas at gmail.com ! src/share/demo/scripting/jconsole-plugin/src/com/sun/demo/scripting/jconsole/ScriptShellPanel.java ! src/share/demo/scripting/jconsole-plugin/src/resources/jconsole.js ! src/share/demo/scripting/jconsole-plugin/src/scripts/invoke.js ! src/share/demo/scripting/jconsole-plugin/src/scripts/jstack.js ! src/share/demo/scripting/jconsole-plugin/src/scripts/jtop.js ! src/share/demo/scripting/jconsole-plugin/src/scripts/sysprops.js ! src/share/sample/scripting/scriptpad/README.txt ! src/share/sample/scripting/scriptpad/src/resources/conc.js ! src/share/sample/scripting/scriptpad/src/resources/mm.js Changeset: 31759750ff63 Author: smarks Date: 2013-08-05 19:12 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/31759750ff63 8020854: change RMI javadocs to specify that remote objects are exported to the wildcard address Reviewed-by: rgallard, alanb ! src/share/classes/java/rmi/server/RMISocketFactory.java ! src/share/classes/java/rmi/server/UnicastRemoteObject.java Changeset: fce446b29577 Author: dsamersoff Date: 2013-08-06 14:04 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/fce446b29577 8011038: sourceObj validation during desereliazation of RelationNotification should be relaxed Summary: sourceObj could be set to null by setSource() relax a validation of deserialized object. Reviewed-by: sjiang, skoivu, dfuchs ! src/share/classes/javax/management/relation/RelationNotification.java Changeset: 6773af0dda02 Author: chegar Date: 2013-08-06 15:35 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/6773af0dda02 8022344: Additional debug info for test/java/net/NetworkInterface/IndexTest.java Reviewed-by: michaelm, alanb ! test/java/net/NetworkInterface/IndexTest.java Changeset: 1f4af3e0447e Author: mullan Date: 2013-08-06 08:31 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/1f4af3e0447e 8022120: JCK test api/javax_xml/crypto/dsig/TransformService/index_ParamMethods fails Summary: TransformService.init and marshalParams must throw NullPointerException when parent parameter is null Reviewed-by: xuelei ! src/share/classes/org/jcp/xml/dsig/internal/dom/ApacheCanonicalizer.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/ApacheTransform.java + test/javax/xml/crypto/dsig/TransformService/NullParent.java Changeset: ba634b53f53a Author: mullan Date: 2013-08-06 08:34 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/ba634b53f53a Merge Changeset: cd0ea5563523 Author: jfranck Date: 2013-08-06 18:54 +0200 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/cd0ea5563523 7184826: (reflect) Add support for Project Lambda concepts in core reflection Reviewed-by: darcy, jfranck Contributed-by: Amy Lu + test/java/lang/reflect/DefaultStaticTest/DefaultStaticInvokeTest.java + test/java/lang/reflect/DefaultStaticTest/DefaultStaticTestData.java + test/java/lang/reflect/DefaultStaticTest/helper/Declared.java + test/java/lang/reflect/DefaultStaticTest/helper/Mod.java ! test/java/lang/reflect/Method/DefaultMethodModeling.java ! test/java/lang/reflect/Method/IsDefaultTest.java Changeset: 98643f3ddf40 Author: darcy Date: 2013-08-06 13:25 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/98643f3ddf40 8022174: Fix doclint warnings in javax.sound 8022404: Fix doclint issues in java.applet Reviewed-by: prr ! src/share/classes/java/applet/AppletContext.java ! src/share/classes/javax/sound/midi/MetaMessage.java ! src/share/classes/javax/sound/midi/MidiDevice.java ! src/share/classes/javax/sound/midi/MidiDeviceReceiver.java ! src/share/classes/javax/sound/midi/MidiDeviceTransmitter.java ! src/share/classes/javax/sound/midi/MidiFileFormat.java ! src/share/classes/javax/sound/midi/MidiMessage.java ! src/share/classes/javax/sound/midi/MidiSystem.java ! src/share/classes/javax/sound/midi/ShortMessage.java ! src/share/classes/javax/sound/midi/Synthesizer.java ! src/share/classes/javax/sound/midi/SysexMessage.java ! src/share/classes/javax/sound/midi/Track.java ! src/share/classes/javax/sound/sampled/AudioFileFormat.java ! src/share/classes/javax/sound/sampled/AudioFormat.java ! src/share/classes/javax/sound/sampled/AudioSystem.java ! src/share/classes/javax/sound/sampled/BooleanControl.java ! src/share/classes/javax/sound/sampled/Mixer.java ! src/share/classes/javax/sound/sampled/spi/FormatConversionProvider.java Changeset: 12c1b78acf9a Author: lagergren Date: 2013-08-06 12:56 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/12c1b78acf9a 8022412: Fixed warnings in java.util root, except for HashMap Reviewed-by: mduigou, darcy Contributed-by: marcus.lagergren at oracle.com ! src/share/classes/java/util/ArrayPrefixHelpers.java ! src/share/classes/java/util/Collections.java ! src/share/classes/java/util/Comparator.java ! src/share/classes/java/util/Comparators.java ! src/share/classes/java/util/Hashtable.java ! src/share/classes/java/util/IdentityHashMap.java ! src/share/classes/java/util/Vector.java ! src/share/classes/java/util/WeakHashMap.java Changeset: 8112076ae424 Author: juh Date: 2013-08-06 13:46 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/8112076ae424 8022439: Fix lint warnings in sun.security.ec Reviewed-by: darcy ! src/share/classes/sun/security/ec/ECDSASignature.java Changeset: 69cfd941aec2 Author: juh Date: 2013-08-06 14:10 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/69cfd941aec2 8022443: Fix lint warnings in sun.security.pkcs12 Reviewed-by: darcy ! src/share/classes/sun/security/pkcs12/PKCS12KeyStore.java Changeset: 31e923842d49 Author: smarks Date: 2013-08-06 14:24 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/31e923842d49 8022440: suppress deprecation warnings in sun.rmi Reviewed-by: mduigou ! src/share/classes/sun/rmi/runtime/Log.java ! src/share/classes/sun/rmi/server/ActivatableRef.java ! src/share/classes/sun/rmi/server/Dispatcher.java ! src/share/classes/sun/rmi/server/LoaderHandler.java ! src/share/classes/sun/rmi/server/UnicastRef.java ! src/share/classes/sun/rmi/server/UnicastServerRef.java ! src/share/classes/sun/rmi/server/Util.java ! src/share/classes/sun/rmi/transport/DGCImpl.java ! src/share/classes/sun/rmi/transport/StreamRemoteCall.java ! src/share/classes/sun/rmi/transport/Transport.java ! src/share/classes/sun/rmi/transport/proxy/RMIMasterSocketFactory.java ! src/share/classes/sun/rmi/transport/tcp/ConnectionMultiplexer.java ! src/share/classes/sun/rmi/transport/tcp/TCPTransport.java Changeset: 4b8b811059db Author: dxu Date: 2013-08-06 14:33 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/4b8b811059db 8022410: Fix Javac Warnings in com.sun.security.auth Package Reviewed-by: darcy ! src/share/classes/com/sun/security/auth/PolicyFile.java ! src/share/classes/com/sun/security/auth/SubjectCodeSource.java Changeset: d5694d78ebc6 Author: darcy Date: 2013-08-06 16:01 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/d5694d78ebc6 8022406: Fix doclint issues in java.beans Reviewed-by: prr ! src/share/classes/java/beans/AppletInitializer.java ! src/share/classes/java/beans/Beans.java ! src/share/classes/java/beans/ConstructorProperties.java ! src/share/classes/java/beans/DefaultPersistenceDelegate.java ! src/share/classes/java/beans/EventHandler.java ! src/share/classes/java/beans/Expression.java ! src/share/classes/java/beans/IndexedPropertyDescriptor.java ! src/share/classes/java/beans/Introspector.java ! src/share/classes/java/beans/PersistenceDelegate.java ! src/share/classes/java/beans/PropertyChangeSupport.java ! src/share/classes/java/beans/PropertyDescriptor.java ! src/share/classes/java/beans/Transient.java ! src/share/classes/java/beans/VetoableChangeSupport.java ! src/share/classes/java/beans/beancontext/BeanContext.java ! src/share/classes/java/beans/beancontext/BeanContextChild.java ! src/share/classes/java/beans/beancontext/BeanContextChildSupport.java ! src/share/classes/java/beans/beancontext/BeanContextMembershipEvent.java ! src/share/classes/java/beans/beancontext/BeanContextServices.java ! src/share/classes/java/beans/beancontext/BeanContextServicesSupport.java ! src/share/classes/java/beans/beancontext/BeanContextSupport.java Changeset: 939c3be6cc86 Author: briangoetz Date: 2013-06-28 16:26 -0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/939c3be6cc86 8015318: Extend Collector with 'finish' operation Reviewed-by: mduigou Contributed-by: brian.goetz at oracle.com ! src/share/classes/java/util/DoubleSummaryStatistics.java ! src/share/classes/java/util/IntSummaryStatistics.java ! src/share/classes/java/util/LongSummaryStatistics.java ! src/share/classes/java/util/StringJoiner.java ! src/share/classes/java/util/stream/Collector.java ! src/share/classes/java/util/stream/Collectors.java ! src/share/classes/java/util/stream/DelegatingStream.java ! src/share/classes/java/util/stream/DoubleStream.java ! src/share/classes/java/util/stream/IntStream.java ! src/share/classes/java/util/stream/LongStream.java ! src/share/classes/java/util/stream/ReduceOps.java ! src/share/classes/java/util/stream/ReferencePipeline.java ! src/share/classes/java/util/stream/Stream.java ! src/share/classes/java/util/stream/package-info.java ! test/java/util/stream/test/org/openjdk/tests/java/util/FillableStringTest.java ! test/java/util/stream/test/org/openjdk/tests/java/util/stream/GroupByOpTest.java ! test/java/util/stream/test/org/openjdk/tests/java/util/stream/SummaryStatisticsTest.java ! test/java/util/stream/test/org/openjdk/tests/java/util/stream/TabulatorsTest.java ! test/jdk/lambda/MethodReferenceTestInstanceMethod.java ! test/jdk/lambda/separate/TestHarness.java Changeset: 6cc8c2ad9804 Author: darcy Date: 2013-08-06 16:45 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/6cc8c2ad9804 8022453: Fix doclint issues in javax.accessibility Reviewed-by: prr ! src/share/classes/javax/accessibility/Accessible.java ! src/share/classes/javax/accessibility/AccessibleBundle.java ! src/share/classes/javax/accessibility/AccessibleExtendedTable.java ! src/share/classes/javax/accessibility/AccessibleRelationSet.java ! src/share/classes/javax/accessibility/AccessibleTable.java ! src/share/classes/javax/accessibility/AccessibleTableModelChange.java ! src/share/classes/javax/accessibility/AccessibleTextSequence.java ! src/share/classes/javax/accessibility/AccessibleValue.java Changeset: 2bc9ce1aade5 Author: lana Date: 2013-08-06 17:01 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/2bc9ce1aade5 Merge Changeset: 7ab5f19a9a31 Author: lana Date: 2013-08-06 17:13 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/7ab5f19a9a31 Merge Changeset: e303c228bf31 Author: henryjen Date: 2013-08-06 17:42 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/e303c228bf31 8022446: Fix serial warnings in java.util.stream Reviewed-by: darcy ! src/share/classes/java/util/stream/AbstractShortCircuitTask.java ! src/share/classes/java/util/stream/AbstractTask.java ! src/share/classes/java/util/stream/FindOps.java ! src/share/classes/java/util/stream/ForEachOps.java ! src/share/classes/java/util/stream/MatchOps.java ! src/share/classes/java/util/stream/Nodes.java ! src/share/classes/java/util/stream/ReduceOps.java ! src/share/classes/java/util/stream/SliceOps.java Changeset: 1d21ff5c2b3f Author: dxu Date: 2013-08-06 18:16 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/1d21ff5c2b3f 8022478: Fix Warnings In sun.net.www.protocol.http Package Reviewed-by: darcy ! src/share/classes/sun/net/www/protocol/http/AuthCacheValue.java ! src/share/classes/sun/net/www/protocol/http/AuthenticationInfo.java Changeset: e117fcdd2176 Author: mduigou Date: 2013-08-06 18:18 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/e117fcdd2176 8022476: cleanup some raw types and unchecked warnings in java.util.stream Reviewed-by: darcy Contributed-by: mike.duigou at oracle.com, henry.jen at oracle.com ! src/share/classes/java/util/Optional.java ! src/share/classes/java/util/stream/AbstractPipeline.java ! src/share/classes/java/util/stream/AbstractShortCircuitTask.java ! src/share/classes/java/util/stream/DoublePipeline.java ! src/share/classes/java/util/stream/IntPipeline.java ! src/share/classes/java/util/stream/LongPipeline.java ! src/share/classes/java/util/stream/Nodes.java ! src/share/classes/java/util/stream/ReduceOps.java ! src/share/classes/java/util/stream/ReferencePipeline.java ! src/share/classes/java/util/stream/Sink.java ! src/share/classes/java/util/stream/SortedOps.java ! src/share/classes/java/util/stream/StreamSpliterators.java Changeset: 906dd23334c1 Author: weijun Date: 2013-08-07 19:06 +0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/906dd23334c1 7151062: [macosx] SCDynamicStore prints error messages to stderr Reviewed-by: xuelei ! src/macosx/native/java/util/SCDynamicStoreConfig.m Changeset: 99f4319763a9 Author: sundar Date: 2013-08-07 18:16 +0530 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/99f4319763a9 8022483: Nashorn compatibility issues in jhat's OQL feature Reviewed-by: lagergren, attila, hannesw ! src/share/classes/com/sun/tools/hat/resources/hat.js ! src/share/classes/com/sun/tools/hat/resources/oqlhelp.html Changeset: 8c7cf4926157 Author: xuelei Date: 2013-08-07 06:42 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/8c7cf4926157 8013809: deadlock in SSLSocketImpl between between write and close Reviewed-by: wetmore ! src/share/classes/sun/security/ssl/SSLSocketImpl.java Changeset: c1f129f62f36 Author: lagergren Date: 2013-08-07 08:08 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/c1f129f62f36 8022454: Fixed various serializations and deprecation warnings in java.util, java.net and sun.tools Reviewed-by: darcy Contributed-by: marcus.lagergren at oracle.com ! src/share/classes/java/net/SocketAddress.java ! src/share/classes/java/util/logging/XMLFormatter.java ! src/share/classes/sun/tools/jar/JarException.java Changeset: d1c82d5bee3f Author: dxu Date: 2013-08-07 12:13 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/d1c82d5bee3f 8022554: Fix Warnings in sun.invoke.anon Package Reviewed-by: darcy, mduigou, lancea ! src/share/classes/sun/invoke/anon/ConstantPoolPatch.java Changeset: 8c50c27418d3 Author: smarks Date: 2013-08-07 16:29 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/8c50c27418d3 8022479: clean up warnings from sun.tools.asm Reviewed-by: lancea, darcy ! src/share/classes/sun/tools/asm/Assembler.java ! src/share/classes/sun/tools/asm/ConstantPool.java ! src/share/classes/sun/tools/asm/Instruction.java ! src/share/classes/sun/tools/asm/SwitchData.java ! src/share/classes/sun/tools/asm/TryData.java Changeset: 23e68a8e4b91 Author: lana Date: 2013-08-07 19:56 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/23e68a8e4b91 Merge - test/java/lang/System/MacJNUEncoding/ExpectedEncoding.java - test/java/lang/System/MacJNUEncoding/MacJNUEncoding.sh Changeset: e0f6039c0290 Author: lana Date: 2013-08-13 10:42 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/e0f6039c0290 Merge Changeset: 149bf2400fa1 Author: lana Date: 2013-08-13 15:49 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/149bf2400fa1 Merge - test/java/lang/System/MacJNUEncoding/ExpectedEncoding.java - test/java/lang/System/MacJNUEncoding/MacJNUEncoding.sh From lana.steuck at oracle.com Tue Aug 13 17:00:10 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 14 Aug 2013 00:00:10 +0000 Subject: hg: jdk8/awt: Added tag jdk8-b102 for changeset 5eb3c1dc348f Message-ID: <20130814000011.EFC814883F@hg.openjdk.java.net> Changeset: b7e64be81c8a Author: cl Date: 2013-08-08 10:10 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/rev/b7e64be81c8a Added tag jdk8-b102 for changeset 5eb3c1dc348f ! .hgtags From petr.pchelko at oracle.com Wed Aug 14 04:17:56 2013 From: petr.pchelko at oracle.com (Petr Pchelko) Date: Wed, 14 Aug 2013 15:17:56 +0400 Subject: [8] Review Request: JDK-7173464 Clipboard.getAvailableDataFlavors: Comparison method violates contract Message-ID: <1D8209A7-D537-4EE8-86B7-AF2D3860B39D@oracle.com> Hello, AWT Team. Please review the fix for the following issue: http://bugs.sun.com/view_bug.do?bug_id=7173464 The fix is available at: http://cr.openjdk.java.net/~pchelko/7173464/webrev.00/ The problem: DataTransfer.DataFlavorComparator sometimes returns 0 for non-equal DataFlavors. the reason is that some flavors are not comparable: for example Image and HTML. Before the fix handles to native flavor representations were used to compare incomparable flavors. this is bad for many reasons: 1. Exposing the existence of native handles to public methods 2. The order might change from run to run 3. For some DataFlavorComparator constructors native handles were not provided. The solution: The spec of the comparator was changed. Now it compares string representations of flavors, so now it's impossible that comparator returns 0 for non-equal flavors. The use of natives was removed. The class is a part of sun.awt package, there are not regression or JCK tests for this, so the spec could be safely changed. It's unlikely to have any regressions, because it really does not matter how to compare incomparable flavors. With best regards. Petr. From artem.ananiev at oracle.com Wed Aug 14 05:18:49 2013 From: artem.ananiev at oracle.com (Artem Ananiev) Date: Wed, 14 Aug 2013 16:18:49 +0400 Subject: [8] Review Request: JDK-7173464 Clipboard.getAvailableDataFlavors: Comparison method violates contract In-Reply-To: <1D8209A7-D537-4EE8-86B7-AF2D3860B39D@oracle.com> References: <1D8209A7-D537-4EE8-86B7-AF2D3860B39D@oracle.com> Message-ID: <520B75A9.5020701@oracle.com> Looks fine to me. Thanks, Artem On 8/14/2013 3:17 PM, Petr Pchelko wrote: > Hello, AWT Team. > > Please review the fix for the following issue: > http://bugs.sun.com/view_bug.do?bug_id=7173464 > The fix is available at: > http://cr.openjdk.java.net/~pchelko/7173464/webrev.00/ > > The problem: > DataTransfer.DataFlavorComparator sometimes returns 0 for non-equal DataFlavors. the reason is that some flavors are not comparable: for example Image and HTML. Before the fix handles to native flavor representations were used to compare incomparable flavors. this is bad for many reasons: > 1. Exposing the existence of native handles to public methods > 2. The order might change from run to run > 3. For some DataFlavorComparator constructors native handles were not provided. > > The solution: > The spec of the comparator was changed. Now it compares string representations of flavors, so now it's impossible that comparator returns 0 for non-equal flavors. > The use of natives was removed. The class is a part of sun.awt package, there are not regression or JCK tests for this, so the spec could be safely changed. > It's unlikely to have any regressions, because it really does not matter how to compare incomparable flavors. > > With best regards. Petr. > From Sergey.Bylokhov at oracle.com Wed Aug 14 05:31:27 2013 From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov) Date: Wed, 14 Aug 2013 16:31:27 +0400 Subject: [8] Review Request: JDK-7173464 Clipboard.getAvailableDataFlavors: Comparison method violates contract In-Reply-To: <1D8209A7-D537-4EE8-86B7-AF2D3860B39D@oracle.com> References: <1D8209A7-D537-4EE8-86B7-AF2D3860B39D@oracle.com> Message-ID: <520B789F.3010007@oracle.com> Hi, Petr. Fix looks fine. On 14.08.2013 15:17, Petr Pchelko wrote: > Hello, AWT Team. > > Please review the fix for the following issue: > http://bugs.sun.com/view_bug.do?bug_id=7173464 > The fix is available at: > http://cr.openjdk.java.net/~pchelko/7173464/webrev.00/ > > The problem: > DataTransfer.DataFlavorComparator sometimes returns 0 for non-equal DataFlavors. the reason is that some flavors are not comparable: for example Image and HTML. Before the fix handles to native flavor representations were used to compare incomparable flavors. this is bad for many reasons: > 1. Exposing the existence of native handles to public methods > 2. The order might change from run to run > 3. For some DataFlavorComparator constructors native handles were not provided. > > The solution: > The spec of the comparator was changed. Now it compares string representations of flavors, so now it's impossible that comparator returns 0 for non-equal flavors. > The use of natives was removed. The class is a part of sun.awt package, there are not regression or JCK tests for this, so the spec could be safely changed. > It's unlikely to have any regressions, because it really does not matter how to compare incomparable flavors. > > With best regards. Petr. -- Best regards, Sergey. From anthony.petrov at oracle.com Wed Aug 14 05:41:14 2013 From: anthony.petrov at oracle.com (Anthony Petrov) Date: Wed, 14 Aug 2013 16:41:14 +0400 Subject: [8] Review Request: JDK-7173464 Clipboard.getAvailableDataFlavors: Comparison method violates contract In-Reply-To: <1D8209A7-D537-4EE8-86B7-AF2D3860B39D@oracle.com> References: <1D8209A7-D537-4EE8-86B7-AF2D3860B39D@oracle.com> Message-ID: <520B7AEA.2030101@oracle.com> Hi Petr, I'm not an expert in DnD, but the proposed solution sounds reasonable and the code changes look fine to me. -- best regards, Anthony On 08/14/2013 03:17 PM, Petr Pchelko wrote: > Hello, AWT Team. > > Please review the fix for the following issue: > http://bugs.sun.com/view_bug.do?bug_id=7173464 > The fix is available at: > http://cr.openjdk.java.net/~pchelko/7173464/webrev.00/ > > The problem: > DataTransfer.DataFlavorComparator sometimes returns 0 for non-equal DataFlavors. the reason is that some flavors are not comparable: for example Image and HTML. Before the fix handles to native flavor representations were used to compare incomparable flavors. this is bad for many reasons: > 1. Exposing the existence of native handles to public methods > 2. The order might change from run to run > 3. For some DataFlavorComparator constructors native handles were not provided. > > The solution: > The spec of the comparator was changed. Now it compares string representations of flavors, so now it's impossible that comparator returns 0 for non-equal flavors. > The use of natives was removed. The class is a part of sun.awt package, there are not regression or JCK tests for this, so the spec could be safely changed. > It's unlikely to have any regressions, because it really does not matter how to compare incomparable flavors. > > With best regards. Petr. > From petr.pchelko at oracle.com Wed Aug 14 05:17:26 2013 From: petr.pchelko at oracle.com (petr.pchelko at oracle.com) Date: Wed, 14 Aug 2013 12:17:26 +0000 Subject: hg: jdk8/awt/jdk: 8013454: [parfait] Memory leak in jdk/src/windows/native/sun/windows/awt_Cursor.cpp; ... Message-ID: <20130814121815.6F4864887A@hg.openjdk.java.net> Changeset: c5db3ec83cba Author: pchelko Date: 2013-08-14 16:17 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/c5db3ec83cba 8013454: [parfait] Memory leak in jdk/src/windows/native/sun/windows/awt_Cursor.cpp 8012079: [parfait] possible null pointer dereference in jdk/src/windows/native/sun/windows/awt_Font.cpp Reviewed-by: art, serb ! src/windows/native/sun/windows/awt_Cursor.cpp ! src/windows/native/sun/windows/awt_Font.cpp From Sergey.Bylokhov at oracle.com Wed Aug 14 07:10:15 2013 From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov) Date: Wed, 14 Aug 2013 18:10:15 +0400 Subject: [8] Request for review: 8020051 [TEST_BUG] Testcase for 8004859 has a typo. Message-ID: <520B8FC7.9050207@oracle.com> Hello, Please review the fix for jdk 8. The test should check graphics has correct clip if an empty rectangle(with negative width and height) was used. Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8020051 Webrev can be found at: http://cr.openjdk.java.net/~serb/8020051/webrev.00 -- Best regards, Sergey. From anthony.petrov at oracle.com Wed Aug 14 07:24:55 2013 From: anthony.petrov at oracle.com (Anthony Petrov) Date: Wed, 14 Aug 2013 18:24:55 +0400 Subject: [8] Request for review: 8020051 [TEST_BUG] Testcase for 8004859 has a typo. In-Reply-To: <520B8FC7.9050207@oracle.com> References: <520B8FC7.9050207@oracle.com> Message-ID: <520B9337.9090600@oracle.com> Looks fine. -- best regards, Anthony On 08/14/2013 06:10 PM, Sergey Bylokhov wrote: > Hello, > Please review the fix for jdk 8. > The test should check graphics has correct clip if an empty > rectangle(with negative width and height) was used. > > Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8020051 > Webrev can be found at: http://cr.openjdk.java.net/~serb/8020051/webrev.00 > From petr.pchelko at oracle.com Wed Aug 14 06:20:14 2013 From: petr.pchelko at oracle.com (petr.pchelko at oracle.com) Date: Wed, 14 Aug 2013 13:20:14 +0000 Subject: hg: jdk8/awt/jdk: 7173464: Clipboard.getAvailableDataFlavors: Comparison method violates contract Message-ID: <20130814132046.C29BE4887C@hg.openjdk.java.net> Changeset: 1d6ce0070fd3 Author: pchelko Date: 2013-08-14 17:20 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/1d6ce0070fd3 7173464: Clipboard.getAvailableDataFlavors: Comparison method violates contract Reviewed-by: anthony, art, serb ! src/share/classes/sun/awt/datatransfer/ClipboardTransferable.java ! src/share/classes/sun/awt/datatransfer/DataTransferer.java + test/sun/awt/datatransfer/DataFlavorComparatorTest.java From leonid.romanov at oracle.com Wed Aug 14 09:44:04 2013 From: leonid.romanov at oracle.com (Leonid Romanov) Date: Wed, 14 Aug 2013 20:44:04 +0400 Subject: [8] Review request for 8022997: [macosx] Remaining duplicated key events Message-ID: <9E34DB6A-C9C9-4DE6-B664-959E38BFD995@oracle.com> Hello, Please review a one line fix for 8022997: [macosx] Remaining duplicated key events. NsCharToJavaChar() we call at CMenuItem.m:92 translates NSCarriageReturnCharacter (which is the key code generated by OS X when user presses "enter" key) into NSNewlineCharacter. So, in order to filter out the duplicate event at line 101, menuKey has to be NSNewlineCharacter as well. This is what the fix does. Bug: http://bugs.sun.com/view_bug.do?bug_id=8022997 (might not be available yet) webrev: http://cr.openjdk.java.net/~leonidr/8022997/webrev.00/ Thanks, Leonid. From anthony.petrov at oracle.com Wed Aug 14 09:50:38 2013 From: anthony.petrov at oracle.com (Anthony Petrov) Date: Wed, 14 Aug 2013 20:50:38 +0400 Subject: [8] Review request for 8022997: [macosx] Remaining duplicated key events In-Reply-To: <9E34DB6A-C9C9-4DE6-B664-959E38BFD995@oracle.com> References: <9E34DB6A-C9C9-4DE6-B664-959E38BFD995@oracle.com> Message-ID: <520BB55E.1000506@oracle.com> The fix looks good to me. -- best regards, Anthony On 08/14/2013 08:44 PM, Leonid Romanov wrote: > Hello, > Please review a one line fix for 8022997: [macosx] Remaining duplicated key events. NsCharToJavaChar() we call at CMenuItem.m:92 translates NSCarriageReturnCharacter (which is the key code generated by OS X when user presses "enter" key) into NSNewlineCharacter. So, in order to filter out the duplicate event at line 101, menuKey has to be NSNewlineCharacter as well. This is what the fix does. > > Bug: http://bugs.sun.com/view_bug.do?bug_id=8022997 (might not be available yet) > webrev: http://cr.openjdk.java.net/~leonidr/8022997/webrev.00/ > > Thanks, > Leonid. > From Sergey.Bylokhov at oracle.com Wed Aug 14 09:59:36 2013 From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov) Date: Wed, 14 Aug 2013 20:59:36 +0400 Subject: [8] Review request for 8022997: [macosx] Remaining duplicated key events In-Reply-To: <9E34DB6A-C9C9-4DE6-B664-959E38BFD995@oracle.com> References: <9E34DB6A-C9C9-4DE6-B664-959E38BFD995@oracle.com> Message-ID: <520BB778.8040604@oracle.com> Hi, Leonid. Fix looks fine. On 14.08.2013 20:44, Leonid Romanov wrote: > Hello, > Please review a one line fix for 8022997: [macosx] Remaining duplicated key events. NsCharToJavaChar() we call at CMenuItem.m:92 translates NSCarriageReturnCharacter (which is the key code generated by OS X when user presses "enter" key) into NSNewlineCharacter. So, in order to filter out the duplicate event at line 101, menuKey has to be NSNewlineCharacter as well. This is what the fix does. > > Bug: http://bugs.sun.com/view_bug.do?bug_id=8022997 (might not be available yet) > webrev: http://cr.openjdk.java.net/~leonidr/8022997/webrev.00/ > > Thanks, > Leonid. > -- Best regards, Sergey. From Sergey.Bylokhov at oracle.com Wed Aug 14 10:06:59 2013 From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov) Date: Wed, 14 Aug 2013 21:06:59 +0400 Subject: [8] Review request for 7191018: Manual test closed/java/awt/JAWT causes JVM to crash starting from JDK 5 In-Reply-To: <52012CA1.7050106@oracle.com> References: <52012CA1.7050106@oracle.com> Message-ID: <520BB933.5010508@oracle.com> Hi, Anton. Fix looks fine. On 06.08.2013 21:04, Anton Litvinov wrote: > Hello, > > Could you please review the following fix for a bug from AWT Native > Interface area. > > Bug: http://bugs.sun.com/view_bug.do?bug_id=7191018 > Webrev: http://cr.openjdk.java.net/~alitvinov/7191018/webrev.00 > > The solution is based on introduction of initialization of "jobject > peer" local variable by means of JNI invocation of the Java method > "sun.awt.X11.XToolkit.windowToXWindow(long window)". > > Thank you, > Anton -- Best regards, Sergey. From leonid.romanov at oracle.com Wed Aug 14 14:18:13 2013 From: leonid.romanov at oracle.com (leonid.romanov at oracle.com) Date: Wed, 14 Aug 2013 21:18:13 +0000 Subject: hg: jdk8/awt/jdk: 8022997: [macosx] Remaining duplicated key events Message-ID: <20130814211838.4A9E6488A0@hg.openjdk.java.net> Changeset: 3930a827160a Author: leonidr Date: 2013-08-15 01:17 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/3930a827160a 8022997: [macosx] Remaining duplicated key events Reviewed-by: anthony, serb ! src/macosx/native/sun/awt/CMenuItem.m ! test/javax/swing/JMenuItem/ActionListenerCalledTwice/ActionListenerCalledTwiceTest.java From petr.pchelko at oracle.com Thu Aug 15 01:20:21 2013 From: petr.pchelko at oracle.com (Petr Pchelko) Date: Thu, 15 Aug 2013 12:20:21 +0400 Subject: [8] RFR: JDK-8015371 The HTML text without tags does not appear inside the WordPad application, and we try to click the button, but the case exits. Message-ID: <455AB4E1-6EC9-4980-998D-484E069A6137@oracle.com> Hello, AWT Team. Please review the following fix: http://cr.openjdk.java.net/~pchelko/8015371/webrev.00/ The bug: one of the regression tests fail, because of a NPE in translateTrasferable. This is a regression of the following fix: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/96750ebc769b The reason: We are passing bytes=null to HTMLCodec.convertToHTMLFormat instead of passing a result of the super.translateTransferable. With best regards. Petr. From petr.pchelko at oracle.com Thu Aug 15 03:22:47 2013 From: petr.pchelko at oracle.com (Petr Pchelko) Date: Thu, 15 Aug 2013 14:22:47 +0400 Subject: [8] RFR: JDK-8015453 java/awt/DataFlavor/MissedHtmlAndRtfBug/MissedHtmlAndRtfBug.java failed on windows with jdk8 since b86 Message-ID: <4A70A18D-F93B-4CE7-967E-842A40DE9B5F@oracle.com> Hello, AWT Team. Please review the following fix: http://cr.openjdk.java.net/~pchelko/8015453/webrev.00/ The bug: The test fails because of an IOException. The problem: It is a regression of the following fix: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/96750ebc769b It that fix the the DataTransfer.translateBytesOrStream was splitted to translateBytes and translateStream, however one if clause was from the original method was not moved to the translateStream method, so we were trying to translate an object incorrectly. The solution: The missing if clause was added to it's place. With best regards. Petr. From anton.litvinov at oracle.com Thu Aug 15 03:26:12 2013 From: anton.litvinov at oracle.com (anton.litvinov at oracle.com) Date: Thu, 15 Aug 2013 10:26:12 +0000 Subject: hg: jdk8/awt/jdk: 7191018: Manual test closed/java/awt/JAWT causes JVM to crash starting from JDK 5 Message-ID: <20130815102636.84A06488BA@hg.openjdk.java.net> Changeset: d7a34d7e7f22 Author: alitvinov Date: 2013-08-15 14:20 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/d7a34d7e7f22 7191018: Manual test closed/java/awt/JAWT causes JVM to crash starting from JDK 5 Reviewed-by: anthony, serb ! src/solaris/native/sun/awt/awt_DrawingSurface.c From anthony.petrov at oracle.com Thu Aug 15 04:50:40 2013 From: anthony.petrov at oracle.com (Anthony Petrov) Date: Thu, 15 Aug 2013 15:50:40 +0400 Subject: [8] RFR: JDK-8015371 The HTML text without tags does not appear inside the WordPad application, and we try to click the button, but the case exits. In-Reply-To: <455AB4E1-6EC9-4980-998D-484E069A6137@oracle.com> References: <455AB4E1-6EC9-4980-998D-484E069A6137@oracle.com> Message-ID: <520CC090.9010001@oracle.com> I suggest to also correct the spelling at line 214: s/handel/handle/. -- best regards, Anthony On 08/15/13 12:20, Petr Pchelko wrote: > Hello, AWT Team. > > Please review the following fix: > http://cr.openjdk.java.net/~pchelko/8015371/webrev.00/ > > The bug: one of the regression tests fail, because of a NPE in translateTrasferable. This is a regression of the following fix: > http://hg.openjdk.java.net/jdk8/awt/jdk/rev/96750ebc769b > > The reason: > We are passing bytes=null to HTMLCodec.convertToHTMLFormat instead of passing a result of the super.translateTransferable. > > With best regards. Petr. > From sergey.bylokhov at oracle.com Fri Aug 16 05:54:48 2013 From: sergey.bylokhov at oracle.com (sergey.bylokhov at oracle.com) Date: Fri, 16 Aug 2013 12:54:48 +0000 Subject: hg: jdk8/awt/jdk: 8020051: [TEST_BUG] Testcase for 8004859 has a typo Message-ID: <20130816125520.6686848932@hg.openjdk.java.net> Changeset: c089e93e6444 Author: serb Date: 2013-08-16 16:52 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/c089e93e6444 8020051: [TEST_BUG] Testcase for 8004859 has a typo Reviewed-by: anthony ! test/java/awt/Graphics2D/Test8004859/Test8004859.java From anton.litvinov at oracle.com Fri Aug 16 08:48:06 2013 From: anton.litvinov at oracle.com (Anton Litvinov) Date: Fri, 16 Aug 2013 19:48:06 +0400 Subject: [7u] Review request for 7191018: Manual test closed/java/awt/JAWT causes JVM to crash starting from JDK 5 Message-ID: <520E49B6.9020605@oracle.com> Hello Anthony and Sergey, Could you please review this backport of the fix, which was approved by you for JDK 8, from JDK 8 to JDK 7. Bug: http://bugs.sun.com/view_bug.do?bug_id=7191018 Webrev: http://cr.openjdk.java.net/~alitvinov/7191018/jdk7/webrev.00 JDK 8 webrev: http://cr.openjdk.java.net/~alitvinov/7191018/webrev.00 The backport fix consists of two parts: - The fix. It is the same with the original fix, but is not binary equal, because the function "awt_GetComponent(JNIEnv* env, void* platformInfo)" from "awt_DrawingSurface.c" file in JDK 7 contains "#ifndef XAWT" macros, which are absent in JDK 8. - The regression test "test/java/awt/JAWT" imported from JDK 8. It is a complete copy of the regression test from JDK 8. The fix assumes that the existing purely manual JAWT test is removed from the workspace, as it was done in JDK 8 for CR 7190587. Thank you, Anton From anthony.petrov at oracle.com Fri Aug 16 09:10:56 2013 From: anthony.petrov at oracle.com (Anthony Petrov) Date: Fri, 16 Aug 2013 20:10:56 +0400 Subject: [7u] Review request for 7191018: Manual test closed/java/awt/JAWT causes JVM to crash starting from JDK 5 In-Reply-To: <520E49B6.9020605@oracle.com> References: <520E49B6.9020605@oracle.com> Message-ID: <520E4F10.2000207@oracle.com> Hi Anton, The fix looks fine to me. Since you're also porting a fix for 7190587, when pushing it please specify both bug id-s in your commit message, like this: 7191018: ... 7190587: ... Summary:/Reviewed-by:/etc. This will mark the second bug as ported to 7u automatically (well, it should, if not - there's bug in our HG hook then). -- best regards, Anthony On 08/16/2013 07:48 PM, Anton Litvinov wrote: > Hello Anthony and Sergey, > > Could you please review this backport of the fix, which was approved by > you for JDK 8, from JDK 8 to JDK 7. > > Bug: http://bugs.sun.com/view_bug.do?bug_id=7191018 > Webrev: http://cr.openjdk.java.net/~alitvinov/7191018/jdk7/webrev.00 > JDK 8 webrev: http://cr.openjdk.java.net/~alitvinov/7191018/webrev.00 > > The backport fix consists of two parts: > > - The fix. It is the same with the original fix, but is not binary > equal, because the function "awt_GetComponent(JNIEnv* env, void* > platformInfo)" from "awt_DrawingSurface.c" file in JDK 7 contains > "#ifndef XAWT" macros, which are absent in JDK 8. > > - The regression test "test/java/awt/JAWT" imported from JDK 8. It is a > complete copy of the regression test from JDK 8. The fix assumes that > the existing purely manual JAWT test is removed from the workspace, as > it was done in JDK 8 for CR 7190587. > > Thank you, > Anton From anton.litvinov at oracle.com Fri Aug 16 09:33:01 2013 From: anton.litvinov at oracle.com (Anton Litvinov) Date: Fri, 16 Aug 2013 20:33:01 +0400 Subject: [7u] Review request for 7191018: Manual test closed/java/awt/JAWT causes JVM to crash starting from JDK 5 In-Reply-To: <520E4F10.2000207@oracle.com> References: <520E49B6.9020605@oracle.com> <520E4F10.2000207@oracle.com> Message-ID: <520E543D.8040003@oracle.com> Hello Anthony, Thank you for review of this backport fix. Yes, surely, 7190587 with its synopsis will be specified in a changeset comment during pushing of the fix. Thank you, Anton On 8/16/2013 8:10 PM, Anthony Petrov wrote: > Hi Anton, > > The fix looks fine to me. Since you're also porting a fix for 7190587, > when pushing it please specify both bug id-s in your commit message, > like this: > > 7191018: ... > 7190587: ... > Summary:/Reviewed-by:/etc. > > This will mark the second bug as ported to 7u automatically (well, it > should, if not - there's bug in our HG hook then). > > -- > best regards, > Anthony > > On 08/16/2013 07:48 PM, Anton Litvinov wrote: >> Hello Anthony and Sergey, >> >> Could you please review this backport of the fix, which was approved by >> you for JDK 8, from JDK 8 to JDK 7. >> >> Bug: http://bugs.sun.com/view_bug.do?bug_id=7191018 >> Webrev: http://cr.openjdk.java.net/~alitvinov/7191018/jdk7/webrev.00 >> JDK 8 webrev: http://cr.openjdk.java.net/~alitvinov/7191018/webrev.00 >> >> The backport fix consists of two parts: >> >> - The fix. It is the same with the original fix, but is not binary >> equal, because the function "awt_GetComponent(JNIEnv* env, void* >> platformInfo)" from "awt_DrawingSurface.c" file in JDK 7 contains >> "#ifndef XAWT" macros, which are absent in JDK 8. >> >> - The regression test "test/java/awt/JAWT" imported from JDK 8. It is a >> complete copy of the regression test from JDK 8. The fix assumes that >> the existing purely manual JAWT test is removed from the workspace, as >> it was done in JDK 8 for CR 7190587. >> >> Thank you, >> Anton From sergey.bylokhov at oracle.com Fri Aug 16 09:58:58 2013 From: sergey.bylokhov at oracle.com (sergey.bylokhov at oracle.com) Date: Fri, 16 Aug 2013 16:58:58 +0000 Subject: hg: jdk8/awt/jdk: 8006085: [findbugs] a warning on javax.sound.sampled.DataLine$Info constructor Message-ID: <20130816165929.C7BEF48942@hg.openjdk.java.net> Changeset: e3316cd6ca47 Author: serb Date: 2013-08-16 20:56 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/e3316cd6ca47 8006085: [findbugs] a warning on javax.sound.sampled.DataLine$Info constructor Reviewed-by: art, prr ! src/share/classes/javax/sound/sampled/DataLine.java From sergey.bylokhov at oracle.com Fri Aug 16 10:21:15 2013 From: sergey.bylokhov at oracle.com (sergey.bylokhov at oracle.com) Date: Fri, 16 Aug 2013 17:21:15 +0000 Subject: hg: jdk8/awt/jdk: 8005980: [findbugs] More com.sun.media.sound.* warnings Message-ID: <20130816172129.A46EA48944@hg.openjdk.java.net> Changeset: 64dc24e0d577 Author: serb Date: 2013-08-16 21:18 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/64dc24e0d577 8005980: [findbugs] More com.sun.media.sound.* warnings Reviewed-by: art, prr ! src/share/classes/com/sun/media/sound/DataPusher.java ! src/share/classes/com/sun/media/sound/ModelStandardDirector.java ! src/share/classes/com/sun/media/sound/ModelStandardIndexedDirector.java ! src/share/classes/com/sun/media/sound/SoftMixingClip.java ! src/share/classes/sun/audio/AudioData.java From Sergey.Bylokhov at oracle.com Fri Aug 16 10:26:24 2013 From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov) Date: Fri, 16 Aug 2013 21:26:24 +0400 Subject: [7u] Review request for 7191018: Manual test closed/java/awt/JAWT causes JVM to crash starting from JDK 5 In-Reply-To: <520E543D.8040003@oracle.com> References: <520E49B6.9020605@oracle.com> <520E4F10.2000207@oracle.com> <520E543D.8040003@oracle.com> Message-ID: <520E60C0.3090505@oracle.com> Hello, Anton. Fix looks fine to me. On 16.08.2013 20:33, Anton Litvinov wrote: > Hello Anthony, > > Thank you for review of this backport fix. Yes, surely, 7190587 with > its synopsis will be specified in a changeset comment during pushing > of the fix. > > Thank you, > Anton > > On 8/16/2013 8:10 PM, Anthony Petrov wrote: >> Hi Anton, >> >> The fix looks fine to me. Since you're also porting a fix for >> 7190587, when pushing it please specify both bug id-s in your commit >> message, like this: >> >> 7191018: ... >> 7190587: ... >> Summary:/Reviewed-by:/etc. >> >> This will mark the second bug as ported to 7u automatically (well, it >> should, if not - there's bug in our HG hook then). >> >> -- >> best regards, >> Anthony >> >> On 08/16/2013 07:48 PM, Anton Litvinov wrote: >>> Hello Anthony and Sergey, >>> >>> Could you please review this backport of the fix, which was approved by >>> you for JDK 8, from JDK 8 to JDK 7. >>> >>> Bug: http://bugs.sun.com/view_bug.do?bug_id=7191018 >>> Webrev: http://cr.openjdk.java.net/~alitvinov/7191018/jdk7/webrev.00 >>> JDK 8 webrev: http://cr.openjdk.java.net/~alitvinov/7191018/webrev.00 >>> >>> The backport fix consists of two parts: >>> >>> - The fix. It is the same with the original fix, but is not binary >>> equal, because the function "awt_GetComponent(JNIEnv* env, void* >>> platformInfo)" from "awt_DrawingSurface.c" file in JDK 7 contains >>> "#ifndef XAWT" macros, which are absent in JDK 8. >>> >>> - The regression test "test/java/awt/JAWT" imported from JDK 8. It is a >>> complete copy of the regression test from JDK 8. The fix assumes that >>> the existing purely manual JAWT test is removed from the workspace, as >>> it was done in JDK 8 for CR 7190587. >>> >>> Thank you, >>> Anton > -- Best regards, Sergey. From alexandr.scherbatiy at oracle.com Tue Aug 20 07:12:23 2013 From: alexandr.scherbatiy at oracle.com (Alexander Scherbatiy) Date: Tue, 20 Aug 2013 18:12:23 +0400 Subject: [8] Review request for 8007156 [macosx] Wrong events in processKeyBinding of JTable Message-ID: <52137947.9040202@oracle.com> Hello, Could you review the fix: bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8007156 webrev: http://cr.openjdk.java.net/~alexsch/8007156/webrev.00 The fix sets extended key code for the key events on Mac OS X. Thanks, Alexandr. From david.dehaven at oracle.com Tue Aug 20 07:50:01 2013 From: david.dehaven at oracle.com (David DeHaven) Date: Tue, 20 Aug 2013 07:50:01 -0700 Subject: [macosx] disable X11 toolkit? Message-ID: <9617AF48-9933-4B1D-A219-B3E47D59E44A@oracle.com> I recall discussing removal of the X11 toolkit on Mac OS X... There's already a JBS issue for it: https://jbs.oracle.com/bugs/browse/JDK-8003900 Time to pull the trigger? I did a test run last night with a fairly simple fix that disabled building X11 code, all but a few jtreg tests passed and the failures were unrelated. It would be ideal if I could get this fix in before backporting my fix for jawt_md.h as I'd prefer removing the X11 stuff from that header, though I suppose I could do that first then remove those sections as part of this fix. The build system needs a bit more cleanup before the patch is ready for review though, there were a number of Mac specific items in the makefiles. -DrD- From anthony.petrov at oracle.com Tue Aug 20 08:28:45 2013 From: anthony.petrov at oracle.com (Anthony Petrov) Date: Tue, 20 Aug 2013 19:28:45 +0400 Subject: [macosx] disable X11 toolkit? In-Reply-To: <9617AF48-9933-4B1D-A219-B3E47D59E44A@oracle.com> References: <9617AF48-9933-4B1D-A219-B3E47D59E44A@oracle.com> Message-ID: <52138B2D.9060709@oracle.com> +1 -- best regards, Anthony On 08/20/2013 06:50 PM, David DeHaven wrote: > > I recall discussing removal of the X11 toolkit on Mac OS X... > > There's already a JBS issue for it: > https://jbs.oracle.com/bugs/browse/JDK-8003900 > > Time to pull the trigger? > > I did a test run last night with a fairly simple fix that disabled building X11 code, all but a few jtreg tests passed and the failures were unrelated. It would be ideal if I could get this fix in before backporting my fix for jawt_md.h as I'd prefer removing the X11 stuff from that header, though I suppose I could do that first then remove those sections as part of this fix. The build system needs a bit more cleanup before the patch is ready for review though, there were a number of Mac specific items in the makefiles. > > -DrD- > From petr.pchelko at oracle.com Wed Aug 21 02:21:37 2013 From: petr.pchelko at oracle.com (Petr Pchelko) Date: Wed, 21 Aug 2013 13:21:37 +0400 Subject: [8] Review Request: CR 8015455 java/awt/dnd/DisposeFrameOnDragCrash/DisposeFrameOnDragTest.java hangs on windows Message-ID: <141F1F72-46DF-4BD5-881B-6B0FAA56E30B@oracle.com> Hello, AWT Team. Please review the fix for the issue: http://bugs.sun.com/view_bug.do?bug_id=8015455 The fix is available at: http://cr.openjdk.java.net/~pchelko/8015455/webrev.00/ The SwingDropTarget initializes a SwingTimer to handle autoscroll. This timer was stopped on dragExit and drop. However, if the frame was disposed in some dropTarget listener the timer was never stopped and prevented the AWT application from exiting. With best regards. Petr, From alexandr.scherbatiy at oracle.com Wed Aug 21 02:37:50 2013 From: alexandr.scherbatiy at oracle.com (Alexander Scherbatiy) Date: Wed, 21 Aug 2013 13:37:50 +0400 Subject: [8] Review Request: CR 8015455 java/awt/dnd/DisposeFrameOnDragCrash/DisposeFrameOnDragTest.java hangs on windows In-Reply-To: <141F1F72-46DF-4BD5-881B-6B0FAA56E30B@oracle.com> References: <141F1F72-46DF-4BD5-881B-6B0FAA56E30B@oracle.com> Message-ID: <52148A6E.3070109@oracle.com> On 8/21/2013 1:21 PM, Petr Pchelko wrote: > Hello, AWT Team. > > Please review the fix for the issue: > http://bugs.sun.com/view_bug.do?bug_id=8015455 > The fix is available at: > http://cr.openjdk.java.net/~pchelko/8015455/webrev.00/ > > The SwingDropTarget initializes a SwingTimer to handle autoscroll. This timer was stopped on dragExit and drop. However, if the frame was disposed in some dropTarget listener the timer was never stopped and prevented the AWT application from exiting. I think that changing the dtListener variable visibility to protected requires necessary CCC request. Thanks, Alexandr. > > With best regards. Petr, From anthony.petrov at oracle.com Wed Aug 21 02:40:40 2013 From: anthony.petrov at oracle.com (Anthony Petrov) Date: Wed, 21 Aug 2013 13:40:40 +0400 Subject: [8] Review Request: CR 8015455 java/awt/dnd/DisposeFrameOnDragCrash/DisposeFrameOnDragTest.java hangs on windows In-Reply-To: <141F1F72-46DF-4BD5-881B-6B0FAA56E30B@oracle.com> References: <141F1F72-46DF-4BD5-881B-6B0FAA56E30B@oracle.com> Message-ID: <52148B18.9060005@oracle.com> Hi Petr, The java.awt.dnd.DropTarget is a public class, and as such adding any non-private member to it is an API change. I'm not sure we want to expose the dtListener field as a public (well, protected) API because it's too low-level IMO. Besides, it seems that in the case if the frame is disposed, an application won't ever receive an event indicating that the DnD operation has ended (IIUC, if it did, the normal processing of the dragExit would reset the timer). So, how about overriding the removeNotify() in DropTarget() and sending an appropriate DnD gesture termination event from there? -- best regards, Anthony On 08/21/2013 01:21 PM, Petr Pchelko wrote: > Hello, AWT Team. > > Please review the fix for the issue: > http://bugs.sun.com/view_bug.do?bug_id=8015455 > The fix is available at: > http://cr.openjdk.java.net/~pchelko/8015455/webrev.00/ > > The SwingDropTarget initializes a SwingTimer to handle autoscroll. This timer was stopped on dragExit and drop. However, if the frame was disposed in some dropTarget listener the timer was never stopped and prevented the AWT application from exiting. > > With best regards. Petr, > From petr.pchelko at oracle.com Wed Aug 21 05:11:58 2013 From: petr.pchelko at oracle.com (Petr Pchelko) Date: Wed, 21 Aug 2013 16:11:58 +0400 Subject: [8] Review Request: CR 8015455 java/awt/dnd/DisposeFrameOnDragCrash/DisposeFrameOnDragTest.java hangs on windows In-Reply-To: <52148B18.9060005@oracle.com> References: <141F1F72-46DF-4BD5-881B-6B0FAA56E30B@oracle.com> <52148B18.9060005@oracle.com> Message-ID: <01B6B116-C85D-42A8-AE26-A35C199FA3B3@oracle.com> Hello Anthony, Alexandr. Thank you for the reviews. Please hava a look on the new version of this fix: http://cr.openjdk.java.net/~pchelko/8015455/webrev.01/ I have changed the approach according to your comments. DropTarget is tracking if it is under the mouse and sends a synthetic dragExit on removeNotify if necessary. Also I've added a check in TransferHandler.SwingDropTarget.dragExit to make sure that the cleanup would be called even if the DropTarget is inactive and dragExit events are not dispatched to the dtListener. With best regards. Petr. On Aug 21, 2013, at 1:40 PM, Anthony Petrov wrote: > Hi Petr, > > The java.awt.dnd.DropTarget is a public class, and as such adding any non-private member to it is an API change. I'm not sure we want to expose the dtListener field as a public (well, protected) API because it's too low-level IMO. > > Besides, it seems that in the case if the frame is disposed, an application won't ever receive an event indicating that the DnD operation has ended (IIUC, if it did, the normal processing of the dragExit would reset the timer). > > So, how about overriding the removeNotify() in DropTarget() and sending an appropriate DnD gesture termination event from there? > > > -- > best regards, > Anthony > > On 08/21/2013 01:21 PM, Petr Pchelko wrote: >> Hello, AWT Team. >> >> Please review the fix for the issue: >> http://bugs.sun.com/view_bug.do?bug_id=8015455 >> The fix is available at: >> http://cr.openjdk.java.net/~pchelko/8015455/webrev.00/ >> >> The SwingDropTarget initializes a SwingTimer to handle autoscroll. This timer was stopped on dragExit and drop. However, if the frame was disposed in some dropTarget listener the timer was never stopped and prevented the AWT application from exiting. >> >> With best regards. Petr, >> From anthony.petrov at oracle.com Wed Aug 21 05:44:17 2013 From: anthony.petrov at oracle.com (Anthony Petrov) Date: Wed, 21 Aug 2013 16:44:17 +0400 Subject: [8] Review Request: CR 8015455 java/awt/dnd/DisposeFrameOnDragCrash/DisposeFrameOnDragTest.java hangs on windows In-Reply-To: <01B6B116-C85D-42A8-AE26-A35C199FA3B3@oracle.com> References: <141F1F72-46DF-4BD5-881B-6B0FAA56E30B@oracle.com> <52148B18.9060005@oracle.com> <01B6B116-C85D-42A8-AE26-A35C199FA3B3@oracle.com> Message-ID: <5214B621.4090707@oracle.com> Hi Petr, The new fix looks much better. Thanks! I'm only concerned with the synchronization scheme. Since the DnD handlers are synchronized methods, the new boolean flag should only be accessed under a synchronized(this){} block in removeNotify() for consistency and thread safety. Are you sure the cleanup() method needs to be made package-private? I believe it should be accessible from dragExit() even if it stays private because the methods belong to the same outer class. Also, I suggest to run some DnD regression tests to ensure the fix is safe. -- best regards, Anthony On 08/21/2013 04:11 PM, Petr Pchelko wrote: > Hello Anthony, Alexandr. > > Thank you for the reviews. > > Please hava a look on the new version of this fix: > http://cr.openjdk.java.net/~pchelko/8015455/webrev.01/ > > I have changed the approach according to your comments. DropTarget is tracking if it is under the mouse and sends a synthetic dragExit on removeNotify if necessary. > Also I've added a check in TransferHandler.SwingDropTarget.dragExit to make sure that the cleanup would be called even if the DropTarget is inactive and dragExit events are not dispatched to the dtListener. > > With best regards. Petr. > > On Aug 21, 2013, at 1:40 PM, Anthony Petrov wrote: > >> Hi Petr, >> >> The java.awt.dnd.DropTarget is a public class, and as such adding any non-private member to it is an API change. I'm not sure we want to expose the dtListener field as a public (well, protected) API because it's too low-level IMO. >> >> Besides, it seems that in the case if the frame is disposed, an application won't ever receive an event indicating that the DnD operation has ended (IIUC, if it did, the normal processing of the dragExit would reset the timer). >> >> So, how about overriding the removeNotify() in DropTarget() and sending an appropriate DnD gesture termination event from there? >> >> >> -- >> best regards, >> Anthony >> >> On 08/21/2013 01:21 PM, Petr Pchelko wrote: >>> Hello, AWT Team. >>> >>> Please review the fix for the issue: >>> http://bugs.sun.com/view_bug.do?bug_id=8015455 >>> The fix is available at: >>> http://cr.openjdk.java.net/~pchelko/8015455/webrev.00/ >>> >>> The SwingDropTarget initializes a SwingTimer to handle autoscroll. This timer was stopped on dragExit and drop. However, if the frame was disposed in some dropTarget listener the timer was never stopped and prevented the AWT application from exiting. >>> >>> With best regards. Petr, >>> > From petr.pchelko at oracle.com Wed Aug 21 07:37:52 2013 From: petr.pchelko at oracle.com (Petr Pchelko) Date: Wed, 21 Aug 2013 18:37:52 +0400 Subject: [8] Review Request: CR 8015455 java/awt/dnd/DisposeFrameOnDragCrash/DisposeFrameOnDragTest.java hangs on windows In-Reply-To: <5214B621.4090707@oracle.com> References: <141F1F72-46DF-4BD5-881B-6B0FAA56E30B@oracle.com> <52148B18.9060005@oracle.com> <01B6B116-C85D-42A8-AE26-A35C199FA3B3@oracle.com> <5214B621.4090707@oracle.com> Message-ID: Hello, Anthony. I've updated the fix according to your comments: http://cr.openjdk.java.net/~pchelko/8015455/webrev.02/ > Also, I suggest to run some DnD regression tests to ensure the fix is safe. I've run all dnd regression tests on Windows and Mac. No new failures after the fix. With best regards. Petr. On Aug 21, 2013, at 4:44 PM, Anthony Petrov wrote: > Hi Petr, > > The new fix looks much better. Thanks! > > I'm only concerned with the synchronization scheme. Since the DnD handlers are synchronized methods, the new boolean flag should only be accessed under a synchronized(this){} block in removeNotify() for consistency and thread safety. > > Are you sure the cleanup() method needs to be made package-private? I believe it should be accessible from dragExit() even if it stays private because the methods belong to the same outer class. > > Also, I suggest to run some DnD regression tests to ensure the fix is safe. > > -- > best regards, > Anthony > > On 08/21/2013 04:11 PM, Petr Pchelko wrote: >> Hello Anthony, Alexandr. >> >> Thank you for the reviews. >> >> Please hava a look on the new version of this fix: >> http://cr.openjdk.java.net/~pchelko/8015455/webrev.01/ >> >> I have changed the approach according to your comments. DropTarget is tracking if it is under the mouse and sends a synthetic dragExit on removeNotify if necessary. >> Also I've added a check in TransferHandler.SwingDropTarget.dragExit to make sure that the cleanup would be called even if the DropTarget is inactive and dragExit events are not dispatched to the dtListener. >> >> With best regards. Petr. >> >> On Aug 21, 2013, at 1:40 PM, Anthony Petrov wrote: >> >>> Hi Petr, >>> >>> The java.awt.dnd.DropTarget is a public class, and as such adding any non-private member to it is an API change. I'm not sure we want to expose the dtListener field as a public (well, protected) API because it's too low-level IMO. >>> >>> Besides, it seems that in the case if the frame is disposed, an application won't ever receive an event indicating that the DnD operation has ended (IIUC, if it did, the normal processing of the dragExit would reset the timer). >>> >>> So, how about overriding the removeNotify() in DropTarget() and sending an appropriate DnD gesture termination event from there? >>> >>> >>> -- >>> best regards, >>> Anthony >>> >>> On 08/21/2013 01:21 PM, Petr Pchelko wrote: >>>> Hello, AWT Team. >>>> >>>> Please review the fix for the issue: >>>> http://bugs.sun.com/view_bug.do?bug_id=8015455 >>>> The fix is available at: >>>> http://cr.openjdk.java.net/~pchelko/8015455/webrev.00/ >>>> >>>> The SwingDropTarget initializes a SwingTimer to handle autoscroll. This timer was stopped on dragExit and drop. However, if the frame was disposed in some dropTarget listener the timer was never stopped and prevented the AWT application from exiting. >>>> >>>> With best regards. Petr, >>>> >> From anthony.petrov at oracle.com Wed Aug 21 07:58:48 2013 From: anthony.petrov at oracle.com (Anthony Petrov) Date: Wed, 21 Aug 2013 18:58:48 +0400 Subject: [8] Review Request: CR 8015455 java/awt/dnd/DisposeFrameOnDragCrash/DisposeFrameOnDragTest.java hangs on windows In-Reply-To: References: <141F1F72-46DF-4BD5-881B-6B0FAA56E30B@oracle.com> <52148B18.9060005@oracle.com> <01B6B116-C85D-42A8-AE26-A35C199FA3B3@oracle.com> <5214B621.4090707@oracle.com> Message-ID: <5214D5A8.2040203@oracle.com> Looks great. -- best regards, Anthony On 08/21/2013 06:37 PM, Petr Pchelko wrote: > Hello, Anthony. > > I've updated the fix according to your comments: > http://cr.openjdk.java.net/~pchelko/8015455/webrev.02/ > >> Also, I suggest to run some DnD regression tests to ensure the fix is safe. > I've run all dnd regression tests on Windows and Mac. No new failures after the fix. > > With best regards. Petr. > > On Aug 21, 2013, at 4:44 PM, Anthony Petrov wrote: > >> Hi Petr, >> >> The new fix looks much better. Thanks! >> >> I'm only concerned with the synchronization scheme. Since the DnD handlers are synchronized methods, the new boolean flag should only be accessed under a synchronized(this){} block in removeNotify() for consistency and thread safety. >> >> Are you sure the cleanup() method needs to be made package-private? I believe it should be accessible from dragExit() even if it stays private because the methods belong to the same outer class. >> >> Also, I suggest to run some DnD regression tests to ensure the fix is safe. >> >> -- >> best regards, >> Anthony >> >> On 08/21/2013 04:11 PM, Petr Pchelko wrote: >>> Hello Anthony, Alexandr. >>> >>> Thank you for the reviews. >>> >>> Please hava a look on the new version of this fix: >>> http://cr.openjdk.java.net/~pchelko/8015455/webrev.01/ >>> >>> I have changed the approach according to your comments. DropTarget is tracking if it is under the mouse and sends a synthetic dragExit on removeNotify if necessary. >>> Also I've added a check in TransferHandler.SwingDropTarget.dragExit to make sure that the cleanup would be called even if the DropTarget is inactive and dragExit events are not dispatched to the dtListener. >>> >>> With best regards. Petr. >>> >>> On Aug 21, 2013, at 1:40 PM, Anthony Petrov wrote: >>> >>>> Hi Petr, >>>> >>>> The java.awt.dnd.DropTarget is a public class, and as such adding any non-private member to it is an API change. I'm not sure we want to expose the dtListener field as a public (well, protected) API because it's too low-level IMO. >>>> >>>> Besides, it seems that in the case if the frame is disposed, an application won't ever receive an event indicating that the DnD operation has ended (IIUC, if it did, the normal processing of the dragExit would reset the timer). >>>> >>>> So, how about overriding the removeNotify() in DropTarget() and sending an appropriate DnD gesture termination event from there? >>>> >>>> >>>> -- >>>> best regards, >>>> Anthony >>>> >>>> On 08/21/2013 01:21 PM, Petr Pchelko wrote: >>>>> Hello, AWT Team. >>>>> >>>>> Please review the fix for the issue: >>>>> http://bugs.sun.com/view_bug.do?bug_id=8015455 >>>>> The fix is available at: >>>>> http://cr.openjdk.java.net/~pchelko/8015455/webrev.00/ >>>>> >>>>> The SwingDropTarget initializes a SwingTimer to handle autoscroll. This timer was stopped on dragExit and drop. However, if the frame was disposed in some dropTarget listener the timer was never stopped and prevented the AWT application from exiting. >>>>> >>>>> With best regards. Petr, >>>>> >>> > From leonid.romanov at oracle.com Wed Aug 21 11:16:08 2013 From: leonid.romanov at oracle.com (Leonid Romanov) Date: Wed, 21 Aug 2013 22:16:08 +0400 Subject: [8] Review request for 8007156 [macosx] Wrong events in processKeyBinding of JTable In-Reply-To: <52137947.9040202@oracle.com> References: <52137947.9040202@oracle.com> Message-ID: <7823A24E-F639-4DEB-BE7F-559DF5022A97@oracle.com> Looks good. On Aug 20, 2013, at 6:12 PM, Alexander Scherbatiy wrote: > > Hello, > > Could you review the fix: > bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8007156 > webrev: http://cr.openjdk.java.net/~alexsch/8007156/webrev.00 > > The fix sets extended key code for the key events on Mac OS X. > > Thanks, > Alexandr. From dmitry.markov at oracle.com Thu Aug 22 04:08:22 2013 From: dmitry.markov at oracle.com (dmitry markov) Date: Thu, 22 Aug 2013 15:08:22 +0400 Subject: [8] Review request for 8023474: First mousepress doesn't start editing in JTree Message-ID: <5215F126.4050607@oracle.com> Hello, Could you review the fix, please? bug: http://bugs.sun.com/view_bug.do?bug_id=8023474 webrev: http://cr.openjdk.java.net/~dmarkov/8023474/webrev.00/ The method BasicTreeUI.startEditing() should find the first valid root for the editingComponent and call validateUnconditionally() for it instead of editingComponent.revalidate() invocation. Thanks, Dmitry From sergey.malenkov at oracle.com Thu Aug 22 06:17:52 2013 From: sergey.malenkov at oracle.com (sergey.malenkov at oracle.com) Date: Thu, 22 Aug 2013 13:17:52 +0000 Subject: hg: jdk8/awt/jdk: 8023536: Some regression tests have a wrong header Message-ID: <20130822131829.47B5848A8D@hg.openjdk.java.net> Changeset: 0151f12bd392 Author: malenkov Date: 2013-08-22 17:17 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/0151f12bd392 8023536: Some regression tests have a wrong header Reviewed-by: alexsch ! test/java/beans/Performance/Test7122740.java ! test/java/beans/Performance/Test7184799.java ! test/javax/swing/JTree/8013571/Test8013571.java From anthony.petrov at oracle.com Thu Aug 22 06:28:57 2013 From: anthony.petrov at oracle.com (Anthony Petrov) Date: Thu, 22 Aug 2013 17:28:57 +0400 Subject: [8] Review request for 8023474: First mousepress doesn't start editing in JTree In-Reply-To: <5215F126.4050607@oracle.com> References: <5215F126.4050607@oracle.com> Message-ID: <52161219.5090606@oracle.com> Hi Dmitry, A few comments: 1. The concept of validate roots has been extended to AWT components since JDK 7. Therefore, I suggest to use the same logic regardless of whether the editor is an instance of JComponent or not. 2. What you're trying to implement here, is actually called revalidateSynchronously(), as opposed to the regular revalidate() method, which in Swing is asynchronous. I believe that rS() might be very much useful in many cases. Therefore, I suggest to add a package-private java.awt.Component.revalidateSynchronously(), and call it via the AWTAccessor from BasicTreeUI.java. Note that the current Component.revalidate() should simply call the new rS() directly, and the rS() may reuse the current implementation of the Component.revalidate(). 3. > 2230 // The implementation of the method is copied from SwingUtilities Copying an implementation is almost always wrong. It might be better to access a method from another package via e.g. an accessor, or reflection, or otherwise find a way to share this code rather than copy it. However, I think you won't need this code anyway if we implement the suggestion #2 above. 4. Is there a similar problem with JTable custom editors? What else Swing components allow for editors? -- best regards, Anthony On 08/22/13 15:08, dmitry markov wrote: > Hello, > > Could you review the fix, please? > bug: http://bugs.sun.com/view_bug.do?bug_id=8023474 > webrev: http://cr.openjdk.java.net/~dmarkov/8023474/webrev.00/ > > The method BasicTreeUI.startEditing() should find the first valid root > for the editingComponent and call validateUnconditionally() for it > instead of editingComponent.revalidate() invocation. > > Thanks, > Dmitry From alexandr.scherbatiy at oracle.com Thu Aug 22 07:28:14 2013 From: alexandr.scherbatiy at oracle.com (Alexander Scherbatiy) Date: Thu, 22 Aug 2013 18:28:14 +0400 Subject: [8] Review request for 8022401 [macosx] javax/swing/text/JTextComponent/5074573/bug5074573.java fails Message-ID: <52161FFE.8050402@oracle.com> Hello, Could you review the fix: bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8022401 webrev: http://cr.openjdk.java.net/~alexsch/8022401/webrev.00 The nsToJavaChar method from AWTEvent.m has char type (1 byte) for the nsChar parameter instead of jchar. Thanks, Alexandr. From srikalyan.chandrashekar at oracle.com Thu Aug 22 09:25:52 2013 From: srikalyan.chandrashekar at oracle.com (srikalyan chandrashekar) Date: Thu, 22 Aug 2013 09:25:52 -0700 Subject: [8] Review request for 8022184 - JDK8 java.awt Static and Raw type warnings fix Message-ID: <52163B90.4080603@oracle.com> Hi team , could someone review the fix Bug : https://jbs.oracle.com/bugs/browse/JDK-8022184 Webrev : https://github.com/srikalyc/JDKfixes/blob/master/java.awt.static_raw_webrev.zip Fix : static and raw type warnings fix for java.awt classes -- -- Thanks kalyan From artem.ananiev at oracle.com Thu Aug 22 09:40:55 2013 From: artem.ananiev at oracle.com (Artem Ananiev) Date: Thu, 22 Aug 2013 20:40:55 +0400 Subject: [8] Review request for 8022184 - JDK8 java.awt Static and Raw type warnings fix In-Reply-To: <52163B90.4080603@oracle.com> References: <52163B90.4080603@oracle.com> Message-ID: <52163F17.8020906@oracle.com> On 8/22/2013 8:25 PM, srikalyan chandrashekar wrote: > Hi team , could someone review the fix > Bug : https://jbs.oracle.com/bugs/browse/JDK-8022184 Here is the right link visible for everyone: http://bugs.sun.com/view_bug.do?bug_id=8022184 > Webrev : > https://github.com/srikalyc/JDKfixes/blob/master/java.awt.static_raw_webrev.zip For convenient reviewing, I put it to cr.openjdk.java.net: http://cr.openjdk.java.net/~art/srikalyc/8022184/ Thanks, Artem > Fix : static and raw type warnings fix for java.awt classes > From sergey.malenkov at oracle.com Thu Aug 22 10:05:40 2013 From: sergey.malenkov at oracle.com (sergey.malenkov at oracle.com) Date: Thu, 22 Aug 2013 17:05:40 +0000 Subject: hg: jdk8/awt/jdk: 7057769: JScrollBar spec should specify that unit increment & decrement functionality may not be present Message-ID: <20130822170611.5B33A48AA4@hg.openjdk.java.net> Changeset: b71f112dab2a Author: malenkov Date: 2013-08-22 21:05 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/b71f112dab2a 7057769: JScrollBar spec should specify that unit increment & decrement functionality may not be present Reviewed-by: alexsch ! src/share/classes/javax/swing/JScrollBar.java From anthony.petrov at oracle.com Fri Aug 23 03:19:58 2013 From: anthony.petrov at oracle.com (Anthony Petrov) Date: Fri, 23 Aug 2013 14:19:58 +0400 Subject: [8] Review request for 8022401 [macosx] javax/swing/text/JTextComponent/5074573/bug5074573.java fails In-Reply-To: <52161FFE.8050402@oracle.com> References: <52161FFE.8050402@oracle.com> Message-ID: <5217374E.7020502@oracle.com> Hi Alexander, The fix looks fine to me. However, please correct the year in the copyright notice in the test before pushing your fix, since currently it lists 2011 instead of 2013. -- best regards, Anthony On 08/22/2013 06:28 PM, Alexander Scherbatiy wrote: > > Hello, > > Could you review the fix: > bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8022401 > webrev: http://cr.openjdk.java.net/~alexsch/8022401/webrev.00 > > The nsToJavaChar method from AWTEvent.m has char type (1 byte) for the > nsChar parameter instead of jchar. > > Thanks, > Alexandr. > From anthony.petrov at oracle.com Fri Aug 23 03:44:27 2013 From: anthony.petrov at oracle.com (Anthony Petrov) Date: Fri, 23 Aug 2013 14:44:27 +0400 Subject: [8] Review request for 8022184 - JDK8 java.awt Static and Raw type warnings fix In-Reply-To: <52163F17.8020906@oracle.com> References: <52163B90.4080603@oracle.com> <52163F17.8020906@oracle.com> Message-ID: <52173D0B.8070605@oracle.com> Hi Srikalyan, Thanks for fixing the warnings. A couple of comments: src/share/classes/java/awt/KeyboardFocusManager.java > 3065 proxyActive = (Field) AccessController.doPrivileged(new PrivilegedAction() { I suppose an explicit type-cast may now be removed from here. src/share/classes/java/awt/WaitDispatchSupport.java > 227 AccessController.doPrivileged(new PrivilegedAction() { Usually Void is used instead of Object if we know that we don't use the return value. Otherwise the fix looks good to me. -- best regards, Anthony On 08/22/2013 08:40 PM, Artem Ananiev wrote: > > On 8/22/2013 8:25 PM, srikalyan chandrashekar wrote: >> Hi team , could someone review the fix >> Bug : https://jbs.oracle.com/bugs/browse/JDK-8022184 > > Here is the right link visible for everyone: > > http://bugs.sun.com/view_bug.do?bug_id=8022184 > >> Webrev : >> https://github.com/srikalyc/JDKfixes/blob/master/java.awt.static_raw_webrev.zip >> > > For convenient reviewing, I put it to cr.openjdk.java.net: > > http://cr.openjdk.java.net/~art/srikalyc/8022184/ > > Thanks, > > Artem > >> Fix : static and raw type warnings fix for java.awt classes >> From dmitry.markov at oracle.com Fri Aug 23 05:18:09 2013 From: dmitry.markov at oracle.com (dmitry markov) Date: Fri, 23 Aug 2013 16:18:09 +0400 Subject: [8] Review request for 8023474: First mousepress doesn't start editing in JTree In-Reply-To: <52161219.5090606@oracle.com> References: <5215F126.4050607@oracle.com> <52161219.5090606@oracle.com> Message-ID: <52175301.4070804@oracle.com> Hi Anthony, Thank you for your comments. I changed the fix based on your suggestions. Please find new webrev at http://cr.openjdk.java.net/~dmarkov/8023474/webrev.01/. Could you review it, please? Thanks, Dmitry On 22/08/2013 17:28, Anthony Petrov wrote: > Hi Dmitry, > > A few comments: > > 1. The concept of validate roots has been extended to AWT components > since JDK 7. Therefore, I suggest to use the same logic regardless of > whether the editor is an instance of JComponent or not. > > 2. What you're trying to implement here, is actually called > revalidateSynchronously(), as opposed to the regular revalidate() > method, which in Swing is asynchronous. I believe that rS() might be > very much useful in many cases. Therefore, I suggest to add a > package-private java.awt.Component.revalidateSynchronously(), and call > it via the AWTAccessor from BasicTreeUI.java. Note that the current > Component.revalidate() should simply call the new rS() directly, and > the rS() may reuse the current implementation of the > Component.revalidate(). > > 3. >> 2230 // The implementation of the method is copied from >> SwingUtilities > > Copying an implementation is almost always wrong. It might be better > to access a method from another package via e.g. an accessor, or > reflection, or otherwise find a way to share this code rather than > copy it. However, I think you won't need this code anyway if we > implement the suggestion #2 above. > > 4. Is there a similar problem with JTable custom editors? What else > Swing components allow for editors? > As far as I know, JTable does not have this problem. > -- > best regards, > Anthony > > On 08/22/13 15:08, dmitry markov wrote: >> Hello, >> >> Could you review the fix, please? >> bug: http://bugs.sun.com/view_bug.do?bug_id=8023474 >> webrev: http://cr.openjdk.java.net/~dmarkov/8023474/webrev.00/ >> >> The method BasicTreeUI.startEditing() should find the first valid root >> for the editingComponent and call validateUnconditionally() for it >> instead of editingComponent.revalidate() invocation. >> >> Thanks, >> Dmitry From anthony.petrov at oracle.com Fri Aug 23 06:59:26 2013 From: anthony.petrov at oracle.com (Anthony Petrov) Date: Fri, 23 Aug 2013 17:59:26 +0400 Subject: [8] Review request for 8023474: First mousepress doesn't start editing in JTree In-Reply-To: <52175301.4070804@oracle.com> References: <5215F126.4050607@oracle.com> <52161219.5090606@oracle.com> <52175301.4070804@oracle.com> Message-ID: <52176ABE.5040308@oracle.com> Hi Dmitry, The fix looks good to me. As to the test, you should dispose() the frame before the if (!result){} statement, so that the test could exit when it passes. -- best regards, Anthony On 08/23/2013 04:18 PM, dmitry markov wrote: > Hi Anthony, > > Thank you for your comments. I changed the fix based on your > suggestions. Please find new webrev at > http://cr.openjdk.java.net/~dmarkov/8023474/webrev.01/. > Could you review it, please? > > Thanks, > Dmitry > > On 22/08/2013 17:28, Anthony Petrov wrote: >> Hi Dmitry, >> >> A few comments: >> >> 1. The concept of validate roots has been extended to AWT components >> since JDK 7. Therefore, I suggest to use the same logic regardless of >> whether the editor is an instance of JComponent or not. >> >> 2. What you're trying to implement here, is actually called >> revalidateSynchronously(), as opposed to the regular revalidate() >> method, which in Swing is asynchronous. I believe that rS() might be >> very much useful in many cases. Therefore, I suggest to add a >> package-private java.awt.Component.revalidateSynchronously(), and call >> it via the AWTAccessor from BasicTreeUI.java. Note that the current >> Component.revalidate() should simply call the new rS() directly, and >> the rS() may reuse the current implementation of the >> Component.revalidate(). >> >> 3. >>> 2230 // The implementation of the method is copied from >>> SwingUtilities >> >> Copying an implementation is almost always wrong. It might be better >> to access a method from another package via e.g. an accessor, or >> reflection, or otherwise find a way to share this code rather than >> copy it. However, I think you won't need this code anyway if we >> implement the suggestion #2 above. >> >> 4. Is there a similar problem with JTable custom editors? What else >> Swing components allow for editors? >> > As far as I know, JTable does not have this problem. >> -- >> best regards, >> Anthony >> >> On 08/22/13 15:08, dmitry markov wrote: >>> Hello, >>> >>> Could you review the fix, please? >>> bug: http://bugs.sun.com/view_bug.do?bug_id=8023474 >>> webrev: http://cr.openjdk.java.net/~dmarkov/8023474/webrev.00/ >>> >>> The method BasicTreeUI.startEditing() should find the first valid root >>> for the editingComponent and call validateUnconditionally() for it >>> instead of editingComponent.revalidate() invocation. >>> >>> Thanks, >>> Dmitry > From sergey.malenkov at oracle.com Fri Aug 23 08:30:28 2013 From: sergey.malenkov at oracle.com (sergey.malenkov at oracle.com) Date: Fri, 23 Aug 2013 15:30:28 +0000 Subject: hg: jdk8/awt/jdk: 7080613: java.beans.DefaultPersistenceDelegate.instantiate(..) doesn't throw NPE Message-ID: <20130823153117.CF45748B0A@hg.openjdk.java.net> Changeset: f983fd18dd81 Author: malenkov Date: 2013-08-23 19:29 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/f983fd18dd81 7080613: java.beans.DefaultPersistenceDelegate.instantiate(..) doesn't throw NPE Reviewed-by: alexsch ! src/share/classes/java/beans/DefaultPersistenceDelegate.java ! src/share/classes/java/beans/PersistenceDelegate.java From srikalyan.chandrashekar at oracle.com Fri Aug 23 10:24:43 2013 From: srikalyan.chandrashekar at oracle.com (srikalyan chandrashekar) Date: Fri, 23 Aug 2013 10:24:43 -0700 Subject: [8] Review request for 8022184 - JDK8 java.awt Static and Raw type warnings fix In-Reply-To: <52173D0B.8070605@oracle.com> References: <52163B90.4080603@oracle.com> <52163F17.8020906@oracle.com> <52173D0B.8070605@oracle.com> Message-ID: <52179ADB.6050501@oracle.com> Antony, Thanks for the review. Here's the renewed link covering the gaps. -- Thanks kalyan On 8/23/13 3:44 AM, Anthony Petrov wrote: > Hi Srikalyan, > > Thanks for fixing the warnings. A couple of comments: > > src/share/classes/java/awt/KeyboardFocusManager.java >> 3065 proxyActive = (Field) >> AccessController.doPrivileged(new PrivilegedAction() { > > I suppose an explicit type-cast may now be removed from here. > > > src/share/classes/java/awt/WaitDispatchSupport.java >> 227 AccessController.doPrivileged(new PrivilegedAction() { > > Usually Void is used instead of Object if we know that we don't use > the return value. > > Otherwise the fix looks good to me. > > -- > best regards, > Anthony > > On 08/22/2013 08:40 PM, Artem Ananiev wrote: >> >> On 8/22/2013 8:25 PM, srikalyan chandrashekar wrote: >>> Hi team , could someone review the fix >>> Bug : https://jbs.oracle.com/bugs/browse/JDK-8022184 >> >> Here is the right link visible for everyone: >> >> http://bugs.sun.com/view_bug.do?bug_id=8022184 >> >>> Webrev : >>> https://github.com/srikalyc/JDKfixes/blob/master/java.awt.static_raw_webrev.zip >>> >>> >> >> For convenient reviewing, I put it to cr.openjdk.java.net: >> >> http://cr.openjdk.java.net/~art/srikalyc/8022184/ >> >> Thanks, >> >> Artem >> >>> Fix : static and raw type warnings fix for java.awt classes >>> -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20130823/cdee6169/attachment.html From oleg.pekhovskiy at oracle.com Sun Aug 25 05:40:54 2013 From: oleg.pekhovskiy at oracle.com (Oleg Pekhovskiy) Date: Sun, 25 Aug 2013 16:40:54 +0400 Subject: [8] Review request for 8016356: Any swing frame resizes ugly. Message-ID: <5219FB56.6070700@oracle.com> Hi all, please review the fix http://cr.openjdk.java.net/~bagiras/8016356.1/ for http://bugs.sun.com/view_bug.do?bug_id=8016356 Windows 7 has a feature that makes "window being automatically arranged when moved to the edge of the screen". And there is no specific system notification when that happens. From the other side AwtWindow class has some optimization algorithm for resizing that doesn't take into account such the arranging. I found indirect way to determine the arranging by tracking the sequence of WM_GETMINMAXINFO and WM_SIZE before the end of resizing routine, and call WindowResized() when needed to update the layout. Thanks, Oleg From petr.pchelko at oracle.com Mon Aug 26 03:54:20 2013 From: petr.pchelko at oracle.com (Petr Pchelko) Date: Mon, 26 Aug 2013 14:54:20 +0400 Subject: [8] RFR: JDK-8015453 java/awt/DataFlavor/MissedHtmlAndRtfBug/MissedHtmlAndRtfBug.java failed on windows with jdk8 since b86 In-Reply-To: <4A70A18D-F93B-4CE7-967E-842A40DE9B5F@oracle.com> References: <4A70A18D-F93B-4CE7-967E-842A40DE9B5F@oracle.com> Message-ID: <5B9455A1-45D6-4962-8E68-8CE6C891ACCF@oracle.com> Hello, AWT Team. This is a reminder. Could somebody please review this fix. With bet regards. Petr. On Aug 15, 2013, at 2:22 PM, Petr Pchelko wrote: > Hello, AWT Team. > > Please review the following fix: > http://cr.openjdk.java.net/~pchelko/8015453/webrev.00/ > > The bug: > The test fails because of an IOException. > > The problem: > It is a regression of the following fix: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/96750ebc769b > It that fix the the DataTransfer.translateBytesOrStream was splitted to translateBytes and translateStream, > however one if clause was from the original method was not moved to the translateStream method, so we were trying > to translate an object incorrectly. > > The solution: > The missing if clause was added to it's place. > > With best regards. Petr. From petr.pchelko at oracle.com Mon Aug 26 03:55:30 2013 From: petr.pchelko at oracle.com (Petr Pchelko) Date: Mon, 26 Aug 2013 14:55:30 +0400 Subject: [8] Review Request: CR 8015455 java/awt/dnd/DisposeFrameOnDragCrash/DisposeFrameOnDragTest.java hangs on windows In-Reply-To: References: <141F1F72-46DF-4BD5-881B-6B0FAA56E30B@oracle.com> <52148B18.9060005@oracle.com> <01B6B116-C85D-42A8-AE26-A35C199FA3B3@oracle.com> <5214B621.4090707@oracle.com> Message-ID: <2EA3CA61-5FA6-4AFF-B7CD-125957F3A063@oracle.com> Hello, AWT Team. This is a reminder. Could I please get a second review on this fix. With best regards. Petr. On Aug 21, 2013, at 6:37 PM, Petr Pchelko wrote: > Hello, Anthony. > > I've updated the fix according to your comments: > http://cr.openjdk.java.net/~pchelko/8015455/webrev.02/ > >> Also, I suggest to run some DnD regression tests to ensure the fix is safe. > I've run all dnd regression tests on Windows and Mac. No new failures after the fix. > > With best regards. Petr. > > On Aug 21, 2013, at 4:44 PM, Anthony Petrov wrote: > >> Hi Petr, >> >> The new fix looks much better. Thanks! >> >> I'm only concerned with the synchronization scheme. Since the DnD handlers are synchronized methods, the new boolean flag should only be accessed under a synchronized(this){} block in removeNotify() for consistency and thread safety. >> >> Are you sure the cleanup() method needs to be made package-private? I believe it should be accessible from dragExit() even if it stays private because the methods belong to the same outer class. >> >> Also, I suggest to run some DnD regression tests to ensure the fix is safe. >> >> -- >> best regards, >> Anthony >> >> On 08/21/2013 04:11 PM, Petr Pchelko wrote: >>> Hello Anthony, Alexandr. >>> >>> Thank you for the reviews. >>> >>> Please hava a look on the new version of this fix: >>> http://cr.openjdk.java.net/~pchelko/8015455/webrev.01/ >>> >>> I have changed the approach according to your comments. DropTarget is tracking if it is under the mouse and sends a synthetic dragExit on removeNotify if necessary. >>> Also I've added a check in TransferHandler.SwingDropTarget.dragExit to make sure that the cleanup would be called even if the DropTarget is inactive and dragExit events are not dispatched to the dtListener. >>> >>> With best regards. Petr. >>> >>> On Aug 21, 2013, at 1:40 PM, Anthony Petrov wrote: >>> >>>> Hi Petr, >>>> >>>> The java.awt.dnd.DropTarget is a public class, and as such adding any non-private member to it is an API change. I'm not sure we want to expose the dtListener field as a public (well, protected) API because it's too low-level IMO. >>>> >>>> Besides, it seems that in the case if the frame is disposed, an application won't ever receive an event indicating that the DnD operation has ended (IIUC, if it did, the normal processing of the dragExit would reset the timer). >>>> >>>> So, how about overriding the removeNotify() in DropTarget() and sending an appropriate DnD gesture termination event from there? >>>> >>>> >>>> -- >>>> best regards, >>>> Anthony >>>> >>>> On 08/21/2013 01:21 PM, Petr Pchelko wrote: >>>>> Hello, AWT Team. >>>>> >>>>> Please review the fix for the issue: >>>>> http://bugs.sun.com/view_bug.do?bug_id=8015455 >>>>> The fix is available at: >>>>> http://cr.openjdk.java.net/~pchelko/8015455/webrev.00/ >>>>> >>>>> The SwingDropTarget initializes a SwingTimer to handle autoscroll. This timer was stopped on dragExit and drop. However, if the frame was disposed in some dropTarget listener the timer was never stopped and prevented the AWT application from exiting. >>>>> >>>>> With best regards. Petr, >>>>> >>> > From alexander.potochkin at oracle.com Mon Aug 26 05:37:40 2013 From: alexander.potochkin at oracle.com (Alexander Potochkin) Date: Mon, 26 Aug 2013 16:37:40 +0400 Subject: [8] Review request for 8023474: First mousepress doesn't start editing in JTree In-Reply-To: <52175301.4070804@oracle.com> References: <5215F126.4050607@oracle.com> <52161219.5090606@oracle.com> <52175301.4070804@oracle.com> Message-ID: <521B4C14.30205@oracle.com> Hello Dmitry The fix looks good to me as well I should say that the final version is much better than the first one, thank you Anthony for the thorough review! alexp On 8/23/2013 4:18 PM, dmitry markov wrote: > Hi Anthony, > > Thank you for your comments. I changed the fix based on your > suggestions. Please find new webrev at > http://cr.openjdk.java.net/~dmarkov/8023474/webrev.01/. > Could you review it, please? > > Thanks, > Dmitry > > On 22/08/2013 17:28, Anthony Petrov wrote: >> Hi Dmitry, >> >> A few comments: >> >> 1. The concept of validate roots has been extended to AWT components >> since JDK 7. Therefore, I suggest to use the same logic regardless of >> whether the editor is an instance of JComponent or not. >> >> 2. What you're trying to implement here, is actually called >> revalidateSynchronously(), as opposed to the regular revalidate() >> method, which in Swing is asynchronous. I believe that rS() might be >> very much useful in many cases. Therefore, I suggest to add a >> package-private java.awt.Component.revalidateSynchronously(), and >> call it via the AWTAccessor from BasicTreeUI.java. Note that the >> current Component.revalidate() should simply call the new rS() >> directly, and the rS() may reuse the current implementation of the >> Component.revalidate(). >> >> 3. >>> 2230 // The implementation of the method is copied from >>> SwingUtilities >> >> Copying an implementation is almost always wrong. It might be better >> to access a method from another package via e.g. an accessor, or >> reflection, or otherwise find a way to share this code rather than >> copy it. However, I think you won't need this code anyway if we >> implement the suggestion #2 above. >> >> 4. Is there a similar problem with JTable custom editors? What else >> Swing components allow for editors? >> > As far as I know, JTable does not have this problem. >> -- >> best regards, >> Anthony >> >> On 08/22/13 15:08, dmitry markov wrote: >>> Hello, >>> >>> Could you review the fix, please? >>> bug: http://bugs.sun.com/view_bug.do?bug_id=8023474 >>> webrev: http://cr.openjdk.java.net/~dmarkov/8023474/webrev.00/ >>> >>> The method BasicTreeUI.startEditing() should find the first valid root >>> for the editingComponent and call validateUnconditionally() for it >>> instead of editingComponent.revalidate() invocation. >>> >>> Thanks, >>> Dmitry > From anthony.petrov at oracle.com Mon Aug 26 06:20:25 2013 From: anthony.petrov at oracle.com (Anthony Petrov) Date: Mon, 26 Aug 2013 17:20:25 +0400 Subject: [8] Review request for 8016356: Any swing frame resizes ugly. In-Reply-To: <5219FB56.6070700@oracle.com> References: <5219FB56.6070700@oracle.com> Message-ID: <521B5619.7030705@oracle.com> Hi Oleg, The fix looks somewhat fragile to me. The sequence of events may change in a future version of Windows, and the fix will fail then. Are there any peculiarities for the WM_SIZE messages being posted when a window is snapped? I'm referring to [1] for example, and they suggest that a proper SC_ flag might be specified when snapping occurs. So, if we could detect that, we might unblock the WindowResized() call at the end of the WmSize() method in the AwtWindow class, which would fix the issue. You might also want to explore the WM_WINDOWPOSCHANGED and WM_WINDOWPOSCHANGING events that the window receives during snapping, perhaps they have some characteristics allowing us to ignore the IsResizing() and call the WindowResized() nonetheless. [1] http://stackoverflow.com/questions/9321549/handling-aerosnap-message-in-wndproc -- best regards, Anthony On 08/25/13 16:40, Oleg Pekhovskiy wrote: > Hi all, > > please review the fix > http://cr.openjdk.java.net/~bagiras/8016356.1/ > for > http://bugs.sun.com/view_bug.do?bug_id=8016356 > > Windows 7 has a feature that makes "window being automatically arranged > when moved to the edge of the screen". And there is no specific system > notification when that happens. From the other side AwtWindow class has > some optimization algorithm for resizing that doesn't take into account > such the arranging. I found indirect way to determine the arranging by > tracking the sequence of WM_GETMINMAXINFO and WM_SIZE before the end of > resizing routine, and call WindowResized() when needed to update the > layout. > > Thanks, > Oleg From artem.ananiev at oracle.com Mon Aug 26 06:39:44 2013 From: artem.ananiev at oracle.com (Artem Ananiev) Date: Mon, 26 Aug 2013 17:39:44 +0400 Subject: [8] Review request for 8022184 - JDK8 java.awt Static and Raw type warnings fix In-Reply-To: <52179ADB.6050501@oracle.com> References: <52163B90.4080603@oracle.com> <52163F17.8020906@oracle.com> <52173D0B.8070605@oracle.com> <52179ADB.6050501@oracle.com> Message-ID: <521B5AA0.5010404@oracle.com> On 8/23/2013 9:24 PM, srikalyan chandrashekar wrote: > Antony, Thanks for the review. Here's the renewed link > > covering the gaps. Here is the updated link at cr.openjdk.java.net: http://cr.openjdk.java.net/~art/srikalyc/8022184.01/ A few comments: 1. GraphicsEnvironment.java:109 - class cast is redundant 2. KeyboardFocusManager.java:2655 - class cast is redundant 3. KeyboardFocusManager.java:2985 - class cast is redundant 4. DefaultKeyboardFocusManager.java:816 - class cast is redundant 5. DefaultKeyboardFocusManager.java:1067 - class cast is redundant Thanks, Artem > -- > Thanks > kalyan > > On 8/23/13 3:44 AM, Anthony Petrov wrote: >> Hi Srikalyan, >> >> Thanks for fixing the warnings. A couple of comments: >> >> src/share/classes/java/awt/KeyboardFocusManager.java >>> 3065 proxyActive = (Field) >>> AccessController.doPrivileged(new PrivilegedAction() { >> >> I suppose an explicit type-cast may now be removed from here. >> >> >> src/share/classes/java/awt/WaitDispatchSupport.java >>> 227 AccessController.doPrivileged(new PrivilegedAction() { >> >> Usually Void is used instead of Object if we know that we don't use >> the return value. >> >> Otherwise the fix looks good to me. >> >> -- >> best regards, >> Anthony >> >> On 08/22/2013 08:40 PM, Artem Ananiev wrote: >>> >>> On 8/22/2013 8:25 PM, srikalyan chandrashekar wrote: >>>> Hi team , could someone review the fix >>>> Bug : https://jbs.oracle.com/bugs/browse/JDK-8022184 >>> >>> Here is the right link visible for everyone: >>> >>> http://bugs.sun.com/view_bug.do?bug_id=8022184 >>> >>>> Webrev : >>>> https://github.com/srikalyc/JDKfixes/blob/master/java.awt.static_raw_webrev.zip >>>> >>>> >>> >>> For convenient reviewing, I put it to cr.openjdk.java.net: >>> >>> http://cr.openjdk.java.net/~art/srikalyc/8022184/ >>> >>> Thanks, >>> >>> Artem >>> >>>> Fix : static and raw type warnings fix for java.awt classes >>>> > From anton.litvinov at oracle.com Mon Aug 26 06:41:09 2013 From: anton.litvinov at oracle.com (anton.litvinov at oracle.com) Date: Mon, 26 Aug 2013 13:41:09 +0000 Subject: hg: jdk8/awt/jdk: 8023474: First mousepress doesn't start editing in JTree Message-ID: <20130826134225.A081648B5B@hg.openjdk.java.net> Changeset: 22ef5187a3e6 Author: dmarkov Date: 2013-08-26 17:21 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/22ef5187a3e6 8023474: First mousepress doesn't start editing in JTree Reviewed-by: alexp, anthony ! src/share/classes/java/awt/Component.java ! src/share/classes/javax/swing/plaf/basic/BasicTreeUI.java ! src/share/classes/sun/awt/AWTAccessor.java + test/javax/swing/plaf/basic/BasicTreeUI/8023474/bug8023474.java From artem.ananiev at oracle.com Mon Aug 26 07:01:37 2013 From: artem.ananiev at oracle.com (Artem Ananiev) Date: Mon, 26 Aug 2013 18:01:37 +0400 Subject: [8] RFR: JDK-8015453 java/awt/DataFlavor/MissedHtmlAndRtfBug/MissedHtmlAndRtfBug.java failed on windows with jdk8 since b86 In-Reply-To: <5B9455A1-45D6-4962-8E68-8CE6C891ACCF@oracle.com> References: <4A70A18D-F93B-4CE7-967E-842A40DE9B5F@oracle.com> <5B9455A1-45D6-4962-8E68-8CE6C891ACCF@oracle.com> Message-ID: <521B5FC1.2070904@oracle.com> Hi, Petr, the fix looks fine. Could you add more details about the failure to the bug comments, please? Thanks, Artem On 8/26/2013 2:54 PM, Petr Pchelko wrote: > Hello, AWT Team. > > This is a reminder. Could somebody please review this fix. > > With bet regards. Petr. > > On Aug 15, 2013, at 2:22 PM, Petr Pchelko wrote: > >> Hello, AWT Team. >> >> Please review the following fix: >> http://cr.openjdk.java.net/~pchelko/8015453/webrev.00/ >> >> The bug: >> The test fails because of an IOException. >> >> The problem: >> It is a regression of the following fix: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/96750ebc769b >> It that fix the the DataTransfer.translateBytesOrStream was splitted to translateBytes and translateStream, >> however one if clause was from the original method was not moved to the translateStream method, so we were trying >> to translate an object incorrectly. >> >> The solution: >> The missing if clause was added to it's place. >> >> With best regards. Petr. > From petr.pchelko at oracle.com Mon Aug 26 08:08:06 2013 From: petr.pchelko at oracle.com (Petr Pchelko) Date: Mon, 26 Aug 2013 19:08:06 +0400 Subject: [8] RFR: JDK-8012026 [macosx] Component.getMousePosition() does not work in an applet on MacOS Message-ID: <79A4EE25-94E5-46AD-A6D7-570D966353BF@oracle.com> Hello, AWT Team. Please review the fix for the following issue: http://bugs.sun.com/view_bug.do?bug_id=8012026 The fix is available at: http://cr.openjdk.java.net/~pchelko/8012026/webrev.00/ MoiseInfoPeer.isWindowUnderMouse was implemented via the native peer method. This was a workaround for another issue: if a new frame Popups under the mouse we did not get MouseEntered/Exited events for it. However, this issue was already resolved, so the workaround is not needed any more. The only problem was with inactive applications: we did not get MouseEntered/Exited for them, but this was also wrong, because on Windows and Linux we get mouse events for inactive apps. So, after the issue with inactive apps was resolved (see AWTView.m) the workaround could be safely removed. This fix resolves a number of bugs I've found for normal frames: the Component.getMousePosition did not pay attention to overlay windows and so did not conform to the javadoc. And Component.getMousePosition works for applets now. There is a minor problem with applets though: it reports null if the browser window is inactive. However, this is a limitation in NPAPI, so no workaround could be created. Tested on Mac in Applet mode, with SWT_AWT bridge and for normal windows. With best regards. Petr. From srikalyan.chandrashekar at oracle.com Tue Aug 27 00:02:02 2013 From: srikalyan.chandrashekar at oracle.com (srikalyan chandrashekar) Date: Tue, 27 Aug 2013 00:02:02 -0700 Subject: [8] Review request for 8022184 - JDK8 java.awt Static and Raw type warnings fix In-Reply-To: <521B5AA0.5010404@oracle.com> References: <52163B90.4080603@oracle.com> <52163F17.8020906@oracle.com> <52173D0B.8070605@oracle.com> <52179ADB.6050501@oracle.com> <521B5AA0.5010404@oracle.com> Message-ID: <521C4EEA.70604@oracle.com> Artem these explicit casts existed and is now redundant because the warnings are fixed For Ex: 1.Class obj = .... 2.obj = cl.newInstance(); Explicit cast is not required in the line 2 because type is now known due to fix. There could potentially be many such do you want them to be identified and fixed as part of this effort? The thing is we need to look around warning areas a little bit.. -- Thanks kalyan On 8/26/13 6:39 AM, Artem Ananiev wrote: > > On 8/23/2013 9:24 PM, srikalyan chandrashekar wrote: >> Antony, Thanks for the review. Here's the renewed link >> >> >> covering the gaps. > > Here is the updated link at cr.openjdk.java.net: > > http://cr.openjdk.java.net/~art/srikalyc/8022184.01/ > > A few comments: > > 1. GraphicsEnvironment.java:109 - class cast is redundant > > 2. KeyboardFocusManager.java:2655 - class cast is redundant > > 3. KeyboardFocusManager.java:2985 - class cast is redundant > > 4. DefaultKeyboardFocusManager.java:816 - class cast is redundant > > 5. DefaultKeyboardFocusManager.java:1067 - class cast is redundant > > Thanks, > > Artem > >> -- >> Thanks >> kalyan >> >> On 8/23/13 3:44 AM, Anthony Petrov wrote: >>> Hi Srikalyan, >>> >>> Thanks for fixing the warnings. A couple of comments: >>> >>> src/share/classes/java/awt/KeyboardFocusManager.java >>>> 3065 proxyActive = (Field) >>>> AccessController.doPrivileged(new PrivilegedAction() { >>> >>> I suppose an explicit type-cast may now be removed from here. >>> >>> >>> src/share/classes/java/awt/WaitDispatchSupport.java >>>> 227 AccessController.doPrivileged(new PrivilegedAction() { >>> >>> Usually Void is used instead of Object if we know that we don't use >>> the return value. >>> >>> Otherwise the fix looks good to me. >>> >>> -- >>> best regards, >>> Anthony >>> >>> On 08/22/2013 08:40 PM, Artem Ananiev wrote: >>>> >>>> On 8/22/2013 8:25 PM, srikalyan chandrashekar wrote: >>>>> Hi team , could someone review the fix >>>>> Bug : https://jbs.oracle.com/bugs/browse/JDK-8022184 >>>> >>>> Here is the right link visible for everyone: >>>> >>>> http://bugs.sun.com/view_bug.do?bug_id=8022184 >>>> >>>>> Webrev : >>>>> https://github.com/srikalyc/JDKfixes/blob/master/java.awt.static_raw_webrev.zip >>>>> >>>>> >>>>> >>>> >>>> For convenient reviewing, I put it to cr.openjdk.java.net: >>>> >>>> http://cr.openjdk.java.net/~art/srikalyc/8022184/ >>>> >>>> Thanks, >>>> >>>> Artem >>>> >>>>> Fix : static and raw type warnings fix for java.awt >>>>> classes >>>>> >> From artem.ananiev at oracle.com Tue Aug 27 01:26:07 2013 From: artem.ananiev at oracle.com (Artem Ananiev) Date: Tue, 27 Aug 2013 12:26:07 +0400 Subject: [8] Review request for 8022184 - JDK8 java.awt Static and Raw type warnings fix In-Reply-To: <521C4EEA.70604@oracle.com> References: <52163B90.4080603@oracle.com> <52163F17.8020906@oracle.com> <52173D0B.8070605@oracle.com> <52179ADB.6050501@oracle.com> <521B5AA0.5010404@oracle.com> <521C4EEA.70604@oracle.com> Message-ID: <521C629F.7090902@oracle.com> Hi, Kalyan, On 8/27/2013 11:02 AM, srikalyan chandrashekar wrote: > Artem these explicit casts existed and is now redundant because the > warnings are fixed > For Ex: 1.Class obj = .... > 2.obj = cl.newInstance(); > > Explicit cast is not required in the line 2 because type is now known > due to fix. There could potentially be many such do you want them to be > identified and fixed as part of this effort? The thing is we need to > look around warning areas a little bit.. I don't think we should fix all the possible javac warnings as a part of 8022184 - there are tons of them! However, if you touch a line, it seems reasonable to fix adjacent lines as well. For example, in case #1, "Class geCls" is changed to "Class geCls", so we do know that geCls.newInstance() returns a GraphicsEnvironment object and the class cast is not required. Thanks, Artem > -- > Thanks > kalyan > > On 8/26/13 6:39 AM, Artem Ananiev wrote: >> >> On 8/23/2013 9:24 PM, srikalyan chandrashekar wrote: >>> Antony, Thanks for the review. Here's the renewed link >>> >>> >>> covering the gaps. >> >> Here is the updated link at cr.openjdk.java.net: >> >> http://cr.openjdk.java.net/~art/srikalyc/8022184.01/ >> >> A few comments: >> >> 1. GraphicsEnvironment.java:109 - class cast is redundant >> >> 2. KeyboardFocusManager.java:2655 - class cast is redundant >> >> 3. KeyboardFocusManager.java:2985 - class cast is redundant >> >> 4. DefaultKeyboardFocusManager.java:816 - class cast is redundant >> >> 5. DefaultKeyboardFocusManager.java:1067 - class cast is redundant >> >> Thanks, >> >> Artem >> >>> -- >>> Thanks >>> kalyan >>> >>> On 8/23/13 3:44 AM, Anthony Petrov wrote: >>>> Hi Srikalyan, >>>> >>>> Thanks for fixing the warnings. A couple of comments: >>>> >>>> src/share/classes/java/awt/KeyboardFocusManager.java >>>>> 3065 proxyActive = (Field) >>>>> AccessController.doPrivileged(new PrivilegedAction() { >>>> >>>> I suppose an explicit type-cast may now be removed from here. >>>> >>>> >>>> src/share/classes/java/awt/WaitDispatchSupport.java >>>>> 227 AccessController.doPrivileged(new PrivilegedAction() { >>>> >>>> Usually Void is used instead of Object if we know that we don't use >>>> the return value. >>>> >>>> Otherwise the fix looks good to me. >>>> >>>> -- >>>> best regards, >>>> Anthony >>>> >>>> On 08/22/2013 08:40 PM, Artem Ananiev wrote: >>>>> >>>>> On 8/22/2013 8:25 PM, srikalyan chandrashekar wrote: >>>>>> Hi team , could someone review the fix >>>>>> Bug : https://jbs.oracle.com/bugs/browse/JDK-8022184 >>>>> >>>>> Here is the right link visible for everyone: >>>>> >>>>> http://bugs.sun.com/view_bug.do?bug_id=8022184 >>>>> >>>>>> Webrev : >>>>>> https://github.com/srikalyc/JDKfixes/blob/master/java.awt.static_raw_webrev.zip >>>>>> >>>>>> >>>>>> >>>>> >>>>> For convenient reviewing, I put it to cr.openjdk.java.net: >>>>> >>>>> http://cr.openjdk.java.net/~art/srikalyc/8022184/ >>>>> >>>>> Thanks, >>>>> >>>>> Artem >>>>> >>>>>> Fix : static and raw type warnings fix for java.awt >>>>>> classes >>>>>> >>> > From sergey.malenkov at oracle.com Tue Aug 27 02:14:23 2013 From: sergey.malenkov at oracle.com (sergey.malenkov at oracle.com) Date: Tue, 27 Aug 2013 09:14:23 +0000 Subject: hg: jdk8/awt/jdk: 8021379: JFileChooser Create New Folder button enabled in write proteced directory Message-ID: <20130827091438.A5EA648BB1@hg.openjdk.java.net> Changeset: 92adff44c841 Author: malenkov Date: 2013-08-27 13:13 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/92adff44c841 8021379: JFileChooser Create New Folder button enabled in write proteced directory Reviewed-by: alexsch ! src/share/classes/sun/swing/FilePane.java From sergey.malenkov at oracle.com Tue Aug 27 01:54:36 2013 From: sergey.malenkov at oracle.com (sergey.malenkov at oracle.com) Date: Tue, 27 Aug 2013 08:54:36 +0000 Subject: hg: jdk8/awt/jdk: 7195179: ClassCastException for null values in JComboBox Message-ID: <20130827085513.CEC9A48BAF@hg.openjdk.java.net> Changeset: abd068530590 Author: malenkov Date: 2013-08-27 12:53 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/abd068530590 7195179: ClassCastException for null values in JComboBox Reviewed-by: alexsch ! src/share/classes/javax/swing/plaf/basic/BasicComboBoxUI.java + test/javax/swing/JComboBox/7195179/Test7195179.java From sergey.malenkov at oracle.com Tue Aug 27 02:38:26 2013 From: sergey.malenkov at oracle.com (sergey.malenkov at oracle.com) Date: Tue, 27 Aug 2013 09:38:26 +0000 Subject: hg: jdk8/awt/jdk: 8022398: javax/swing/JFileChooser/8013442/Test8013442.java fails Message-ID: <20130827093911.529E048BB2@hg.openjdk.java.net> Changeset: 4bfcf9c5ced3 Author: malenkov Date: 2013-08-27 13:37 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/4bfcf9c5ced3 8022398: javax/swing/JFileChooser/8013442/Test8013442.java fails Reviewed-by: alexsch ! src/macosx/classes/com/apple/laf/AquaFileChooserUI.java ! src/share/classes/com/sun/java/swing/plaf/gtk/GTKFileChooserUI.java ! src/share/classes/com/sun/java/swing/plaf/motif/MotifFileChooserUI.java ! src/share/classes/com/sun/java/swing/plaf/windows/WindowsFileChooserUI.java ! src/share/classes/javax/swing/plaf/metal/MetalFileChooserUI.java + src/share/classes/sun/swing/AbstractFilterComboBoxModel.java ! src/share/classes/sun/swing/plaf/synth/SynthFileChooserUIImpl.java From anthony.petrov at oracle.com Tue Aug 27 03:22:13 2013 From: anthony.petrov at oracle.com (Anthony Petrov) Date: Tue, 27 Aug 2013 14:22:13 +0400 Subject: [8] RFR: JDK-8012026 [macosx] Component.getMousePosition() does not work in an applet on MacOS In-Reply-To: <79A4EE25-94E5-46AD-A6D7-570D966353BF@oracle.com> References: <79A4EE25-94E5-46AD-A6D7-570D966353BF@oracle.com> Message-ID: <521C7DD5.4050408@oracle.com> Hi Petr, The fix looks good to me. Note that AWT is a multi-threaded GUI toolkit, and since you don't use Swing APIs in your fix, you could eliminate all the invokeLater/invokeAndWait() calls from the tests to simplify them. But I don't insist on this. They should work fine as they are, too. -- best regards, Anthony On 08/26/2013 07:08 PM, Petr Pchelko wrote: > Hello, AWT Team. > > Please review the fix for the following issue: > http://bugs.sun.com/view_bug.do?bug_id=8012026 > The fix is available at: > http://cr.openjdk.java.net/~pchelko/8012026/webrev.00/ > > MoiseInfoPeer.isWindowUnderMouse was implemented via the native peer method. This was a workaround for another issue: > if a new frame Popups under the mouse we did not get MouseEntered/Exited events for it. However, this issue was already resolved, > so the workaround is not needed any more. The only problem was with inactive applications: we did not get MouseEntered/Exited > for them, but this was also wrong, because on Windows and Linux we get mouse events for inactive apps. So, after the issue > with inactive apps was resolved (see AWTView.m) the workaround could be safely removed. > > This fix resolves a number of bugs I've found for normal frames: the Component.getMousePosition did not pay attention to overlay windows > and so did not conform to the javadoc. And Component.getMousePosition works for applets now. There is a minor problem with applets though: > it reports null if the browser window is inactive. However, this is a limitation in NPAPI, so no workaround could be created. > > Tested on Mac in Applet mode, with SWT_AWT bridge and for normal windows. > > With best regards. Petr. > From vova.kravets at gmail.com Tue Aug 27 05:53:03 2013 From: vova.kravets at gmail.com (Vladimir Kravets) Date: Tue, 27 Aug 2013 12:53:03 +0000 (UTC) Subject: Invitation to connect on LinkedIn Message-ID: <788086811.5268792.1377607983495.JavaMail.app@ela4-app0132.prod> LinkedIn ------------ I'd like to add you to my professional network on LinkedIn. - Vladimir Vladimir Kravets Java/Python Middle Development Engineer at Hewlett-Packard Ukraine Confirm that you know Vladimir Kravets: https://www.linkedin.com/e/f41a9e-hkv4831j-19/isd/16087089608/eWb7gzpA/?hs=false&tok=3_OkV2SYY5m5U1 -- You are receiving Invitation to Connect emails. Click to unsubscribe: http://www.linkedin.com/e/f41a9e-hkv4831j-19/XypAlmt_1kw_IB9xZNpGU8841qFqAWldbb7wiV/goo/awt-dev%40openjdk%2Ejava%2Enet/20061/I5350916548_1/?hs=false&tok=1hNwP8mlc5m5U1 (c) 2012 LinkedIn Corporation. 2029 Stierlin Ct, Mountain View, CA 94043, USA. -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20130827/f425df16/attachment-0001.html From artem.ananiev at oracle.com Tue Aug 27 06:18:09 2013 From: artem.ananiev at oracle.com (Artem Ananiev) Date: Tue, 27 Aug 2013 17:18:09 +0400 Subject: Invitation to connect on LinkedIn In-Reply-To: <788086811.5268792.1377607983495.JavaMail.app@ela4-app0132.prod> References: <788086811.5268792.1377607983495.JavaMail.app@ela4-app0132.prod> Message-ID: <521CA711.7080804@oracle.com> Vladimir, OpenJDK mailing lists are supposed to be used for OpenJDK related discussions only. Emails like this are not acceptable and will result in your removal from the list of subscribers in the future. Thanks, Artem On 8/27/2013 4:53 PM, Vladimir Kravets wrote: > LinkedIn > > > Vladimir Kravets > > > *From Vladimir Kravets * > > Java/Python Middle Development Engineer at Hewlett-Packard > Ukraine > > > > > > > > > > > > I'd like to add you to my professional network on LinkedIn. > > - Vladimir > > > > Confirm that you know Vladimir > > > > > You are receiving Invitation to Connect emails. Unsubscribe > > ? 2012, LinkedIn Corporation. 2029 Stierlin Ct. Mountain View, CA 94043, USA > From vova.kravets at gmail.com Tue Aug 27 06:26:20 2013 From: vova.kravets at gmail.com (Vladimir Kravets) Date: Tue, 27 Aug 2013 16:26:20 +0300 Subject: Invitation to connect on LinkedIn In-Reply-To: <521CA711.7080804@oracle.com> References: <788086811.5268792.1377607983495.JavaMail.app@ela4-app0132.prod> <521CA711.7080804@oracle.com> Message-ID: Upss.. I'm very apologize for this, it's my miss... Sorry again... Best Regards, Vladimir 2013/8/27 Artem Ananiev > Vladimir, > > OpenJDK mailing lists are supposed to be used for OpenJDK related > discussions only. Emails like this are not acceptable and will result in > your removal from the list of subscribers in the future. > > Thanks, > > Artem > > On 8/27/2013 4:53 PM, Vladimir Kravets wrote: > >> LinkedIn >> >> >> Vladimir Kravets >> >> >> *From Vladimir Kravets * >> >> Java/Python Middle Development Engineer at Hewlett-Packard >> Ukraine >> >> >> >> >> >> >> >> >> >> >> >> I'd like to add you to my professional network on LinkedIn. >> >> - Vladimir >> >> >> >> Confirm that you know Vladimir >> > 16087089608/eWb7gzpA/?hs=**false&tok=3_OkV2SYY5m5U1 >> > >> >> >> >> You are receiving Invitation to Connect emails. Unsubscribe >> > IB9xZNpGU8841qFqAWldbb7wiV/**goo/awt-dev%40openjdk%2Ejava%** >> 2Enet/20061/I5350916548_1/?hs=**false&tok=1hNwP8mlc5m5U1 >> > >> ? 2012, LinkedIn Corporation. 2029 Stierlin Ct. Mountain View, CA 94043, >> USA >> >> -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20130827/deee1416/attachment.html From oleg.pekhovskiy at oracle.com Tue Aug 27 14:35:42 2013 From: oleg.pekhovskiy at oracle.com (Oleg Pekhovskiy) Date: Wed, 28 Aug 2013 01:35:42 +0400 Subject: [8] Review request for 8016356: Any swing frame resizes ugly. In-Reply-To: <521B5619.7030705@oracle.com> References: <5219FB56.6070700@oracle.com> <521B5619.7030705@oracle.com> Message-ID: <521D1BAE.2050908@oracle.com> Hi Anthony, thank you for the review, please, see my comments below... Thanks, Oleg On 26.08.2013 17:20, Anthony Petrov wrote: > Hi Oleg, > > The fix looks somewhat fragile to me. The sequence of events may change > in a future version of Windows, and the fix will fail then. I agree, the fix is not elegant. As for the future: I tested it on Windows 8.1 - it worked. > > Are there any peculiarities for the WM_SIZE messages being posted when a > window is snapped? I'm referring to [1] for example, and they suggest > that a proper SC_ flag might be specified when snapping occurs. So, if > we could detect that, we might unblock the WindowResized() call at the > end of the WmSize() method in the AwtWindow class, which would fix the > issue. Unfortunately there is not direct way to determine the snapping. My experience says not to play with sending system events manually on Windows. That is much more fragile and nobody knows how DefWindowProc() would behave. I chose WM_SYSCOMMAND handler in AwtWindow::WindowProc() because it's synchronous during window resize (looping in AwtWindow::DefWindowProc()) So WindowResized() would be called only when the user releases mouse button after resizing. But WM_SIZE message is called each time the size of the window is changed while resizing. You might also want to explore the WM_WINDOWPOSCHANGED and > WM_WINDOWPOSCHANGING events that the window receives during snapping, > perhaps they have some characteristics allowing us to ignore the > IsResizing() and call the WindowResized() nonetheless. These messages are sent "as a result of a call to the SetWindowPos function or another window-management function" and never appears during window resizing with the mouse. > > [1] > http://stackoverflow.com/questions/9321549/handling-aerosnap-message-in-wndproc > This article is an attempt to handle maximize/restore snapping, but this issue deals with vertical snapping, when top or bottom edge of the window moved to the corresponding edge of the screen. > > -- > best regards, > Anthony > > On 08/25/13 16:40, Oleg Pekhovskiy wrote: >> Hi all, >> >> please review the fix >> http://cr.openjdk.java.net/~bagiras/8016356.1/ >> for >> http://bugs.sun.com/view_bug.do?bug_id=8016356 >> >> Windows 7 has a feature that makes "window being automatically arranged >> when moved to the edge of the screen". And there is no specific system >> notification when that happens. From the other side AwtWindow class has >> some optimization algorithm for resizing that doesn't take into account >> such the arranging. I found indirect way to determine the arranging by >> tracking the sequence of WM_GETMINMAXINFO and WM_SIZE before the end of >> resizing routine, and call WindowResized() when needed to update the >> layout. >> >> Thanks, >> Oleg From srikalyan.chandrashekar at oracle.com Wed Aug 28 00:00:38 2013 From: srikalyan.chandrashekar at oracle.com (srikalyan chandrashekar) Date: Wed, 28 Aug 2013 00:00:38 -0700 Subject: [8] Review request for 8022184 - JDK8 java.awt Static and Raw type warnings fix In-Reply-To: <521C629F.7090902@oracle.com> References: <52163B90.4080603@oracle.com> <52163F17.8020906@oracle.com> <52173D0B.8070605@oracle.com> <52179ADB.6050501@oracle.com> <521B5AA0.5010404@oracle.com> <521C4EEA.70604@oracle.com> <521C629F.7090902@oracle.com> Message-ID: <521DA016.5040208@oracle.com> On 8/27/13 1:26 AM, Artem Ananiev wrote: > Hi, Kalyan, > > On 8/27/2013 11:02 AM, srikalyan chandrashekar wrote: >> Artem these explicit casts existed and is now redundant because the >> warnings are fixed >> For Ex: 1.Class obj = .... >> 2.obj = cl.newInstance(); >> >> Explicit cast is not required in the line 2 because type is now known >> due to fix. There could potentially be many such do you want them to be >> identified and fixed as part of this effort? The thing is we need to >> look around warning areas a little bit.. > > I don't think we should fix all the possible javac warnings as a part > of 8022184 - there are tons of them! However, if you touch a line, it > seems reasonable to fix adjacent lines as well. For example, in case > #1, "Class geCls" is changed to "Class geCls", so > we do know that geCls.newInstance() returns a GraphicsEnvironment > object and the class cast is not required. Hi Artem ,i glanced through usages of all such variables and made fixes , here's is the renewed link . -- Thanks kalyan > > Thanks, > > Artem > >> -- >> Thanks >> kalyan >> >> On 8/26/13 6:39 AM, Artem Ananiev wrote: >>> >>> On 8/23/2013 9:24 PM, srikalyan chandrashekar wrote: >>>> Antony, Thanks for the review. Here's the renewed link >>>> >>>> >>>> >>>> covering the gaps. >>> >>> Here is the updated link at cr.openjdk.java.net: >>> >>> http://cr.openjdk.java.net/~art/srikalyc/8022184.01/ >>> >>> A few comments: >>> >>> 1. GraphicsEnvironment.java:109 - class cast is redundant >>> >>> 2. KeyboardFocusManager.java:2655 - class cast is redundant >>> >>> 3. KeyboardFocusManager.java:2985 - class cast is redundant >>> >>> 4. DefaultKeyboardFocusManager.java:816 - class cast is redundant >>> >>> 5. DefaultKeyboardFocusManager.java:1067 - class cast is redundant >>> >>> Thanks, >>> >>> Artem >>> >>>> -- >>>> Thanks >>>> kalyan >>>> >>>> On 8/23/13 3:44 AM, Anthony Petrov wrote: >>>>> Hi Srikalyan, >>>>> >>>>> Thanks for fixing the warnings. A couple of comments: >>>>> >>>>> src/share/classes/java/awt/KeyboardFocusManager.java >>>>>> 3065 proxyActive = (Field) >>>>>> AccessController.doPrivileged(new PrivilegedAction() { >>>>> >>>>> I suppose an explicit type-cast may now be removed from here. >>>>> >>>>> >>>>> src/share/classes/java/awt/WaitDispatchSupport.java >>>>>> 227 AccessController.doPrivileged(new PrivilegedAction() { >>>>> >>>>> Usually Void is used instead of Object if we know that we don't use >>>>> the return value. >>>>> >>>>> Otherwise the fix looks good to me. >>>>> >>>>> -- >>>>> best regards, >>>>> Anthony >>>>> >>>>> On 08/22/2013 08:40 PM, Artem Ananiev wrote: >>>>>> >>>>>> On 8/22/2013 8:25 PM, srikalyan chandrashekar wrote: >>>>>>> Hi team , could someone review the fix >>>>>>> Bug : https://jbs.oracle.com/bugs/browse/JDK-8022184 >>>>>> >>>>>> Here is the right link visible for everyone: >>>>>> >>>>>> http://bugs.sun.com/view_bug.do?bug_id=8022184 >>>>>> >>>>>>> Webrev : >>>>>>> https://github.com/srikalyc/JDKfixes/blob/master/java.awt.static_raw_webrev.zip >>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>> >>>>>> For convenient reviewing, I put it to cr.openjdk.java.net: >>>>>> >>>>>> http://cr.openjdk.java.net/~art/srikalyc/8022184/ >>>>>> >>>>>> Thanks, >>>>>> >>>>>> Artem >>>>>> >>>>>>> Fix : static and raw type warnings fix for java.awt >>>>>>> classes >>>>>>> >>>> >> -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20130828/35648670/attachment.html From lana.steuck at oracle.com Wed Aug 28 00:13:10 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 28 Aug 2013 07:13:10 +0000 Subject: hg: jdk8/awt: 9 new changesets Message-ID: <20130828071312.BE96F48C14@hg.openjdk.java.net> Changeset: ceefd94ef326 Author: cl Date: 2013-08-15 09:25 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/rev/ceefd94ef326 Added tag jdk8-b103 for changeset b7e64be81c8a ! .hgtags Changeset: 4fb877dfe5c4 Author: erikj Date: 2013-08-15 17:14 +0200 URL: http://hg.openjdk.java.net/jdk8/awt/rev/4fb877dfe5c4 8020411: lin32 - JDK 8 build for Linux-i586 on Oracle Linux 6.4 64-bit machines does not generate the bundles directory in the build directory Reviewed-by: tbell ! common/autoconf/generated-configure.sh ! common/autoconf/platform.m4 ! common/autoconf/spec.gmk.in Changeset: f10f673d9b17 Author: igerasim Date: 2013-08-16 14:43 +0200 URL: http://hg.openjdk.java.net/jdk8/awt/rev/f10f673d9b17 8023156: make dist-clean should remove javacservers directory Reviewed-by: erikj ! common/makefiles/Main.gmk Changeset: dadf49495ab4 Author: erikj Date: 2013-08-19 10:31 +0200 URL: http://hg.openjdk.java.net/jdk8/awt/rev/dadf49495ab4 8021430: 64 bit JDK build fails on windows 7 due to missing corba source files Reviewed-by: tbell, katleman ! common/makefiles/IdlCompilation.gmk Changeset: 96c1b9b7524b Author: katleman Date: 2013-08-20 15:42 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/rev/96c1b9b7524b Merge Changeset: c3b5197f2851 Author: cl Date: 2013-08-22 09:09 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/rev/c3b5197f2851 Added tag jdk8-b104 for changeset 96c1b9b7524b ! .hgtags Changeset: 00dcfaa6bc01 Author: aefimov Date: 2013-08-16 18:40 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/rev/00dcfaa6bc01 8021820: Number of opened files used in select() is limited to 1024 [macosx] Reviewed-by: alanb, chegar, tbell, smarks ! common/autoconf/generated-configure.sh ! common/autoconf/toolchain.m4 Changeset: e8a3edda1f60 Author: lana Date: 2013-08-20 17:40 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/rev/e8a3edda1f60 Merge Changeset: 056398db9dcb Author: lana Date: 2013-08-23 14:09 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/rev/056398db9dcb Merge ! common/autoconf/generated-configure.sh From lana.steuck at oracle.com Wed Aug 28 00:13:08 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 28 Aug 2013 07:13:08 +0000 Subject: hg: jdk8/awt/corba: 2 new changesets Message-ID: <20130828071316.1180D48C15@hg.openjdk.java.net> Changeset: d411c60a8c2f Author: cl Date: 2013-08-15 09:25 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/corba/rev/d411c60a8c2f Added tag jdk8-b103 for changeset 49c4a777fdfd ! .hgtags Changeset: 4e38de7c767e Author: cl Date: 2013-08-22 09:09 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/corba/rev/4e38de7c767e Added tag jdk8-b104 for changeset d411c60a8c2f ! .hgtags From lana.steuck at oracle.com Wed Aug 28 00:13:10 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 28 Aug 2013 07:13:10 +0000 Subject: hg: jdk8/awt/jaxws: 2 new changesets Message-ID: <20130828071328.3BBDE48C16@hg.openjdk.java.net> Changeset: 42211ab0ab1c Author: cl Date: 2013-08-15 09:25 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jaxws/rev/42211ab0ab1c Added tag jdk8-b103 for changeset 6cdc6ed98780 ! .hgtags Changeset: 88390df7ed2c Author: cl Date: 2013-08-22 09:10 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jaxws/rev/88390df7ed2c Added tag jdk8-b104 for changeset 42211ab0ab1c ! .hgtags From lana.steuck at oracle.com Wed Aug 28 00:13:20 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 28 Aug 2013 07:13:20 +0000 Subject: hg: jdk8/awt/jaxp: 6 new changesets Message-ID: <20130828071415.07F8148C17@hg.openjdk.java.net> Changeset: a22fe9bd01e6 Author: cl Date: 2013-08-15 09:25 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jaxp/rev/a22fe9bd01e6 Added tag jdk8-b103 for changeset b1ceab582fc6 ! .hgtags Changeset: af28b93bfb6f Author: cl Date: 2013-08-22 09:10 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jaxp/rev/af28b93bfb6f Added tag jdk8-b104 for changeset a22fe9bd01e6 ! .hgtags Changeset: 4e23bc205d9d Author: joehw Date: 2013-08-09 12:10 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jaxp/rev/4e23bc205d9d 8022548: SPECJVM2008 has errors introduced in 7u40-b34 Reviewed-by: chegar, lancea ! src/com/sun/org/apache/xerces/internal/parsers/DTDConfiguration.java ! src/com/sun/org/apache/xerces/internal/parsers/NonValidatingConfiguration.java ! src/com/sun/org/apache/xerces/internal/parsers/SAXParser.java Changeset: 9800647936dd Author: lana Date: 2013-08-13 18:28 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jaxp/rev/9800647936dd Merge Changeset: d4d6422ec564 Author: lana Date: 2013-08-20 17:41 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jaxp/rev/d4d6422ec564 Merge Changeset: 09a46ec11f88 Author: lana Date: 2013-08-23 14:09 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jaxp/rev/09a46ec11f88 Merge From lana.steuck at oracle.com Wed Aug 28 00:13:25 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 28 Aug 2013 07:13:25 +0000 Subject: hg: jdk8/awt/nashorn: 24 new changesets Message-ID: <20130828071418.B584B48C18@hg.openjdk.java.net> Changeset: afc100513451 Author: cl Date: 2013-08-15 09:26 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/nashorn/rev/afc100513451 Added tag jdk8-b103 for changeset 414203de4374 ! .hgtags Changeset: 74244f43c577 Author: cl Date: 2013-08-22 09:10 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/nashorn/rev/74244f43c577 Added tag jdk8-b104 for changeset afc100513451 ! .hgtags Changeset: 9a3e3bb30db3 Author: attila Date: 2013-08-07 16:38 +0200 URL: http://hg.openjdk.java.net/jdk8/awt/nashorn/rev/9a3e3bb30db3 8022509: Various Dynalink security enhancements Reviewed-by: jlaskey, hannesw ! src/jdk/internal/dynalink/ChainedCallSite.java ! src/jdk/internal/dynalink/DynamicLinkerFactory.java ! src/jdk/internal/dynalink/beans/ClassString.java ! src/jdk/internal/dynalink/beans/StaticClassLinker.java - src/jdk/internal/dynalink/support/Backport.java ! src/jdk/internal/dynalink/support/ClassMap.java ! src/jdk/internal/dynalink/support/Guards.java ! src/jdk/internal/dynalink/support/Lookup.java ! src/jdk/internal/dynalink/support/TypeConverterFactory.java ! src/jdk/nashorn/internal/runtime/linker/Bootstrap.java Changeset: dd79c04ef7df Author: sundar Date: 2013-08-08 16:38 +0530 URL: http://hg.openjdk.java.net/jdk8/awt/nashorn/rev/dd79c04ef7df 8022524: Memory leaks in nashorn sources and tests found by jhat analysis Reviewed-by: attila, hannesw ! make/project.properties ! src/jdk/nashorn/internal/codegen/CompileUnit.java ! src/jdk/nashorn/internal/objects/Global.java ! src/jdk/nashorn/internal/objects/NativeArray.java ! src/jdk/nashorn/internal/objects/NativeDate.java ! src/jdk/nashorn/internal/objects/NativeJSON.java ! src/jdk/nashorn/internal/objects/NativeObject.java ! src/jdk/nashorn/internal/runtime/GlobalObject.java ! src/jdk/nashorn/internal/runtime/JSONFunctions.java ! src/jdk/nashorn/internal/runtime/ListAdapter.java ! src/jdk/nashorn/internal/runtime/RecompilableScriptFunctionData.java ! src/jdk/nashorn/internal/runtime/ScriptFunction.java ! src/jdk/nashorn/internal/runtime/UserAccessorProperty.java ! src/jdk/nashorn/internal/runtime/linker/JavaAdapterClassLoader.java ! src/jdk/nashorn/internal/runtime/linker/JavaAdapterFactory.java ! test/script/basic/JDK-8020357.js ! test/src/jdk/nashorn/api/javaaccess/BooleanAccessTest.java ! test/src/jdk/nashorn/api/javaaccess/MethodAccessTest.java ! test/src/jdk/nashorn/api/javaaccess/NumberAccessTest.java ! test/src/jdk/nashorn/api/javaaccess/NumberBoxingTest.java ! test/src/jdk/nashorn/api/javaaccess/ObjectAccessTest.java ! test/src/jdk/nashorn/api/javaaccess/StringAccessTest.java ! test/src/jdk/nashorn/internal/codegen/CompilerTest.java ! test/src/jdk/nashorn/internal/parser/ParserTest.java Changeset: 0d7484bf8597 Author: sundar Date: 2013-08-08 18:19 +0530 URL: http://hg.openjdk.java.net/jdk8/awt/nashorn/rev/0d7484bf8597 Merge - src/jdk/internal/dynalink/support/Backport.java Changeset: 14ea21d58f83 Author: jlaskey Date: 2013-08-08 11:20 -0300 URL: http://hg.openjdk.java.net/jdk8/awt/nashorn/rev/14ea21d58f83 Merge - src/jdk/internal/dynalink/support/Backport.java Changeset: 47e2b609fe31 Author: sundar Date: 2013-08-09 20:48 +0530 URL: http://hg.openjdk.java.net/jdk8/awt/nashorn/rev/47e2b609fe31 8022707: Revisit all doPrivileged blocks Reviewed-by: jlaskey, hannesw ! make/project.properties ! src/jdk/nashorn/api/scripting/NashornScriptEngine.java ! src/jdk/nashorn/api/scripting/NashornScriptEngineFactory.java ! src/jdk/nashorn/api/scripting/ScriptObjectMirror.java ! src/jdk/nashorn/internal/objects/Global.java ! src/jdk/nashorn/internal/objects/NativeDebug.java ! src/jdk/nashorn/internal/runtime/Context.java ! src/jdk/nashorn/internal/runtime/ECMAErrors.java ! src/jdk/nashorn/internal/runtime/Logging.java ! src/jdk/nashorn/internal/runtime/linker/ClassAndLoader.java ! src/jdk/nashorn/internal/runtime/linker/JavaAdapterBytecodeGenerator.java ! src/jdk/nashorn/internal/runtime/linker/JavaAdapterClassLoader.java ! src/jdk/nashorn/internal/runtime/linker/JavaAdapterFactory.java ! src/jdk/nashorn/internal/runtime/linker/ReflectionCheckLinker.java ! src/jdk/nashorn/internal/runtime/options/Options.java ! src/jdk/nashorn/tools/Shell.java Changeset: 01304b0550fb Author: sundar Date: 2013-08-12 14:43 +0530 URL: http://hg.openjdk.java.net/jdk8/awt/nashorn/rev/01304b0550fb 8022782: publicLookup access failures in ScriptObject, ScriptFunction and ScriptFunction Reviewed-by: lagergren, attila, hannesw ! src/jdk/nashorn/internal/codegen/CompilerConstants.java ! src/jdk/nashorn/internal/runtime/JSType.java ! src/jdk/nashorn/internal/runtime/ScriptObject.java ! src/jdk/nashorn/internal/runtime/ScriptRuntime.java Changeset: 3c13fba4d727 Author: attila Date: 2013-08-12 12:46 +0200 URL: http://hg.openjdk.java.net/jdk8/awt/nashorn/rev/3c13fba4d727 8022789: Revisit doPrivileged blocks in Dynalink Reviewed-by: lagergren, sundar ! src/jdk/internal/dynalink/DynamicLinkerFactory.java + src/jdk/internal/dynalink/support/ClassLoaderGetterContextProvider.java ! src/jdk/internal/dynalink/support/ClassMap.java ! src/jdk/internal/dynalink/support/TypeConverterFactory.java Changeset: 0bbaa0ac36ab Author: sundar Date: 2013-08-12 16:52 +0530 URL: http://hg.openjdk.java.net/jdk8/awt/nashorn/rev/0bbaa0ac36ab 8022614: Please exclude test test/script/trusted/JDK-8020809.js from Nashorn code coverage run Reviewed-by: jlaskey, lagergren ! exclude/exclude_list_cc.txt Changeset: 03ba1cd734c0 Author: hannesw Date: 2013-08-12 13:31 +0200 URL: http://hg.openjdk.java.net/jdk8/awt/nashorn/rev/03ba1cd734c0 8022731: NativeArguments has wrong implementation of isMapped() Reviewed-by: lagergren, jlaskey ! src/jdk/nashorn/internal/objects/NativeArguments.java + test/script/basic/JDK-8022731.js + test/script/basic/JDK-8022731.js.EXPECTED Changeset: 821b605c7046 Author: sundar Date: 2013-08-12 17:08 +0530 URL: http://hg.openjdk.java.net/jdk8/awt/nashorn/rev/821b605c7046 8022615: [nightly] Two nashorn print tests fail in nightly builds on Windows Reviewed-by: lagergren, jlaskey ! test/src/jdk/nashorn/api/scripting/ScriptEngineTest.java Changeset: f2e1673db03b Author: sundar Date: 2013-08-12 18:16 +0530 URL: http://hg.openjdk.java.net/jdk8/awt/nashorn/rev/f2e1673db03b 8022598: Object.getPrototypeOf should return null for host objects rather than throwing TypeError Reviewed-by: lagergren, jlaskey, attila, hannesw ! src/jdk/nashorn/internal/objects/NativeObject.java + test/script/basic/JDK-8022598.js Changeset: a0807e889be3 Author: sundar Date: 2013-08-12 20:37 +0530 URL: http://hg.openjdk.java.net/jdk8/awt/nashorn/rev/a0807e889be3 Merge Changeset: 8ecf68b292d0 Author: lana Date: 2013-08-13 18:34 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/nashorn/rev/8ecf68b292d0 Merge Changeset: bbc4e9d37315 Author: jlaskey Date: 2013-08-12 18:00 -0300 URL: http://hg.openjdk.java.net/jdk8/awt/nashorn/rev/bbc4e9d37315 8022676: Confusing error message checking instanceof non-class Reviewed-by: jlaskey, sundar Contributed-by: michael.horowitz at oracle.com ! src/jdk/nashorn/internal/runtime/resources/Messages.properties Changeset: ba507ac08719 Author: sundar Date: 2013-08-14 20:51 +0530 URL: http://hg.openjdk.java.net/jdk8/awt/nashorn/rev/ba507ac08719 8023026: Array.prototype iterator functions like forEach, reduce should work for Java arrays, lists Reviewed-by: jlaskey, lagergren - src/jdk/nashorn/internal/runtime/arrays/ArrayIterator.java ! src/jdk/nashorn/internal/runtime/arrays/ArrayLikeIterator.java + src/jdk/nashorn/internal/runtime/arrays/JavaArrayIterator.java + src/jdk/nashorn/internal/runtime/arrays/JavaListIterator.java - src/jdk/nashorn/internal/runtime/arrays/MapIterator.java - src/jdk/nashorn/internal/runtime/arrays/ReverseArrayIterator.java + src/jdk/nashorn/internal/runtime/arrays/ReverseJavaArrayIterator.java + src/jdk/nashorn/internal/runtime/arrays/ReverseJavaListIterator.java - src/jdk/nashorn/internal/runtime/arrays/ReverseMapIterator.java + src/jdk/nashorn/internal/runtime/arrays/ReverseScriptArrayIterator.java + src/jdk/nashorn/internal/runtime/arrays/ReverseScriptObjectIterator.java + src/jdk/nashorn/internal/runtime/arrays/ScriptArrayIterator.java + src/jdk/nashorn/internal/runtime/arrays/ScriptObjectIterator.java + test/script/basic/JDK-8023026.js + test/script/basic/JDK-8023026.js.EXPECTED Changeset: 09c99b58b81e Author: sundar Date: 2013-08-16 15:04 +0530 URL: http://hg.openjdk.java.net/jdk8/awt/nashorn/rev/09c99b58b81e 8020355: bind on built-in constructors don't use bound argument values Reviewed-by: lagergren, hannesw ! src/jdk/nashorn/internal/runtime/ScriptFunctionData.java + test/script/basic/JDK-8020355.js Changeset: 1d29d2e27590 Author: hannesw Date: 2013-08-16 13:42 +0200 URL: http://hg.openjdk.java.net/jdk8/awt/nashorn/rev/1d29d2e27590 8019985: Date.parse("2000-01-01T00:00:00.Z") should return NaN Reviewed-by: sundar, jlaskey ! src/jdk/nashorn/internal/parser/DateParser.java + test/script/basic/JDK-8019985.js Changeset: 36fb36217e1d Author: lagergren Date: 2013-08-16 18:51 +0200 URL: http://hg.openjdk.java.net/jdk8/awt/nashorn/rev/36fb36217e1d 8023017: SUB missing for widest op == number for BinaryNode Reviewed-by: sundar, jlaskey ! src/jdk/nashorn/internal/codegen/ObjectClassGenerator.java ! src/jdk/nashorn/internal/codegen/ObjectCreator.java ! src/jdk/nashorn/internal/ir/BinaryNode.java ! src/jdk/nashorn/internal/ir/BreakableNode.java ! src/jdk/nashorn/internal/ir/IdentNode.java ! src/jdk/nashorn/internal/ir/LexicalContextNode.java ! src/jdk/nashorn/internal/objects/NativeArguments.java ! src/jdk/nashorn/internal/objects/NativeArray.java ! src/jdk/nashorn/internal/parser/Parser.java ! src/jdk/nashorn/internal/runtime/Context.java ! src/jdk/nashorn/internal/runtime/RecompilableScriptFunctionData.java ! src/jdk/nashorn/internal/runtime/ScriptFunction.java ! src/jdk/nashorn/internal/runtime/ScriptObject.java ! src/jdk/nashorn/internal/runtime/arrays/ArrayLikeIterator.java ! src/jdk/nashorn/internal/runtime/arrays/LongArrayData.java ! src/jdk/nashorn/internal/runtime/arrays/SparseArrayData.java ! src/jdk/nashorn/internal/runtime/linker/BoundDynamicMethod.java ! src/jdk/nashorn/internal/runtime/linker/BoundDynamicMethodLinker.java ! src/jdk/nashorn/internal/runtime/linker/JavaAdapterClassLoader.java Changeset: bd0174b1a42f Author: sundar Date: 2013-08-19 17:16 +0530 URL: http://hg.openjdk.java.net/jdk8/awt/nashorn/rev/bd0174b1a42f 8023210: jjs tools should support a mode where it will load few command line scripts and then entering into interactive shell Reviewed-by: hannesw, attila, lagergren, jlaskey ! src/jdk/nashorn/internal/runtime/options/Options.java ! src/jdk/nashorn/tools/Shell.java Changeset: e628aefac504 Author: sundar Date: 2013-08-19 19:37 +0530 URL: http://hg.openjdk.java.net/jdk8/awt/nashorn/rev/e628aefac504 Merge - src/jdk/nashorn/internal/runtime/arrays/ArrayIterator.java - src/jdk/nashorn/internal/runtime/arrays/MapIterator.java - src/jdk/nashorn/internal/runtime/arrays/ReverseArrayIterator.java - src/jdk/nashorn/internal/runtime/arrays/ReverseMapIterator.java Changeset: 1f2394beecf7 Author: lana Date: 2013-08-20 17:46 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/nashorn/rev/1f2394beecf7 Merge - src/jdk/internal/dynalink/support/Backport.java - src/jdk/nashorn/internal/runtime/arrays/ArrayIterator.java - src/jdk/nashorn/internal/runtime/arrays/MapIterator.java - src/jdk/nashorn/internal/runtime/arrays/ReverseArrayIterator.java - src/jdk/nashorn/internal/runtime/arrays/ReverseMapIterator.java Changeset: f484bfb624dd Author: lana Date: 2013-08-23 14:18 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/nashorn/rev/f484bfb624dd Merge - src/jdk/internal/dynalink/support/Backport.java - src/jdk/nashorn/internal/runtime/arrays/ArrayIterator.java - src/jdk/nashorn/internal/runtime/arrays/MapIterator.java - src/jdk/nashorn/internal/runtime/arrays/ReverseArrayIterator.java - src/jdk/nashorn/internal/runtime/arrays/ReverseMapIterator.java From lana.steuck at oracle.com Wed Aug 28 00:14:20 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 28 Aug 2013 07:14:20 +0000 Subject: hg: jdk8/awt/hotspot: 67 new changesets Message-ID: <20130828071714.E49B048C1B@hg.openjdk.java.net> Changeset: 0bbd1c775bef Author: cl Date: 2013-08-15 09:25 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/0bbd1c775bef Added tag jdk8-b103 for changeset 6f9be7f87b96 ! .hgtags Changeset: 39127bb12d32 Author: amurillo Date: 2013-08-09 01:39 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/39127bb12d32 8022688: new hotspot build - hs25-b46 Reviewed-by: jcoomes ! make/hotspot_version Changeset: ca0165daa6ec Author: sspitsyn Date: 2013-08-06 16:33 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/ca0165daa6ec 7187554: JSR 292: JVMTI PopFrame needs to handle appendix arguments Summary: Restore the appendix argument after PopFrame() call Reviewed-by: twisti, coleenp Contributed-by: serguei.spitsyn at oracle.com ! src/cpu/sparc/vm/templateInterpreter_sparc.cpp ! src/cpu/x86/vm/templateInterpreter_x86_32.cpp ! src/cpu/x86/vm/templateInterpreter_x86_64.cpp ! src/share/vm/classfile/javaClasses.cpp ! src/share/vm/classfile/javaClasses.hpp ! src/share/vm/classfile/systemDictionary.hpp ! src/share/vm/classfile/vmSymbols.hpp ! src/share/vm/interpreter/interpreterRuntime.cpp ! src/share/vm/interpreter/interpreterRuntime.hpp Changeset: c54a3122f9c8 Author: omajid Date: 2013-08-06 12:28 -0400 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/c54a3122f9c8 8022188: Make zero compile after 8016131 and 8016697 Reviewed-by: dholmes, twisti ! src/cpu/zero/vm/entryFrame_zero.hpp ! src/cpu/zero/vm/frame_zero.inline.hpp ! src/cpu/zero/vm/stubGenerator_zero.cpp ! src/os_cpu/linux_zero/vm/os_linux_zero.cpp Changeset: 196aa14f9f29 Author: dholmes Date: 2013-08-06 21:06 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/196aa14f9f29 Merge Changeset: 195ff07bc7f6 Author: dsamersoff Date: 2013-08-07 19:02 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/195ff07bc7f6 8021771: warning stat64 is deprecated - when building on OSX 10.7.5 Summary: stat64 have to be replaced with stat Reviewed-by: dholmes, kmo Contributed-by: rednaxelafx at gmail.com ! src/os/bsd/vm/attachListener_bsd.cpp Changeset: 31f3b1e1c5e5 Author: dcubed Date: 2013-08-08 09:21 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/31f3b1e1c5e5 8016601: Unable to build hsx24 on Windows using project creator and Visual Studio Summary: ProjectCreator tool is modified to support two new options: '-relativeAltSrcInclude' and '-altRelativeInclude' which prevents IDE linker errors. Also fixed some cmd line build linker warnings. Misc cleanups. Reviewed-by: rdurbin, coleenp ! make/windows/create.bat ! make/windows/create_obj_files.sh ! make/windows/makefiles/projectcreator.make ! make/windows/makefiles/trace.make ! make/windows/makefiles/vm.make ! src/share/tools/ProjectCreator/BuildConfig.java ! src/share/tools/ProjectCreator/FileTreeCreatorVC10.java ! src/share/tools/ProjectCreator/ProjectCreator.java ! src/share/tools/ProjectCreator/WinGammaPlatform.java ! src/share/tools/ProjectCreator/WinGammaPlatformVC10.java Changeset: c661fa2e5189 Author: iklam Date: 2013-08-08 14:45 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/c661fa2e5189 8022093: syntax error near "umpiconninfo_t" -- when building on Solaris 10 Summary: Added extra help message in make/solaris/makefiles/dtrace.make Reviewed-by: dholmes, sspitsyn ! make/solaris/makefiles/dtrace.make Changeset: 57ac7245594c Author: minqi Date: 2013-08-08 15:19 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/57ac7245594c 8019583: [TESTBUG] runtime/7107135 always passes Summary: If java test return none zero, the value will be override by 'if' statement, the exit value will always '0' and pass. Fix by recording the result in a variable. Reviewed-by: coleenp, dholmes, iklam Contributed-by: yumin.qi at oracle.com ! test/runtime/7107135/Test7107135.sh Changeset: 6222a021d582 Author: minqi Date: 2013-08-08 20:13 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/6222a021d582 Merge Changeset: 98aa538fd97e Author: mikael Date: 2013-08-09 09:51 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/98aa538fd97e 8022452: Hotspot needs to know about Windows 8.1 and Windows Server 2012 R2 Summary: Add support for recognizing Windows 8.1 and Server 2012 R2 and minor cleanup Reviewed-by: coleenp, dsamersoff ! src/os/windows/vm/os_windows.cpp Changeset: ed7c17e7d45b Author: dcubed Date: 2013-08-09 13:19 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/ed7c17e7d45b Merge Changeset: 7b03590c334b Author: dcubed Date: 2013-08-09 15:36 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/7b03590c334b Merge Changeset: bd0e82136b03 Author: iklam Date: 2013-08-10 10:56 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/bd0e82136b03 8022740: Visual 2008 IDE build is broken Summary: Fixed project generation code, and added warning to upgrade to VS 2008 SP1. Reviewed-by: dcubed, ccheung ! make/windows/projectfiles/common/Makefile ! src/share/tools/ProjectCreator/FileTreeCreator.java ! src/share/tools/ProjectCreator/FileTreeCreatorVC10.java ! src/share/tools/ProjectCreator/FileTreeCreatorVC7.java ! src/share/tools/ProjectCreator/WinGammaPlatformVC7.java Changeset: 85147f28faba Author: coleenp Date: 2013-08-12 17:24 -0400 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/85147f28faba 8009728: nsk/jvmti/AttachOnDemand/attach030 crashes on Win32 Summary: ActiveMethodOopsCache was used to keep track of old versions of some methods that are cached in Universe but is buggy with permgen removal and not needed anymore Reviewed-by: sspitsyn, dcubed, mseledtsov ! src/share/vm/memory/universe.cpp ! src/share/vm/memory/universe.hpp ! src/share/vm/oops/method.cpp ! src/share/vm/prims/jvmtiRedefineClasses.cpp ! test/runtime/RedefineObject/Agent.java ! test/runtime/RedefineObject/TestRedefineObject.java + test/runtime/RedefineObject/WalkThroughInvoke.java Changeset: d1034bd8cefc Author: adlertz Date: 2013-08-07 17:56 +0200 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/d1034bd8cefc 8022284: Hide internal data structure in PhaseCFG Summary: Hide private node to block mapping using public interface Reviewed-by: kvn, roland ! agent/src/share/classes/sun/jvm/hotspot/opto/PhaseCFG.java ! src/share/vm/opto/block.cpp ! src/share/vm/opto/block.hpp ! src/share/vm/opto/buildOopMap.cpp ! src/share/vm/opto/chaitin.cpp ! src/share/vm/opto/coalesce.cpp ! src/share/vm/opto/compile.cpp ! src/share/vm/opto/domgraph.cpp ! src/share/vm/opto/gcm.cpp ! src/share/vm/opto/idealGraphPrinter.cpp ! src/share/vm/opto/ifg.cpp ! src/share/vm/opto/lcm.cpp ! src/share/vm/opto/live.cpp ! src/share/vm/opto/node.hpp ! src/share/vm/opto/output.cpp ! src/share/vm/opto/output.hpp ! src/share/vm/opto/postaloc.cpp ! src/share/vm/opto/reg_split.cpp ! src/share/vm/runtime/vmStructs.cpp Changeset: ce8969c36762 Author: adlertz Date: 2013-08-07 18:04 +0200 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/ce8969c36762 8022475: Remove unneeded ad-files Summary: Remove .ad files that are not used Reviewed-by: kvn ! make/bsd/makefiles/adlc.make ! make/linux/makefiles/adlc.make ! make/solaris/makefiles/adlc.make ! make/windows/makefiles/adlc.make - src/os_cpu/bsd_x86/vm/bsd_x86_32.ad - src/os_cpu/bsd_x86/vm/bsd_x86_64.ad - src/os_cpu/linux_x86/vm/linux_x86_32.ad - src/os_cpu/linux_x86/vm/linux_x86_64.ad - src/os_cpu/solaris_sparc/vm/solaris_sparc.ad - src/os_cpu/solaris_x86/vm/solaris_x86_32.ad - src/os_cpu/solaris_x86/vm/solaris_x86_64.ad - src/os_cpu/windows_x86/vm/windows_x86_32.ad - src/os_cpu/windows_x86/vm/windows_x86_64.ad Changeset: 5394ec69f112 Author: rbackman Date: 2013-08-09 18:05 +0200 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/5394ec69f112 Merge - src/os_cpu/bsd_x86/vm/bsd_x86_32.ad - src/os_cpu/bsd_x86/vm/bsd_x86_64.ad - src/os_cpu/linux_x86/vm/linux_x86_32.ad - src/os_cpu/linux_x86/vm/linux_x86_64.ad - src/os_cpu/solaris_sparc/vm/solaris_sparc.ad - src/os_cpu/solaris_x86/vm/solaris_x86_32.ad - src/os_cpu/solaris_x86/vm/solaris_x86_64.ad - src/os_cpu/windows_x86/vm/windows_x86_32.ad - src/os_cpu/windows_x86/vm/windows_x86_64.ad Changeset: 11237ee74aae Author: iignatyev Date: 2013-08-10 10:01 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/11237ee74aae 8019915: whitebox testClearMethodStateTest fails with tiered on sparc Summary: 'compileonly' directive has beens added to each 'compiler/whitebox' test Reviewed-by: kvn ! test/compiler/whitebox/ClearMethodStateTest.java ! test/compiler/whitebox/CompilerWhiteBoxTest.java ! test/compiler/whitebox/DeoptimizeAllTest.java ! test/compiler/whitebox/DeoptimizeMethodTest.java ! test/compiler/whitebox/EnqueueMethodForCompilationTest.java ! test/compiler/whitebox/IsMethodCompilableTest.java ! test/compiler/whitebox/MakeMethodNotCompilableTest.java ! test/compiler/whitebox/SetDontInlineMethodTest.java ! test/compiler/whitebox/SetForceInlineMethodTest.java Changeset: bcc4f6f54d83 Author: kvn Date: 2013-08-14 10:21 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/bcc4f6f54d83 8022993: Convert MAX_UNROLL constant to LoopMaxUnroll C2 flag Summary: Replace MAX_UNROLL constant with new C2 LoopMaxUnroll flag. Reviewed-by: roland ! src/share/vm/opto/c2_globals.hpp ! src/share/vm/opto/loopTransform.cpp Changeset: 56b94e55267a Author: rbackman Date: 2013-08-15 15:26 +0200 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/56b94e55267a Merge - src/os_cpu/bsd_x86/vm/bsd_x86_32.ad - src/os_cpu/bsd_x86/vm/bsd_x86_64.ad - src/os_cpu/linux_x86/vm/linux_x86_32.ad - src/os_cpu/linux_x86/vm/linux_x86_64.ad - src/os_cpu/solaris_sparc/vm/solaris_sparc.ad - src/os_cpu/solaris_x86/vm/solaris_x86_32.ad - src/os_cpu/solaris_x86/vm/solaris_x86_64.ad - src/os_cpu/windows_x86/vm/windows_x86_32.ad - src/os_cpu/windows_x86/vm/windows_x86_64.ad Changeset: 9766f73e770d Author: stefank Date: 2013-05-31 14:32 +0200 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/9766f73e770d 8022880: False sharing between PSPromotionManager instances Summary: Pad the PSPromotionManager instances in the manager array. Reviewed-by: brutisso, jmasa ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp ! src/share/vm/gc_implementation/parNew/parNewGeneration.hpp ! src/share/vm/gc_implementation/parNew/parOopClosures.hpp ! src/share/vm/gc_implementation/parallelScavenge/psPromotionManager.cpp ! src/share/vm/gc_implementation/parallelScavenge/psPromotionManager.hpp ! src/share/vm/gc_implementation/parallelScavenge/psPromotionManager.inline.hpp + src/share/vm/memory/padded.hpp + src/share/vm/memory/padded.inline.hpp ! src/share/vm/utilities/debug.hpp ! src/share/vm/utilities/globalDefinitions.hpp Changeset: 330dfb0476f4 Author: brutisso Date: 2013-08-14 09:02 +0200 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/330dfb0476f4 8022800: Use specific generations rather than generation iteration Reviewed-by: jmasa, ehelin ! src/share/vm/gc_implementation/parNew/parNewGeneration.cpp ! src/share/vm/memory/cardTableRS.cpp ! src/share/vm/memory/cardTableRS.hpp ! src/share/vm/memory/defNewGeneration.cpp ! src/share/vm/memory/genCollectedHeap.cpp ! src/share/vm/memory/genCollectedHeap.hpp ! src/share/vm/memory/genMarkSweep.cpp ! src/share/vm/memory/genRemSet.hpp Changeset: 3f22cbf5275d Author: brutisso Date: 2013-08-14 10:55 +0200 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/3f22cbf5275d Merge Changeset: 5d9995d16b26 Author: ehelin Date: 2013-08-14 13:49 +0200 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/5d9995d16b26 8022899: SunStudio compiler can not handle EXCEPTION_MARK and inlining Reviewed-by: coleenp, mgerdin ! src/share/vm/utilities/exceptions.hpp Changeset: bd902affe102 Author: brutisso Date: 2013-08-15 10:05 +0200 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/bd902affe102 8023021: Unnecessary clearing of the card table introduced by the fix for JDK-8023013 Reviewed-by: stefank, ehelin ! src/share/vm/memory/cardTableRS.cpp ! src/share/vm/memory/cardTableRS.hpp ! src/share/vm/memory/genMarkSweep.cpp ! src/share/vm/memory/genRemSet.hpp Changeset: 274ce305e5b9 Author: ehelin Date: 2013-08-13 18:16 +0200 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/274ce305e5b9 8020598: ObjectCountEventSender::send needs INCLUDE_TRACE guards when building OpenJDK with INCLUDE_TRACE=0 Reviewed-by: stefank, brutisso, sjohanss ! src/share/vm/gc_implementation/shared/objectCountEventSender.cpp Changeset: 33d39b75663f Author: ehelin Date: 2013-08-15 06:20 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/33d39b75663f Merge Changeset: 5a62937e55b3 Author: brutisso Date: 2013-08-16 09:02 +0200 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/5a62937e55b3 Merge - src/os_cpu/bsd_x86/vm/bsd_x86_32.ad - src/os_cpu/bsd_x86/vm/bsd_x86_64.ad - src/os_cpu/linux_x86/vm/linux_x86_32.ad - src/os_cpu/linux_x86/vm/linux_x86_64.ad - src/os_cpu/solaris_sparc/vm/solaris_sparc.ad - src/os_cpu/solaris_x86/vm/solaris_x86_32.ad - src/os_cpu/solaris_x86/vm/solaris_x86_64.ad - src/os_cpu/windows_x86/vm/windows_x86_32.ad - src/os_cpu/windows_x86/vm/windows_x86_64.ad Changeset: 580430d131cc Author: amurillo Date: 2013-08-16 04:14 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/580430d131cc Merge - src/os_cpu/bsd_x86/vm/bsd_x86_32.ad - src/os_cpu/bsd_x86/vm/bsd_x86_64.ad - src/os_cpu/linux_x86/vm/linux_x86_32.ad - src/os_cpu/linux_x86/vm/linux_x86_64.ad - src/os_cpu/solaris_sparc/vm/solaris_sparc.ad - src/os_cpu/solaris_x86/vm/solaris_x86_32.ad - src/os_cpu/solaris_x86/vm/solaris_x86_64.ad - src/os_cpu/windows_x86/vm/windows_x86_32.ad - src/os_cpu/windows_x86/vm/windows_x86_64.ad Changeset: 104743074675 Author: amurillo Date: 2013-08-16 04:14 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/104743074675 Added tag hs25-b46 for changeset 580430d131cc ! .hgtags Changeset: c93e0a210e1b Author: cl Date: 2013-08-22 09:10 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/c93e0a210e1b Added tag jdk8-b104 for changeset 104743074675 ! .hgtags Changeset: 37165c3618a3 Author: amurillo Date: 2013-08-16 04:24 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/37165c3618a3 8023152: new hotspot build - hs25-b47 Reviewed-by: jcoomes ! make/hotspot_version Changeset: d96f52012aaa Author: rdurbin Date: 2013-08-14 15:12 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/d96f52012aaa 8005073: [TESTBUG] remove crufty '_g' support from HS tests Summary: remove crufty '_g' support from HS tests Reviewed-by: dcubed, sla ! test/Makefile Changeset: 740e263c80c6 Author: hseigel Date: 2013-08-15 20:04 -0400 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/740e263c80c6 8003424: Enable Class Data Sharing for CompressedOops 8016729: ObjectAlignmentInBytes=16 now forces the use of heap based compressed oops 8005933: The -Xshare:auto option is ignored for -server Summary: Move klass metaspace above the heap and support CDS with compressed klass ptrs. Reviewed-by: coleenp, kvn, mgerdin, tschatzl, stefank ! src/cpu/sparc/vm/macroAssembler_sparc.cpp ! src/cpu/sparc/vm/macroAssembler_sparc.hpp ! src/cpu/sparc/vm/relocInfo_sparc.cpp ! src/cpu/sparc/vm/sparc.ad ! src/cpu/sparc/vm/vtableStubs_sparc.cpp ! src/cpu/x86/vm/macroAssembler_x86.cpp ! src/cpu/x86/vm/macroAssembler_x86.hpp ! src/cpu/x86/vm/relocInfo_x86.cpp ! src/cpu/x86/vm/stubGenerator_x86_32.cpp ! src/cpu/x86/vm/stubGenerator_x86_64.cpp ! src/cpu/x86/vm/vtableStubs_x86_64.cpp ! src/cpu/x86/vm/x86_64.ad ! src/share/vm/memory/filemap.cpp ! src/share/vm/memory/filemap.hpp ! src/share/vm/memory/heap.cpp ! src/share/vm/memory/metaspace.cpp ! src/share/vm/memory/metaspace.hpp ! src/share/vm/memory/metaspaceShared.cpp ! src/share/vm/memory/universe.cpp ! src/share/vm/memory/universe.hpp ! src/share/vm/oops/klass.hpp ! src/share/vm/oops/klass.inline.hpp ! src/share/vm/oops/oop.hpp ! src/share/vm/oops/oop.inline.hpp ! src/share/vm/oops/oopsHierarchy.hpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/arguments.hpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/init.cpp ! src/share/vm/utilities/globalDefinitions.hpp + test/runtime/CDSCompressedKPtrs/CDSCompressedKPtrs.java + test/runtime/CDSCompressedKPtrs/CDSCompressedKPtrsError.java + test/runtime/CDSCompressedKPtrs/XShareAuto.java ! test/runtime/SharedArchiveFile/CdsSameObjectAlignment.java Changeset: e5003079dfa5 Author: dcubed Date: 2013-08-16 10:06 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/e5003079dfa5 Merge ! src/share/vm/utilities/globalDefinitions.hpp Changeset: b1fd869e7df0 Author: minqi Date: 2013-08-19 09:16 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/b1fd869e7df0 8023188: Unsafe volatile double store on bsd is broken Reviewed-by: dcubed, dholmes Contributed-by: yumin.qi at oracle.com ! src/os_cpu/bsd_x86/vm/orderAccess_bsd_x86.inline.hpp Changeset: 1a8fb39bdbc4 Author: ehelin Date: 2013-08-07 16:47 +0200 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/1a8fb39bdbc4 8014659: NPG: performance counters for compressed klass space Reviewed-by: mgerdin, coleenp, hseigel, jmasa, ctornqvi ! src/share/vm/gc_implementation/g1/g1MonitoringSupport.cpp ! src/share/vm/gc_implementation/parallelScavenge/parallelScavengeHeap.cpp ! src/share/vm/memory/genCollectedHeap.cpp ! src/share/vm/memory/metaspace.cpp ! src/share/vm/memory/metaspace.hpp ! src/share/vm/memory/metaspaceCounters.cpp ! src/share/vm/memory/metaspaceCounters.hpp ! src/share/vm/memory/universe.cpp + test/gc/metaspace/TestMetaspacePerfCounters.java + test/testlibrary/AssertsTest.java + test/testlibrary/com/oracle/java/testlibrary/Asserts.java + test/testlibrary/com/oracle/java/testlibrary/ByteCodeLoader.java + test/testlibrary/com/oracle/java/testlibrary/InMemoryJavaCompiler.java + test/testlibrary/com/oracle/java/testlibrary/InputArguments.java + test/testlibrary/com/oracle/java/testlibrary/PerfCounter.java + test/testlibrary/com/oracle/java/testlibrary/PerfCounters.java Changeset: 878bb0b7e799 Author: ehelin Date: 2013-08-19 17:29 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/878bb0b7e799 Merge Changeset: 10c59b8021ec Author: kevinw Date: 2013-08-19 14:28 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/10c59b8021ec 8022655: ClassDump ignored jarStream setting Reviewed-by: minqi, sla ! agent/src/share/classes/sun/jvm/hotspot/tools/jcore/ClassDump.java ! test/compiler/ciReplay/common.sh Changeset: 9011aa6843ce Author: kevinw Date: 2013-08-19 22:28 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/9011aa6843ce Merge Changeset: e22ee8e7ae62 Author: jiangli Date: 2013-08-19 14:59 -0400 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/e22ee8e7ae62 8021948: Change InstanceKlass::_source_file_name and _generic_signature from Symbol* to constant pool indexes. Summary: Change InstanceKlass::_source_file_name and _generic_signature to u2 fields. Reviewed-by: coleenp, iklam ! agent/src/share/classes/sun/jvm/hotspot/oops/InstanceKlass.java ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/classfile/classFileParser.hpp ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/oops/instanceKlass.hpp ! src/share/vm/prims/jvmtiRedefineClasses.cpp ! src/share/vm/runtime/vmStructs.cpp Changeset: aeebffb56606 Author: jiangli Date: 2013-08-20 00:48 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/aeebffb56606 Merge Changeset: 9d6c9b0a8f15 Author: dcubed Date: 2013-08-20 13:47 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/9d6c9b0a8f15 8023287: HOTSPOT_BUILD_COMPILER needs to support "Sun Studio 12u3" Summary: Recognize 0x5120 as "Sun Studio 12u3". Reviewed-by: dholmes, coleenp ! src/share/vm/runtime/vm_version.cpp Changeset: afbe18ae0905 Author: bharadwaj Date: 2013-08-15 11:59 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/afbe18ae0905 8022441: Bad code generated for certain interpreted CRC intrinsics, 2 cases Summary: Corrected details Reviewed-by: kvn, twisti, rbackman Contributed-by: david.r.chase at oracle.com ! src/cpu/x86/vm/templateInterpreter_x86_64.cpp Changeset: adb9a7d94cb5 Author: adlertz Date: 2013-08-16 10:23 +0200 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/adb9a7d94cb5 8023003: Cleanup the public interface to PhaseCFG Summary: public methods that don't need to be public should be private. Reviewed-by: kvn, twisti ! src/share/vm/opto/block.cpp ! src/share/vm/opto/block.hpp ! src/share/vm/opto/buildOopMap.cpp ! src/share/vm/opto/chaitin.cpp ! src/share/vm/opto/coalesce.cpp ! src/share/vm/opto/compile.cpp ! src/share/vm/opto/domgraph.cpp ! src/share/vm/opto/gcm.cpp ! src/share/vm/opto/idealGraphPrinter.cpp ! src/share/vm/opto/ifg.cpp ! src/share/vm/opto/lcm.cpp ! src/share/vm/opto/live.cpp ! src/share/vm/opto/matcher.cpp ! src/share/vm/opto/matcher.hpp ! src/share/vm/opto/output.cpp ! src/share/vm/opto/phaseX.cpp ! src/share/vm/opto/postaloc.cpp ! src/share/vm/opto/reg_split.cpp ! src/share/vm/runtime/vmStructs.cpp Changeset: 6c72125a2f40 Author: iignatyev Date: 2013-08-16 17:34 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/6c72125a2f40 8016456: ciReplay test assumes TIERED compilation is available Reviewed-by: vlivanov, kvn, dholmes ! test/compiler/ciReplay/common.sh Changeset: f99558245e5c Author: iignatyev Date: 2013-08-14 23:50 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/f99558245e5c 8022832: Add WB APIs for OSR compilation Reviewed-by: kvn ! src/share/vm/oops/method.cpp ! src/share/vm/prims/whitebox.cpp ! src/share/vm/runtime/compilationPolicy.cpp ! src/share/vm/runtime/compilationPolicy.hpp ! test/compiler/whitebox/ClearMethodStateTest.java ! test/compiler/whitebox/CompilerWhiteBoxTest.java ! test/compiler/whitebox/DeoptimizeAllTest.java ! test/compiler/whitebox/DeoptimizeMethodTest.java ! test/compiler/whitebox/EnqueueMethodForCompilationTest.java ! test/compiler/whitebox/IsMethodCompilableTest.java ! test/compiler/whitebox/MakeMethodNotCompilableTest.java ! test/compiler/whitebox/SetDontInlineMethodTest.java ! test/compiler/whitebox/SetForceInlineMethodTest.java ! test/testlibrary/whitebox/sun/hotspot/WhiteBox.java Changeset: d18b10b1fd09 Author: iignatyev Date: 2013-08-16 13:39 -0400 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/d18b10b1fd09 Merge Changeset: 4b2838704fd5 Author: kvn Date: 2013-08-16 14:11 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/4b2838704fd5 8021898: Broken JIT compiler optimization for loop unswitching Summary: fix method clone_projs() to clone all related MachProj nodes. Reviewed-by: roland, adlertz ! src/share/vm/opto/chaitin.cpp ! src/share/vm/opto/chaitin.hpp ! src/share/vm/opto/coalesce.cpp ! src/share/vm/opto/reg_split.cpp ! src/share/vm/runtime/frame.cpp ! src/share/vm/utilities/vmError.cpp Changeset: 6725044c5725 Author: rbackman Date: 2013-08-19 09:33 +0200 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/6725044c5725 Merge ! src/cpu/x86/vm/templateInterpreter_x86_64.cpp ! src/share/vm/oops/method.cpp Changeset: e16282db4946 Author: twisti Date: 2013-08-20 10:57 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/e16282db4946 8022956: Clang: enable return type warnings on BSD Reviewed-by: coleenp, sla ! make/bsd/makefiles/gcc.make ! src/cpu/zero/vm/assembler_zero.cpp ! src/cpu/zero/vm/cppInterpreter_zero.cpp ! src/cpu/zero/vm/frame_zero.cpp ! src/cpu/zero/vm/frame_zero.inline.hpp ! src/cpu/zero/vm/icBuffer_zero.cpp ! src/cpu/zero/vm/interp_masm_zero.hpp ! src/cpu/zero/vm/interpreter_zero.cpp ! src/cpu/zero/vm/nativeInst_zero.hpp ! src/cpu/zero/vm/register_zero.cpp ! src/cpu/zero/vm/relocInfo_zero.cpp ! src/cpu/zero/vm/sharedRuntime_zero.cpp ! src/cpu/zero/vm/vtableStubs_zero.cpp ! src/os_cpu/bsd_x86/vm/os_bsd_x86.cpp ! src/os_cpu/bsd_zero/vm/os_bsd_zero.cpp ! src/os_cpu/bsd_zero/vm/thread_bsd_zero.hpp Changeset: acedd49a1bce Author: rbackman Date: 2013-08-08 03:16 +0200 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/acedd49a1bce 8022675: Redundant class init check Reviewed-by: kvn, twisti ! src/share/vm/opto/library_call.cpp Changeset: 4dece0730c50 Author: rbackman Date: 2013-08-22 18:37 +0200 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/4dece0730c50 Merge ! src/share/vm/runtime/vmStructs.cpp ! test/compiler/ciReplay/common.sh Changeset: 5888334c9c24 Author: johnc Date: 2013-08-15 10:52 +0200 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/5888334c9c24 7145569: G1: optimize nmethods scanning Summary: Add a list of nmethods to the RSet for a region that contain references into the region. Skip scanning the code cache during root scanning and scan the nmethod lists during RSet scanning instead. Reviewed-by: tschatzl, brutisso, mgerdin, twisti, kvn ! src/share/vm/c1/c1_Runtime1.cpp ! src/share/vm/code/nmethod.cpp ! src/share/vm/code/nmethod.hpp ! src/share/vm/gc_implementation/g1/concurrentMark.cpp ! src/share/vm/gc_implementation/g1/concurrentMark.hpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp ! src/share/vm/gc_implementation/g1/g1GCPhaseTimes.cpp ! src/share/vm/gc_implementation/g1/g1GCPhaseTimes.hpp ! src/share/vm/gc_implementation/g1/g1RemSet.cpp ! src/share/vm/gc_implementation/g1/g1RemSet.hpp ! src/share/vm/gc_implementation/g1/g1RemSetSummary.cpp ! src/share/vm/gc_implementation/g1/g1_globals.hpp ! src/share/vm/gc_implementation/g1/heapRegion.cpp ! src/share/vm/gc_implementation/g1/heapRegion.hpp ! src/share/vm/gc_implementation/g1/heapRegionRemSet.cpp ! src/share/vm/gc_implementation/g1/heapRegionRemSet.hpp ! src/share/vm/gc_interface/collectedHeap.cpp ! src/share/vm/gc_interface/collectedHeap.hpp ! src/share/vm/memory/iterator.cpp ! src/share/vm/runtime/sweeper.hpp ! src/share/vm/utilities/growableArray.hpp Changeset: 8088d93a63e6 Author: brutisso Date: 2013-08-15 13:02 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/8088d93a63e6 Merge Changeset: 9720d338b1d5 Author: brutisso Date: 2013-08-16 11:26 +0200 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/9720d338b1d5 8023145: G1: G1CollectedHeap::mark_strong_code_roots() needs to handle ParallelGCThreads=0 Reviewed-by: stefank, mgerdin ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp Changeset: d0afbee540e0 Author: stefank Date: 2013-08-19 13:44 +0200 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/d0afbee540e0 8023227: Enhance layout_helper_log2_element_size assert Reviewed-by: mgerdin, jmasa ! src/share/vm/oops/klass.hpp Changeset: 422920730903 Author: ehelin Date: 2013-08-19 18:17 +0200 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/422920730903 8023219: NPG: MetaspaceMemoryPool should report statistics for all of metaspace Reviewed-by: stefank, sjohanss ! src/share/vm/services/memoryPool.cpp Changeset: 57600c4aeabe Author: jmasa Date: 2013-08-19 08:58 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/57600c4aeabe Merge - src/os_cpu/bsd_x86/vm/bsd_x86_32.ad - src/os_cpu/bsd_x86/vm/bsd_x86_64.ad - src/os_cpu/linux_x86/vm/linux_x86_32.ad - src/os_cpu/linux_x86/vm/linux_x86_64.ad - src/os_cpu/solaris_sparc/vm/solaris_sparc.ad - src/os_cpu/solaris_x86/vm/solaris_x86_32.ad - src/os_cpu/solaris_x86/vm/solaris_x86_64.ad - src/os_cpu/windows_x86/vm/windows_x86_32.ad - src/os_cpu/windows_x86/vm/windows_x86_64.ad Changeset: 31f220c1f789 Author: jmasa Date: 2013-08-20 10:02 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/31f220c1f789 Merge Changeset: 61521bd65100 Author: tschatzl Date: 2013-08-21 10:32 +0200 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/61521bd65100 8022784: TaskQueue misses minimal documentation and references for analysis Summary: Add appropriate documentation and references to publication to allow easier analysis of the TaskQueue implementation. Reviewed-by: dholmes, ehelin ! src/share/vm/utilities/taskqueue.hpp Changeset: cb9da55b1990 Author: jmasa Date: 2013-08-14 19:52 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/cb9da55b1990 8021809: Partitioning based on eden sampling during allocation not reset correctly Reviewed-by: ysr, hiroshi ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp Changeset: b51aee2dd8bb Author: jmasa Date: 2013-08-22 11:13 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/b51aee2dd8bb Merge ! src/share/vm/oops/klass.hpp Changeset: 8009adb44523 Author: jmasa Date: 2013-08-22 14:03 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/8009adb44523 Merge Changeset: c1604d5885a6 Author: amurillo Date: 2013-08-23 03:01 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/c1604d5885a6 Merge Changeset: acac3bde66b2 Author: amurillo Date: 2013-08-23 03:01 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/acac3bde66b2 Added tag hs25-b47 for changeset c1604d5885a6 ! .hgtags From lana.steuck at oracle.com Wed Aug 28 00:13:43 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 28 Aug 2013 07:13:43 +0000 Subject: hg: jdk8/awt/langtools: 30 new changesets Message-ID: <20130828071625.431B248C19@hg.openjdk.java.net> Changeset: dd4a00c220c6 Author: cl Date: 2013-08-15 09:26 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/dd4a00c220c6 Added tag jdk8-b103 for changeset 76cfe7c61f25 ! .hgtags Changeset: f2ee3a4e7927 Author: cl Date: 2013-08-22 09:10 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/f2ee3a4e7927 Added tag jdk8-b104 for changeset dd4a00c220c6 ! .hgtags Changeset: b8610a65fbf9 Author: vromero Date: 2013-08-08 11:49 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/b8610a65fbf9 8019486: javac, generates erroneous LVT for a test case with lambda code Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java + test/tools/javac/T8019486/WrongLVTForLambdaTest.java Changeset: d601238641e6 Author: ksrini Date: 2013-08-09 15:01 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/d601238641e6 8022161: javac Null Pointer Exception in Enter.visitTopLevel Reviewed-by: jjg, vromero, jlahoda ! src/share/classes/com/sun/tools/javac/comp/Enter.java ! test/tools/javac/TestPkgInfo.java Changeset: 0d9bc764cac7 Author: vromero Date: 2013-08-10 13:27 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/0d9bc764cac7 8009640: -profile does not work when -bootclasspath specified Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/main/Main.java ! src/share/classes/com/sun/tools/javac/resources/javac.properties + test/tools/javac/T8009640/CheckRejectProfileBCPOptionsIfUsedTogetherTest.java Changeset: 8f282dc58dfc Author: vromero Date: 2013-08-10 16:26 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/8f282dc58dfc 8022622: javac, two tests are failing with compile time error after class Collector was modified Reviewed-by: mcimadamore ! test/tools/javac/lambda/TargetType59.java ! test/tools/javac/lambda/TargetType62.java Changeset: aa6c6f8b5622 Author: vromero Date: 2013-08-10 16:29 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/aa6c6f8b5622 6983297: methods missing from NewArrayTree Reviewed-by: jjg ! src/share/classes/com/sun/source/tree/NewArrayTree.java ! src/share/classes/com/sun/source/util/TreeScanner.java ! src/share/classes/com/sun/tools/javac/tree/JCTree.java ! test/tools/javac/tree/SourceTreeScannerTest.java Changeset: f7f271bd74a2 Author: mcimadamore Date: 2013-08-12 17:25 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/f7f271bd74a2 6537020: JCK tests: a compile-time error should be given in case of ambiguously imported fields (types, methods) Summary: Hiding check does not support interface multiple inheritance Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Scope.java ! src/share/classes/com/sun/tools/javac/code/Symbol.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/comp/MemberEnter.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! test/tools/javac/4980495/static/Test.out ! test/tools/javac/diags/examples/AlreadyDefinedStaticImport/AlreadDefinedStaticImport.java ! test/tools/javac/diags/examples/AlreadyDefinedStaticImport/p/E1.java ! test/tools/javac/diags/examples/AlreadyDefinedStaticImport/p/E2.java + test/tools/javac/staticImport/6537020/T6537020.java + test/tools/javac/staticImport/6537020/T6537020.out Changeset: af80273f630a Author: mcimadamore Date: 2013-08-12 17:28 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/af80273f630a 8021567: Javac doesn't report \"java: reference to method is ambiguous\" any more Summary: Javac incorrectly forgets about constant folding results within lambdas Reviewed-by: jjg, vromero ! src/share/classes/com/sun/tools/javac/code/Type.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java + test/tools/javac/lambda/8021567/T8021567.java + test/tools/javac/lambda/8021567/T8021567.out + test/tools/javac/lambda/8021567/T8021567b.java Changeset: 32b6a99cc74e Author: lana Date: 2013-08-13 18:34 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/32b6a99cc74e Merge Changeset: 0ad781399706 Author: vromero Date: 2013-08-14 10:53 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/0ad781399706 8013394: compile of iterator use fails with error \"defined in an inaccessible class or interface\" Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/comp/Lower.java + test/tools/javac/T8013394/CompileErrorWithIteratorTest.java Changeset: 3ab468194f11 Author: ksrini Date: 2013-08-14 07:07 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/3ab468194f11 8007517: DefaultMethodRegressionTests.java fail in TL Reviewed-by: jjg, vromero - test/tools/javac/defaultMethods/defaultMethodExecution/DefaultMethodRegressionTests.java Changeset: 14faef2b51eb Author: jjg Date: 2013-08-14 16:41 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/14faef2b51eb 8017191: Javadoc is confused by @link to imported classes outside of the set of generated packages Reviewed-by: bpatel ! src/share/classes/com/sun/tools/doclets/formats/html/LinkFactoryImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/StringContent.java + test/com/sun/javadoc/testSeeTag/TestSeeTag.java + test/com/sun/javadoc/testSeeTag/pkg/Test.java Changeset: fac0d1bb87f2 Author: ksrini Date: 2013-08-14 18:58 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/fac0d1bb87f2 6840442: JavaCompiler.getTask() has incomplete specification for IllegalArgumentException Reviewed-by: jjg ! src/share/classes/javax/tools/JavaCompiler.java Changeset: 3d4f0fa2ad05 Author: bpatel Date: 2013-08-14 21:44 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/3d4f0fa2ad05 8016921: Change the profiles table on overview-summary.html page to a list Reviewed-by: jjg ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractPackageIndexWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageIndexWriter.java ! test/com/sun/javadoc/testProfiles/TestProfiles.java Changeset: 71b0089b146f Author: erikj Date: 2013-08-15 17:24 +0200 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/71b0089b146f 8015145: Smartjavac needs more flexibility with linking to sources Reviewed-by: jjg, ohrstrom ! src/share/classes/com/sun/tools/sjavac/JavacState.java ! src/share/classes/com/sun/tools/sjavac/Main.java ! test/tools/sjavac/SJavac.java Changeset: a6378c19836b Author: vromero Date: 2013-08-16 10:32 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/a6378c19836b 8022053: javac generates unverifiable initializer for nested subclass of local class Reviewed-by: jjg, mcimadamore ! src/share/classes/com/sun/tools/javac/comp/Lower.java + test/tools/javac/T8022053/UnverifiableInitForNestedLocalClassTest.java Changeset: ec77c7b46c37 Author: jlahoda Date: 2013-08-15 22:33 +0200 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/ec77c7b46c37 8015809: More user friendly compile-time errors for uncaught exceptions in lambda expression Summary: Producing individual errors for uncaught undeclared exceptions inside lambda expressions, rather than one error for the whole lambda Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/code/Type.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Flow.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! src/share/classes/com/sun/tools/javac/tree/JCTree.java - test/tools/javac/diags/examples/IncompatibleThrownTypesInLambda.java + test/tools/javac/lambda/ExceptionsInLambda.java + test/tools/javac/lambda/ExceptionsInLambda.out ! test/tools/javac/lambda/TargetType21.out Changeset: f657d400c736 Author: jlahoda Date: 2013-08-15 22:36 +0200 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/f657d400c736 8022508: javac crashes if the generics arity of a base class is wrong Reviewed-by: mcimadamore, vromero ! src/share/classes/com/sun/tools/javac/comp/Check.java ! test/tools/javac/generics/8016640/T8016640.java Changeset: 4300c2f5fb1b Author: erikj Date: 2013-08-16 16:00 +0200 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/4300c2f5fb1b 8023146: Sjavac test failes in langtools nightly Reviewed-by: mcimadamore, jfranck ! test/tools/sjavac/SJavac.java Changeset: 389eaf6ed973 Author: ksrini Date: 2013-08-19 07:47 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/389eaf6ed973 7071377: Exception when javac -processor is given a class name with invalid postfix Reviewed-by: jjg, vromero ! src/share/classes/com/sun/tools/javac/comp/Attr.java + test/tools/javac/processing/errors/TestClassNames.java Changeset: 55da6b3a6940 Author: kizune Date: 2013-08-20 17:34 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/55da6b3a6940 7182350: Regression in wording of unchecked warning message Reviewed-by: mcimadamore, jjg ! src/share/classes/com/sun/tools/javac/comp/Check.java ! test/tools/javac/6758789/T6758789b.out + test/tools/javac/7182350/T7182350.java + test/tools/javac/7182350/T7182350.out ! test/tools/javac/generics/7015430/T7015430_1.out ! test/tools/javac/generics/7015430/T7015430_2.out ! test/tools/javac/generics/7151802/T7151802.out ! test/tools/javac/generics/inference/6718364/T6718364.out ! test/tools/javac/generics/inference/7177306/T7177306a.out Changeset: e811fb09a1dc Author: jfranck Date: 2013-08-20 17:21 +0200 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/e811fb09a1dc 8019243: AnnotationTypeMismatchException instead of MirroredTypeException Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Attribute.java ! src/share/classes/com/sun/tools/javac/comp/Annotate.java ! src/share/classes/com/sun/tools/javac/model/AnnotationProxyMaker.java + test/tools/javac/processing/errors/EnsureMirroredTypeException/Processor.java + test/tools/javac/processing/errors/EnsureMirroredTypeException/Source.java + test/tools/javac/processing/errors/EnsureMirroredTypeException/Source.out Changeset: 58da1296c6b3 Author: darcy Date: 2013-08-20 12:15 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/58da1296c6b3 8011043: Warn about use of 1.5 and earlier source and target values Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! src/share/classes/com/sun/tools/javadoc/Start.java + test/tools/javac/diags/examples/ObsoleteSourceAndTarget.java Changeset: 0f88e3d3d250 Author: ksrini Date: 2013-08-20 14:15 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/0f88e3d3d250 7179455: tools/javac/processing/model/testgetallmembers/Main.java fails against JDK 7 and JDK 8 Reviewed-by: jjg ! test/tools/javac/processing/model/testgetallmembers/Main.java Changeset: a76dc1b4c299 Author: jjg Date: 2013-08-20 14:46 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/a76dc1b4c299 8020663: Restructure some properties to facilitate better translation Reviewed-by: darcy ! src/share/classes/com/sun/tools/doclets/internal/toolkit/resources/doclets.properties ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/Util.java Changeset: 79e341614c50 Author: jjg Date: 2013-08-20 14:55 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/79e341614c50 8022080: javadoc generates invalid HTML in Turkish locale Reviewed-by: bpatel ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlTag.java ! src/share/classes/com/sun/tools/doclint/HtmlTag.java Changeset: 720992953d43 Author: jjg Date: 2013-08-20 15:12 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/720992953d43 8013887: In class use, some tables are randomly unsorted Reviewed-by: bpatel ! src/share/classes/com/sun/tools/doclets/formats/html/ClassUseWriter.java Changeset: b59a0b4675c9 Author: lana Date: 2013-08-20 17:46 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/b59a0b4675c9 Merge - test/tools/javac/defaultMethods/defaultMethodExecution/DefaultMethodRegressionTests.java - test/tools/javac/diags/examples/IncompatibleThrownTypesInLambda.java Changeset: 375834b5cf08 Author: lana Date: 2013-08-23 14:17 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/375834b5cf08 Merge - test/tools/javac/defaultMethods/defaultMethodExecution/DefaultMethodRegressionTests.java - test/tools/javac/diags/examples/IncompatibleThrownTypesInLambda.java From lana.steuck at oracle.com Wed Aug 28 00:16:29 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 28 Aug 2013 07:16:29 +0000 Subject: hg: jdk8/awt/jdk: 87 new changesets Message-ID: <20130828073438.55F7C48C1E@hg.openjdk.java.net> Changeset: f1d8d15bfcb5 Author: cl Date: 2013-08-15 09:25 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/f1d8d15bfcb5 Added tag jdk8-b103 for changeset e0f6039c0290 ! .hgtags Changeset: c982f579b67e Author: cl Date: 2013-08-22 09:10 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/c982f579b67e Added tag jdk8-b104 for changeset f1d8d15bfcb5 ! .hgtags Changeset: 2722f4000b65 Author: jgodinez Date: 2013-08-15 11:56 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/2722f4000b65 8023045: [MacOSX] PrinterIOException when printing a JComponent Reviewed-by: bae, jchen ! src/share/classes/sun/print/PSPrinterJob.java Changeset: b44ce67c0565 Author: vadim Date: 2013-08-16 15:57 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/b44ce67c0565 8013446: [parfait] Memory leak in jdk/src/windows/native/sun/java2d/opengl/WGLSurfaceData.c Reviewed-by: bae, prr ! src/windows/native/sun/java2d/opengl/WGLSurfaceData.c Changeset: dadd43e02a79 Author: prr Date: 2013-08-19 03:58 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/dadd43e02a79 8017580: Crash in font loading code on Linux (due to use of reflection) Reviewed-by: bae, vadim ! src/share/native/sun/font/sunFont.c ! src/share/native/sun/font/sunfontids.h Changeset: 0c950b2be7ab Author: jgodinez Date: 2013-08-19 11:21 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/0c950b2be7ab 8022241: [macosx] [PIT] lookupPrintServices() returns one too long array Reviewed-by: prr, jchen ! src/solaris/classes/sun/print/UnixPrintServiceLookup.java Changeset: 64be71ae6185 Author: lana Date: 2013-08-20 17:35 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/64be71ae6185 Merge Changeset: fefa29e15a14 Author: lana Date: 2013-08-20 17:38 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/fefa29e15a14 Merge Changeset: 0beaa65c90c8 Author: okutsu Date: 2013-08-08 13:51 +0900 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/0beaa65c90c8 8015986: Incorrect Localization of HijrahChronology Reviewed-by: naoto Contributed-by: scolebourne at joda.org, roger.riggs at oracle.com ! make/tools/src/build/tools/cldrconverter/CLDRConverter.java ! make/tools/src/build/tools/cldrconverter/CalendarType.java ! src/share/classes/sun/text/resources/FormatData.java ! src/share/classes/sun/text/resources/ar/FormatData_ar.java ! test/java/time/test/java/time/format/TestNonIsoFormatter.java Changeset: 2c4f1081a0fa Author: uta Date: 2013-08-08 09:16 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/2c4f1081a0fa 7147084: (process) appA hangs when read output stream of appB which starts appC that runs forever Reviewed-by: alanb, robm, martin ! src/windows/classes/java/lang/ProcessImpl.java ! src/windows/native/java/lang/ProcessImpl_md.c + test/java/lang/ProcessBuilder/InheritIOEHandle.java + test/java/lang/ProcessBuilder/SiblingIOEHandle.java Changeset: b7d594716f86 Author: weijun Date: 2013-08-08 21:13 +0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/b7d594716f86 8016594: Native Windows ccache still reads DES tickets Reviewed-by: dsamersoff, xuelei ! src/share/classes/sun/security/krb5/Credentials.java ! src/share/native/sun/security/krb5/nativeccache.c ! src/windows/native/sun/security/krb5/NativeCreds.c Changeset: a388263a7287 Author: sherman Date: 2013-08-08 12:03 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/a388263a7287 8015666: test/tools/pack200/TimeStamp.java failing Summary: to keep the default behavior of ZOS unchanged, if ze extra time not explicitly set Reviewed-by: alanb, ksrini ! src/share/classes/java/util/zip/ZipConstants.java ! src/share/classes/java/util/zip/ZipEntry.java ! src/share/classes/java/util/zip/ZipFile.java ! src/share/classes/java/util/zip/ZipInputStream.java ! src/share/classes/java/util/zip/ZipOutputStream.java ! src/share/classes/java/util/zip/ZipUtils.java ! test/ProblemList.txt ! test/java/util/zip/TestExtraTime.java ! test/tools/pack200/TimeStamp.java Changeset: 67edbf7e6b26 Author: juh Date: 2013-08-08 17:06 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/67edbf7e6b26 8022461: Fix lint warnings in sun.security.{provider,rsa,x509} Reviewed-by: darcy, weijun, xuelei, mullan ! src/share/classes/sun/security/provider/DSAPublicKey.java ! src/share/classes/sun/security/rsa/RSAPublicKeyImpl.java ! src/share/classes/sun/security/rsa/RSASignature.java ! src/share/classes/sun/security/x509/AlgIdDSA.java ! src/share/classes/sun/security/x509/X509Key.java Changeset: 758e3117899c Author: weijun Date: 2013-08-09 11:41 +0800 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/758e3117899c 8021788: JarInputStream doesn't provide certificates for some file under META-INF Reviewed-by: chegar, sherman ! src/share/classes/java/util/jar/JarVerifier.java + test/java/util/jar/JarInputStream/ExtraFileInMetaInf.java Changeset: 54f0ccdd9ad7 Author: sherman Date: 2013-08-08 23:40 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/54f0ccdd9ad7 6614237: missing codepage Cp290 at java runtime Summary: to add charset Cp290 and Cp300 Reviewed-by: okutsu + make/tools/CharsetMapping/IBM290.c2b + make/tools/CharsetMapping/IBM290.map + make/tools/CharsetMapping/IBM300.c2b + make/tools/CharsetMapping/IBM300.map ! make/tools/CharsetMapping/dbcs ! make/tools/CharsetMapping/extsbcs ! make/tools/src/build/tools/charsetmapping/DBCS.java ! src/share/classes/sun/nio/cs/ext/ExtendedCharsets.java Changeset: c29ca19cb816 Author: psandoz Date: 2013-08-09 11:44 +0200 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/c29ca19cb816 8022326: Spliterator for values of j.u.c.ConcurrentSkipListMap does not report ORDERED Reviewed-by: martin, chegar ! src/share/classes/java/util/TreeMap.java ! src/share/classes/java/util/concurrent/ConcurrentSkipListMap.java ! test/java/util/Spliterator/SpliteratorCharacteristics.java Changeset: 84004d0e3fdd Author: chegar Date: 2013-08-09 13:50 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/84004d0e3fdd 8022661: InetAddress.writeObject() performs flush() on object output stream Reviewed-by: michaelm, alanb ! src/share/classes/java/net/InetAddress.java Changeset: ce1c874903cb Author: dl Date: 2013-08-09 17:56 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/ce1c874903cb 8022724: lint warnings in j.u.concurrent packages Reviewed-by: chegar, lancea, darcy ! src/share/classes/java/util/concurrent/CompletableFuture.java ! src/share/classes/java/util/concurrent/ConcurrentHashMap.java ! src/share/classes/java/util/concurrent/atomic/Striped64.java Changeset: 03822f2389bf Author: dxu Date: 2013-08-09 10:55 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/03822f2389bf 8021977: Opening a file using java.io can throw IOException on Windows Summary: Remove IOException related error-handling code for backward compatibility Reviewed-by: alanb, lancea, mr ! src/windows/native/java/io/io_util_md.c Changeset: a7c341f30747 Author: sherman Date: 2013-08-09 12:40 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/a7c341f30747 8020054: (tz) Support tzdata2013d Summary: update the jdk8 tz data to version 2013d Reviewed-by: coffeys, peytoia ! make/sun/javazic/tzdata/VERSION ! make/sun/javazic/tzdata/africa ! make/sun/javazic/tzdata/antarctica ! make/sun/javazic/tzdata/asia ! make/sun/javazic/tzdata/australasia ! make/sun/javazic/tzdata/backward ! make/sun/javazic/tzdata/etcetera ! make/sun/javazic/tzdata/europe ! make/sun/javazic/tzdata/factory ! make/sun/javazic/tzdata/iso3166.tab ! make/sun/javazic/tzdata/leapseconds ! make/sun/javazic/tzdata/northamerica ! make/sun/javazic/tzdata/pacificnew ! make/sun/javazic/tzdata/solar87 ! make/sun/javazic/tzdata/solar88 ! make/sun/javazic/tzdata/solar89 ! make/sun/javazic/tzdata/southamerica ! make/sun/javazic/tzdata/systemv ! make/sun/javazic/tzdata/zone.tab ! test/sun/util/calendar/zi/tzdata/VERSION ! test/sun/util/calendar/zi/tzdata/africa ! test/sun/util/calendar/zi/tzdata/antarctica ! test/sun/util/calendar/zi/tzdata/asia ! test/sun/util/calendar/zi/tzdata/australasia ! test/sun/util/calendar/zi/tzdata/backward ! test/sun/util/calendar/zi/tzdata/etcetera ! test/sun/util/calendar/zi/tzdata/europe ! test/sun/util/calendar/zi/tzdata/factory ! test/sun/util/calendar/zi/tzdata/iso3166.tab ! test/sun/util/calendar/zi/tzdata/leapseconds ! test/sun/util/calendar/zi/tzdata/northamerica ! test/sun/util/calendar/zi/tzdata/pacificnew ! test/sun/util/calendar/zi/tzdata/solar87 ! test/sun/util/calendar/zi/tzdata/solar88 ! test/sun/util/calendar/zi/tzdata/solar89 ! test/sun/util/calendar/zi/tzdata/southamerica ! test/sun/util/calendar/zi/tzdata/systemv ! test/sun/util/calendar/zi/tzdata/zone.tab Changeset: 8f01ccb0c981 Author: joehw Date: 2013-08-09 12:53 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/8f01ccb0c981 8022548: SPECJVM2008 has errors introduced in 7u40-b34 Reviewed-by: chegar, lancea + test/javax/xml/jaxp/parsers/8022548/JDK8022548.xml + test/javax/xml/jaxp/parsers/8022548/JDK8022548.xsl + test/javax/xml/jaxp/parsers/8022548/TestBase.java + test/javax/xml/jaxp/parsers/8022548/XOMParserTest.java Changeset: ea4f4164422e Author: xuelei Date: 2013-08-11 18:21 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/ea4f4164422e 8022487: DEREncodedKeyValue.supportedKeyTypes should be private Reviewed-by: mullan ! src/share/classes/com/sun/org/apache/xml/internal/security/keys/content/DEREncodedKeyValue.java Changeset: ffacf3e7a130 Author: mullan Date: 2013-08-12 09:03 -0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/ffacf3e7a130 8016848: javax_security/auth/login tests fail in compact 1 and 2 profiles Summary: Change the default value of the "login.configuration.provider" security property to sun.security.provider.ConfigFile Reviewed-by: xuelei ! src/share/classes/com/sun/security/auth/login/ConfigFile.java ! src/share/classes/javax/security/auth/login/Configuration.java + src/share/classes/sun/security/provider/ConfigFile.java - src/share/classes/sun/security/provider/ConfigSpiFile.java ! src/share/classes/sun/security/provider/SunEntries.java ! src/share/lib/security/java.security-linux ! src/share/lib/security/java.security-macosx ! src/share/lib/security/java.security-solaris ! src/share/lib/security/java.security-windows Changeset: d73fbf005f5f Author: mullan Date: 2013-08-12 09:29 -0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/d73fbf005f5f Merge - src/share/classes/java/net/package.html - test/java/lang/System/MacJNUEncoding/ExpectedEncoding.java - test/java/lang/System/MacJNUEncoding/MacJNUEncoding.sh Changeset: 70c8f4a4b8d6 Author: vromero Date: 2013-08-12 17:40 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/70c8f4a4b8d6 8015780: java/lang/reflect/Method/GenericStringTest.java failing Reviewed-by: darcy, jfranck ! test/ProblemList.txt ! test/java/lang/reflect/Method/GenericStringTest.java Changeset: 7758bcf0ab6b Author: henryjen Date: 2013-08-12 12:11 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/7758bcf0ab6b 8022749: Convert junit tests to testng in test/java/lang/invoke Reviewed-by: mduigou, alanb Contributed-by: Mani Sarkar ! test/java/lang/invoke/AccessControlTest.java ! test/java/lang/invoke/ClassValueTest.java ! test/java/lang/invoke/InvokeGenericTest.java ! test/java/lang/invoke/JavaDocExamplesTest.java ! test/java/lang/invoke/MethodTypeTest.java ! test/java/lang/invoke/PermuteArgsTest.java ! test/java/lang/invoke/ThrowExceptionsTest.java Changeset: cc64a05836a7 Author: lancea Date: 2013-08-12 16:09 -0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/cc64a05836a7 8022753: SQLXML javadoc example typo Reviewed-by: alanb, mchung ! src/share/classes/java/sql/SQLXML.java Changeset: 5b14d702b0b8 Author: ascarpino Date: 2013-08-12 11:25 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/5b14d702b0b8 8020081: Cipher with OAEPPadding and OAEPParameterSpec can't be created Reviewed-by: mullan ! src/share/classes/com/sun/crypto/provider/SunJCE.java + test/com/sun/crypto/provider/Cipher/RSA/TestOAEPPadding.java Changeset: 818c3f82269c Author: vinnie Date: 2013-08-13 14:15 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/818c3f82269c 8013170: Spec for PBEParameterSpec does not specify behavior when paramSpec is null Reviewed-by: mullan ! src/share/classes/javax/crypto/spec/PBEParameterSpec.java Changeset: 26753a05859a Author: vinnie Date: 2013-08-13 14:18 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/26753a05859a Merge Changeset: 834faf2081b3 Author: bpb Date: 2013-08-12 16:21 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/834faf2081b3 8022180: BigInteger Burnikel-Ziegler quotient and remainder calculation assumes quotient parameter is zero Summary: Clear the quotient in divideAndRemainderBurnikelZiegler() if the divisor is larger than the dividend. Reviewed-by: alanb, bpb Contributed-by: Timothy Buktu ! src/share/classes/java/math/MutableBigInteger.java ! test/java/math/BigInteger/BigIntegerTest.java Changeset: 18e15d92610b Author: chegar Date: 2013-08-13 14:57 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/18e15d92610b 8022779: ProblemList.txt updates (8/2013) Summary: Update ProblemList and remove AggressiveOpts MOAT test run Reviewed-by: chegar, alanb Contributed-by: Amy Lu ! test/ProblemList.txt ! test/java/util/Collection/MOAT.java Changeset: 78c102c3eefc Author: dfuchs Date: 2013-08-13 16:00 +0200 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/78c102c3eefc 8019948: java/util/logging/bundlesearch/ResourceBundleSearchTest.java is failing intermittently Reviewed-by: mchung, dholmes ! test/java/util/logging/bundlesearch/ResourceBundleSearchTest.java Changeset: 412b2f0950a9 Author: mullan Date: 2013-08-13 10:06 -0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/412b2f0950a9 8022897: Add test/com/sun/crypto/provider/Cipher/RSA/TestOAEPPadding.java to ProblemList Reviewed-by: vinnie, chegar ! test/ProblemList.txt Changeset: 19133b3af95f Author: mullan Date: 2013-08-13 10:07 -0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/19133b3af95f Merge ! test/ProblemList.txt Changeset: cd9379e348d0 Author: darcy Date: 2013-08-13 10:12 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/cd9379e348d0 8022959: Fix new doclint issues in java.util.zip Reviewed-by: chegar ! src/share/classes/java/util/zip/ZipEntry.java Changeset: a4b0be7341ef Author: robm Date: 2013-08-13 19:10 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/a4b0be7341ef 5049299: (process) Use posix_spawn, not fork, on S10 to avoid swap exhaustion Reviewed-by: alanb, dholmes, martin, erikj, coffeys ! make/java/java/Exportedfiles.gmk ! make/java/java/Makefile ! makefiles/CompileLaunchers.gmk ! makefiles/CompileNativeLibraries.gmk ! src/solaris/classes/java/lang/UNIXProcess.java.bsd ! src/solaris/classes/java/lang/UNIXProcess.java.linux ! src/solaris/classes/java/lang/UNIXProcess.java.solaris ! src/solaris/native/java/lang/UNIXProcess_md.c + src/solaris/native/java/lang/childproc.c + src/solaris/native/java/lang/childproc.h + src/solaris/native/java/lang/jspawnhelper.c ! test/java/lang/ProcessBuilder/Basic.java Changeset: 18ce880b5fb4 Author: lana Date: 2013-08-13 18:33 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/18ce880b5fb4 Merge ! makefiles/CompileNativeLibraries.gmk Changeset: cb74d71fd02f Author: hseigel Date: 2013-08-13 10:56 -0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/cb74d71fd02f 8022259: MakeClasslist is buggy and its README is out of date. Summary: Fixed bug in FOR loop and updated comments and README Reviewed-by: dholmes, alanb ! make/tools/sharing/README.txt ! make/tools/src/build/tools/makeclasslist/MakeClasslist.java Changeset: f9cf6ecf596c Author: coleenp Date: 2013-08-14 10:14 -0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/f9cf6ecf596c Merge Changeset: bc3cafb17c09 Author: ksrini Date: 2013-08-14 08:12 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/bc3cafb17c09 8022547: [verifier] move DefaultMethodRegressionTests.java to jdk Reviewed-by: acorn + test/vm/verifier/defaultMethods/DefaultMethodRegressionTests.java + test/vm/verifier/defaultMethods/DefaultMethodRegressionTestsRun.java Changeset: 444a7edcf367 Author: darcy Date: 2013-08-14 11:26 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/444a7edcf367 8022990: Fix dep_ann lint warnings in swing code Reviewed-by: alexsch ! src/share/classes/com/sun/java/swing/Painter.java ! src/share/classes/com/sun/java/swing/plaf/nimbus/AbstractRegionPainter.java ! src/share/classes/com/sun/java/swing/plaf/nimbus/NimbusLookAndFeel.java Changeset: c138d1b608e0 Author: sherman Date: 2013-08-14 11:42 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/c138d1b608e0 8022178: System.console() throws IOE on some Windows Summary: to remove the IOE throwing code Reviewed-by: alanb ! src/windows/native/java/io/Console_md.c Changeset: 17dfbb3f60d3 Author: bpb Date: 2013-08-12 10:35 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/17dfbb3f60d3 8022109: Evaluate adding incrementExact, decrementExact, negateExact to java.lang.Math Summary: Add the methods for parameter types int and long. Reviewed-by: mduigou Contributed-by: Brian Burkhalter ! src/share/classes/java/lang/Math.java ! test/java/lang/Math/ExactArithTests.java Changeset: f8af3499c1fb Author: wetmore Date: 2013-08-14 19:19 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/f8af3499c1fb 8023075: JDK-5049299 has broken old make in jdk8 Reviewed-by: katleman ! make/java/java/Makefile Changeset: 2f6523abab08 Author: yhuang Date: 2013-08-14 22:49 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/2f6523abab08 8021121: ISO 4217 Amendment Number 156 Reviewed-by: naoto ! src/share/classes/java/util/CurrencyData.properties ! src/share/classes/sun/util/resources/lv/CurrencyNames_lv_LV.properties ! test/java/util/Currency/tablea1.txt ! test/sun/text/resources/LocaleData ! test/sun/text/resources/LocaleDataTest.java Changeset: 5ff3b55df2d4 Author: alanb Date: 2013-08-15 11:54 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/5ff3b55df2d4 8022921: Remove experimental Profile attribute Reviewed-by: mchung, chegar ! src/share/classes/java/net/URLClassLoader.java ! src/share/classes/java/util/jar/Attributes.java ! src/share/classes/java/util/jar/JarFile.java ! src/share/classes/java/util/jar/JavaUtilJarAccessImpl.java - src/share/classes/java/util/jar/UnsupportedProfileException.java ! src/share/classes/sun/launcher/LauncherHelper.java ! src/share/classes/sun/launcher/resources/launcher.properties ! src/share/classes/sun/misc/JavaUtilJarAccess.java ! src/share/classes/sun/misc/URLClassPath.java ! src/share/classes/sun/misc/Version.java.template ! src/share/classes/sun/tools/jar/Main.java ! src/share/classes/sun/tools/jar/resources/jar.properties - test/java/net/URLClassLoader/profiles/Basic.java - test/java/net/URLClassLoader/profiles/Lib.java - test/java/net/URLClassLoader/profiles/basic.sh - test/tools/jar/AddAndUpdateProfile.java - test/tools/launcher/profiles/Basic.java - test/tools/launcher/profiles/Logging.java - test/tools/launcher/profiles/Main.java - test/tools/launcher/profiles/VersionCheck.java Changeset: b7b0beef5ded Author: alanb Date: 2013-08-15 13:42 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/b7b0beef5ded 8015765: TEST_BUG: java/nio/channels/ServerSocketChannel/AdaptServerSocket.java failing intermittently Reviewed-by: chegar, dholmes, alanb Contributed-by: yiming.wang at oracle.com ! test/java/nio/channels/ServerSocketChannel/AdaptServerSocket.java Changeset: 7d7d553a8c61 Author: igerasim Date: 2013-08-13 13:04 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/7d7d553a8c61 8022584: Memory leak in some NetworkInterface methods Reviewed-by: alanb, dholmes, chegar, michaelm ! src/solaris/native/java/net/NetworkInterface.c + test/java/net/NetworkInterface/MemLeakTest.java Changeset: 3223342fb76e Author: dl Date: 2013-08-15 15:01 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/3223342fb76e 8023103: FJ parallelism zero 8020537: java/util/concurrent/forkjoin/ThrowingRunnable.java Reviewed-by: chegar, mduigou, alanb ! src/share/classes/java/util/concurrent/ForkJoinPool.java Changeset: b07b19182e40 Author: dl Date: 2013-08-15 15:04 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/b07b19182e40 8023104: ConcurrentHashMap typo Reviewed-by: chegar, mduigou ! src/share/classes/java/util/concurrent/ConcurrentHashMap.java Changeset: e7137695dce3 Author: chegar Date: 2013-08-15 15:16 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/e7137695dce3 8022126: Remove throws SocketException from DatagramPacket constructors accepting SocketAddress Reviewed-by: smarks, alanb, michaelm, darcy ! src/share/classes/java/net/DatagramPacket.java Changeset: 6c307b4d0dd8 Author: sherman Date: 2013-08-15 10:41 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/6c307b4d0dd8 7154662: {CRC32, Adler32}.update(byte[] b, int off, int len): undocumented ArrayIndexOutOfBoundsException Summary: to add the throws clause Reviewed-by: alanb, chegar ! src/share/classes/java/util/zip/Adler32.java ! src/share/classes/java/util/zip/CRC32.java Changeset: b4645069238a Author: vinnie Date: 2013-08-15 19:49 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/b4645069238a 8023108: Remove ShortRSAKey1024.sh from ProblemList.txt Reviewed-by: mullan ! test/ProblemList.txt Changeset: 3211caab58ba Author: vinnie Date: 2013-08-15 19:56 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/3211caab58ba Merge Changeset: 5bb196aa183c Author: dxu Date: 2013-08-15 12:36 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/5bb196aa183c 4858457: File.getCanonicalPath() throws IOException when invoked with "nul" (win) Reviewed-by: alanb ! src/windows/native/java/io/canonicalize_md.c ! test/java/io/File/WinDeviceName.java Changeset: 0d27309a87e0 Author: dxu Date: 2013-08-15 14:11 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/0d27309a87e0 8017109: Cleanup overrides warning in src/solaris/classes/sun/print/AttributeClass.java Reviewed-by: jgodinez ! src/solaris/classes/sun/print/AttributeClass.java Changeset: 5649837a4cfa Author: briangoetz Date: 2013-08-12 12:06 -0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/5649837a4cfa 8019401: Collectors.collectingAndThen Reviewed-by: mduigou Contributed-by: brian.goetz at oracle.com ! src/share/classes/java/util/stream/Collectors.java ! test/java/util/stream/test/org/openjdk/tests/java/util/stream/TabulatorsTest.java Changeset: 5fe19566b6f0 Author: psandoz Date: 2013-08-16 12:29 +0200 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/5fe19566b6f0 8023150: java/util/stream tests no longer compiling following JDK-8019401 Reviewed-by: alanb ! test/java/util/stream/test/org/openjdk/tests/java/util/stream/TabulatorsTest.java Changeset: 2eebaff52a94 Author: psandoz Date: 2013-08-16 12:46 +0200 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/2eebaff52a94 8012940: More than 50 tests failed in Serialization/DeSerialization testing (test-mangled) Reviewed-by: ksrini + test/java/util/stream/bootlib/java/util/stream/LambdaTestMode.java ! test/java/util/stream/bootlib/java/util/stream/StreamTestDataProvider.java Changeset: 02ce5a0e4b98 Author: psandoz Date: 2013-08-16 12:46 +0200 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/02ce5a0e4b98 8022898: java/util/Spliterator/SpliteratorCollisions.java fails in HashableIntSpliteratorWithNull data provider Reviewed-by: henryjen, alanb, rriggs ! test/java/util/Spliterator/SpliteratorCollisions.java Changeset: 737b6c298d81 Author: psandoz Date: 2013-08-13 11:16 +0200 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/737b6c298d81 8022797: Clarify spliterator characteristics for collections containing no elements Reviewed-by: alanb, mduigou ! src/share/classes/java/util/Collection.java Changeset: 53819fd0ab61 Author: rriggs Date: 2013-08-16 11:28 -0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/53819fd0ab61 8022770: java/time/tck/java/time/chrono/TCKChronology.java start failing 8022766: java/time/test/java/time/chrono/TestUmmAlQuraChronology.java failed. Summary: TCKChronology: corrected display name to match update from JDK-8015986 Reviewed-by: alanb ! test/java/time/tck/java/time/chrono/TCKChronology.java ! test/java/time/test/java/time/chrono/TestUmmAlQuraChronology.java Changeset: d7fc4e149bb8 Author: rriggs Date: 2013-08-16 11:11 -0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/d7fc4e149bb8 8022193: java/time/test/java/util/TestFormatter.java failed in th locale. Summary: Tests corrected to use fixed locale and not dependent on the environment Reviewed-by: sherman ! src/share/classes/java/util/Formatter.java ! test/java/time/test/java/util/TestFormatter.java Changeset: acaa256e3f7c Author: rriggs Date: 2013-08-16 13:58 -0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/acaa256e3f7c 8019185: Inconsistency between JapaneseEra start dates and java.util.JapaneseImperialDate Summary: align Meiji start date with lib/calendar.properties to avoid any confusion Reviewed-by: sherman ! src/share/classes/java/time/chrono/JapaneseEra.java Changeset: 9e9f5713b26d Author: psandoz Date: 2013-08-06 14:26 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/9e9f5713b26d 8022318: Document Spliterator characteristics and binding policy of java util concurrent collection impls Reviewed-by: chegar Contributed-by: Martin Buchholz , Paul Sandoz ! src/share/classes/java/util/concurrent/ArrayBlockingQueue.java ! src/share/classes/java/util/concurrent/ConcurrentHashMap.java ! src/share/classes/java/util/concurrent/ConcurrentLinkedDeque.java ! src/share/classes/java/util/concurrent/ConcurrentLinkedQueue.java ! src/share/classes/java/util/concurrent/ConcurrentNavigableMap.java ! src/share/classes/java/util/concurrent/ConcurrentSkipListMap.java ! src/share/classes/java/util/concurrent/ConcurrentSkipListSet.java ! src/share/classes/java/util/concurrent/CopyOnWriteArrayList.java ! src/share/classes/java/util/concurrent/CopyOnWriteArraySet.java ! src/share/classes/java/util/concurrent/DelayQueue.java ! src/share/classes/java/util/concurrent/LinkedBlockingDeque.java ! src/share/classes/java/util/concurrent/LinkedBlockingQueue.java ! src/share/classes/java/util/concurrent/LinkedTransferQueue.java ! src/share/classes/java/util/concurrent/PriorityBlockingQueue.java ! src/share/classes/java/util/concurrent/SynchronousQueue.java ! src/share/classes/java/util/concurrent/package-info.java Changeset: 8e098a29ecd8 Author: egahlin Date: 2013-08-16 17:02 +0200 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/8e098a29ecd8 6417702: Graph in Memory tab is not redrawn immediately if changed via 'Chart' combo box Reviewed-by: alanb, jbachorik, sjiang ! src/share/classes/sun/tools/jconsole/MemoryTab.java Changeset: c67cb9d4d51a Author: egahlin Date: 2013-08-16 17:11 +0200 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/c67cb9d4d51a 6721425: jconsole Makefile clean rule is missing rm of generated Version.java Reviewed-by: alanb, jbachorik ! make/sun/jconsole/Makefile Changeset: 89ef4bcf7b0e Author: egahlin Date: 2013-08-16 16:53 +0200 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/89ef4bcf7b0e 7015157: String "Tabular Navigation" should be rephrased for avoiding mistranslation Reviewed-by: alanb, jbachorik, sjiang ! src/share/classes/sun/tools/jconsole/resources/messages.properties Changeset: 71bad9540825 Author: egahlin Date: 2013-08-16 18:58 +0200 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/71bad9540825 6696970: Jconsole becomes unusable if a plugin throws an exception Reviewed-by: mchung, jbachorik + src/share/classes/sun/tools/jconsole/ExceptionSafePlugin.java ! src/share/classes/sun/tools/jconsole/Messages.java ! src/share/classes/sun/tools/jconsole/VMPanel.java ! src/share/classes/sun/tools/jconsole/resources/messages.properties Changeset: 11ccaabdb2a8 Author: aefimov Date: 2013-08-16 18:41 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/11ccaabdb2a8 8021820: Number of opened files used in select() is limited to 1024 [macosx] Reviewed-by: alanb, chegar, tbell, smarks + test/java/net/ServerSocket/SelectFdsLimit.java Changeset: f580728b08b4 Author: alanb Date: 2013-08-19 11:04 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/f580728b08b4 8023215: test/java/util/Comparator/TypeTest.java not running (failing but reported as passing) Reviewed-by: psandoz ! test/java/util/Comparator/TypeTest.java Changeset: 3647aab7b1d5 Author: psandoz Date: 2013-08-06 14:26 +0100 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/3647aab7b1d5 8014824: Document Spliterator characteristics and binding policy of java util collection impls Reviewed-by: chegar ! src/share/classes/java/util/ArrayDeque.java ! src/share/classes/java/util/ArrayList.java ! src/share/classes/java/util/HashSet.java ! src/share/classes/java/util/LinkedHashMap.java ! src/share/classes/java/util/LinkedHashSet.java ! src/share/classes/java/util/LinkedList.java ! src/share/classes/java/util/List.java ! src/share/classes/java/util/PriorityQueue.java ! src/share/classes/java/util/Set.java ! src/share/classes/java/util/SortedSet.java ! src/share/classes/java/util/Spliterator.java ! src/share/classes/java/util/TreeMap.java ! src/share/classes/java/util/TreeSet.java ! src/share/classes/java/util/Vector.java Changeset: bce5205dbe84 Author: ascarpino Date: 2013-08-14 10:50 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/bce5205dbe84 8022669: OAEPParameterSpec does not work if MGF1ParameterSpec is set to SHA2 algorithms Reviewed-by: mullan ! src/share/classes/sun/security/rsa/RSAPadding.java ! test/com/sun/crypto/provider/Cipher/RSA/TestOAEPPadding.java Changeset: b40d246d4d81 Author: ascarpino Date: 2013-08-16 12:31 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/b40d246d4d81 8022896: test/com/sun/crypto/provider/Cipher/RSA/TestOAEPPadding.java fails Reviewed-by: mullan ! test/ProblemList.txt Changeset: 2fd841fccb2e Author: dxu Date: 2013-08-19 12:38 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/2fd841fccb2e 8023203: Wrap RandomAccessFile.seek native method into a Java helper method Reviewed-by: alanb, chegar ! make/java/java/mapfile-vers ! makefiles/mapfiles/libjava/mapfile-vers ! src/share/classes/java/io/RandomAccessFile.java ! src/share/native/java/io/RandomAccessFile.c Changeset: f120e2c4b4b1 Author: mullan Date: 2013-08-19 17:17 -0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/f120e2c4b4b1 8016850: JCK javax.security.auth.Policy tests fail when run in Profiles mode Summary: Move default javax.security.auth.Policy implementation to compact1 profile Reviewed-by: vinnie ! src/share/classes/com/sun/security/auth/PolicyFile.java - src/share/classes/com/sun/security/auth/PolicyParser.java - src/share/classes/com/sun/security/auth/SubjectCodeSource.java ! src/share/classes/javax/security/auth/Policy.java + src/share/classes/sun/security/provider/AuthPolicyFile.java + src/share/classes/sun/security/provider/SubjectCodeSource.java Changeset: 096e7c665857 Author: xuelei Date: 2013-08-19 17:42 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/096e7c665857 8020842: IDN do not throw IAE when hostname ends with a trailing dot Reviewed-by: weijun, michaelm ! src/share/classes/java/net/IDN.java + test/java/net/IDN/IllegalArg.java + test/sun/security/ssl/javax/net/ssl/ServerName/IllegalSNIName.java Changeset: 21a25911f7f7 Author: xuelei Date: 2013-08-19 18:49 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/21a25911f7f7 8023230: The impl of KerberosClientKeyExchange maybe not exist Reviewed-by: weijun ! src/share/classes/sun/security/ssl/KerberosClientKeyExchange.java Changeset: 53ea4b5cef9b Author: sla Date: 2013-08-20 08:59 +0200 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/53ea4b5cef9b 8022071: Some vm/jvmti tests fail because cannot attach to the Java virtual machine Reviewed-by: erikj, sspitsyn ! makefiles/CompileNativeLibraries.gmk + makefiles/mapfiles/libattach/reorder-windows-x86 + makefiles/mapfiles/libattach/reorder-windows-x86_64 ! src/windows/native/sun/tools/attach/WindowsVirtualMachine.c Changeset: e17da8b09f5e Author: dholmes Date: 2013-08-20 03:18 -0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/e17da8b09f5e 8023311: Clean up profile-includes.txt Reviewed-by: alanb ! makefiles/profile-includes.txt Changeset: 961cdea684b5 Author: sla Date: 2013-08-20 16:53 +0200 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/961cdea684b5 8016727: test/com/sun/jdi/sde/TemperatureTableTest.java failing intermittently Reviewed-by: alanb ! test/com/sun/jdi/sde/TemperatureTableTest.java Changeset: c17d6543b30f Author: psandoz Date: 2013-08-20 17:36 +0200 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/c17d6543b30f 8023367: Collections.emptyList().sort((Comparator)null) throws NPE Reviewed-by: alanb, mduigou ! src/share/classes/java/util/Collections.java ! test/java/util/Collection/ListDefaults.java Changeset: 1ccc7bbee0bb Author: attila Date: 2013-08-20 11:15 +0200 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/1ccc7bbee0bb 8023250: Update JavaScript code in JDK for changes in iteration over Java arrays Reviewed-by: sundar, sla ! src/share/classes/com/sun/tools/hat/resources/hat.js Changeset: a79fcf53195f Author: lana Date: 2013-08-20 17:44 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/a79fcf53195f Merge - src/share/classes/com/sun/security/auth/PolicyParser.java - src/share/classes/com/sun/security/auth/SubjectCodeSource.java - src/share/classes/java/util/jar/UnsupportedProfileException.java - src/share/classes/sun/security/provider/ConfigSpiFile.java - test/java/net/URLClassLoader/profiles/Basic.java - test/java/net/URLClassLoader/profiles/Lib.java - test/java/net/URLClassLoader/profiles/basic.sh - test/tools/jar/AddAndUpdateProfile.java - test/tools/launcher/profiles/Basic.java - test/tools/launcher/profiles/Logging.java - test/tools/launcher/profiles/Main.java - test/tools/launcher/profiles/VersionCheck.java Changeset: 9626ba160e3d Author: lana Date: 2013-08-23 14:14 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/9626ba160e3d Merge - src/share/classes/com/sun/security/auth/PolicyParser.java - src/share/classes/com/sun/security/auth/SubjectCodeSource.java - src/share/classes/java/util/jar/UnsupportedProfileException.java - src/share/classes/sun/security/provider/ConfigSpiFile.java - test/java/net/URLClassLoader/profiles/Basic.java - test/java/net/URLClassLoader/profiles/Lib.java - test/java/net/URLClassLoader/profiles/basic.sh - test/tools/jar/AddAndUpdateProfile.java - test/tools/launcher/profiles/Basic.java - test/tools/launcher/profiles/Logging.java - test/tools/launcher/profiles/Main.java - test/tools/launcher/profiles/VersionCheck.java Changeset: e11ed7187b0c Author: lana Date: 2013-08-27 21:46 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/e11ed7187b0c Merge - src/share/classes/com/sun/security/auth/PolicyParser.java - src/share/classes/com/sun/security/auth/SubjectCodeSource.java - src/share/classes/java/util/jar/UnsupportedProfileException.java - src/share/classes/sun/security/provider/ConfigSpiFile.java - test/java/net/URLClassLoader/profiles/Basic.java - test/java/net/URLClassLoader/profiles/Lib.java - test/java/net/URLClassLoader/profiles/basic.sh - test/tools/jar/AddAndUpdateProfile.java - test/tools/launcher/profiles/Basic.java - test/tools/launcher/profiles/Logging.java - test/tools/launcher/profiles/Main.java - test/tools/launcher/profiles/VersionCheck.java From alexandr.scherbatiy at oracle.com Wed Aug 28 05:14:59 2013 From: alexandr.scherbatiy at oracle.com (Alexander Scherbatiy) Date: Wed, 28 Aug 2013 16:14:59 +0400 Subject: javax.swing.RepaintManager volatileMap In-Reply-To: References: Message-ID: <521DE9C3.3060301@oracle.com> forwarded the question to awt-dev alias. On 8/28/2013 3:00 PM, Vladimir Sitnikov wrote: > Hi, > > In the heapdump of SQL Developer 4.0 I found that RepaintManager holds > 23 items of sun.awt.image.BufImgVolatileSurfaceManager 5-10MiB each. > > All the images are contained in "volatileMap" HashMap. > > I identified that the key of the map is sun.awt.Win32GraphicsConfig > and that class does not override equals/hashCode. > > Can you please tell me if "using GraphicsConfig as a key knowing the > fact this key does not ovveride equals/hashCode" is intentional or not? > > I have checked several keys of the map (Win32GraphicsConfig) and they > have identical value (even screen and sTypeOrig references point to > the same objects), however as the Win32GraphicsConfig objects itself > are different java objects they occupy different entries in valueMap. > > -- > Regards, > Vladimir Sitnikov From artem.ananiev at oracle.com Wed Aug 28 06:28:23 2013 From: artem.ananiev at oracle.com (artem.ananiev at oracle.com) Date: Wed, 28 Aug 2013 13:28:23 +0000 Subject: hg: jdk8/awt/jdk: 8011955: Lunar screen reader crashes intermittently in WindowsAccessBridge-32.DLL; ... Message-ID: <20130828132852.9D24948C27@hg.openjdk.java.net> Changeset: 43de418f1345 Author: ptbrunet Date: 2013-08-28 17:25 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/43de418f1345 8011955: Lunar screen reader crashes intermittently in WindowsAccessBridge-32.DLL 6995891: JAWS will occasionally stop speaking focused objects as user TABs -> problem with message queue 8014738: Combobox menu items are not announced with JAWS 8011938: Java Ferret example corrupts JCombobox of the running application 8012011: JAB 2.0.2 incompletely shows kbd accelerator in menus 8022966: Java Access Bridge no longer usable with screen magnifiers Reviewed-by: raginip, tbell, erikj, art ! make/bridge/AccessBridgeJava/Makefile ! makefiles/CompileJavaClasses.gmk ! makefiles/GensrcMisc.gmk From sergey.malenkov at oracle.com Wed Aug 28 06:33:18 2013 From: sergey.malenkov at oracle.com (sergey.malenkov at oracle.com) Date: Wed, 28 Aug 2013 13:33:18 +0000 Subject: hg: jdk8/awt/jdk: 6968363: ClassCastException while entering HINDI characters with CustomDocument Message-ID: <20130828133343.0262148C28@hg.openjdk.java.net> Changeset: 35644adc3269 Author: malenkov Date: 2013-08-28 17:32 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/35644adc3269 6968363: ClassCastException while entering HINDI characters with CustomDocument Reviewed-by: alexsch ! src/share/classes/javax/swing/text/AbstractDocument.java ! src/share/classes/javax/swing/text/DefaultCaret.java ! src/share/classes/javax/swing/text/GlyphPainter2.java ! src/share/classes/javax/swing/text/ParagraphView.java + test/javax/swing/text/AbstractDocument/6968363/Test6968363.java From artem.ananiev at oracle.com Wed Aug 28 06:52:48 2013 From: artem.ananiev at oracle.com (Artem Ananiev) Date: Wed, 28 Aug 2013 17:52:48 +0400 Subject: javax.swing.RepaintManager volatileMap In-Reply-To: References: Message-ID: <521E00B0.5080205@oracle.com> Hi, Vladimir, I agree that using a class with no equals/hashCode overridden as a key for HashMap is not the best thing to do. However, in this case the problem seems to be caused by something else. I'm not an expert in RepaintManager, but here is what I observe: 1. When graphics environment changes, we get displayChanged() notification (it's not a public API yet, unfortunately). 2. RepaintManager.displayChanged() clears all the volatile images, as they depend on the GraphicsConfiguration objects and may be invalid 3. In clearImages(), we iterate through volatileMap and remove the images. Note that despite GraphicsConfiguration doesn't override equals/hashCode, iteration should still work. Anyway, it indeed looks like a bug, no matter of what it's caused by. Do you have a test case that can be used to reproduce it, other than to run JDeveloper? Thanks, Artem On 8/28/2013 3:00 PM, Vladimir Sitnikov wrote: > Hi, > > In the heapdump of SQL Developer 4.0 I found that RepaintManager holds > 23 items of sun.awt.image.BufImgVolatileSurfaceManager 5-10MiB each. > > All the images are contained in "volatileMap" HashMap. > > I identified that the key of the map is sun.awt.Win32GraphicsConfig and > that class does not override equals/hashCode. > > Can you please tell me if "using GraphicsConfig as a key knowing the > fact this key does not ovveride equals/hashCode" is intentional or not? > > I have checked several keys of the map (Win32GraphicsConfig) and they > have identical value (even screen and sTypeOrig references point to the > same objects), however as the Win32GraphicsConfig objects itself are > different java objects they occupy different entries in valueMap. > > -- > Regards, > Vladimir Sitnikov From petr.pchelko at oracle.com Thu Aug 29 03:32:24 2013 From: petr.pchelko at oracle.com (Petr Pchelko) Date: Thu, 29 Aug 2013 14:32:24 +0400 Subject: [8] Review Request for JDK-8023966 JViewPort.BLIT_SCROLL_MODE does not work in JLightweightFrame Message-ID: Hello, AWT Team. Please review the fix for the following issue: http://bugs.sun.com/view_bug.do?bug_id=8023966 The issue might not be available at bugs.sun.com. The problem is that JViewPort.BLIT_SCROLL_MODE does not work inside the JLightweightFrame. The fix is available at: http://cr.openjdk.java.net/~pchelko/8023966/webrev.00/ The idea of the fix is to detect if the JViewPort was added into the JLightweightFrame and set a supported scroll mode instead of the BLIT_SCROLL_MODE With best regards. Petr. From oleg.pekhovskiy at oracle.com Thu Aug 29 03:52:06 2013 From: oleg.pekhovskiy at oracle.com (Oleg Pekhovskiy) Date: Thu, 29 Aug 2013 14:52:06 +0400 Subject: [8] Review request for 8003965: Toolkit.beep() documentation is ambiguous Message-ID: <521F27D6.3060303@oracle.com> Hi all, please review the fix for JDK-8003965 (not available on bugs.sun.com): http://cr.openjdk.java.net/~bagiras/8003965.1/ It's just a Javadoc fix. Thanks, Oleg From anthony.petrov at oracle.com Thu Aug 29 05:03:03 2013 From: anthony.petrov at oracle.com (Anthony Petrov) Date: Thu, 29 Aug 2013 16:03:03 +0400 Subject: [8] Review request for 8003965: Toolkit.beep() documentation is ambiguous In-Reply-To: <521F27D6.3060303@oracle.com> References: <521F27D6.3060303@oracle.com> Message-ID: <521F3877.4090807@oracle.com> Hi Oleg, I believe that a javadoc shouldn't mention any particular native APIs used to implement a particular functionality, because: 1. There are many more platforms where Java runs, and they also may implement the beep() method. 2. In the future we may need to change the underlying implementation, and we certainly don't want to also change the javadoc to describe the low-level changes. Hence, I suggest to only state something like the following: "Tells the native system to emit a beep. Emitting depends on system settings and hardware capabilities." -- best regards, Anthony On 08/29/13 14:52, Oleg Pekhovskiy wrote: > Hi all, > > please review the fix for JDK-8003965 (not available on bugs.sun.com): > http://cr.openjdk.java.net/~bagiras/8003965.1/ > > It's just a Javadoc fix. > > Thanks, > Oleg From anthony.petrov at oracle.com Thu Aug 29 05:05:45 2013 From: anthony.petrov at oracle.com (Anthony Petrov) Date: Thu, 29 Aug 2013 16:05:45 +0400 Subject: [8] Review request for 8003965: Toolkit.beep() documentation is ambiguous In-Reply-To: <521F3877.4090807@oracle.com> References: <521F27D6.3060303@oracle.com> <521F3877.4090807@oracle.com> Message-ID: <521F3919.9090201@oracle.com> Note that this change will also need a CCC request filed/approved before the fix may be pushed. -- best regards, Anthony On 08/29/13 16:03, Anthony Petrov wrote: > Hi Oleg, > > I believe that a javadoc shouldn't mention any particular native APIs > used to implement a particular functionality, because: > > 1. There are many more platforms where Java runs, and they also may > implement the beep() method. > > 2. In the future we may need to change the underlying implementation, > and we certainly don't want to also change the javadoc to describe the > low-level changes. > > Hence, I suggest to only state something like the following: > > "Tells the native system to emit a beep. Emitting depends on system > settings and hardware capabilities." > > -- > best regards, > Anthony > > On 08/29/13 14:52, Oleg Pekhovskiy wrote: >> Hi all, >> >> please review the fix for JDK-8003965 (not available on bugs.sun.com): >> http://cr.openjdk.java.net/~bagiras/8003965.1/ >> >> It's just a Javadoc fix. >> >> Thanks, >> Oleg From anthony.petrov at oracle.com Thu Aug 29 05:12:27 2013 From: anthony.petrov at oracle.com (Anthony Petrov) Date: Thu, 29 Aug 2013 16:12:27 +0400 Subject: [8] Review Request for JDK-8023966 JViewPort.BLIT_SCROLL_MODE does not work in JLightweightFrame In-Reply-To: References: Message-ID: <521F3AAB.6090309@oracle.com> Hi Petr, The fix looks fine to me. I assume the SIMPLE_SCROLL_MODE works fine as well when in a JLightweightFrame, right? -- best regards, Anthony On 08/29/13 14:32, Petr Pchelko wrote: > Hello, AWT Team. > > Please review the fix for the following issue: > http://bugs.sun.com/view_bug.do?bug_id=8023966 > The issue might not be available at bugs.sun.com. The problem is that JViewPort.BLIT_SCROLL_MODE does not work inside the JLightweightFrame. > > The fix is available at: > http://cr.openjdk.java.net/~pchelko/8023966/webrev.00/ > > The idea of the fix is to detect if the JViewPort was added into the JLightweightFrame and set a supported scroll mode instead of the BLIT_SCROLL_MODE > > With best regards. Petr. From petr.pchelko at oracle.com Thu Aug 29 05:14:53 2013 From: petr.pchelko at oracle.com (Petr Pchelko) Date: Thu, 29 Aug 2013 16:14:53 +0400 Subject: [8] Review Request for JDK-8023966 JViewPort.BLIT_SCROLL_MODE does not work in JLightweightFrame In-Reply-To: <521F3AAB.6090309@oracle.com> References: <521F3AAB.6090309@oracle.com> Message-ID: <24C84318-A528-467F-A271-730EA0E18BA3@oracle.com> Hello, Anthony. > I assume the SIMPLE_SCROLL_MODE works fine as well when in a JLightweightFrame, right? Yes. Only the BLIT_SCROLL_MODE mode is problematic. With best regards. Petr. On Aug 29, 2013, at 4:12 PM, Anthony Petrov wrote: > Hi Petr, > > The fix looks fine to me. > > I assume the SIMPLE_SCROLL_MODE works fine as well when in a JLightweightFrame, right? > > -- > best regards, > Anthony > > On 08/29/13 14:32, Petr Pchelko wrote: >> Hello, AWT Team. >> >> Please review the fix for the following issue: >> http://bugs.sun.com/view_bug.do?bug_id=8023966 >> The issue might not be available at bugs.sun.com. The problem is that JViewPort.BLIT_SCROLL_MODE does not work inside the JLightweightFrame. >> >> The fix is available at: >> http://cr.openjdk.java.net/~pchelko/8023966/webrev.00/ >> >> The idea of the fix is to detect if the JViewPort was added into the JLightweightFrame and set a supported scroll mode instead of the BLIT_SCROLL_MODE >> >> With best regards. Petr. From anthony.petrov at oracle.com Thu Aug 29 06:16:51 2013 From: anthony.petrov at oracle.com (Anthony Petrov) Date: Thu, 29 Aug 2013 17:16:51 +0400 Subject: [8] Review request for 8016356: Any swing frame resizes ugly. In-Reply-To: <521D1BAE.2050908@oracle.com> References: <5219FB56.6070700@oracle.com> <521B5619.7030705@oracle.com> <521D1BAE.2050908@oracle.com> Message-ID: <521F49C3.2040703@oracle.com> Hi Oleg, On 08/28/13 01:35, Oleg Pekhovskiy wrote: > On 26.08.2013 17:20, Anthony Petrov wrote: >> The fix looks somewhat fragile to me. The sequence of events may change >> in a future version of Windows, and the fix will fail then. > > I agree, the fix is not elegant. > As for the future: I tested it on Windows 8.1 - it worked. I didn't mean *the* Win 8.1, I meant *a* future version. I suppose you can't test with Win 9 or Win 19 yet, can you? :) >> Are there any peculiarities for the WM_SIZE messages being posted when a >> window is snapped? I'm referring to [1] for example, and they suggest >> that a proper SC_ flag might be specified when snapping occurs. So, if >> we could detect that, we might unblock the WindowResized() call at the >> end of the WmSize() method in the AwtWindow class, which would fix the >> issue. > > Unfortunately there is not direct way to determine the snapping. > My experience says not to play with sending system events manually on > Windows. That is much more fragile and nobody knows how DefWindowProc() > would behave. I totally agree. > I chose WM_SYSCOMMAND handler in AwtWindow::WindowProc() because it's > synchronous during window resize (looping in AwtWindow::DefWindowProc()) > So WindowResized() would be called only when the user releases mouse > button after resizing. But WM_SIZE message is called each time the size > of the window is changed while resizing. Aren't the position/size of a window change noticeably greater from one WM_SIZE message to the next one when the snapping occurs, as opposed to normal resizing? Could we introduce a threshold and only call WindowResized from WmSize() if the size/position change is greater than the threshold? I realize that such a solution is no more elegant than your original one, but at least it doesn't rely on a particular sequence of different messages, which may change in future versions of Windows. -- best regards, Anthony > > You might also want to explore the WM_WINDOWPOSCHANGED and >> WM_WINDOWPOSCHANGING events that the window receives during snapping, >> perhaps they have some characteristics allowing us to ignore the >> IsResizing() and call the WindowResized() nonetheless. > > These messages are sent "as a result of a call to the SetWindowPos > function or another window-management function" and never appears during > window resizing with the mouse. > >> >> [1] >> http://stackoverflow.com/questions/9321549/handling-aerosnap-message-in-wndproc >> >> > > This article is an attempt to handle maximize/restore snapping, but this > issue deals with vertical snapping, when top or bottom edge of the > window moved to the corresponding edge of the screen. > >> >> -- >> best regards, >> Anthony >> >> On 08/25/13 16:40, Oleg Pekhovskiy wrote: >>> Hi all, >>> >>> please review the fix >>> http://cr.openjdk.java.net/~bagiras/8016356.1/ >>> for >>> http://bugs.sun.com/view_bug.do?bug_id=8016356 >>> >>> Windows 7 has a feature that makes "window being automatically arranged >>> when moved to the edge of the screen". And there is no specific system >>> notification when that happens. From the other side AwtWindow class has >>> some optimization algorithm for resizing that doesn't take into account >>> such the arranging. I found indirect way to determine the arranging by >>> tracking the sequence of WM_GETMINMAXINFO and WM_SIZE before the end of >>> resizing routine, and call WindowResized() when needed to update the >>> layout. >>> >>> Thanks, >>> Oleg From anton.tarasov at oracle.com Thu Aug 29 06:37:33 2013 From: anton.tarasov at oracle.com (Anton V. Tarasov) Date: Thu, 29 Aug 2013 17:37:33 +0400 Subject: [8] Review Request for JDK-8023966 JViewPort.BLIT_SCROLL_MODE does not work in JLightweightFrame In-Reply-To: References: Message-ID: <521F4E9D.2070806@oracle.com> Hi Petr, I like much this simple solution! Thanks, Anton. On 29.08.2013 14:32, Petr Pchelko wrote: > Hello, AWT Team. > > Please review the fix for the following issue: > http://bugs.sun.com/view_bug.do?bug_id=8023966 > The issue might not be available at bugs.sun.com. The problem is that JViewPort.BLIT_SCROLL_MODE does not work inside the JLightweightFrame. > > The fix is available at: > http://cr.openjdk.java.net/~pchelko/8023966/webrev.00/ > > The idea of the fix is to detect if the JViewPort was added into the JLightweightFrame and set a supported scroll mode instead of the BLIT_SCROLL_MODE > > With best regards. Petr. From petr.pchelko at oracle.com Fri Aug 30 00:11:27 2013 From: petr.pchelko at oracle.com (petr.pchelko at oracle.com) Date: Fri, 30 Aug 2013 07:11:27 +0000 Subject: hg: jdk8/awt/jdk: 8023966: JViewPort.BLIT_SCROLL_MODE does not work in JLightweightFrame Message-ID: <20130830071240.5FA9562409@hg.openjdk.java.net> Changeset: 6432f8749e1d Author: pchelko Date: 2013-08-30 11:11 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/6432f8749e1d 8023966: JViewPort.BLIT_SCROLL_MODE does not work in JLightweightFrame Reviewed-by: anthony, ant ! src/share/classes/javax/swing/JViewport.java From alexandr.scherbatiy at oracle.com Fri Aug 30 02:18:26 2013 From: alexandr.scherbatiy at oracle.com (alexandr.scherbatiy at oracle.com) Date: Fri, 30 Aug 2013 09:18:26 +0000 Subject: hg: jdk8/awt/jdk: 8022401: [macosx] javax/swing/text/JTextComponent/5074573/bug5074573.java fails Message-ID: <20130830091904.0FF7962412@hg.openjdk.java.net> Changeset: 7151f08eeadf Author: alexsch Date: 2013-08-30 13:28 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/7151f08eeadf 8022401: [macosx] javax/swing/text/JTextComponent/5074573/bug5074573.java fails Reviewed-by: anthony ! src/macosx/native/sun/awt/AWTEvent.m + test/java/awt/event/KeyEvent/KeyChar/KeyCharTest.java From oleg.pekhovskiy at oracle.com Sat Aug 31 23:32:25 2013 From: oleg.pekhovskiy at oracle.com (Oleg Pekhovskiy) Date: Sun, 01 Sep 2013 10:32:25 +0400 Subject: [8] Review request for 8016356: Any swing frame resizes ugly. In-Reply-To: <521F49C3.2040703@oracle.com> References: <5219FB56.6070700@oracle.com> <521B5619.7030705@oracle.com> <521D1BAE.2050908@oracle.com> <521F49C3.2040703@oracle.com> Message-ID: <5222DF79.4080007@oracle.com> Hi Anthony, On 29.08.2013 17:16, Anthony Petrov wrote: > Hi Oleg, > > On 08/28/13 01:35, Oleg Pekhovskiy wrote: >> On 26.08.2013 17:20, Anthony Petrov wrote: >>> The fix looks somewhat fragile to me. The sequence of events may change >>> in a future version of Windows, and the fix will fail then. >> >> I agree, the fix is not elegant. >> As for the future: I tested it on Windows 8.1 - it worked. > > I didn't mean *the* Win 8.1, I meant *a* future version. I suppose you > can't test with Win 9 or Win 19 yet, can you? :) > Sure, no guarantee... > >>> Are there any peculiarities for the WM_SIZE messages being posted when a >>> window is snapped? I'm referring to [1] for example, and they suggest >>> that a proper SC_ flag might be specified when snapping occurs. So, if >>> we could detect that, we might unblock the WindowResized() call at the >>> end of the WmSize() method in the AwtWindow class, which would fix the >>> issue. >> >> Unfortunately there is not direct way to determine the snapping. >> My experience says not to play with sending system events manually on >> Windows. That is much more fragile and nobody knows how DefWindowProc() >> would behave. > > I totally agree. > >> I chose WM_SYSCOMMAND handler in AwtWindow::WindowProc() because it's >> synchronous during window resize (looping in AwtWindow::DefWindowProc()) >> So WindowResized() would be called only when the user releases mouse >> button after resizing. But WM_SIZE message is called each time the size >> of the window is changed while resizing. > > Aren't the position/size of a window change noticeably greater from one > WM_SIZE message to the next one when the snapping occurs, as opposed to > normal resizing? Could we introduce a threshold and only call > WindowResized from WmSize() if the size/position change is greater than > the threshold? Unfortunately, that's impossible in, at least, to cases: 1. The height of window is near the height of desktop, so snapping increases the height of window just for a few pixels. 2. The mouse is moved quite fast during the simple resizing (I got >100 pixel increase for one WM_SIZE message). > > I realize that such a solution is no more elegant than your original > one, but at least it doesn't rely on a particular sequence of different > messages, which may change in future versions of Windows. > > -- > best regards, > Anthony > >> >> You might also want to explore the WM_WINDOWPOSCHANGED and >>> WM_WINDOWPOSCHANGING events that the window receives during snapping, >>> perhaps they have some characteristics allowing us to ignore the >>> IsResizing() and call the WindowResized() nonetheless. >> >> These messages are sent "as a result of a call to the SetWindowPos >> function or another window-management function" and never appears during >> window resizing with the mouse. >> >>> >>> [1] >>> http://stackoverflow.com/questions/9321549/handling-aerosnap-message-in-wndproc >>> >>> >>> >> >> This article is an attempt to handle maximize/restore snapping, but this >> issue deals with vertical snapping, when top or bottom edge of the >> window moved to the corresponding edge of the screen. >> >>> >>> -- >>> best regards, >>> Anthony >>> >>> On 08/25/13 16:40, Oleg Pekhovskiy wrote: >>>> Hi all, >>>> >>>> please review the fix >>>> http://cr.openjdk.java.net/~bagiras/8016356.1/ >>>> for >>>> http://bugs.sun.com/view_bug.do?bug_id=8016356 >>>> >>>> Windows 7 has a feature that makes "window being automatically arranged >>>> when moved to the edge of the screen". And there is no specific system >>>> notification when that happens. From the other side AwtWindow class has >>>> some optimization algorithm for resizing that doesn't take into account >>>> such the arranging. I found indirect way to determine the arranging by >>>> tracking the sequence of WM_GETMINMAXINFO and WM_SIZE before the end of >>>> resizing routine, and call WindowResized() when needed to update the >>>> layout. >>>> >>>> Thanks, >>>> Oleg