<AWT Dev> [7u] Review request for 7191018: Manual test closed/java/awt/JAWT causes JVM to crash starting from JDK 5

[Sergey Bylokhov]

Hello, Anton.
Fix looks fine to me.
On 16.08.2013 20:33, Anton Litvinov wrote:
> Hello Anthony,
>
> Thank you for review of this backport fix. Yes, surely, 7190587 with 
> its synopsis will be specified in a changeset comment during pushing 
> of the fix.
>
> Thank you,
> Anton
>
> On 8/16/2013 8:10 PM, Anthony Petrov wrote:
>> Hi Anton,
>>
>> The fix looks fine to me. Since you're also porting a fix for 
>> 7190587, when pushing it please specify both bug id-s in your commit 
>> message, like this:
>>
>> 7191018: ...
>> 7190587: ...
>> Summary:/Reviewed-by:/etc.
>>
>> This will mark the second bug as ported to 7u automatically (well, it 
>> should, if not - there's bug in our HG hook then).
>>
>> -- 
>> best regards,
>> Anthony
>>
>> On 08/16/2013 07:48 PM, Anton Litvinov wrote:
>>> Hello Anthony and Sergey,
>>>
>>> Could you please review this backport of the fix, which was approved by
>>> you for JDK 8, from JDK 8 to JDK 7.
>>>
>>> Bug: http://bugs.sun.com/view_bug.do?bug_id=7191018
>>> Webrev: http://cr.openjdk.java.net/~alitvinov/7191018/jdk7/webrev.00
>>> JDK 8 webrev: http://cr.openjdk.java.net/~alitvinov/7191018/webrev.00
>>>
>>> The backport fix consists of two parts:
>>>
>>> - The fix. It is the same with the original fix, but is not binary
>>> equal, because the function "awt_GetComponent(JNIEnv* env, void*
>>> platformInfo)" from "awt_DrawingSurface.c" file in JDK 7 contains
>>> "#ifndef XAWT" macros, which are absent in JDK 8.
>>>
>>> - The regression test "test/java/awt/JAWT" imported from JDK 8. It is a
>>> complete copy of the regression test from JDK 8. The fix assumes that
>>> the existing purely manual JAWT test is removed from the workspace, as
>>> it was done in JDK 8 for CR 7190587.
>>>
>>> Thank you,
>>> Anton
>


-- 
Best regards, Sergey.