<AWT Dev> [8] Review Request: CR 8015455 java/awt/dnd/DisposeFrameOnDragCrash/DisposeFrameOnDragTest.java hangs on windows

Anthony Petrov anthony.petrov at oracle.com
Wed Aug 21 02:40:40 PDT 2013


Hi Petr,

The java.awt.dnd.DropTarget is a public class, and as such adding any 
non-private member to it is an API change. I'm not sure we want to 
expose the dtListener field as a public (well, protected) API because 
it's too low-level IMO.

Besides, it seems that in the case if the frame is disposed, an 
application won't ever receive an event indicating that the DnD 
operation has ended (IIUC, if it did, the normal processing of the 
dragExit would reset the timer).

So, how about overriding the removeNotify() in DropTarget() and sending 
an appropriate DnD gesture termination event from there?


--
best regards,
Anthony

On 08/21/2013 01:21 PM, Petr Pchelko wrote:
> Hello, AWT Team.
>
> Please review the fix for the issue:
> http://bugs.sun.com/view_bug.do?bug_id=8015455
> The fix is available at:
> http://cr.openjdk.java.net/~pchelko/8015455/webrev.00/
>
> The SwingDropTarget initializes a SwingTimer to handle autoscroll. This timer was stopped on dragExit and drop. However, if the frame was disposed in some dropTarget listener the timer was never stopped and prevented the AWT application from exiting.
>
> With best regards. Petr,
>


More information about the awt-dev mailing list