<AWT Dev> [8] Review request for 8022401 [macosx] javax/swing/text/JTextComponent/5074573/bug5074573.java fails

Anthony Petrov anthony.petrov at oracle.com
Fri Aug 23 03:19:58 PDT 2013


Hi Alexander,

The fix looks fine to me. However, please correct the year in the 
copyright notice in the test before pushing your fix, since currently it 
lists 2011 instead of 2013.

--
best regards,
Anthony

On 08/22/2013 06:28 PM, Alexander Scherbatiy wrote:
>
> Hello,
>
> Could you review the fix:
>    bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8022401
>    webrev: http://cr.openjdk.java.net/~alexsch/8022401/webrev.00
>
>   The nsToJavaChar method from AWTEvent.m has char type (1 byte) for the
> nsChar parameter instead of jchar.
>
>   Thanks,
> Alexandr.
>


More information about the awt-dev mailing list