<AWT Dev> [8] Review request for 8024926 [macosx] AquaIcon HiDPI support

[Sergey Bylokhov]

Hi, Alexander.
The fix looks good.
On 12/5/13 6:01 PM, Alexander Scherbatiy wrote:
>
>  Could you review the updated fix:
>     http://cr.openjdk.java.net/~alexsch/8024926/webrev.02/
>
>    - the graphics object is disposed in the 
> AquaImageFactory.MultiResolutionIconImage constructor
>
>   Thanks,
>   Alexandr.
>
> On 12/3/2013 8:39 PM, Anthony Petrov wrote:
>> Hi Alexander,
>>
>> The Graphics obtained at line 519 in AquaImageFactory.java is never 
>> dispose()'d.
>>
>> Other than that, the fix looks good to me (although I'm not an expert 
>> in Aqua L&F or HiDPI support code).
>>
>> -- 
>> best regards,
>> Anthony
>>
>> On 12/03/2013 08:11 PM, Alexander Scherbatiy wrote:
>>>
>>>    Could you review the updated fix:
>>>      http://cr.openjdk.java.net/~alexsch/8024926/webrev.01/
>>>    - MultiResolutionImage interface is used from the fix 8011059
>>>    - Only icons with resolution 1x and 2x are created.
>>>
>>>      The real Mac OS X system icon have more resolutions.
>>>      The full fix requires retrieving and handling all NSImage
>>> representations. It can be addressed for the next release.
>>>
>>>    Thanks,
>>>    Alexandr.
>>>
>>> On 10/29/2013 8:47 PM, Alexander Scherbatiy wrote:
>>>> Hello,
>>>>
>>>> Could you review the fix:
>>>>   bug: https://bugs.openjdk.java.net/browse/JDK-8024926
>>>>   webrev: http://cr.openjdk.java.net/~alexsch/8024926/webrev.00
>>>>
>>>> The fix returns a high resolution system icon in the overridden
>>>> getScaledInstance(width, height, hints) method.
>>>>
>>>> The fix relies on the fix for the issue JDK-8011059 [macosx] Make JDK
>>>> demos look perfect on retina displays:
>>>> http://mail.openjdk.java.net/pipermail/awt-dev/2013-October/006133.html 
>>>>
>>>>  - getScaledInstance(width, height, hints) method is used for the
>>>> image drawing when IMAGE_SCALING hints are enabled
>>>>  - LWCToolkit.ScalableToolkitImage class is public
>>>>
>>>> Thanks,
>>>> Alexandr.
>>>>
>>>
>


-- 
Best regards, Sergey.