<AWT Dev> Review Request: JDK-7175457 Fix for [TEST_BUG] closed/java/awt/Window/AlwaysOnTop/TestAlwaysOnTopBeforeShow.java still failed

Anthony Petrov anthony.petrov at oracle.com
Thu Dec 5 11:49:23 PST 2013


Thanks, Andrei. The second version of the fix looks fine to me.

In the future, please advise Shura to send his feedback on the mailing 
list directly, so that all interested parties could see and discuss any 
suggestions.

--
best regards,
Anthony

On 12/05/2013 03:01 PM, andrei.eremeev wrote:
> Shura have advised me to make some variables which can be accessed from
> several threads volatile.
>
> The fix is available at:
> http://cr.openjdk.java.net/~yan/7175457/webrev.diff.01/
>
> Test moved to open:
> http://cr.openjdk.java.net/~yan/7175457/webrev.01/
>
> Andrei
>
> On 12/05/2013 02:04 PM, Anthony Petrov wrote:
>> Hi Andrei,
>>
>> I haven't seen any messages regarding this fix on this mailing list.
>>
>> Where did the review take place? What suggestions have been proposed,
>> and what exactly have changed in the new version? And yes, where's
>> this new version of the fix published?
>>
>> --
>> best regards,
>> Anthony
>>
>> On 12/05/2013 01:18 PM, andrei.eremeev wrote:
>>> I have updated fix after Shura's review.
>>>
>>> Andrei
>>>
>>> On 12/03/2013 10:48 PM, Anthony Petrov wrote:
>>>> Hi Andrei,
>>>>
>>>> The fix looks good to me.
>>>>
>>>> --
>>>> best regards,
>>>> Anthony
>>>>
>>>> On 12/03/2013 06:46 PM, andrei.eremeev wrote:
>>>>> Hi, AWT team.
>>>>>
>>>>> Please review the fix for the issue:
>>>>> https://bugs.openjdk.java.net/browse/JDK-7175457
>>>>>
>>>>> The fix is available at:
>>>>> http://cr.openjdk.java.net/~yan/7175457/webrev.diff.00/
>>>>>
>>>>> Test moved to open:
>>>>> http://cr.openjdk.java.net/~yan/7175457/webrev.00/
>>>
>


More information about the awt-dev mailing list