<AWT Dev> [7u] Review request for 8025775: JNI warnings in TryXShmAttach

[Anthony Petrov]

Hi Anton,

The fix looks good to me.

--
best regards,
Anthony

On 12/07/2013 02:03 AM, Anton Litvinov wrote:
> Hello Artem and Anthony,
>
> Could you please review this backport of the fix, which was approved by
> you for JDK 8, from JDK 8 to JDK 7.
>
> Bug: http://bugs.sun.com/view_bug.do?bug_id=8025775
> Webrev: http://cr.openjdk.java.net/~alitvinov/8025775/jdk7/webrev.00
> JDK 8 webrev: http://cr.openjdk.java.net/~alitvinov/8025775/jdk8/webrev.01
>
> The fix contains all changes from the fix for JDK 8 and the next
> additional changes:
>
> 1. Files "awt_wm.c", "awt_xembed_server.c". Reversion of XError handling
> code implemented as "native -> Java" calls in JDK 7 version of the fix
> for CR 8005607 to its prior state with native error handlers.
>
> 2. Files "awt_util.h", "awt_util.c". Return of the macro "XERROR_SAVE"
> and the external global variable "xerror_code", because of their active
> use in XError handling code in the files "awt_wm.c" and
> "awt_xembed_server.c".
>
> Thank you,
> Anton