<AWT Dev> [8] Review request for JDK-8029923 Many Swing tests and SwingSet2 are failing under Solaris using GTK LaF - "Unable to load native GTK libraries"

[Anthony Petrov]

The fix looks fine to me. Thanks.

--
best regards,
Anthony

On 12/12/2013 02:35 PM, Alexander Zvegintsev wrote:
> Hi Anthony,
>
> Sure, here is the updated webrev:
> http://cr.openjdk.java.net/~azvegint/jdk/8/8029923/webrev.01/
>
> Thanks,
>
> Alexander.
>
> On 12/11/2013 10:21 PM, Anthony Petrov wrote:
>> Hi Alexander,
>>
>> It appears we have to use the same pattern for every call to the
>> glib_check_version(), and you're repeating it twice already. I suggest
>> to introduce a helper macro (or inline function) that would return the
>> result of:
>>
>> (fp_glib_check_version && fp_glib_check_version(X, Y, Z) == NULL)
>>
>> It may be useful in the future, and even with your fix it would avoid
>> code replication.
>>
>> --
>> best regards,
>> Anthony
>>
>> On 12/11/2013 08:31 PM, Alexander Zvegintsev wrote:
>>> Hello, AWT Team.
>>>
>>> Please review the fix
>>> http://cr.openjdk.java.net/~azvegint/jdk/8/8029923/webrev.00/
>>> for the issue
>>> https://bugs.openjdk.java.net/browse/JDK-8029923
>>>
>>> Solaris 10 have glib 2.4.1 installed by default and glib_check_version()
>>> is available since 2.6 [1]. So the fix is to ignore "symbol not found"
>>> error.
>>>
>>> [1]
>>> https://developer.gnome.org/glib/2.32/glib-Version-Information.html#glib-check-version
>>>
>>>
>>>
>>>
>>>
>