<AWT Dev> [9] Review Request: JDK-8007220 [macosx] Setting popupmenu on TrayIcon do not work if done *after* adding TrayIcon

[Anthony Petrov]

The fix looks good.

--
best regards,
Anthony

On 12/16/2013 05:25 PM, Petr Pchelko wrote:
> Hello, Sergey.
>
>> Since you add new call to addNotify(), can you check that we call removeNotify when necessary?
>
> On Win and Linux we were calling it properly for popups, but on mac os x we haven't been doing that. The new version of the fix fixes that.
>
> The new version is here:
> http://cr.openjdk.java.net/~pchelko/9/8007220/webrev.01/
>
> With best regards. Petr.
>
> On 16.12.2013, at 16:38, Sergey Bylokhov <Sergey.Bylokhov at oracle.com> wrote:
>
>> Hi, Petr.
>> Since you add new call to addNotify(), can you check that we call removeNotify when necessary?
>>
>> On 16.12.2013 16:02, Petr Pchelko wrote:
>>> Hello, AWT Team.
>>>
>>> Please review the fix for the issue:
>>> https://bugs.openjdk.java.net/browse/JDK-8007220
>>> The fix is available at:
>>> http://cr.openjdk.java.net/~pchelko/9/8007220/webrev/
>>>
>>> The problem: the CTrayIcon.popup field was set only in a constructor, but it should be updated every time the popup is opened.
>>>
>>> With best regards. Petr.
>>
>>
>> --
>> Best regards, Sergey.
>>
>