<AWT Dev> [9] Review Request: JDK-7154841 [macosx] Popups appear behind taskbar

[Anthony Petrov]

Hi Petr,

The fix looks fine to me.

--
best regards,
Anthony

On 12/24/2013 01:49 PM, Petr Pchelko wrote:
> Hello, Sergey.
>
> Please se the updated version:
> http://cr.openjdk.java.net/~pchelko/9/7154841/webrev.02/
>
>> Is it possible to the window have a few levels? If not we can use
>> ifelse in applyWindowLevel().
> No, just one. But in case the window is simultaneously alwaysOnTop and
> popup the POPUP window level should take precedence.
>
>> Should we update CWarningWindow.setVisible() also?
> I couldn't think of an example when this would be needed, but let's
> update it also for consistency.
>
> With best regards. Petr.
>
> On 24.12.2013, at 13:18, Sergey Bylokhov <Sergey.Bylokhov at oracle.com
> <mailto:Sergey.Bylokhov at oracle.com>> wrote:
>
>> HI, Petr.
>> Is it possible to the window have a few levels? If not we can use
>> ifelse in applyWindowLevel(). Should we update
>> CWarningWindow.setVisible() also?
>>
>> On 12/24/13 12:50 PM, Petr Pchelko wrote:
>>> Hello, Anthony.
>>>
>>> Thank you for the review.
>>>
>>> The updated version could be found here:http://cr.openjdk.java.net/~pchelko/9/7154841/webrev.01/
>>>
>>> With best regards. Petr.
>>>
>>> On 23.12.2013, at 23:10, Anthony Petrov<anthony.petrov at oracle.com>  wrote:
>>>
>>>> Hi Petr,
>>>>
>>>> src/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java
>>>>> 621                         applyWindowLevel();
>>>> Here the applyWindowLevel() method should be invoked on the 'pw' instance rather than on 'this'.
>>>>
>>>> --
>>>> best regards,
>>>> Anthony
>>>>
>>>> On 12/23/2013 07:21 PM, Petr Pchelko wrote:
>>>>> Hello, AWT Team.
>>>>>
>>>>> Please review the fix for the issue:
>>>>> https://bugs.openjdk.java.net/browse/JDK-7154841
>>>>> The fix is available at:
>>>>> http://cr.openjdk.java.net/~pchelko/9/7154841/webrev/
>>>>>
>>>>> The fix is simple: for popup windows we should use an NSPopupMenuWindowLevel level.
>>>>>
>>>>> With best regards. Petr.
>>>>>
>>
>>
>> --
>> Best regards, Sergey.
>