<AWT Dev> [9] Review Request: 8030987 sun_awt_X11_GtkFileDialogPeer.h can be removed

Petr Pchelko petr.pchelko at oracle.com
Wed Dec 25 10:32:40 PST 2013


> Usually the license header contains the date when the non-documentation change was done, and it was 2012 for this file.
Oh.. Sure. The fix looks good in this case.

With best regards. Petr.

25 дек. 2013 г., в 10:31 после полудня, Sergey Bylokhov <Sergey.Bylokhov at oracle.com> написал(а):

> Hi, Petr.
> Thanks for the quick review.
> Usually the license header contains the date when the non-documentation change was done, and it was 2012 for this file.
> 
> On 25.12.2013 22:28, Petr Pchelko wrote:
>> Hello, Sergey.
>> 
>>> - sun_awt_X11_GtkFileDialogPeer.c added copyright header
>> The copyright header says 2012. Should that be 2013?
>> 
>> All the rest look good.
>> 
>> With best regards. Petr.
>> 
>> 25 дек. 2013 г., в 10:20 после полудня, Sergey Bylokhov <Sergey.Bylokhov at oracle.com> написал(а):
>> 
>>> Hello.
>>> Please review the fix for jdk 9.
>>> - sun_awt_X11_GtkFileDialogPeer.h was removed, because it is created during the build of jdk.
>>> - sun_awt_X11_GtkFileDialogPeer.c added copyright header
>>> - small cleanup in java file.
>>> 
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8030987
>>> Webrev can be found at: http://cr.openjdk.java.net/~serb/8030987/webrev.00
>>> 
>>> -- 
>>> Best regards, Sergey.
>>> 
> 
> 
> -- 
> Best regards, Sergey.
> 



More information about the awt-dev mailing list