<AWT Dev> [9] Review Request: JDK-7154841 [macosx] Popups appear behind taskbar

Sergey Bylokhov Sergey.Bylokhov at oracle.com
Mon Dec 30 03:12:08 PST 2013


Hi, Petr.
One related question:
Is this change related to the SunToolkit.canPopupOverlapTaskBar()? Do 
you know why it always return false on macosx?

On 24.12.2013 13:18, Sergey Bylokhov wrote:
> HI, Petr.
> Is it possible to the window have a few levels? If not we can use 
> ifelse in applyWindowLevel(). Should we update 
> CWarningWindow.setVisible() also?
>
> On 12/24/13 12:50 PM, Petr Pchelko wrote:
>> Hello, Anthony.
>>
>> Thank you for the review.
>>
>> The updated version could be found here:http://cr.openjdk.java.net/~pchelko/9/7154841/webrev.01/
>>
>> With best regards. Petr.
>>
>> On 23.12.2013, at 23:10, Anthony Petrov<anthony.petrov at oracle.com>  wrote:
>>
>>> Hi Petr,
>>>
>>> src/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java
>>>> 621                         applyWindowLevel();
>>> Here the applyWindowLevel() method should be invoked on the 'pw' instance rather than on 'this'.
>>>
>>> --
>>> best regards,
>>> Anthony
>>>
>>> On 12/23/2013 07:21 PM, Petr Pchelko wrote:
>>>> Hello, AWT Team.
>>>>
>>>> Please review the fix for the issue:
>>>> https://bugs.openjdk.java.net/browse/JDK-7154841
>>>> The fix is available at:
>>>> http://cr.openjdk.java.net/~pchelko/9/7154841/webrev/
>>>>
>>>> The fix is simple: for popup windows we should use an NSPopupMenuWindowLevel level.
>>>>
>>>> With best regards. Petr.
>>>>
>
>
> -- 
> Best regards, Sergey.


-- 
Best regards, Sergey.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20131230/00441725/attachment.html 


More information about the awt-dev mailing list