<AWT Dev> [8] Review request for 8005492: Reduce number of warnings in sun/awt/* classes

Anthony Petrov anthony.petrov at oracle.com
Tue Jan 15 03:28:03 PST 2013


The fix looks good to me.

--
best regards,
Anthony

On 1/14/2013 15:04, mikhail cherkasov wrote:
> Thanks Artem,
> I haven't found any mention of ScrollPane.java in patch file, strange 
> that it is listed in webrev.
> 
> BTW, I still need one more reviewer. Could someone please assist with 
> review?
> 
> Thanks,
> Mikhail.
> 
> 14.01.2013 14:23, Artem Ananiev пишет:
>> Hi, Mikhail,
>>
>> this .02 version of the webrev looks fine. Don't forget to revert 
>> ScrollPane.java before pushing the fix, as this file is not changed.
>>
>> Thanks,
>>
>> Artem
>>
>> On 1/9/2013 8:50 PM, mikhail cherkasov wrote:
>>> Hello All,
>>>
>>> Could you please review new version:
>>> http://cr.openjdk.java.net/~mcherkas/8005492/webrev.02/
>>> <http://cr.openjdk.java.net/%7Emcherkas/8005492/webrev.02/>
>>>
>>> I revert all changes that replace deprecated API use. I think that
>>> changes are not clear
>>> and can produce problems for people who will migrate to jdk8.
>>>
>>> Thanks,
>>> Mikhail.
>>>
>>> 29.12.2012 14:41, mikhail cherkasov пишет:
>>>> Hello All,
>>>>
>>>> Please review the following patch:
>>>>
>>>> webrev: http://cr.openjdk.java.net/~mcherkas/8005492/webrev.00/
>>>> <http://cr.openjdk.java.net/%7Emcherkas/8005492/webrev.00/>
>>>> bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8005492
>>>>
>>>> the following classes was cleaned from warnings:
>>>> src/share/classes/java/awt/Button.java
>>>> src/share/classes/java/awt/Canvas.java
>>>> src/share/classes/java/awt/Checkbox.java
>>>> src/share/classes/java/awt/Choice.java
>>>> src/share/classes/java/awt/Component.java
>>>> src/share/classes/java/awt/Container.java
>>>> src/share/classes/java/awt/Dialog.java
>>>> src/share/classes/java/awt/FontMetrics.java
>>>> src/share/classes/java/awt/Frame.java
>>>> src/share/classes/java/awt/Graphics.java
>>>> src/share/classes/java/awt/KeyboardFocusManager.java
>>>> src/share/classes/java/awt/ScrollPane.java
>>>> src/share/classes/java/awt/Scrollbar.java
>>>> src/share/classes/java/awt/TextArea.java
>>>> src/share/classes/java/awt/TextComponent.java
>>>> src/share/classes/java/awt/TextField.java
>>>> src/share/classes/java/awt/Toolkit.java
>>>> src/share/classes/java/awt/Window.java
>>>> src/share/classes/sun/awt/image/SurfaceManager.java
>>>>
>>>> Thanks,
>>>> Mikhail.
>>>
> 



More information about the awt-dev mailing list