<AWT Dev> [8] Review request for CR 8020210 [macosx] JVM crashes in CWrapper$NSWindow.screen(long)

[Anthony Petrov]

Hi Petr,

A few questions:

Does getGraphicsDevice() always return a non-null value?

A specific GC is always associated with a window. Why do we use the 
default one then?

After removing CWrapper.NSWindow.screen(), do we still use any of the 
CWrapper.NSScreen methods?

--
best regards,
Anthony

On 07/10/2013 02:31 PM, Petr Pchelko wrote:
> Hello, AWT Team.
>
> Please review the fix for the following issue:
> http://bugs.sun.com/view_bug.do?bug_id=8020210
> The fix is available at:
> http://cr.openjdk.java.net/~pchelko/8020210/webrev.00/
>
> In case the window is offscreen the [NSWindow screen] method could return null, so we crashed in CFRetain(screen). So the CWrapper.Window.screen method is quite dangerous. I've replaced it with getting screen bounds/insets using a GraphicsDevice.
>
> With best regards. Petr.
>