<AWT Dev> [URGENT] Code Review Request: JDK-8009168

Ragini Prasad ragini.prasad at oracle.com
Wed Jul 10 13:03:35 PDT 2013


Thanks Michael and Pete for review and approval.

Alexandr,
Can you please review / approve it.
Thanks,
Ragini.

On 7/10/2013 12:49 PM, Michael Fang wrote:
> Thanks so much Ragini. The webrevs look good.
>
> thanks,
>
> -michael
>
> On 07/10/13 12:40, Ragini Prasad wrote:
>> Hi Michael,
>> Ive added for translated files too. See webrev below for 8 and 7:
>>
>> JDK8:
>> http://javaweb.us.oracle.com/~rrprasad/AccessBridge/8009168/jdk8/webrev.1/
>>
>> JDK7udev
>> http://cr.openjdk.java.net/~raginip/8009168/webrev.1/
>>
>> Thanks,
>> Ragini.
>>
>> On 7/10/2013 11:54 AM, Michael Fang wrote:
>>> Hi Ragini,
>>>
>>> Thanks for the fix. The webrev looks good to me.
>>>
>>> Do you think you can also update the l10n files together since it 
>>> doesn't involve translation changes? Our team currently doesn't have 
>>> another message drop planned for 7u40. For jdk8, the message update 
>>> will be done around August 22.
>>>
>>> thanks,
>>>
>>> -michael
>>>
>>> On 07/10/13 10:52, Ragini Prasad wrote:
>>>> Michael, Alexandr, Pete,
>>>> Could you please urgently review / approve the bug fix for the 
>>>> following:
>>>>
>>>> Bug id:
>>>> https://jbs.oracle.com/bugs/browse/JDK-8009168
>>>>
>>>> Brief Fix Explanation:
>>>> A simple fix to modify the String value for TOGGLE_EXPAND in 
>>>> AccessibleAction from "toggle expand" to "toggleexpand".
>>>> And a follow up change in 
>>>> jdk/src/share/classes/com/sun/accessibility/internal/resources/accessibility.properties
>>>>
>>>> The localized versions change will be fixed by Michaels team for 
>>>> localized version of accessibility.properties.
>>>>
>>>> Webrev for JDK8:
>>>> http://javaweb.us.oracle.com/~rrprasad/AccessBridge/8009168/jdk8/webrev.0/ 
>>>>
>>>>
>>>> Webrev for 7udev:
>>>> http://javaweb.us.oracle.com/~rrprasad/AccessBridge/8009168/jdk7udev/webrev.0/ 
>>>>
>>>>
>>>> Note: Will send email for review / approval on 7udev 
>>>> jdk7u-dev at openjdk.java.net 
>>>> <http://mail.openjdk.java.net/mailman/listinfo/jdk7u-dev> shortly.
>>>> Thanks,
>>>> Ragini.
>>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20130710/cc922a4f/attachment.html 


More information about the awt-dev mailing list