<AWT Dev> [8] Review request for 6847588: AWT test fails

Sergey Bylokhov Sergey.Bylokhov at oracle.com
Thu Jun 13 02:32:38 PDT 2013


On 11.06.2013 17:21, Anthony Petrov wrote:
> On 06/11/2013 03:31 PM, Sergey Bylokhov wrote:
>> On 11.06.2013 15:04, Anthony Petrov wrote:
>>> In (X)KFMPeer.java we know we always operate on Window instances. The
>>> setCurrentFocusedWindow(Window) method will never be called with any
>>> other components. Therefore, to avoid the overhead of taking multiple
>>> locks I suggest to use the AWTAccessor.getPeer directly in this case.
>> SunToolkiit already used in osx version of KeyboardFocusManagerPeer.
>
> That may as well be a mistake.
And absence of the lock in an accessor is a bug too.

-- 
Best regards, Sergey.



More information about the awt-dev mailing list