<AWT Dev> [8] Request for review: 8000435: [macosx] Button painting error under Java 7 on Mac

Denis S. Fokin denis.fokin at oracle.com
Fri Mar 15 10:06:15 PDT 2013


This 'magical' fix looks fine to me.

Thank you,
    Denis.

On 3/15/2013 8:58 PM, Sergey Bylokhov wrote:
>
> Hello,
> Please review the fix for jdk 8. Fix will be ported to jdk7 as well.
> This is a tweak of the code which mimic some macosx constant.
> The problem was in the assumption that we can paint native buttons with
> the height of >=18 pixel(28 - 5 - 5 ), but currently it should be
>> =24(28 - 2 - 2).
>
> In AquaButtonExtendedTypes constants in alterInsets() were changed to be
> less strict.
> http://cr.openjdk.java.net/~serb/8000435/before_segmentedRoundRect_first_small.png
>
> http://cr.openjdk.java.net/~serb/8000435/after_segmentedRoundRect_first_small.png
>
>
> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8000435
> Webrev can be found at: http://cr.openjdk.java.net/~serb/8000435/webrev.00/
>




More information about the awt-dev mailing list