<AWT Dev> [7uX] Review request for 8010721: In JDK7 the menu bar disappears when a Dialog is shown

[Anthony Petrov]

On 3/25/2013 19:08, Vladislav Karnaukhov wrote:
> Yes, that would definitely work and I know that we usually fix issues in 
> jdk8 first. I was just hoping to discuss a possible way to change menu 
> bar items when a modal dialog is shown - regardless of jdk version, as 
> the issue is reproducible in both jdk7 and jdk8.

I see. It would still be best to start with a fix for JDK 8 first. 
Generally, the if() statement in windowDidBecomeKey: you're proposing 
looks OK to me. Could you please prepare such a fix, test it with JDK 8, 
and post it for review here?


> bugs.sun.com also doesn't contain an information about this bug. Maybe 
> this is due to slow synchronization between Jira and bugs.sun.com.

That's correct. However, the jbs links are useless for outside folks, 
and the synchronization is happening every day in any case. So you can 
always post a link to bugs.sun.com and say it's going to be available in 
a day or two. This is our usual practice.

--
best regards,
Anthony

> 
> - Vlad
> 
> On 3/25/2013 07:00 PM, Anthony Petrov wrote:
>> Hi Vladislav,
>>
>> Usually we port fixes in the backward direction - fix an issue in the
>> current development release (JDK 8) first, and then port it to an update
>> for a previous release(s) if there's enough justification. This allows
>> your fix to be baked in the beta release for some time, to ensure no
>> regressions arise. Would that process work for this issue?
>>
>> Also, at this time the JBS system is unavailable outside Oracle. Please
>> provide links to bugs at bugs.sun.com when posting on public mailing 
>> lists.
>>
>> -- 
>> best regards,
>> Anthony
>>
>> On 03/25/13 18:01, Vladislav Karnaukhov wrote:
>>> Hello,
>>>
>>> please review an initial version of the fix for 8010721.
>>>
>>> This solution doesn't handle a situation when a modal dialog is shown.
>>> In this case we should disable a menu bar' items. My fix doesn't do
>>> this. I would welcome a suggestion on how we could track a window that
>>> loses its "key" status.
>>>
>>> I know that in jdk8 we track the last key window, however in jdk7 this
>>> code is absent. Would it be feasible to introduce this code into jdk7?
>>> The issue is reproducible in jdk8 too BTW, so definitely I'll forward
>>> this fix into jdk8.
>>>
>>> jira: https://jbs.oracle.com/bugs/browse/JDK-8010721
>>> webrev: http://cr.openjdk.java.net/~vkarnauk/8010721/jdk7/webrev.00/
>>>
>>> Regards,
>>> - Vlad
> 
>