<AWT Dev> <Swing Dev> [PATCH] 7168064: SwingUtilities.sharedOwnerFrame multiplies window close event

[Anthony Petrov]

Thank you, Jose. Here's an updated webrev:

http://cr.openjdk.java.net/~anthony/8-59-windowClosedEvents-8015500.1/

The fix still looks fine to me.

Could anyone else review it please?

--
best regards,
Anthony

On 05/28/2013 09:03 PM, Jose Luis Martin wrote:
> Hi Anthony,
>
> Just fixed. Thanks again.
>
> Best Regards,
>
>
> -- Jose Luis Martin.
>
>
> On 28-05-2013 a las 19:13 +0400, Anthony Petrov wrote
>> Hi Jose,
>>
>> I filed a bug for this issue:
>> http://bugs.sun.com/view_bug.do?bug_id=8015500
>>
>> and published your patch as a webrev at:
>>
>> http://cr.openjdk.java.net/~anthony/8-59-windowClosedEvents-8015500.0/
>>
>> Please note that in JDK we use 4 spaces (and not TABs characters) for
>> indenting lines. Could you please reformat your test and also use proper
>> indentation for the two lines in Window.java that you're changing? Also,
>> the copyright header in the test should be from the year 2013, not 2006.
>> :) Please fix this and resend your patch.
>>
>> Other than these minor suggestions, the proposed fix looks good to me.
>>
>> Note that we need to get at least one more review from a reviewer on
>> this mailing list before we can push this fix to a repository.
>>
>> --
>> best regards,
>> Anthony
>