<AWT Dev> Review Request: JDK-7124253 [macosx] Flavor change notification not coming

[Anthony Petrov]

+1.

--
best regards,
Anthony

On 11/14/2013 05:01 PM, Sergey Bylokhov wrote:
> Hi, Petr.
> Thanks. Fix looks fine.
>
> On 14.11.2013 16:58, Petr Pchelko wrote:
>> Hello, Sergey.
>>
>> Thank you for the review, the updated version is here:
>> http://cr.openjdk.java.net/~pchelko/7124253/webrev.01/
>>
>> I've split too long lines in native and also removed commented-out code.
>>
>> With best regards. Petr.
>>
>> On 14.11.2013, at 16:41, Sergey Bylokhov <Sergey.Bylokhov at oracle.com>
>> wrote:
>>
>>> Hi, Petr.
>>> The fix looks good, but can you split "very-long" lines in these files.
>>>
>>> On 14.11.2013 15:32, Petr Pchelko wrote:
>>>> Hello, AWT Team.
>>>>
>>>> Please review the fix for the issue:
>>>> https://bugs.openjdk.java.net/browse/JDK-7124253
>>>> The fix is available at:
>>>> http://cr.openjdk.java.net/~pchelko/7124253/webrev/
>>>>
>>>> The problem was the we did not track flavor changes on Mac. This
>>>> should be tracked for 2 possible cases:
>>>> 1. Flavors changed by Java - it's simple, just check if flavors
>>>> changed when setting contents to native clipboard
>>>> 2. Flavors changed by other apps. Mac does not provide notifications
>>>> when clipboard contents change, so we
>>>> do the same as we do for clipboard owner tracking: the
>>>> checkPasteboard is registered to the ApplicationDidBecomeActive
>>>> notification, and when app get's activated we check if the flavors
>>>> changed.
>>>>
>>>> It's a P4, but SQE test and a couple of our regression tests are
>>>> failing because of this issue.
>>>> Checked with SQE and reg tests for clipboard and DataTransfer.
>>>
>>> --
>>> Best regards, Sergey.
>>>
>
>