<AWT Dev> [8] Review request for 8028995: Write regression test for JDK-8016356

[Sergey Bylokhov]

Thanks!
The fix looks good.

On 22.11.2013 18:19, Oleg Pekhovskiy wrote:
> Hi Sergey,
>
> thanks you for the review,
> please take a look at the next version of fix:
> http://cr.openjdk.java.net/~bagiras/8028995.2/
>
> Changes:
> 1. OSInfo used.
> 2. Location and Dimensions of Frame are retrieved on EDT.
>
> Thanks,
> Oleg
>
> On 22.11.2013 17:16, Sergey Bylokhov wrote:
>> Hi, Oleg.
>> Usually we check the type of OS via sun.awt.OSInfo
>> Note that all these things should be on EDT as well:
>>
>>    // Retrieving the color of window expanded area
>>    86                 p = frame.getLocationOnScreen();
>>    87                 d = frame.getSize();
>>    88                 Insets insets = frame.getInsets();
>>
>>    91
>>    92                 frame.dispose();
>>
>>
>> On 22.11.2013 16:37, Oleg Pekhovskiy wrote:
>>> Hi all,
>>>
>>> please review the fix
>>> http://cr.openjdk.java.net/~bagiras/8028995.1/
>>> for
>>> https://bugs.openjdk.java.net/browse/JDK-8028995
>>>
>>> It's just a regression test for JDK-8016356.
>>>
>>> Thanks,
>>> Oleg
>>
>>


-- 
Best regards, Sergey.