<AWT Dev> <AWT-Dev> [8] Review Request: JDK-8011142 [TEST_BUG] 2 AppContext regression tests failed since 7u25b03 with NullPointerException

Petr Pchelko petr.pchelko at oracle.com
Tue Nov 26 07:23:24 PST 2013


Please review the updated fix:
http://cr.openjdk.java.net/~pchelko/8011142/webrev.01/

It appears that we do not have a regression test for the AppContext fix.
So it was decided to change the test instead of removing it.

Thank you.
With best regards. Petr.

On 26.11.2013, at 17:19, Anthony Petrov <anthony.petrov at oracle.com> wrote:

> +1.
> 
> --
> best regards,
> Anthony
> 
> On 11/26/2013 04:16 PM, Petr Pchelko wrote:
>> Hello, AWT Team.
>> 
>> Please review the fix for the issue:
>> https://bugs.openjdk.java.net/browse/JDK-8011142
>> The fix is available at:
>> http://cr.openjdk.java.net/~pchelko/8011142/webrev/
>> 
>> The MainAppContext test verified that the mainAppContext is created when there's already another AppContext created.
>> After the AppContext fix this is incorrect, so the test should be removed, as it's expecting the wrong behavior. The second
>> test mentioned in the bug was already fixed.
>> 
>> We cannot modify the test, because it's testing exclusively the behavior which is wrong now.
>> 
>> Thank you.
>> With best regards. Petr.
>> 



More information about the awt-dev mailing list