<AWT Dev> [8] Review Request: JDK-8024158 [macosx] java/awt/EventDispatchThread/LoopRobustness/LoopRobustness still failed after fix JDK-8022247; since jdk8b96

[Petr Pchelko]

Hello, Leonid.

> Looks good, assuming that the rest of the requestWindowFocus() code doesn't call anything that eventually calls getAppContext().
I've looked through the code and it looks like it does not. Don't know any better way to verify this.

With best regards. Petr.

On Oct 2, 2013, at 4:43 PM, Leonid Romanov <leonid.romanov at oracle.com> wrote:

> Looks good, assuming that the rest of the requestWindowFocus() code doesn't call anything that eventually calls getAppContext().
> 
> On 10/2/2013 16:17, Petr Pchelko wrote:
>> Hello, AWT Team.
>> 
>> Please review the fix for the issue:
>> https://bugs.openjdk.java.net/browse/JDK-8024158
>> The fix is available at:
>> http://cr.openjdk.java.net/~pchelko/8024158/webrev.00/
>> 
>> The problem: Appkit thread could not have an AppContext, so we cannot call KeyboardFocusManager. getCurrentKeyboardFocusManager on it.
>> 
>> The solution: use the Window AppContext to get the KeyboardFocusManager.
>> 
>> With best regards. Petr.
>