<AWT Dev> [8] Review Request: JDK-8025236 [javadoc] fix some errors in AWT

Dmitry Ginzburg dmitry.ginzburg at oracle.com
Fri Oct 4 06:49:39 PDT 2013


doclint doesn't show any error on this issue

04.10.2013 17:47, Sergey Bylokhov wrote:
> InputContext.java: If you remove <p> tag from the end of the list you 
> should remove it from the beginning of the list as well.
>
> On 04.10.2013 17:43, Sergey Bylokhov wrote:
>> *InputEvent.java: *I suppose it would be better to add code tag 
>> instead of changes "&" in the code to &amp;.
>>
>> On 04.10.2013 17:38, Dmitry Ginzburg wrote:
>>> Hi Anthony
>>>
>>> I renewed this fix against your issues: 
>>> http://cr.openjdk.java.net/~yan/jdk-8025236/webrev.01/
>>>
>>> Thanks,
>>> -Dmitry
>>>
>>> 01.10.2013 22:14, Anthony Petrov wrote:
>>>> You should only change the <code> issues in lines that are already 
>>>> modified in your fix. No massive reformatting please.
>>>>
>>>> And yes, the rest of the procedure is to publish the second version 
>>>> of the webrev, and post a link to this mailing list.
>>>>
>>>> -- 
>>>> best regards,
>>>> Anthony
>>>>
>>>> On 09/30/2013 05:52 PM, Dmitry Ginzburg wrote:
>>>>> So, should I fix all the issues with this "<code>"'s, do webrev again
>>>>> and send it to yan, and send it here again?
>>>>>
>>>>> Thanks,
>>>>>
>>>>> -Dmitry
>>>>>
>>>>> 27.09.2013 17:52, Anthony Petrov wrote:
>>>>>> The fix looks good to me. Again, if possible, I'd suggest to replace
>>>>>> <code> with {@code ..} if you're changing a line anyway.
>>>>>>
>>>>>> -- 
>>>>>> best regards,
>>>>>> Anthony
>>>>>>
>>>>>> On 09/26/2013 06:21 PM, Dmitry Ginzburg wrote:
>>>>>>> Hello, AWT Team.
>>>>>>>
>>>>>>> Please review the fix for the following issue:
>>>>>>> https://bugs.openjdk.java.net/browse/JDK-8025236
>>>>>>> The fix is available at:
>>>>>>> http://cr.openjdk.java.net/~yan/jdk-8025236/webrev.00/
>>>>>>>
>>>>>>> This is the fix for javadoc errors, on which doclint was showing 
>>>>>>> some
>>>>>>> issues.
>>>>>>>
>>>>>>> The patch contains only simple markup fixes; no changes/fixes in
>>>>>>> documentation text; the specification itself wasn't changed.
>>>>>>>
>>>>>>> Thanks,
>>>>>>> -Dmitry
>>>
>>>
>>
>>
>> -- 
>> Best regards, Sergey.
>
>
> -- 
> Best regards, Sergey.


-- 
Dmitry Ginzburg, FXSQE team member

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20131004/4f8febe2/attachment.html 


More information about the awt-dev mailing list