<AWT Dev> [8] Review Request: JDK-8025236 [javadoc] fix some errors in AWT
Anthony Petrov
anthony.petrov at oracle.com
Tue Oct 8 00:13:20 PDT 2013
Hi Dmitry,
The fix looks good to me. Thanks.
--
best regards,
Anthony
On 10/04/2013 05:38 PM, Dmitry Ginzburg wrote:
> Hi Anthony
>
> I renewed this fix against your issues:
> http://cr.openjdk.java.net/~yan/jdk-8025236/webrev.01/
>
> Thanks,
> -Dmitry
>
> 01.10.2013 22:14, Anthony Petrov wrote:
>> You should only change the <code> issues in lines that are already
>> modified in your fix. No massive reformatting please.
>>
>> And yes, the rest of the procedure is to publish the second version of
>> the webrev, and post a link to this mailing list.
>>
>> --
>> best regards,
>> Anthony
>>
>> On 09/30/2013 05:52 PM, Dmitry Ginzburg wrote:
>>> So, should I fix all the issues with this "<code>"'s, do webrev again
>>> and send it to yan, and send it here again?
>>>
>>> Thanks,
>>>
>>> -Dmitry
>>>
>>> 27.09.2013 17:52, Anthony Petrov wrote:
>>>> The fix looks good to me. Again, if possible, I'd suggest to replace
>>>> <code> with {@code ..} if you're changing a line anyway.
>>>>
>>>> --
>>>> best regards,
>>>> Anthony
>>>>
>>>> On 09/26/2013 06:21 PM, Dmitry Ginzburg wrote:
>>>>> Hello, AWT Team.
>>>>>
>>>>> Please review the fix for the following issue:
>>>>> https://bugs.openjdk.java.net/browse/JDK-8025236
>>>>> The fix is available at:
>>>>> http://cr.openjdk.java.net/~yan/jdk-8025236/webrev.00/
>>>>>
>>>>> This is the fix for javadoc errors, on which doclint was showing some
>>>>> issues.
>>>>>
>>>>> The patch contains only simple markup fixes; no changes/fixes in
>>>>> documentation text; the specification itself wasn't changed.
>>>>>
>>>>> Thanks,
>>>>> -Dmitry
>
>
More information about the awt-dev
mailing list