<AWT Dev> [8] Review request for 7081594 Windows owned by an always-on-top window DO NOT automatically become always-on-top

[Artem Ananiev]

On 10/8/2013 1:05 PM, Alexander Scherbatiy wrote:
> On 10/4/2013 3:39 PM, Anthony Petrov wrote:
>> Good point, Sergey. Indeed, it seems that resetting the always on top
>> state to false for an owner window shouldn't affect its owned windows.
>
>     I do not agree with this. According to the javadoc:
> http://docs.oracle.com/javase/7/docs/api/java/awt/Window.html#setAlwaysOnTop%28boolean%29
>
>      ------------------------------
>      All windows owned by an always-on-top window inherit this state and
> automatically become always-on-top.
>      If a window ceases to be always-on-top, the windows that it owns
> will no longer be always-on-top.
>     ------------------------------
>
>    It clearly says that resetting the window always on top state to
> false should also reset the always on top state for its owned windows.

Thanks for this JavaDoc excerpt. It seems the fix is correct now.

Thanks,

Artem

>    Thanks,
>    Alexandr.
>
>>
>> --
>> best regards,
>> Anthony
>>
>> On 10/04/2013 03:29 PM, Sergey Bylokhov wrote:
>>> Hello.
>>> It is interesting what should happens if we set saot for the child, then
>>> set it to the owner, and then remove this property from the owner.
>>>
>>> On 04.10.2013 12:46, Artem Ananiev wrote:
>>>>
>>>> On 10/4/2013 12:24 PM, Anthony Petrov wrote:
>>>>> The fix looks good to me.
>>>>
>>>> +1.
>>>>
>>>> I would also add a comment to security exception [empty] handler that
>>>> we don't really expect exceptions here: either we have the permission,
>>>> or the owner is not alwaysOnTop.
>>>>
>>>> Thanks,
>>>>
>>>> Artem
>>>>
>>>>> --
>>>>> best regards,
>>>>> Anthony
>>>>>
>>>>> On 10/03/2013 05:03 PM, Alexander Scherbatiy wrote:
>>>>>> Hello,
>>>>>>
>>>>>> Could you review the fix:
>>>>>>    bug: https://bugs.openjdk.java.net/browse/JDK-7081594
>>>>>>    webrev: http://cr.openjdk.java.net/~alexsch/7081594/webrev.00
>>>>>>
>>>>>>    The fix:
>>>>>>      - sets alwaysOnTop field for a new created window from the
>>>>>> parent
>>>>>> value
>>>>>>      - propagates the alwaysOnTop value in setAlwaysOnTop() method to
>>>>>> the owned windows
>>>>>>
>>>>>> Thanks,
>>>>>> Alexandr.
>>>>>>
>>>
>>>
>