<AWT Dev> Review request for JDK-8026021: more fix of javadoc errors and warnings reported by doclint

[Anthony Petrov]

Thanks for the comments and the corrections, Christine. The updated 
webrev looks fine to me.

--
best regards,
Anthony

On 10/09/2013 12:57 AM, christine.lu at oracle.com wrote:
> Thank you all for reviewing. I have posted a new webrev at
> http://cr.openjdk.java.net/~cl/8026021/webrev.01
> <http://cr.openjdk.java.net/%7Ecl/8026021/webrev.00/>
>
> Thanks
> Christine
>
>
> Sergey Bylokhov wrote:
>> Hi Christine,
>> Also looks like you fix include the fix for
>> http://mail.openjdk.java.net/pipermail/awt-dev/2013-September/005699.html
>> InputContext.java:
>> If you look to the generated javadoc you'll see that now the space
>> before list is not the same to the space after the list. So <p> from
>> the beggining should be removed as well.
>>
>> On 10/8/13 12:51 PM, Anthony Petrov wrote:
>>> Hi Christine,
>>>
>>> src/share/classes/java/awt/event/InputEvent.java
>>>> -     * <PRE>
>>>> +     * <PRE>{@code
>> I think not in this case. Since pre tag does not work with &
>> correctly. Probably pre can be removed here?
>> I n the NumericShaper.java I see that & was changed to the &amp;
>> inside <code>. I suppose it is not necessary and <code> can be changed
>> to {@code}
>> Same question about JTextComponent.java can we use {@code} tag for the
>> code instead of &ge;
>>
>>>
>>> The {@code} is redundant here because the <pre> tag forces the text
>>> to use a fixed-size font already. Same comment for
>>> src/share/classes/java/awt/font/LineBreakMeasurer.java.
>>>
>>>
>>> src/share/classes/java/awt/event/MouseEvent.java
>>>> - * <code>Component</code>). Due to platform-dependent Drag&Drop
>>>> implementations,
>>>> + * <code>Component</code>).  Due to platform-dependent
>>>> Drag&amp;Drop implementations,
>>>
>>> Since you change this line anyway, I also suggest to replace <code>
>>> with {@code} here. Same comment for
>>> src/share/classes/java/awt/font/NumericShaper.java.
>>>
>>>
>>> src/share/classes/java/awt/font/OpenType.java
>>>> - * ( <a
>>>> href=http://www.microsoft.com/typography/otspec/">http://www.microsoft.com/typography/otspec/l</a>
>>>> ).
>>>> + * ( <a href="http://www.microsoft.com/typography/otspec/"
>>>> <http://www.microsoft.com/typography/otspec/>>http://www.microsoft.com/typography/otspec/l</a>
>>>> ).
>>>
>>> There's an extra 'l' character right before the closing </a>, which
>>> needs to be removed.
>>>
>>> --
>>> best regards,
>>> Anthony
>>>
>>> On 10/08/2013 05:59 AM, christine.lu at oracle.com
>>> <mailto:christine.lu at oracle.com> wrote:
>>>> Hi,
>>>>
>>>> Please review a fix for
>>>>
>>>> https://bugs.openjdk.java.net/browse/JDK-8026021
>>>> more fix of javadoc errors and warnings reported by doclint, see the
>>>> description
>>>>
>>>> webrev: http://cr.openjdk.java.net/~cl/8026021/webrev.00/
>>>> <http://cr.openjdk.java.net/%7Ecl/8026021/webrev.00/>
>>>>
>>>> Thanks
>>>> Christine
>>>>
>>>>
>>
>>
>> --
>> Best regards, Sergey.
>