<AWT Dev> [8] Review Request: JDK-8024329 [macosx] JRadioButtonMenuItem behaves like a checkbox when using the ScreenMenuBar

[Anthony Petrov]

Hi Petr,

I'm not an expert in this code, but the changes look good to me.

--
best regards,
Anthony

On 10/11/2013 01:35 PM, Petr Pchelko wrote:
> Hello, AWT Team.
>
> Please review the new version of the fix:
> http://cr.openjdk.java.net/~pchelko/8024329/webrev.01/
>
> This version of the fix does not expose the package-private class com.apple.laf.ScreenMenuItemCheckbox
> Instead we override the setState method to no-op and force the setState only when it's really needed.
>
> With best regards. Petr.
>
> On 10.10.2013, at 18:19, Petr Pchelko <petr.pchelko at oracle.com> wrote:
>
>> Hello, AWT Team.
>>
>> Please review the fix for the issue:
>> https://bugs.openjdk.java.net/browse/JDK-8024329
>> The fix is available at:
>> http://cr.openjdk.java.net/~pchelko/8024329/webrev.00/
>>
>> The problem: for AWT menu the peer should update the menu item state unconditionally. However for the Swing menu items used in screen menubar swing should decide wether to update the state or not. So we should not unconditionally update the sate.
>> There's no regression test as there's no way to understand if the native menu item is checked or not.
>>
>> With best regards. Petr.
>