<AWT Dev> [8] Review Request: 7090424 TestGlyphVectorLayout failed automately with java.lang.StackOverflowError

Sergey Bylokhov Sergey.Bylokhov at oracle.com
Tue Oct 22 10:53:10 PDT 2013


On 22.10.2013 21:46, Anthony Petrov wrote:
> See above: if you call Canvas.setBackground(null), currently this 
> triggers repainting of the canvas even if the background hasn't been 
> set previously. After your fix removes XCanvasPeer.setBackground(), 
> this is no longer true. So, -1 time we repaint the canvas. This is 
> what I mean under "not sure...". Let's hope this won't break user code 
> (though it would be worthwhile to investigate the previous logic and 
> understand why this was done...) 
Correct, but color should not be null, because of the code in 
Component.setBackground()
             c = getBackground();
             if (c != null) {
                 peer.setBackground(c);
             }

-- 
Best regards, Sergey.



More information about the awt-dev mailing list