<AWT Dev> [8] Review Request for JDK-8023966 JViewPort.BLIT_SCROLL_MODE does not work in JLightweightFrame

[Artem Ananiev]

Hi, Petr,

the fix looks fine (I see it's been resolved already). However, it would 
be fine to document the new behavior somewhere.

BTW, have you verified that this fix doesn't break JCK tests? I haven't 
seen anywhere in JavaDoc that getScrollMode() must return the value 
previously set with setScrollMode(), but I can imagine JCK tests 
checking that. If such tests exist, they should be corrected, but it 
doesn't eliminate the need to document the new behavior.

Thanks,

Artem

On 8/29/2013 2:32 PM, Petr Pchelko wrote:
> Hello, AWT Team.
>
> Please review the fix for the following issue:
> http://bugs.sun.com/view_bug.do?bug_id=8023966
> The issue might not be available at bugs.sun.com. The problem is that JViewPort.BLIT_SCROLL_MODE does not work inside the JLightweightFrame.
>
> The fix is available at:
> http://cr.openjdk.java.net/~pchelko/8023966/webrev.00/
>
> The idea of the fix is to detect if the JViewPort was added into the JLightweightFrame and set a supported scroll mode instead of the BLIT_SCROLL_MODE
>
> With best regards. Petr.
>