<AWT Dev> [8] Review request for 7129133: [macosx] Accelerators are displayed as Meta instead of the Command symbol

[Leonid Romanov]

I've implemented the approach you suggested, but it didn't pass the regression test I've written for this bug. Even though the test isn't run in headless mode, it doesn't trigger LWCToolkit initialization (you have to insert "Toolkit.getDefaultToolkit()" line to force it). So, I'm unsure whether this approach is a right one. What do you guys think?   

On Sep 12, 2013, at 4:23 PM, Anthony Petrov <anthony.petrov at oracle.com> wrote:

> Hi Leonid,
> 
> Why not put the OS X specific logic into the LWCToolkit and set the Toolkit.platformResources field via the AWTAccessor? This would help avoid checking for a specific platform in our shared code.
> 
> --
> best regards,
> Anthony
> 
> On 09/12/13 15:30, Leonid Romanov wrote:
>> Yes, I'll use OSInfo instead. As for property file name, could you
>> suggest a better one?
>> 
>> On 12.09.2013, at 15:26, Sergey Bylokhov <Sergey.Bylokhov at oracle.com
>> <mailto:Sergey.Bylokhov at oracle.com>> wrote:
>> 
>>> Hi, Leonid.
>>> i think that you can try to reuse OSInfo class.
>>> Also I doubt about property file name.
>>> 
>>> On 12.09.2013 9:09, Leonid Romanov wrote:
>>>> Hi guys,
>>>> Could you review it, please?
>>>> 
>>>> -------- Original Message --------
>>>> Subject: 	[8] Review request for 7129133: [macosx] Accelerators are
>>>> displayed as Meta instead of the Command symbol
>>>> Date: 	Wed, 11 Sep 2013 13:24:32 +0400
>>>> From: 	Leonid Romanov <leonid.romanov at oracle.com>
>>>> To: 	awt-dev <awt-dev at openjdk.java.net>
>>>> CC: 	macosx-port-dev at openjdk.java.net
>>>> <macosx-port-dev at openjdk.java.net>, build-dev
>>>> <build-dev at openjdk.java.net>
>>>> 
>>>> 
>>>> 
>>>> Hello,
>>>> Please review a fix for 7129133: [macosx] Accelerators are displayed as Meta instead of the Command symbol.
>>>> 
>>>> bug:http://bugs.sun.com/view_bug.do?bug_id=7129133
>>>> webrev:http://cr.openjdk.java.net/~leonidr/7129133/webrev.00/
>>>> 
>>>> Thanks,
>>>> Leonid.
>>>> 
>>>> 
>>>> 
>>> 
>>> 
>>> --
>>> Best regards, Sergey.
>>