<AWT Dev> [8] Review Request for 8024122: need test to cover JDK-7146572

[Anthony Petrov]

Hi Alexander,

Indeed, the jtreg FAQ [1] only mentions applet/manual tests. I'm OK with 
your fix then. Thanks for adding a test for this bug.


[1] http://openjdk.java.net/jtreg/faq.html

--
best regards,
Anthony

On 09/13/13 10:28, alexander stepanov wrote:
> Hello Anthony,
>
>  > Does this test have to be an applet test?
>
> It is strange but I wasn't able to start "main/manual=yesno" test using
> current jtreg; the message was:
> "Test.java Error. Parse Exception: Arguments to `manual' option not
> supported: yesno"
>
> It is oddly because the repository contains some other tests with the
> same @run tag options (tried to run one of them and got the similar
> error message).
>
> So I prefer to keep the applet because:
> 1) it provides this handy "yesno" functionality without any effort
> 2) it also allows to place test instructions easily
> while the overhead hopefully isn't so much significant.
>
> Thanks,
> Alexander
>
> On 12.09.2013 17:26, Anthony Petrov wrote:
>> Hi Alexander,
>>
>> Does this test have to be an applet test? Can it be a main test
>> instead to eliminate the unnecessary .html file?
>>
>> Also, you might want to list @bug 8024122 in the test jtreg tags as well.
>>
>> --
>> best regards,
>> Anthony
>>
>> On 09/09/13 15:50, alexander stepanov wrote:
>>> Hello,
>>>
>>> Could you please review the fix for the following [TEST] bug:
>>> http://bugs.sun.com/view_bug.do?bug_id=8024122
>>>
>>> Webrev corresponding:
>>> http://cr.openjdk.java.net/~pchelko/stepanov/7146572/webrev.00/
>>>
>>> Just a new test added; no other code affected.
>>> The patch contains a simple manual test to make sure if
>>> 'enableInputMethods' method works correctly for TextArea and TextField
>>> on Linux platform (hard to automate; the test requires a number of
>>> internationalization settings on a machine).
>>>
>>> Thanks.
>>>
>>> Regards,
>>> Alexander.
>>>
>>> P.S. Apologies for multiple copies; the bug link was incorrect
>>> initially.
>