<AWT Dev> [8] Request for review: 8005255 [macosx] Cleanup warnings in sun.lwawt

[Sergey Bylokhov]

On 16.09.2013 17:08, Anthony Petrov wrote:
> Hi Sergey,
>
> 1. There's some change in RepaintArea logic in LWRepaintArea.java. I'd 
> suggest to push these changes as a separate fix.
There are 2 changed in the file:
  - javadoc
  - flushOnscreenGraphics() is a static method and now it is called via 
class name(LWComponentPeer) instead of instance of this class.
>
> 2. LWWindowPeer.java
>>  46     public enum PeerType {
>
> Why should it not be static?
That's because "Nested enum types are implicitly |static|."
http://docs.oracle.com/javase/specs/jls/se7/html/jls-8.html#jls-8.9
>
> 3.
>>  132         LWWindowPeer ownerPeer = (owner != null) ? 
>> (LWWindowPeer) AWTAccessor
>>  133                 .getComponentAccessor().getPeer(owner) : null;
>
> This could be better formatted as:
>
> ... owner == null ? null :<CR>
> (LWWindowPeer) AWTAccessor...
>
> I.e. to avoid breaking the AWTAccessor call into multiple lines. The 
> same at lines 396, 1166, and 1279.
Will fix it.
>
> The rest of the fix looks fine to me.
>
> -- 
> best regards,
> Anthony
>
> On 09/12/13 18:53, Sergey Bylokhov wrote:
>> Hello,
>> Please review the fix for jdk 8.
>> - Documentation updated
>> - Component.getPeer() replaced with AWTAccessor.
>> - Generics code updated.
>> - For some methods access was changed to weaker
>> - SuppressWarnings were added when needed.
>> Plus some small general cleanup.
>>
>> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8005255
>> Webrev can be found at: 
>> http://cr.openjdk.java.net/~serb/8005255/webrev.00/
>>


-- 
Best regards, Sergey.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20130916/6e009e32/attachment.html