<AWT Dev> [8] Request for review: JDK-8024839 [Unified Swing/Fx threading] don't schedule an event dispatching from the event dispatch thread

Anton V. Tarasov anton.tarasov at oracle.com
Tue Sep 17 23:29:03 PDT 2013


On 9/18/13 10:06 AM, Petr Pchelko wrote:
> Looks fine to me.
>
> Please note that I am not an official reviewer.
Well, I think it's enough you are the author of that code and a jdk8 
commiter =)

Thanks!
Anton.
>
> With best regards. Petr.
>
> On Sep 16, 2013, at 5:55 PM, Anthony Petrov <anthony.petrov at oracle.com> wrote:
>
>> Looks fine.
>>
>> --
>> best regards,
>> Anthony
>>
>> On 09/15/13 19:42, Anton V. Tarasov wrote:
>>> Hello,
>>>
>>> Please, review the fix:
>>>
>>> jira: https://jbs.oracle.com/bugs/browse/JDK-8024839
>>> webrev: http://cr.openjdk.java.net/~ant/JDK-8024839/webrev.0
>>>
>>> In unified Swing/Fx thread mode, an event should be dispatched straight
>>> away when the current thread is reported to be the dispatch thread.
>>>
>>> Otherwise, a "sent event" (like the one produced by
>>> DefaultKeyboardFocusManager.sendMessage) will be a "posted event" which
>>> breaks the functionality.
>>>
>>> Thanks,
>>> Anton.



More information about the awt-dev mailing list