<AWT Dev> [8] Review request for CR 7161320 TEST_BUG: java/awt/event/KeyEvent/SwallowKeyEvents/SwallowKeyEvents.java fails (Invalid key code)

[Anthony Petrov]

Perhaps we should filter out the Windows platform then, and let the test 
run on any other platform instead of restricting it to OS X only?

Konstantin, Sergey, what do you think?

--
best regards,
Anthony

On 09/24/2013 04:24 PM, Konstantin Shefov wrote:
>
> On 24-Sep-13 15:57, Sergey Bylokhov wrote:
>> Hello.
>> I am not sure why r.keyPress(KeyEvent.VK_META) is not supported on
>> windows and where/when is it supported?
> I have run this test on OS X - meta is  supported, on Ubuntu Linux 12 -
> meta is supported, on Windows 7 - Meta is NOT supported.
>> ===============================
>> Hi Konstantin,
>>
>> What is the reason to check the toolkit name as opposed to using the
>> sun.awt.OSInfo.getOSType() in this case?
>>
>> --
>> best regards,
>> Anthony
>>
>> On 09/24/2013 02:51 PM, Konstantin Shefov wrote:
>>> Hello,
>>>
>>> Please review a fix for the issue:
>>>
>>>    7161320 TEST_BUG:
>>> java/awt/event/KeyEvent/SwallowKeyEvents/SwallowKeyEvents.java fails
>>> (Invalid key code)
>>>
>>> Test bug fix.
>>>
>>> http://bugs.sun.com/view_bug.do?bug_id=7161320
>>>
>>> The webrev is: http://cr.openjdk.java.net/~kshefov/7161320/webrev.00
>>>
>>> Thanks,
>>> Konstantin
>