<AWT Dev> [8] Review Request: JDK-8016563 Test closed/java/awt/dnd/ImageTransferTest/ImageTransferTest.html fails

Sergey Bylokhov Sergey.Bylokhov at oracle.com
Fri Sep 27 04:33:25 PDT 2013


Hi, Petr.
The fix looks good.
But i am sure the code simplification is required.

On 27.09.2013 15:04, Petr Pchelko wrote:
> Hello, AWT Team.
>
> Please review the updated fix here:
> http://cr.openjdk.java.net/~pchelko/8015563/webrev.01/
>
> We actually need to throw an exception in case the Data conversion failed.
>
> With best regards. Petr.
>
> On Sep 27, 2013, at 2:47 PM, Petr Pchelko <petr.pchelko at oracle.com> wrote:
>
>> Hello, AWT Team.
>>
>> Please review the fix for the issue:
>> https://bugs.openjdk.java.net/browse/JDK-8016563
>> The fix is available at:
>> http://cr.openjdk.java.net/~pchelko/8015563/webrev.00/
>>
>> This is a regression of the fix for JDK-7075105. On of the if clauses was lost during refactoring.
>>
>> With best regards. Petr.


-- 
Best regards, Sergey.



More information about the awt-dev mailing list