<AWT Dev> [8] Review Request: JDK-8025440 [TEST_BUG] com/sun/awt/SecurityWarning/GetSizeShouldNotReturnZero.java failed since jdk8b108

[Anthony Petrov]

Hi Petr,

Note that the new utility class has limitations. For instance, it won't 
copy inner classes belonging to the main copied class. I suggest to 
document this, or implement this. Also, I suggest to add a message to 
the IllegalArgumentException thrown from the utility class.

I have a question though, why do we need it in the first place? Wouldn't 
it be sufficient to just override the checkPermission() method in the 
inner SecurityManager instance in the test itself? Why move it to a 
top-level class?

--
best regards,
Anthony

On 09/26/2013 01:11 PM, Petr Pchelko wrote:
> Hello, AWT Team.
>
> Please review the fix for the following issue:
> https://bugs.openjdk.java.net/browse/JDK-8025440
> The fix is available at:
> http://cr.openjdk.java.net/~pchelko/8025440/webrev.00/
>
> After SecurityManager.checkTopLevelWindow was deprecated in JDK-8008981 the test fails.
> This fix updates the test. The CopyClassFile util is introduced - it's copying the class file into the specified directory in the test working dir. This is needed to use the -Xbootclasspath, so that the new SecurityManager could work.
>
> This is a test fix, no code is affected.
>
> With best regards. Petr.
>