<AWT Dev> [8] Request for review: 7150100 [macosx] "0123456789" is selected in the TextField.

[Sergey Bylokhov]

On 27.09.2013 16:36, Anthony Petrov wrote:
> On 09/27/2013 04:32 PM, Sergey Bylokhov wrote:
>> On 27.09.2013 16:15, Anthony Petrov wrote:
>>> Hi Sergey,
>>>
>>> Where is the comment that you say you've added? I'd expect to see it
>>> above the setCaretPosition() calls.
>> It was added to bug evaluation in the bug comment.
> This might better be documented in the code, too, so that engineers 
> working on these files in the future wouldn't break things accidentally.
Selection of the text can be changed by the setText() as well. I'll add 
comment to the select method to describe  why it should be called after 
setText and setCaretPosition.
>
>>>
>>> src/solaris/classes/sun/awt/X11/XTextAreaPeer.java
>>>>  410     public void setEditable(boolean editable) {
>>>>  411         this.editable = editable;
>>>
>>> Why do you delete this assignment statement?
>> This field was removed since it is never used.
>
> Indeed, I haven't noticed this at first. This part looks good then.
>
> -- 
> best regards,
> Anthony
>
>>>
>>> -- 
>>> best regards,
>>> Anthony
>>>
>>> On 09/27/2013 02:13 PM, Sergey Bylokhov wrote:
>>>> Hello.
>>>> Please review the updated version of the fix for jdk 8.
>>>> The same problem was found and fixed in xawt as well.
>>>> http://cr.openjdk.java.net/~serb/7150100/webrev.01
>>>>
>>>> On 09.04.2012 15:03, Artem Ananiev wrote:
>>>>> On 4/6/2012 8:25 PM, Sergey Bylokhov wrote:
>>>>>> 05.04.2012 14:53, Artem Ananiev написал:
>>>>>>> Hi, Sergey,
>>>>>>> it's not clear why this particular change fixes the selection. 
>>>>>>> Could
>>>>>>> you add more comments to the bug evaluation, please?
>>>>>> comment added:
>>>>>> This happens because at the beginning of LWTextComponentPeer
>>>>>> initialization we select text and then we call
>>>>>> JTextComponent.setCaretPosition() which clears selection.
>>>>>
>>>>> Thanks. Approved.
>>>>>
>>>>> Artem
>>>>>
>>>>>>>
>>>>>>>> 2) On macosx we clear selection when the test component lost its
>>>>>>>> focus,
>>>>>>>> so test was simplified and instructions dialog was removed 
>>>>>>>> (because
>>>>>>>> sometimes it steal the focus from the text component)
>>>>>>>>
>>>>>>>> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7150100 **
>>>>>>>> Webrev can be found at:
>>>>>>>> http://cr.openjdk.java.net/~serb/7150100/webrev.00/
>>>>>>>>
>>>>>>>> -- 
>>>>>>>> Best regards, Sergey.
>>>>>>>>
>>>>>>
>>>>>>
>>>>>
>>>>
>>>>
>>
>>


-- 
Best regards, Sergey.