<AWT Dev> review request: focus disappears with shift+tab on dialogue having a focus component
Artem Ananiev
artem.ananiev at oracle.com
Thu Apr 10 14:45:16 UTC 2014
Hi, Mikhail,
the fix looks fine.
The test looks fine as well, except the "button" field, which should be
volatile.
Thanks,
Artem
On 4/8/2014 6:03 PM, mikhail cherkasov wrote:
> Hi again,
>
> A regression test was added:
> http://cr.openjdk.java.net/~mcherkas/8031075/webrev.01/
>
> Could you please review second version of webrev?
>
> Thanks,
> Mikhail.
>
> On 1/9/2014 11:59 AM, Sergey Bylokhov wrote:
>> Hi, Mikhail.
>> The fix looks good. But since this regression was not found by our
>> tests it would be good to add new one.
>>
>> On 31.12.2013 15:59, mikhail cherkasov wrote:
>>> Hello all,
>>>
>>> Could you please review the following fix:
>>> https://bugs.openjdk.java.net/browse/JDK-8031075
>>> review request: focus disappears with shift+tab on dialogue having a
>>> focus component
>>> http://cr.openjdk.java.net/~mcherkas/8031075/webrev.00/
>>> <http://cr.openjdk.java.net/%7Emcherkas/8031075/webrev.00/>
>>>
>>> Jdk8 already has it, also it was in jdk7 too, but was mistakenly
>>> reverted by other fix, so
>>> I'm just returning it back.
>>>
>>>
>>> Thanks,
>>> Mikhail.
>>
>>
>> --
>> Best regards, Sergey.
>
More information about the awt-dev
mailing list