<AWT Dev> [9] Review Request: 8039926 -spash:<image> can't be combined with -xStartOnFirstThread since JDK 7

[Anthony Petrov]

Sounds good. Thanks.

--
best regards,
Anthony

On 4/11/2014 3:39 PM, Petr Pchelko wrote:
> Hello, Anthony.
>
> Thank you for the review.
>
>>   Although it would be good to document somewhere (in a comment in the code?) that when running an SWT app in WebStart, the AWT splashscreen is unsupported.
> I'll add the comment before the push.
> Something like: "Can't check if running SWT in webstart, so splash screen in webstart SWT applications is not supported".
>
> With best regards. Petr.
>
> On 11.04.2014, at 15:31, Anthony Petrov <anthony.petrov at oracle.com> wrote:
>
>> Hi Petr,
>>
>> The fix looks fine. I see that we're not checking the isSWTInWebStart() case (see awt.m), but I don't immediately see any way to check this actually, because the JVM isn't started yet when the splashscreen is initializing. So I think we're good with the current solution. Although it would be good to document somewhere (in a comment in the code?) that when running an SWT app in WebStart, the AWT splashscreen is unsupported.
>>
>> --
>> best regards,
>> Anthony
>>
>> On 4/11/2014 3:14 PM, Petr Pchelko wrote:
>>> Hello, AWT Team.
>>>
>>> Please review the fix for the issue:
>>> https://bugs.openjdk.java.net/browse/JDK-8039926
>>> The fix is available at:
>>> http://cr.openjdk.java.net/~pchelko/9/8039926/webrev.00/
>>>
>>> When running SWT we should not start the main event loop for splashscreen because it breaks SWT.
>>> The only way understand that in splashscreen code is to check the system property launcher sets on
>>> the startup. We do the same in awt.m, but we cannot reuse the code because splash and awt are not
>>> statically linked.
>>>
>>> With best regards. Petr.
>>>
>