<AWT Dev> [9] Review Request: 7124365 [macosx] setMaximizedBounds() should be implemented

[Petr Pchelko]

I’ll prepare it and send a new request.

15 апр. 2014 г., в 5:16 после полудня, Sergey Bylokhov <Sergey.Bylokhov at oracle.com> написал(а):

> On 4/15/14 4:56 PM, Petr Pchelko wrote:
>>> Is it true that the native system does not constrain min/max height/width ourselves after the call to windowWillUseStandardFrame?
>> I didn’t quite understand your question) If I set maximum size to 100x100 and return 200x200 from maximized size the frame will ignore the maximum size and appear 200x200.
> ok.
>> We could not modify that test, but write a new one to specifically check this possible bug..
> So we need a new additional test to check intersection of maximizedBounds/maxsize/minsize?
>> 
>> With best regards. Petr.
>> 
>> 15 апр. 2014 г., в 4:51 после полудня, Sergey Bylokhov <Sergey.Bylokhov at oracle.com> написал(а):
>> 
>>> Hi, Petr.
>>> Is it true that the native system does not constrain min/max height/width ourselves after the call to windowWillUseStandardFrame?
>>> I guess we can suggest to sqe to change the test now, since it is currently under review.
>>> 
>>> On 4/15/14 4:33 PM, Petr Pchelko wrote:
>>>> Hello, AWT Team.
>>>> 
>>>> Please review the fix for the issue:
>>>> https://bugs.openjdk.java.net/browse/JDK-7124365
>>>> The fix is available at:
>>>> http://cr.openjdk.java.net/~pchelko/9/7124365/webrev/
>>>> 
>>>> The implementation is pretty straightforward.
>>>> In native -1 indicates that this bound is not set. Using Integer.MAX_VALUE as in Frame’s javadoc isn’t convenient in native code.
>>>> We do not need to worry about bounds that do not fit the screen - Cocoa handles it for us.
>>>> But we need to handle the maximum/minimum sizes manually, because these are applied before the willUseStandardFrame callback is called.
>>>> The regression test for this exists, it’s being moved from SQE right now. I’ll modify it to support Mac as soon as it’s pushed.
>>>> 
>>>> Thank you.
>>>> With best regards. Petr.
>>> 
>>> -- 
>>> Best regards, Sergey.
>>> 
> 
> 
> -- 
> Best regards, Sergey.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20140415/dec68073/attachment-0001.html>