<AWT Dev> [9] Review Request: 8035169 Move ThreadGroupUtils from the sun.misc package
Sergey Bylokhov
Sergey.Bylokhov at oracle.com
Thu Apr 17 15:51:21 UTC 2014
Hi, Petr.
The fix looks good.
On 4/17/14 3:34 PM, Petr Pchelko wrote:
> Hello, Sergey.
>
> Thank you for the review.
> Fixed: http://cr.openjdk.java.net/~pchelko/9/8035169/webrev.01/
>
> With best regards. Petr.
>
> On 17.04.2014, at 13:58, Sergey Bylokhov <Sergey.Bylokhov at oracle.com> wrote:
>
>> Hi, Petr.
>> Typo from the previous review "could could".
>>
>> On 16.04.2014 18:42, Petr Pchelko wrote:
>>> Hello, AWT Team.
>>>
>>> Please review the fix for the issue:
>>> https://bugs.openjdk.java.net/browse/JDK-8035169
>>> The fix is available at:
>>> http://cr.openjdk.java.net/~pchelko/9/8035169/webrev/
>>>
>>> The ThreadGroupUtils class was added to sun.misc, but it's a bad
>>> practice for modularization. We should move it somewhere to AWT.
>>> Here I've put it to sun.awt.util. Nothing.s changed except moving the
>>> class.
>>>
>>> With best regards. Petr.
>>
>> --
>> Best regards, Sergey.
>>
--
Best regards, Sergey.
More information about the awt-dev
mailing list