<AWT Dev> [9] Review request for 8014754: [TEST_BUG] child.exe remains after execution java/awt/dnd/ Win32TYMEDSelectionTest and Win32DropTYMEDSelectionTest

[Anthony Petrov]

Hi Oleg,

The test now requires Visual Studio to be installed on the testing 
system, and the vcvars32.bat to be on PATH. This is not the case for 
most systems used by SQE to run tests. Therefore, leaving this test 
automatic seems undesirable.

I suggest to make it a manual test, so that testers would have to run it 
explicitly. Note that it still should perform all the testing 
automatically using the Robot, and simply report to the user whether 
it's failed or passed.

--
best regards,
Anthony

On 4/19/2014 11:41 AM, Oleg Pekhovskiy wrote:
> Hi Anthony,
>
> thank you for pointing that out.
>
> Please review the new version of fix that meets mentioned requirements:
> http://cr.openjdk.java.net/~bagiras/9/8014754.2
>
> Thanks,
> Oleg
>
> On 18.04.2014 18:18, Anthony Petrov wrote:
>> Hi Oleg,
>>
>> We don't want to add binary files to the open repository. If you can
>> only add the source code to it and make it compile itself upon test
>> execution, then it is fine. But the .exe file itself should not be
>> pushed to the repo.
>>
>> --
>> best regards,
>> Anthony
>>
>> On 4/18/2014 6:13 PM, Oleg Pekhovskiy wrote:
>>> Hi all,
>>>
>>> please review the fix
>>> http://cr.openjdk.java.net/~bagiras/9/8014754.1/
>>> for
>>> https://bugs.openjdk.java.net/browse/JDK-8014754
>>>
>>> Start of 'child.exe' has no timeout, that's why if dragging fails the
>>> executable keeps running and prevents temporary folder from being
>>> cleared.
>>> So I forcibly terminate the process if it was not exited after dnd
>>> action (lines 74-76 in Win32TYMEDSelectionTest.java)
>>>
>>> PS: Webrev doesn't include child.exe but it's also moved with the others
>>> from the closed repository.
>>>
>>> Thanks,
>>> Oleg