<AWT Dev> [9] Review Request: JDK-8042087 [macosx] LWCToolkit.inokeAndWait is calling EventQueue.invokeLater

[Petr Pchelko]

Hello, Sergey.

>> Hello, AWT Team.
>> 
>> Please review the fix for the issue:
>> https://bugs.openjdk.java.net/browse/JDK-8042087
>> The fix is available at:
>> http://cr.openjdk.java.net/~pchelko/9/8042087/webrev/
>> 
>> The problem is that we are using EventQueue.invokeLater on the Toolkit thread.
> I guess the fix changes getSystemEventQueueForInvokeAndWait().postEvent(), and EventQueue.invokeLater is used in another place of LWCToolkit in systemColorsChanged().
>> In applet mode this would fail with NPE. So I've removed the non-working code branch, made general cleanup and added a null check for the component provided to invokeAndWait and invokeLater methods.
Yes, I've called the bug incorrectly) It should be called "[macosx] LWCToolkit.inokeAndWait is relying on main AppContext".. Sorry for 	inaccuracy. I've renamed the issue.

With best regards. Petr.

On 29.04.2014, at 14:38, Sergey Bylokhov <Sergey.Bylokhov at oracle.com> wrote:

> On 4/29/14 12:32 PM, Petr Pchelko wrote:
>> Hello, AWT Team.
>> 
>> Please review the fix for the issue:
>> https://bugs.openjdk.java.net/browse/JDK-8042087
>> The fix is available at:
>> http://cr.openjdk.java.net/~pchelko/9/8042087/webrev/
>> 
>> The problem is that we are using EventQueue.invokeLater on the Toolkit thread.
> I guess the fix changes getSystemEventQueueForInvokeAndWait().postEvent(), and EventQueue.invokeLater is used in another place of LWCToolkit in systemColorsChanged().
>> In applet mode this would fail with NPE. So I've removed the non-working code branch, made general cleanup and added a null check for the component provided to invokeAndWait and invokeLater methods.
>> We don't have open bugs on Mac about NPE in applet mode, so most likely the removed branch was never executed. But with this fix we would catch possible errors early.
>> 
>> With best regards. Petr.
> 
> 
> -- 
> Best regards, Sergey.
>