<AWT Dev> [9] Review Request: 7077826 Unset and empty DISPLAY variable is handled differently by JDK

[Sergey Bylokhov]

Hi, Artem.
Thanks for review!
The new version:
http://cr.openjdk.java.net/~serb/7077826/webrev.01

On 10.12.2014 16:53, Artem Ananiev wrote:
> Hi, Sergey,
>
> the fix looks fine to me as well. Just a few cosmetic comments:
>
> 1. When we don't care about return value, we usually use 
> PrivilegedAction<Void>, not <Object>
>
> 2. For consistency with Boolean.toBoolean(), which is private, I would 
> suggest to change "true".equals() to "true".equalsIgnoreCase(), but 
> it's up to you.
>
> 3. To handle other empty $DISPLAY values, we may want to have 
> .trim().isEmpty() instead of just .isEmpty(), but again, it's up to you.
>
> Thanks,
>
> Artem
>
> On 12/8/2014 4:02 PM, Sergey Bylokhov wrote:
>> Hello.
>> Please review the fix for jdk 9.
>> After the fix we will use empty $DISPLAY in the same way like a null 
>> $DISPLAY.
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-7077826
>> Webrev can be found at: 
>> http://cr.openjdk.java.net/~serb/7077826/webrev.00
>>


-- 
Best regards, Sergey.