<AWT Dev> [9] Review Request: 8032187 [macosx] The fix for MACOSX_PORT-424 should be reworked

[Anthony Petrov]

Hi Sergey,

 From the bug report:
> After discussion, it was decided to accept MACOSX_PORT-424 as not a defect

Are you saying that user code will start receiving hierarchy events 
related to the internal hierarchy of our LWAWT peers? Why would anyone 
want to process these events and why would we want to post them to user 
code? Is there any way to filter them out?

While I agree that using reflection is a bad idea, but is there any 
other real problem with the original fix for MACOSX_PORT-424? I.e. does 
that fix break anything? If not, can we simply replace usages of 
reflection with AWTAccessor-like mechanism?

--
best regards,
Anthony

On 2/4/2014 3:52 PM, Sergey Bylokhov wrote:
> Hello.
> Please review the fix for jdk 9.
>   - Initial fix for MACOSX_PORT-424 was reverted back.
>   - delegate.addNotify(),because it was called from
> delegateContainer.addNotify();
>   - Testcase was updated to filter out events not from the Frame:
>    84             if (e.getSource() instanceof Frame) {
>    85                 counter++;
>    86                 notify();
>    87             }
>
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8032187
> Webrev can be found at: http://cr.openjdk.java.net/~serb/8032187/webrev.00
>