<AWT Dev> [9] Review Request: 8034068 Label.toString performance improvement

Sergey Bylokhov Sergey.Bylokhov at oracle.com
Mon Feb 10 05:53:53 PST 2014


Hello.
Please review the quick fix for jdk 9.
The code in Label was changed to be a faster and a readable. + small 
cleanup in Component.

Actual change is from:
         String str = ",align=";
         switch(alignment) {
           case 0: str = (new 
StringBuilder()).append(s).append("left").toString(); break;
           case 1: str = (new 
StringBuilder()).append(s).append("center").toString(); break;
           case 2: str = (new 
StringBuilder()).append(s).append("right").toString(); break;
         }
         return (new 
StringBuilder()).append(super.paramString()).append(str).append(",text=").append(text).toString(); 

to
         String str = "";
         switch(alignment) {
           case 0: str = "left"; break;
           case 1: str = "center"; break;
           case 2: str = "right"; break;
         }
         return (new 
StringBuilder()).append(super.paramString()).append(",align=").append(str).append(",text=").append(text).toString();


Bug: https://bugs.openjdk.java.net/browse/JDK-8034068
Webrev can be found at: http://cr.openjdk.java.net/~serb/8034068/webrev.00

-- 
Best regards, Sergey.



More information about the awt-dev mailing list