<AWT Dev> [7u] Review request for 7171045 [macosx] There are no enter or exit events reported against 8b39 for MouseEventsDuringDrag.

[dmitry markov]

Hello Alexander, Petr,

Thank you for review.
I agree, the option NSTrackingActiveInActiveApp should be changed to 
NSTrackingActiveAlways. If it is better to back port the changes for 
JDK-8012026 under separate fix, I can do it.

The difference between this backport and main fix is the changes in 
CViewPlatformEmbeddedFrame.java. The original changeset integrated into 
JDK 8 (http://hg.openjdk.java.net/jdk8/awt/jdk/rev/e23311e924b1) does 
not have them, since this file was added later.

Thanks,
Dmitry

**
On 20/02/2014 14:09, Petr Pchelko wrote:
> Hello, Alexander.
>
> We should either combine these 2 fixes together or back port them separately. I don’t think it’s a good idea to mix different fixes in a single back port.
> It could be a good to also back port 8012026, but as a separate fix.
>
>>> The back-port and the main fix integrated into JDK 8 are slightly different.
> Dmitry, could you pleas tell what’s the difference?
>
> Thank you.
> With best regards. Petr.
>
>
> 20 февр. 2014 г., в 1:51 после полудня, Alexander Scherbatiy <alexandr.scherbatiy at oracle.com> написал(а):
>
>>   Could you look at the JDK-8012026 fix to investigate, should the NSTrackingActiveInActiveApp option be changed to NSTrackingActiveAlways
>>   for the resetTrackingRect method in the AWTView.m file for the backport?
>> http://mail.openjdk.java.net/pipermail/awt-dev/2013-August/005347.html
>>     http://cr.openjdk.java.net/~pchelko/8012026/webrev.00/
>>
>>   Thanks,
>>   Alexandr.
>>
>> On 2/11/2014 1:46 PM, dmitry markov wrote:
>>> Hello,
>>>
>>> Could you review a back-port of 7171045 to JDK 7u, please? The back-port and the main fix integrated into JDK 8 are slightly different.
>>>
>>> bug: http://bugs.sun.com/view_bug.do?bug_id=7171045
>>> webrev for jdk7u: http://cr.openjdk.java.net/~dmarkov/7171045/jdk7u/webrev.00/
>>> jdk8 changeset: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/e23311e924b1
>>> technical review for jdk8: http://mail.openjdk.java.net/pipermail/awt-dev/2012-August/003238.html
>>>
>>> Please note: the fix for 7171045 was partly backported to JDK 7u (see http://mail.openjdk.java.net/pipermail/awt-dev/2012-August/003376.html for details). However, some problems related to this case still take place on JDK 7u. So it is necessary to backport full changeset integrated into JDK 8.
>>>
>>> Thanks,
>>> Dmitry

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20140220/931630ec/attachment.html